@nathapp/nax 0.32.0 → 0.32.2

package/README.md

@@ -300,15 +300,96 @@ Integrate notifications, CI triggers, or custom scripts via lifecycle hooks.
 | Event | Fires when |
 |:------|:-----------|
 | `on-start` | Run begins |
-| `on-story-start` | A story starts |
-| `on-story-complete` | A story passes |
-| `on-story-fail` | A story exhausts all attempts |
-| `on-pause` | Run paused (awaiting input) |
-| `on-complete` | All stories done |
-| `on-error` | Unhandled error |
+| `on-story-start` | A story starts processing |
+| `on-story-complete` | A story passes all checks |
+| `on-story-fail` | A story exhausts all retry attempts |
+| `on-pause` | Run paused (awaiting human input) |
+| `on-resume` | Run resumed after pause |
+| `on-session-end` | An agent session ends (per-session teardown) |
+| `on-complete` | All stories finished successfully |
+| `on-error` | Unhandled error terminates the run |
 
 Each hook receives context via `NAX_*` environment variables and full JSON on stdin.
 
+**Environment variables passed to hooks:**
+
+| Variable | Description |
+|:---------|:------------|
+| `NAX_EVENT` | Event name (e.g., `on-story-complete`) |
+| `NAX_FEATURE` | Feature name |
+| `NAX_STORY_ID` | Current story ID (if applicable) |
+| `NAX_STATUS` | Status (`pass`, `fail`, `paused`, `error`) |
+| `NAX_REASON` | Reason for pause or error |
+| `NAX_COST` | Accumulated cost in USD |
+| `NAX_MODEL` | Current model |
+| `NAX_AGENT` | Current agent |
+| `NAX_ITERATION` | Current iteration number |
+
+**Global vs project hooks:** Global hooks (`~/.nax/hooks.json`) fire alongside project hooks. Set `"skipGlobal": true` in your project `hooks.json` to disable global hooks.
+
+---
+
+## Interaction Triggers
+
+nax can pause execution and prompt you for decisions at critical points. Configure triggers in `nax/config.json` (or `~/.nax/config.json` globally):
+
+```json
+{
+  "interaction": {
+    "plugin": "telegram",
+    "defaults": {
+      "timeout": 600000,
+      "fallback": "escalate"
+    },
+    "triggers": {
+      "security-review": true,
+      "cost-exceeded": true,
+      "cost-warning": true,
+      "max-retries": true,
+      "human-review": true,
+      "story-ambiguity": true,
+      "review-gate": true,
+      "pre-merge": false,
+      "merge-conflict": true
+    }
+  }
+}
+```
+
+**Available triggers:**
+
+| Trigger | Safety | Default Fallback | Description |
+|:--------|:------:|:----------------:|:------------|
+| `security-review` | 🔴 Red | `abort` | Critical security issues found during review |
+| `cost-exceeded` | 🔴 Red | `abort` | Run cost exceeded the configured limit |
+| `merge-conflict` | 🔴 Red | `abort` | Git merge conflict detected |
+| `cost-warning` | 🟡 Yellow | `escalate` | Approaching cost limit — escalate to higher model tier? |
+| `max-retries` | 🟡 Yellow | `skip` | Story exhausted all retry attempts — skip and continue? |
+| `pre-merge` | 🟡 Yellow | `escalate` | Checkpoint before merging to main branch |
+| `human-review` | 🟡 Yellow | `skip` | Human review required on critical failure |
+| `story-ambiguity` | 🟢 Green | `continue` | Story requirements unclear — continue with best effort? |
+| `review-gate` | 🟢 Green | `continue` | Code review checkpoint before proceeding |
+
+**Safety tiers:**
+- 🔴 **Red** — Critical; defaults to aborting if no response
+- 🟡 **Yellow** — Caution; defaults to escalating or skipping
+- 🟢 **Green** — Informational; defaults to continuing
+
+**Fallback behaviors** (when interaction times out):
+- `continue` — proceed as normal
+- `skip` — skip the current story
+- `escalate` — escalate to a higher model tier
+- `abort` — stop the run
+
+**Interaction plugins:**
+
+| Plugin | Description |
+|:-------|:------------|
+| `telegram` | Send prompts via Telegram bot (recommended for remote runs) |
+| `cli` | Interactive terminal prompts (for local runs) |
+| `webhook` | POST interaction requests to a webhook URL |
+| `auto` | Auto-respond based on fallback behavior (no human prompt) |
+
 ---
 
 ## Plugins

package/dist/nax.js

@@ -19531,7 +19531,7 @@ var package_default;
 var init_package = __esm(() => {
   package_default = {
     name: "@nathapp/nax",
-    version: "0.32.0",
+    version: "0.32.2",
     description: "AI Coding Agent Orchestrator \u2014 loops until done",
     type: "module",
     bin: {
@@ -19593,8 +19593,8 @@ var init_version = __esm(() => {
   NAX_VERSION = package_default.version;
   NAX_COMMIT = (() => {
     try {
-      if (/^[0-9a-f]{6,10}$/.test("76e82f7"))
-        return "76e82f7";
+      if (/^[0-9a-f]{6,10}$/.test("1012b41"))
+        return "1012b41";
     } catch {}
     try {
       const result = Bun.spawnSync(["git", "rev-parse", "--short", "HEAD"], {
@@ -23625,7 +23625,21 @@ async function runFullSuiteGate(story, config2, workdir, agent, implementerTier,
     if (testSummary.failed > 0) {
       return await runRectificationLoop(story, config2, workdir, agent, implementerTier, contextMarkdown, lite, logger, testSummary, rectificationConfig, testCmd, fullSuiteTimeout);
     }
-    return true;
+    if (testSummary.passed > 0) {
+      logger.info("tdd", "Full suite gate passed (non-zero exit, 0 failures, tests detected)", {
+        storyId: story.id,
+        exitCode: fullSuiteResult.exitCode,
+        passedTests: testSummary.passed
+      });
+      return true;
+    }
+    logger.warn("tdd", "Full suite gate inconclusive \u2014 no test results parsed from output (possible crash/OOM)", {
+      storyId: story.id,
+      exitCode: fullSuiteResult.exitCode,
+      outputLength: fullSuiteResult.output.length,
+      outputTail: fullSuiteResult.output.slice(-200)
+    });
+    return false;
   }
   if (fullSuitePassed) {
     logger.info("tdd", "Full suite gate passed", { storyId: story.id });
@@ -27640,7 +27654,8 @@ function validateHookCommand(command) {
   }
 }
 function parseCommandToArgv(command) {
-  return command.trim().split(/\s+/);
+  const home = process.env.HOME ?? process.env.USERPROFILE ?? "";
+  return command.trim().split(/\s+/).map((token) => token.startsWith("~/") ? home + token.slice(1) : token);
 }
 async function executeHook(hookDef, ctx, workdir) {
   if (hookDef.enabled === false) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nathapp/nax",
-  "version": "0.32.0",
+  "version": "0.32.2",
   "description": "AI Coding Agent Orchestrator \u2014 loops until done",
   "type": "module",
   "bin": {

package/src/hooks/runner.ts

@@ -144,8 +144,12 @@ export function validateHookCommand(command: string): void {
  * @param command - Command string
  * @returns Array of command and arguments
  */
-function parseCommandToArgv(command: string): string[] {
-  return command.trim().split(/\s+/);
+export function parseCommandToArgv(command: string): string[] {
+  const home = process.env.HOME ?? process.env.USERPROFILE ?? "";
+  return command
+    .trim()
+    .split(/\s+/)
+    .map((token) => (token.startsWith("~/") ? home + token.slice(1) : token));
 }
 
 /**

package/src/tdd/rectification-gate.ts

@@ -69,8 +69,29 @@ export async function runFullSuiteGate(
         fullSuiteTimeout,
       );
     }
-    // No failures detected despite non-zero exit — treat as passed
-    return true;
+
+    // BUG-059: Non-zero exit with 0 parsed failures could mean:
+    // (a) Environmental noise (linter warning) — safe to pass
+    // (b) Bun crashed/OOM mid-run — truncated output, parser found nothing
+    // Distinguish by checking if any tests were actually detected in the output.
+    if (testSummary.passed > 0) {
+      // Tests ran and passed, but exit code was non-zero (environmental noise)
+      logger.info("tdd", "Full suite gate passed (non-zero exit, 0 failures, tests detected)", {
+        storyId: story.id,
+        exitCode: fullSuiteResult.exitCode,
+        passedTests: testSummary.passed,
+      });
+      return true;
+    }
+
+    // No tests passed AND no tests failed — output is likely truncated/crashed
+    logger.warn("tdd", "Full suite gate inconclusive — no test results parsed from output (possible crash/OOM)", {
+      storyId: story.id,
+      exitCode: fullSuiteResult.exitCode,
+      outputLength: fullSuiteResult.output.length,
+      outputTail: fullSuiteResult.output.slice(-200),
+    });
+    return false;
   }
   if (fullSuitePassed) {
     logger.info("tdd", "Full suite gate passed", { storyId: story.id });