@nathapp/nax 0.28.0 → 0.30.0

package/nax/features/post-rearch-bugfix/prd.json

@@ -1,137 +0,0 @@
-{
-  "project": "nax",
-  "branchName": "feat/post-rearch-bugfix",
-  "feature": "post-rearch-bugfix",
-  "version": "0.22.3",
-  "description": "Fix all critical and key high-priority bugs found in post-re-architecture code review. Stream deadlocks, unhandled rejections, signal handler safety, lock file reliability, interaction system, parallel executor race, and error swallowing.",
-  "userStories": [
-    {
-      "id": "FIX-C1",
-      "title": "Fix stream deadlock in acceptance and autofix stages",
-      "description": "In src/pipeline/stages/acceptance.ts (line ~136) and src/pipeline/stages/autofix.ts (line ~116), the code awaits proc.exited BEFORE reading stdout/stderr. When output exceeds the 64KB OS pipe buffer, the child blocks on write and proc.exited never resolves, causing a silent deadlock. Fix: use Promise.all([proc.exited, new Response(proc.stdout).text(), new Response(proc.stderr).text()]) to read streams concurrently with exit.",
-      "complexity": "simple",
-      "status": "pending",
-      "acceptanceCriteria": [
-        "acceptance.ts reads stdout/stderr concurrently with proc.exited using Promise.all",
-        "autofix.ts reads stdout/stderr concurrently with proc.exited using Promise.all",
-        "No sequential await proc.exited before stream reads in either file",
-        "Existing tests pass"
-      ]
-    },
-    {
-      "id": "FIX-C2",
-      "title": "Fix emitAsync never called for human-in-the-loop interaction",
-      "description": "In src/execution/pipeline-result-handler.ts (line ~151), human-review:requested is emitted via fire-and-forget emit() instead of emitAsync(). The emitAsync() method in src/pipeline/subscribers/interaction.ts was specifically designed to wait for human response but is never called anywhere. The pipeline races past without waiting for human input. Fix: use await pipelineEventBus.emitAsync() for human-review events.",
-      "complexity": "medium",
-      "status": "pending",
-      "acceptanceCriteria": [
-        "human-review:requested event uses emitAsync instead of emit",
-        "Pipeline waits for human response before continuing",
-        "emitAsync is properly awaited at the call site",
-        "Existing tests pass"
-      ]
-    },
-    {
-      "id": "FIX-C5",
-      "title": "Fix timeoutPromise unhandled rejection in LLM routing",
-      "description": "In src/routing/strategies/llm.ts, the timeoutPromise created in callLlmOnce() uses reject() but if the timer fires between race resolution and clearTimeout, the rejection is unhandled. Add timeoutPromise.catch(() => {}) right after creation, or restructure to use a clearable pattern that does not reject.",
-      "complexity": "simple",
-      "status": "pending",
-      "acceptanceCriteria": [
-        "timeoutPromise rejection is always handled (no unhandled rejection possible)",
-        "Existing BUG-040 tests still pass",
-        "Add test verifying no unhandled rejection when timeout fires after successful completion"
-      ]
-    },
-    {
-      "id": "FIX-C3",
-      "title": "Fix TDZ crash in signal handler — prd accessed before initialization",
-      "description": "In src/execution/runner.ts around line 123, the crash handler closure references prd which is declared later (~line 134). If SIGTERM arrives during setupRun(), accessing prd throws ReferenceError. Fix: declare let prd: PRD | undefined before the crash handler setup, and add a null guard in the getter: () => prd ? countStories(prd).total : 0.",
-      "complexity": "simple",
-      "status": "pending",
-      "acceptanceCriteria": [
-        "prd variable declared before crash handler registration",
-        "Crash handler getter has null guard for prd",
-        "SIGTERM during setupRun does not throw ReferenceError",
-        "Existing tests pass"
-      ]
-    },
-    {
-      "id": "FIX-C6",
-      "title": "Fix parallel executor shared mutable state race condition",
-      "description": "In src/execution/parallel.ts around line 191 and 213, results.totalCost += ... and executing.splice(index, 1) are mutated concurrently from parallel promises. The splice inside .finally() can corrupt array indices when two promises resolve in the same microtask batch. Fix: replace executing array with a Set pattern; use executing.delete(p) instead of splice.",
-      "complexity": "medium",
-      "status": "pending",
-      "acceptanceCriteria": [
-        "executing collection uses Set instead of Array with splice",
-        "totalCost accumulation is safe against concurrent updates",
-        "No array index corruption possible when promises resolve simultaneously",
-        "Existing tests pass"
-      ]
-    },
-    {
-      "id": "FIX-C7",
-      "title": "Fix corrupt lock file permanently blocking all runs",
-      "description": "In src/execution/lock.ts around line 48-79, if JSON.parse(lockContent) throws on a corrupted lock file, the error propagates to the outer catch which returns false, the caller interprets this as another process is running. Fix: wrap JSON.parse in its own try-catch; treat unparseable lock files as stale and delete them.",
-      "complexity": "simple",
-      "status": "pending",
-      "acceptanceCriteria": [
-        "Corrupt/unparseable lock file is treated as stale and deleted",
-        "A warning is logged when a corrupt lock file is found",
-        "nax can start normally after encountering a corrupt lock file",
-        "Existing tests pass"
-      ]
-    },
-    {
-      "id": "FIX-C8",
-      "title": "Fix empty catch in drainWithDeadline swallowing all errors",
-      "description": "In src/verification/executor.ts around line 36-39, the catch block in drainWithDeadline swallows ALL exceptions including TypeError, OutOfMemoryError etc. Output silently becomes empty string with no diagnostic. Fix: narrow the catch to expected stream-destroyed errors only; log unexpected errors at debug level.",
-      "complexity": "simple",
-      "status": "pending",
-      "acceptanceCriteria": [
-        "Expected stream errors (after kill) are still silently handled",
-        "Unexpected errors are logged at debug level",
-        "Output defaults to empty string on expected stream errors",
-        "Existing tests pass"
-      ]
-    },
-    {
-      "id": "FIX-H16",
-      "title": "Fix lock file not released when setupRun fails",
-      "description": "In src/execution/lifecycle/run-setup.ts around line 153-193, the lock is acquired during setupRun but if setupRun fails, it is outside the runner main try block so the lock is never released. Fix: ensure lock release in a finally block within setupRun, or move lock acquisition inside the runner try/finally.",
-      "complexity": "medium",
-      "status": "pending",
-      "acceptanceCriteria": [
-        "Lock file is released when setupRun throws an error",
-        "Lock file is released on all error paths during setup",
-        "Existing tests pass"
-      ]
-    },
-    {
-      "id": "FIX-C4",
-      "title": "Replace uncancellable Bun.sleep timer in executor",
-      "description": "In src/verification/executor.ts around line 97-100, Bun.sleep() is used for the timeout promise but cannot be cancelled. When the process exits quickly, the sleep continues for the full timeoutMs. Fix: replace with a clearable setTimeout-based promise pattern, clearing the timer in the success path.",
-      "complexity": "simple",
-      "status": "pending",
-      "acceptanceCriteria": [
-        "Timeout in executeWithTimeout uses clearable setTimeout not Bun.sleep",
-        "Timer is cleared when process exits before timeout",
-        "No timer leak after successful execution",
-        "Existing tests pass"
-      ]
-    },
-    {
-      "id": "FIX-H5",
-      "title": "Add hard deadline to async signal handlers",
-      "description": "In src/execution/crash-recovery.ts around line 149-170, signal handlers contain multiple await operations. If any hangs, process.exit() is never reached. Fix: add a setTimeout hard deadline (e.g. 10s) at the top of each signal handler that calls process.exit() as a fallback.",
-      "complexity": "simple",
-      "status": "pending",
-      "acceptanceCriteria": [
-        "SIGTERM handler has a hard deadline timeout (10s) that calls process.exit",
-        "SIGINT handler has the same hard deadline",
-        "Hard deadline fires even if async operations hang",
-        "Existing tests pass"
-      ]
-    }
-  ]
-}

package/nax/features/precheck/prd.json

@@ -1,205 +0,0 @@
-{
-  "project": "nax",
-  "feature": "precheck",
-  "branchName": "feat/precheck",
-  "createdAt": "2026-02-27T10:00:00Z",
-  "userStories": [
-    {
-      "id": "US-001",
-      "title": "Precheck types and check implementations",
-      "description": "Create src/precheck/types.ts with PrecheckResult, CheckStatus, CheckTier types. Create src/precheck/checks.ts with individual check implementations. Tier 1 blockers: git repo exists, working tree clean, no stale lock (>2h), PRD valid (required fields: id, title, description), Claude CLI available, dependencies installed (detect node_modules/target/venv/vendor), test/lint/typecheck commands work (from config, skip if not configured), git user configured. Tier 2 warnings: CLAUDE.md exists, disk space >1GB, pending stories exist, missing optional commands. Each check returns {name, tier, passed, message}. Tier 2 warning: .gitignore exists and covers nax runtime files (nax.lock, nax/features/*/runs/, test/tmp/).",
-      "acceptanceCriteria": [
-        "PrecheckResult type includes blockers[] and warnings[] arrays",
-        "Git repo check uses git rev-parse --git-dir",
-        "Working tree check uses git status --porcelain",
-        "Stale lock detection: nax.lock older than 2 hours",
-        "PRD validation checks id, title, description per story",
-        "PRD auto-defaults missing optional fields in-memory (tags=[], status=pending, storyPoints=1)",
-        "Claude CLI check runs claude --version",
-        "Dependency detection is language-aware (node_modules, target, venv, vendor)",
-        "Test/lint/typecheck commands read from config.execution",
-        "Commands set to null/false are skipped silently",
-        "Disk space warning triggers below 1GB",
-        ".gitignore warning if missing or does not cover nax.lock, runs/, test/tmp/"
-      ],
-      "dependencies": [],
-      "tags": [
-        "precheck",
-        "types"
-      ],
-      "status": "passed",
-      "attempts": 2,
-      "priorErrors": [
-        "Attempt 1 failed with model tier: balanced",
-        "Attempt 2 failed with model tier: balanced",
-        "Attempt 1 failed with model tier: balanced"
-      ],
-      "escalations": [],
-      "routing": {
-        "complexity": "complex",
-        "modelTier": "powerful",
-        "testStrategy": "three-session-tdd-lite",
-        "reasoning": "three-session-tdd-lite: complexity:complex, strategy:lite"
-      }
-    },
-    {
-      "id": "US-002",
-      "title": "Precheck orchestrator with formatted output",
-      "description": "Create src/precheck/index.ts. Runs all checks from checks.ts in order. Stops on first Tier 1 blocker (fail-fast). Collects all Tier 2 warnings. Formats human-readable output with emoji indicators (checkmark/cross/warning). Supports --json flag for machine-readable output. Returns summary with counts (checks, passed, failed, warnings).",
-      "acceptanceCriteria": [
-        "Runs Tier 1 checks first, stops on first failure",
-        "Runs all Tier 2 checks even if some warn",
-        "Human output shows emoji per check result",
-        "JSON output matches spec schema (passed, blockers, warnings, summary, feature)",
-        "Exit code 0 for pass, 1 for blocker, 2 for invalid PRD",
-        "Summary line shows total checks/passed/failed/warnings"
-      ],
-      "dependencies": [
-        "US-001"
-      ],
-      "tags": [
-        "precheck",
-        "orchestrator"
-      ],
-      "status": "passed",
-      "attempts": 1,
-      "priorErrors": [
-        "Attempt 1 failed with model tier: balanced"
-      ],
-      "escalations": []
-    },
-    {
-      "id": "US-003",
-      "title": "CLI nax precheck command with --json flag",
-      "description": "Create src/commands/precheck.ts, register in CLI (bin/nax.ts). Uses resolveProject() from US-001 of v0.12.0. Supports -f <feature>, -d <dir>, --json flags. Runs precheck orchestrator and displays results. Uses same project resolver as nax status/logs.",
-      "acceptanceCriteria": [
-        "Registered as nax precheck subcommand",
-        "Uses resolveProject() for directory resolution",
-        "-f flag specifies feature to validate",
-        "-d flag specifies working directory",
-        "--json flag outputs machine-readable JSON",
-        "Without --json shows human-friendly formatted output",
-        "Exit codes: 0=pass, 1=blocker, 2=invalid PRD"
-      ],
-      "dependencies": [
-        "US-002"
-      ],
-      "tags": [
-        "cli",
-        "precheck"
-      ],
-      "status": "passed",
-      "attempts": 2,
-      "priorErrors": [
-        "Attempt 1 failed with model tier: balanced",
-        "Attempt 2 failed with model tier: balanced",
-        "Attempt 1 failed with model tier: balanced"
-      ],
-      "escalations": [],
-      "routing": {
-        "complexity": "medium",
-        "modelTier": "powerful",
-        "testStrategy": "three-session-tdd-lite",
-        "reasoning": "three-session-tdd-lite: strategy:lite"
-      },
-      "passes": true
-    },
-    {
-      "id": "US-004",
-      "title": "Integrate precheck into nax run",
-      "description": "Modify src/execution/runner.ts to run precheck before story execution loop. If precheck fails (any Tier 1 blocker), abort run with clear error message pointing to nax precheck for details. Warnings are logged but execution continues. Add --skip-precheck flag to bypass (for advanced users).",
-      "acceptanceCriteria": [
-        "Precheck runs automatically before first story",
-        "Tier 1 blocker aborts run with descriptive error",
-        "Tier 2 warnings logged but don't block execution",
-        "--skip-precheck flag bypasses all checks",
-        "Precheck results included in run JSONL log",
-        "Failed precheck updates status.json with precheck-failed status"
-      ],
-      "dependencies": [
-        "US-002"
-      ],
-      "tags": [
-        "runner",
-        "integration"
-      ],
-      "status": "passed",
-      "attempts": 1,
-      "priorErrors": [
-        "Attempt 1 failed with model tier: balanced"
-      ],
-      "escalations": [],
-      "passes": true
-    },
-    {
-      "id": "US-005",
-      "title": "Config-driven review commands replacing hardcoded lint",
-      "description": "Modify src/pipeline/stages/review/runner.ts to use config-driven command resolution instead of hardcoded 'bun run lint'. Resolution order: 1) explicit config.execution.lintCommand, 2) package.json has 'lint' script -> 'bun run lint', 3) not found -> skip with warning. Same for typecheckCommand. Setting to null explicitly disables. This fixes BUG-005.",
-      "acceptanceCriteria": [
-        "Review stage reads lintCommand from config.execution",
-        "Review stage reads typecheckCommand from config.execution",
-        "Resolution order: config -> package.json -> skip",
-        "Setting command to null/false explicitly disables it",
-        "Missing command logs warning instead of failing",
-        "Config schema updated with lintCommand and typecheckCommand fields",
-        "BUG-005 (hardcoded bun run lint) is resolved"
-      ],
-      "dependencies": [],
-      "tags": [
-        "review",
-        "config"
-      ],
-      "status": "passed",
-      "attempts": 2,
-      "priorErrors": [
-        "Attempt 1 failed with model tier: balanced",
-        "Attempt 2 failed with model tier: balanced",
-        "Attempt 1 failed with model tier: balanced"
-      ],
-      "escalations": [],
-      "routing": {
-        "complexity": "medium",
-        "modelTier": "powerful",
-        "testStrategy": "three-session-tdd-lite",
-        "reasoning": "three-session-tdd-lite: strategy:lite"
-      }
-    },
-    {
-      "id": "US-006",
-      "title": "PRD auto-default and router tags fix",
-      "description": "Fix src/routing/router.ts line ~277 to use tags ?? [] as defensive fallback (prevents crash on missing tags). During precheck and run initialization, auto-default missing optional PRD fields in-memory: tags->[], status->pending, storyPoints->1, acceptanceCriteria->[]. Do not modify the PRD file on disk. This fixes BUG-004 properly at the source.",
-      "acceptanceCriteria": [
-        "Router uses tags ?? [] for spread operations",
-        "PRD loader auto-defaults tags=[] when missing",
-        "PRD loader auto-defaults status=pending when missing",
-        "PRD loader auto-defaults storyPoints=1 when missing",
-        "PRD file on disk is not modified",
-        "Existing values are preserved (only fills missing)"
-      ],
-      "dependencies": [],
-      "tags": [
-        "fix",
-        "prd"
-      ],
-      "status": "passed",
-      "attempts": 2,
-      "priorErrors": [
-        "Attempt 1 failed with model tier: balanced",
-        "Attempt 2 failed with model tier: balanced",
-        "Attempt 1 failed with model tier: balanced"
-      ],
-      "escalations": [],
-      "routing": {
-        "complexity": "medium",
-        "modelTier": "powerful",
-        "testStrategy": "three-session-tdd-lite",
-        "reasoning": "three-session-tdd-lite: strategy:lite"
-      }
-    }
-  ],
-  "analyzeConfig": {
-    "maxStories": 15,
-    "granularity": "medium"
-  },
-  "updatedAt": "2026-02-27T14:10:37.423Z"
-}

package/nax/features/precheck/progress.txt

@@ -1,15 +0,0 @@
-[2026-02-27T11:20:44.967Z] US-001 — FAILED — Precheck types and check implementations — All tiers exhausted
-[2026-02-27T11:22:41.995Z] US-005 — FAILED — Config-driven review commands replacing hardcoded lint — All tiers exhausted
-[2026-02-27T11:24:08.156Z] US-006 — FAILED — PRD auto-default and router tags fix — All tiers exhausted
-[2026-02-27T12:12:00.514Z] US-001 — FAILED — Precheck types and check implementations — All tiers exhausted
-[2026-02-27T15:30:00.000Z] US-003 — PASSED — CLI nax precheck command with --json flag — Implementation complete
-
-Implementation summary:
-- Created src/commands/precheck.ts with precheckCommand()
-- Registered command in bin/nax.ts with -f, -d, and --json flags
-- Uses resolveProject() for directory resolution (same as status/logs)
-- Calls runPrecheck() orchestrator from US-002
-- Returns proper exit codes: 0=pass, 1=blocker, 2=invalid PRD
-- 7 integration tests in test/integration/cli-precheck.test.ts
-- All acceptance criteria verified
-[2026-02-27T14:00:33.162Z] US-003 — FAILED — CLI nax precheck command with --json flag — All tiers exhausted

package/nax/features/prompt-builder/prd.json

@@ -1,152 +0,0 @@
-{
-  "project": "nax-prompt-builder",
-  "branchName": "feat/prompt-builder",
-  "feature": "prompt-builder",
-  "updatedAt": "2026-03-08T07:39:46.206Z",
-  "userStories": [
-    {
-      "id": "PB-001",
-      "title": "Create PromptBuilder class with layered section architecture",
-      "description": "Currently nax has 11 scattered prompt-building functions across src/tdd/prompts.ts and src/execution/prompts.ts. There is no unified entry point, no user override support, and adding a new prompt variable requires touching multiple files. Introduce a PromptBuilder class in src/prompts/builder.ts with a fluent API. The builder composes a prompt from ordered sections: (1) Constitution, (2) Role task, (3) User override OR default template body, (4) Story context, (5) Isolation rules, (6) Context markdown, (7) Conventions footer. Each section is a typed unit independently testable. The builder is the single entry point — all existing prompt-building calls are migrated to use it.",
-      "acceptanceCriteria": [
-        "src/prompts/builder.ts exports PromptBuilder class with fluent API: PromptBuilder.for(role, options).story(story).context(md).constitution(c).override(path).build()",
-        "PromptBuilder.build() returns Promise<string> — async to support file loading for overrides",
-        "Section precedence enforced: constitution first, role task prepended, isolation rules appended, story context always included, conventions footer always last",
-        "Non-overridable sections (isolation rules, story context, conventions footer) cannot be removed by user override",
-        "src/prompts/types.ts exports: PromptRole ('test-writer' | 'implementer' | 'verifier' | 'single-session'), PromptSection interface, PromptOptions type",
-        "Unit tests: verify section order for each role; verify non-overridable sections always present; verify missing override falls through to default template"
-      ],
-      "complexity": "medium",
-      "status": "passed",
-      "tags": [
-        "feature",
-        "prompts",
-        "architecture"
-      ],
-      "attempts": 0,
-      "priorErrors": [],
-      "priorFailures": [],
-      "escalations": [],
-      "dependencies": [],
-      "storyPoints": 1,
-      "routing": {
-        "complexity": "medium",
-        "initialComplexity": "medium",
-        "testStrategy": "three-session-tdd-lite",
-        "reasoning": "Class design with fluent API, async file loading, section composition/ordering logic, and section non-overridability enforcement.",
-        "contentHash": "0a1c55a2430989f408b99f7b75a82491fc6606eb736f734386e36c61ccc143c9"
-      },
-      "passes": true
-    },
-    {
-      "id": "PB-002",
-      "title": "Implement typed sections: isolation, role-task, story, verdict, conventions",
-      "description": "The PromptBuilder needs typed section builders that produce the non-overridable parts of each prompt. Five sections: (1) isolation.ts — generates isolation rules based on strict (no src/ access) or lite (may read src/, create stubs) mode; (2) role-task.ts — generates role definition for standard implementer (make failing tests pass) or lite implementer (write tests and implement); (3) story.ts — formats title, description, acceptance criteria; (4) verdict.ts — verifier verdict JSON schema instructions (non-overridable); (5) conventions.ts — bun test scoping warning and commit conventions.",
-      "acceptanceCriteria": [
-        "src/prompts/sections/isolation.ts exports buildIsolationSection(mode: 'strict' | 'lite'): string — strict forbids src/ modification, lite allows reading src/ and creating stubs",
-        "src/prompts/sections/role-task.ts exports buildRoleTaskSection(variant: 'standard' | 'lite'): string — standard says 'make failing tests pass, do not modify test files', lite says 'write tests first then implement'",
-        "src/prompts/sections/story.ts exports buildStorySection(story: UserStory): string — formats title, description, numbered acceptance criteria",
-        "src/prompts/sections/verdict.ts exports buildVerdictSection(story: UserStory): string — identical content to current buildVerifierPrompt verdict instructions",
-        "src/prompts/sections/conventions.ts exports buildConventionsSection(): string — includes bun test scoping warning and commit message instruction",
-        "Each section function is pure (no side effects, no file I/O) and independently unit-testable",
-        "Unit tests: isolation strict does not contain 'MAY read'; isolation lite contains 'MAY read src/'; role-task standard contains 'Do NOT modify test files'; role-task lite contains 'Write tests first'"
-      ],
-      "complexity": "simple",
-      "status": "passed",
-      "tags": [
-        "feature",
-        "prompts",
-        "sections"
-      ],
-      "attempts": 0,
-      "priorErrors": [],
-      "priorFailures": [],
-      "escalations": [],
-      "dependencies": [],
-      "storyPoints": 1,
-      "passes": true
-    },
-    {
-      "id": "PB-003",
-      "title": "Implement default templates and user override loader",
-      "description": "Each PromptRole needs a default template forming the overridable body of the prompt. Implement src/prompts/loader.ts which resolves and reads the user override file relative to workdir. If the path is missing or the file does not exist, the loader returns null and the default template is used. The NaxConfig schema gains a new optional prompts block: { overrides: { 'test-writer'?: string, 'implementer'?: string, 'verifier'?: string, 'single-session'?: string } }.",
-      "acceptanceCriteria": [
-        "src/prompts/templates/ contains test-writer.ts, implementer.ts, verifier.ts, single-session.ts — each exports a default template string (body section only, no story/isolation/conventions)",
-        "src/prompts/loader.ts exports loadOverride(role: PromptRole, workdir: string, config: NaxConfig): Promise<string | null>",
-        "Loader resolves path relative to workdir — e.g. '.nax/prompts/test-writer.md' -> '<workdir>/.nax/prompts/test-writer.md'",
-        "Loader returns null (not error) when config.prompts is absent, role key is absent, or file does not exist",
-        "Loader throws with clear message when file path is set but file is unreadable (permissions error)",
-        "src/config/types.ts NaxConfig gains optional prompts?: { overrides?: Partial<Record<PromptRole, string>> }",
-        "Unit tests: loader returns null when config.prompts undefined; returns null when file missing; returns content when file exists; throws on permission error"
-      ],
-      "complexity": "simple",
-      "status": "passed",
-      "tags": [
-        "feature",
-        "prompts",
-        "config",
-        "loader"
-      ],
-      "attempts": 0,
-      "priorErrors": [],
-      "priorFailures": [],
-      "escalations": [],
-      "dependencies": [],
-      "storyPoints": 1,
-      "passes": true
-    },
-    {
-      "id": "PB-004",
-      "title": "Migrate all existing prompt-building call sites to PromptBuilder",
-      "description": "Replace the 6 user-facing scattered prompt functions with PromptBuilder calls. Mapping: buildTestWriterPrompt -> PromptBuilder.for('test-writer', { isolation: 'strict' }); buildTestWriterLitePrompt -> PromptBuilder.for('test-writer', { isolation: 'lite' }); buildImplementerPrompt -> PromptBuilder.for('implementer', { variant: 'standard' }); buildImplementerLitePrompt -> PromptBuilder.for('implementer', { variant: 'lite' }); buildVerifierPrompt -> PromptBuilder.for('verifier'); buildSingleSessionPrompt -> PromptBuilder.for('single-session'). Internal prompts (rectification, routing, batch) remain unchanged.",
-      "acceptanceCriteria": [
-        "All 6 user-facing prompt functions replaced with PromptBuilder calls in their respective call sites",
-        "buildImplementerRectificationPrompt, buildRectificationPrompt, buildBatchPrompt (execution), buildRoutingPrompt, buildBatchPrompt (routing) remain unchanged",
-        "Generated prompt text for each role is semantically equivalent to previous output when no user override is set (no regression)",
-        "All call sites pass workdir and config so the loader can check for overrides",
-        "src/tdd/prompts.ts and src/execution/prompts.ts deleted or reduced to re-exports only if referenced by tests",
-        "Integration test: build each of the 6 roles with no override, verify output contains story title, acceptance criteria, and role-specific instructions"
-      ],
-      "complexity": "medium",
-      "status": "pending",
-      "tags": [
-        "feature",
-        "prompts",
-        "migration",
-        "refactor"
-      ],
-      "attempts": 0,
-      "priorErrors": [],
-      "priorFailures": [],
-      "escalations": [],
-      "dependencies": [],
-      "storyPoints": 1
-    },
-    {
-      "id": "PB-005",
-      "title": "Document prompts config in nax config --explain and add precheck validation",
-      "description": "Users need to discover the prompts.overrides config block. Update nax config --explain to document it with example paths. Add a precheck warning (non-blocking) when a configured override file path does not exist at run start — surfaces the issue early rather than silently falling back to the default at runtime.",
-      "acceptanceCriteria": [
-        "nax config --explain output includes a 'prompts' section describing overrides for each role with example: '.nax/prompts/test-writer.md'",
-        "src/precheck/checks-warnings.ts adds check: for each key in config.prompts?.overrides, if resolved file does not exist, emit warning 'Prompt override file not found for role <role>: <resolved-path>'",
-        "Precheck warning is non-blocking — run continues with default template",
-        "Precheck skipped when config.prompts absent or overrides empty",
-        "Unit tests: override path exists -> no warning; override path set but file missing -> warning emitted; config.prompts absent -> no warning"
-      ],
-      "complexity": "simple",
-      "status": "pending",
-      "tags": [
-        "feature",
-        "prompts",
-        "docs",
-        "precheck"
-      ],
-      "attempts": 0,
-      "priorErrors": [],
-      "priorFailures": [],
-      "escalations": [],
-      "dependencies": [],
-      "storyPoints": 1
-    }
-  ]
-}

package/nax/features/prompt-builder/progress.txt

@@ -1,3 +0,0 @@
-[2026-03-08T07:17:53.244Z] PB-001 — PASSED — Create PromptBuilder class with layered section architecture — Cost: $0.3280
-[2026-03-08T07:29:04.611Z] PB-002 — PASSED — Implement typed sections: isolation, role-task, story, verdict, conventions — Cost: $0.1821
-[2026-03-08T07:39:44.184Z] PB-003 — PASSED — Implement default templates and user override loader — Cost: $0.2823

package/nax/features/review-quality/prd.json

@@ -1,55 +0,0 @@
-{
-  "project": "nax-review-quality",
-  "branchName": "feat/review-quality",
-  "feature": "review-quality",
-  "updatedAt": "2026-03-08T03:03:00.000Z",
-  "userStories": [
-    {
-      "id": "RQ-001",
-      "title": "Assert clean working tree before running review typecheck/lint (BUG-049)",
-      "description": "The review stage runs bun run typecheck and bun run lint on the working tree, not the committed state. If the agent forgets to git add a file (e.g. types.ts with a new interface field), the uncommitted change is still on disk, typecheck passes against the local working tree, but the committed code has a type error. This was observed in the routing-persistence run: RRP-003 committed contentHash refs in routing.ts without the matching StoryRouting.contentHash field in types.ts — typecheck passed because types.ts was locally modified but not staged. Fix: before running built-in checks in review/runner.ts, assert that the working tree has no uncommitted changes to tracked files (git diff --name-only HEAD returns empty). If dirty, fail the review with a clear message listing the uncommitted files so the agent can stage and commit them.",
-      "acceptanceCriteria": [
-        "Before running typecheck or lint in runReview(), call git diff --name-only HEAD (covers both staged and unstaged tracked-file changes)",
-        "If output is non-empty, return a ReviewResult with success: false and failureReason listing the uncommitted files",
-        "Log at warn level via getSafeLogger() with stage 'review' and message 'Uncommitted changes detected before review: <files>'",
-        "If working tree is clean, proceed with typecheck/lint as before — no regression for normal flow",
-        "Unit tests: dirty working tree (mock git diff) returns review failure before running typecheck; clean working tree allows typecheck to run normally",
-        "Unit tests: untracked files only (git diff HEAD returns empty) — review proceeds since only tracked changes matter"
-      ],
-      "complexity": "simple",
-      "status": "pending",
-      "tags": ["bug", "review", "typecheck"]
-    },
-    {
-      "id": "RQ-002",
-      "title": "Fix checkOptionalCommands precheck to use correct config resolution path (BUG-050)",
-      "description": "The precheck check checkOptionalCommands() in src/precheck/checks-warnings.ts checks config.execution.lintCommand and config.execution.typecheckCommand — these are legacy fields that no longer exist in the current config schema. The actual runtime resolution chain used by review/runner.ts is: (1) execution.typecheckCommand, (2) review.commands.typecheck, (3) package.json scripts. As a result, the precheck always warns 'Optional commands not configured: lint, typecheck' even when review.commands.typecheck and review.commands.lint are properly set. Fix: update checkOptionalCommands() to resolve via the same priority chain as review/runner.ts:resolveCommand().",
-      "acceptanceCriteria": [
-        "checkOptionalCommands() resolves typecheck via: execution.typecheckCommand -> review.commands.typecheck -> package.json typecheck script",
-        "checkOptionalCommands() resolves lint via: execution.lintCommand -> review.commands.lint -> package.json lint script",
-        "If config.review.commands.typecheck is set, precheck passes with no warning",
-        "If neither execution field, review.commands, nor package.json script exists, precheck still warns 'not configured'",
-        "Unit tests: config with review.commands.typecheck set -> check passes; config with neither -> check warns; config with package.json script -> check passes"
-      ],
-      "complexity": "simple",
-      "status": "pending",
-      "tags": ["bug", "precheck", "config"]
-    },
-    {
-      "id": "RQ-003",
-      "title": "Consolidate dead quality.commands.typecheck/lint into review resolution chain (BUG-051)",
-      "description": "QualityConfig.commands.typecheck and QualityConfig.commands.lint are declared in src/config/types.ts and documented in nax config --explain, but are never read by runtime code. The review runner reads only review.commands.typecheck/lint. Fix: make review/runner.ts:resolveCommand() also check quality.commands as a fallback after review.commands and before package.json. This gives quality.commands.typecheck semantic meaning without a breaking change. Do NOT remove the fields from QualityConfig — backward compatibility.",
-      "acceptanceCriteria": [
-        "review/runner.ts:resolveCommand() priority chain for typecheck: (1) execution.typecheckCommand, (2) review.commands.typecheck, (3) quality.commands.typecheck, (4) package.json typecheck script",
-        "review/runner.ts:resolveCommand() priority chain for lint: (1) execution.lintCommand, (2) review.commands.lint, (3) quality.commands.lint, (4) package.json lint script",
-        "Setting quality.commands.typecheck in config.json now correctly runs that command in the review stage",
-        "review.commands.typecheck still takes precedence over quality.commands.typecheck when both are set",
-        "CLI config --explain description for quality.commands.typecheck updated to note it is used as fallback in review stage",
-        "Unit tests: quality.commands.typecheck set with review.commands.typecheck absent -> quality command used; both set -> review command takes precedence"
-      ],
-      "complexity": "simple",
-      "status": "pending",
-      "tags": ["bug", "config", "review"]
-    }
-  ]
-}