@nathapp/nax 0.27.0 → 0.28.0

package/src/tdd/rectification-gate.ts

@@ -34,9 +34,9 @@ export async function runFullSuiteGate(
   contextMarkdown: string | undefined,
   lite: boolean,
   logger: ReturnType<typeof getLogger>,
-): Promise<void> {
+): Promise<boolean> {
   const rectificationEnabled = config.execution.rectification?.enabled ?? false;
-  if (!rectificationEnabled) return;
+  if (!rectificationEnabled) return false;
 
   const rectificationConfig = config.execution.rectification;
   const testCmd = config.quality?.commands?.test ?? "bun test";
@@ -54,7 +54,7 @@ export async function runFullSuiteGate(
     const testSummary = parseBunTestOutput(fullSuiteResult.output);
 
     if (testSummary.failed > 0) {
-      await runRectificationLoop(
+      return await runRectificationLoop(
         story,
         config,
         workdir,
@@ -69,14 +69,18 @@ export async function runFullSuiteGate(
         fullSuiteTimeout,
       );
     }
-  } else if (fullSuitePassed) {
+    // No failures detected despite non-zero exit — treat as passed
+    return true;
+  }
+  if (fullSuitePassed) {
     logger.info("tdd", "Full suite gate passed", { storyId: story.id });
-  } else {
-    logger.warn("tdd", "Full suite gate execution failed (no output)", {
-      storyId: story.id,
-      exitCode: fullSuiteResult.exitCode,
-    });
+    return true;
   }
+  logger.warn("tdd", "Full suite gate execution failed (no output)", {
+    storyId: story.id,
+    exitCode: fullSuiteResult.exitCode,
+  });
+  return false;
 }
 
 /** Run the rectification retry loop when full suite gate detects regressions. */
@@ -93,7 +97,7 @@ async function runRectificationLoop(
   rectificationConfig: NonNullable<NaxConfig["execution"]["rectification"]>,
   testCmd: string,
   fullSuiteTimeout: number,
-): Promise<void> {
+): Promise<boolean> {
   const rectificationState: RectificationState = {
     attempt: 0,
     initialFailures: testSummary.failed,
@@ -156,7 +160,7 @@ async function runRectificationLoop(
         storyId: story.id,
         attempt: rectificationState.attempt,
       });
-      break;
+      return true;
     }
 
     if (retryFullSuite.output) {
@@ -177,7 +181,8 @@ async function runRectificationLoop(
       attempts: rectificationState.attempt,
       remainingFailures: rectificationState.currentFailures,
     });
-  } else {
-    logger.info("tdd", "Full suite gate passed", { storyId: story.id });
+    return false;
   }
+  logger.info("tdd", "Full suite gate passed", { storyId: story.id });
+  return true;
 }

package/src/tdd/session-runner.ts

@@ -9,15 +9,9 @@ import type { ModelTier, NaxConfig } from "../config";
 import { resolveModel } from "../config";
 import { getLogger } from "../logger";
 import type { UserStory } from "../prd";
+import { PromptBuilder } from "../prompts";
 import { cleanupProcessTree } from "./cleanup";
 import { getChangedFiles, verifyImplementerIsolation, verifyTestWriterIsolation } from "./isolation";
-import {
-  buildImplementerLitePrompt,
-  buildImplementerPrompt,
-  buildTestWriterLitePrompt,
-  buildTestWriterPrompt,
-  buildVerifierPrompt,
-} from "./prompts";
 import type { IsolationCheck } from "./types";
 import type { TddSessionResult, TddSessionRole } from "./types";
 
@@ -95,15 +89,21 @@ export async function runTddSession(
   let prompt: string;
   switch (role) {
     case "test-writer":
-      prompt = lite ? buildTestWriterLitePrompt(story, contextMarkdown) : buildTestWriterPrompt(story, contextMarkdown);
+      prompt = await PromptBuilder.for("test-writer", { isolation: lite ? "lite" : "strict" })
+        .withLoader(workdir, config)
+        .story(story)
+        .context(contextMarkdown)
+        .build();
       break;
     case "implementer":
-      prompt = lite
-        ? buildImplementerLitePrompt(story, contextMarkdown)
-        : buildImplementerPrompt(story, contextMarkdown);
+      prompt = await PromptBuilder.for("implementer", { variant: lite ? "lite" : "standard" })
+        .withLoader(workdir, config)
+        .story(story)
+        .context(contextMarkdown)
+        .build();
       break;
     case "verifier":
-      prompt = buildVerifierPrompt(story);
+      prompt = await PromptBuilder.for("verifier").withLoader(workdir, config).story(story).build();
       break;
   }
 

package/src/tdd/types.ts

@@ -78,4 +78,6 @@ export interface ThreeSessionTddResult {
    * undefined = verdict was not attempted (e.g. early-exit before session 3 ran)
    */
   verdict?: import("./verdict").VerifierVerdict | null;
+  /** Whether the TDD full-suite gate passed (used by verify stage to skip redundant run, BUG-054) */
+  fullSuiteGatePassed?: boolean;
 }

package/test/integration/cli/cli-config-prompts-explain.test.ts

@@ -0,0 +1,74 @@
+/**
+ * Integration tests for `nax config --explain` prompts section (PB-005)
+ *
+ * Verifies that the prompts.overrides config block is documented in the
+ * --explain output with example paths.
+ */
+
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { afterEach, beforeEach, describe, expect, test } from "bun:test";
+import { configCommand } from "../../../src/cli/config";
+import { loadConfig } from "../../../src/config/loader";
+
+describe("config --explain: prompts section", () => {
+  let tempDir: string;
+  let originalCwd: string;
+  let consoleOutput: string[];
+  let originalConsoleLog: typeof console.log;
+
+  beforeEach(() => {
+    tempDir = mkdtempSync(join(tmpdir(), "nax-config-prompts-test-"));
+    originalCwd = process.cwd();
+
+    consoleOutput = [];
+    originalConsoleLog = console.log;
+    console.log = (...args: unknown[]) => {
+      consoleOutput.push(args.map((a) => String(a)).join(" "));
+    };
+  });
+
+  afterEach(() => {
+    console.log = originalConsoleLog;
+    process.chdir(originalCwd);
+    rmSync(tempDir, { recursive: true, force: true });
+  });
+
+  test("explain output includes a prompts section", async () => {
+    const config = await loadConfig(tempDir);
+    await configCommand(config, { explain: true });
+
+    const output = consoleOutput.join("\n");
+    expect(output).toContain("prompts");
+  });
+
+  test("explain output documents prompts.overrides", async () => {
+    const config = await loadConfig(tempDir);
+    await configCommand(config, { explain: true });
+
+    const output = consoleOutput.join("\n");
+    expect(output).toContain("prompts.overrides");
+  });
+
+  test("explain output includes example path .nax/prompts/test-writer.md", async () => {
+    const config = await loadConfig(tempDir);
+    await configCommand(config, { explain: true });
+
+    const output = consoleOutput.join("\n");
+    expect(output).toContain(".nax/prompts/test-writer.md");
+  });
+
+  test("explain output mentions override roles (test-writer, implementer, verifier)", async () => {
+    const config = await loadConfig(tempDir);
+    await configCommand(config, { explain: true });
+
+    const output = consoleOutput.join("\n");
+    // At least one of the roles should appear in the prompts documentation
+    const mentionsRole =
+      output.includes("test-writer") ||
+      output.includes("implementer") ||
+      output.includes("verifier");
+    expect(mentionsRole).toBe(true);
+  });
+});