@nathapp/nax 0.24.0 → 0.26.0

package/test/unit/pipeline/stages/execution-merge-conflict.test.ts

@@ -0,0 +1,218 @@
+/**
+ * Unit tests for merge-conflict trigger wiring in execution stage (TC-003)
+ *
+ * Covers:
+ * - Agent output with CONFLICT + trigger enabled + chain aborts → fail
+ * - Agent output with CONFLICT + trigger enabled + chain approves → continue
+ * - Agent output with CONFLICT + trigger disabled → no trigger call
+ * - Agent output without CONFLICT + trigger enabled → no trigger call
+ */
+
+import { afterEach, describe, expect, mock, test } from "bun:test";
+import type { NaxConfig } from "../../../../src/config";
+import { InteractionChain } from "../../../../src/interaction/chain";
+import type { InteractionPlugin, InteractionResponse } from "../../../../src/interaction/types";
+import { _executionDeps } from "../../../../src/pipeline/stages/execution";
+import type { PipelineContext } from "../../../../src/pipeline/types";
+import type { PRD, UserStory } from "../../../../src/prd";
+
+// ─────────────────────────────────────────────────────────────────────────────
+// Save originals for restoration
+// ─────────────────────────────────────────────────────────────────────────────
+
+const originalDetectMergeConflict = _executionDeps.detectMergeConflict;
+const originalCheckMergeConflict = _executionDeps.checkMergeConflict;
+
+// ─────────────────────────────────────────────────────────────────────────────
+// Helpers
+// ─────────────────────────────────────────────────────────────────────────────
+
+function makeChain(action: InteractionResponse["action"]): InteractionChain {
+  const chain = new InteractionChain({ defaultTimeout: 5000, defaultFallback: "abort" });
+  const plugin: InteractionPlugin = {
+    name: "test",
+    send: mock(async () => {}),
+    receive: mock(async (id: string): Promise<InteractionResponse> => ({
+      requestId: id,
+      action,
+      respondedBy: "user",
+      respondedAt: Date.now(),
+    })),
+  };
+  chain.register(plugin);
+  return chain;
+}
+
+function makeConfig(triggers: Record<string, unknown>): NaxConfig {
+  return {
+    autoMode: { defaultAgent: "test-agent" },
+    models: { fast: "claude-haiku-4-5", balanced: "claude-sonnet-4-5", powerful: "claude-opus-4-5" },
+    execution: {
+      sessionTimeoutSeconds: 60,
+      dangerouslySkipPermissions: false,
+      costLimit: 10,
+      maxIterations: 10,
+      rectification: { maxRetries: 3 },
+    },
+    interaction: {
+      plugin: "cli",
+      defaults: { timeout: 30000, fallback: "abort" as const },
+      triggers,
+    },
+  } as unknown as NaxConfig;
+}
+
+function makeStory(): UserStory {
+  return {
+    id: "US-001",
+    title: "Test Story",
+    description: "Test",
+    acceptanceCriteria: [],
+    tags: [],
+    dependencies: [],
+    status: "in-progress",
+    passes: false,
+    escalations: [],
+    attempts: 1,
+  };
+}
+
+function makePRD(): PRD {
+  return {
+    project: "test",
+    feature: "my-feature",
+    branchName: "test-branch",
+    createdAt: new Date().toISOString(),
+    updatedAt: new Date().toISOString(),
+    userStories: [makeStory()],
+  };
+}
+
+function makeSuccessfulAgent() {
+  return {
+    name: "test-agent",
+    capabilities: { supportedTiers: ["fast", "balanced", "powerful"] },
+    run: mock(async () => ({
+      success: true,
+      exitCode: 0,
+      output: "CONFLICT (content): Merge conflict in src/foo.ts",
+      stderr: "",
+      rateLimited: false,
+      durationMs: 100,
+      estimatedCost: 0.01,
+    })),
+  };
+}
+
+function makeCtx(config: NaxConfig, interaction?: InteractionChain): PipelineContext {
+  return {
+    config,
+    prd: makePRD(),
+    story: makeStory(),
+    stories: [makeStory()],
+    routing: { complexity: "simple", modelTier: "fast", testStrategy: "test-after", reasoning: "" },
+    workdir: "/tmp/test",
+    prompt: "Do something",
+    hooks: {} as PipelineContext["hooks"],
+    interaction,
+  } as unknown as PipelineContext;
+}
+
+afterEach(() => {
+  mock.restore();
+  _executionDeps.detectMergeConflict = originalDetectMergeConflict;
+  _executionDeps.checkMergeConflict = originalCheckMergeConflict;
+  _executionDeps.getAgent = _executionDeps.getAgent; // restored via mock.restore()
+});
+
+// ─────────────────────────────────────────────────────────────────────────────
+// Merge conflict trigger tests (via _executionDeps injection)
+// ─────────────────────────────────────────────────────────────────────────────
+
+describe("executionStage — merge-conflict trigger", () => {
+  test("returns fail when conflict detected and trigger responds abort", async () => {
+    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
+    const agent = makeSuccessfulAgent();
+    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
+    _executionDeps.detectMergeConflict = mock(() => true);
+    _executionDeps.checkMergeConflict = mock(async () => false);
+
+    const config = makeConfig({ "merge-conflict": { enabled: true } });
+    const chain = makeChain("abort");
+    const ctx = makeCtx(config, chain);
+
+    const result = await executionStage.execute(ctx);
+
+    expect(result.action).toBe("fail");
+    expect((result as { reason?: string }).reason).toContain("Merge conflict");
+    expect(_executionDeps.detectMergeConflict).toHaveBeenCalled();
+    expect(_executionDeps.checkMergeConflict).toHaveBeenCalledTimes(1);
+  });
+
+  test("returns continue when conflict detected but trigger approves", async () => {
+    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
+    const agent = makeSuccessfulAgent();
+    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
+    _executionDeps.detectMergeConflict = mock(() => true);
+    _executionDeps.checkMergeConflict = mock(async () => true);
+
+    const config = makeConfig({ "merge-conflict": { enabled: true } });
+    const chain = makeChain("approve");
+    const ctx = makeCtx(config, chain);
+
+    const result = await executionStage.execute(ctx);
+
+    expect(result.action).toBe("continue");
+    expect(_executionDeps.checkMergeConflict).toHaveBeenCalledTimes(1);
+  });
+
+  test("does not call trigger when trigger is disabled", async () => {
+    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
+    const agent = makeSuccessfulAgent();
+    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
+    _executionDeps.detectMergeConflict = mock(() => true);
+    _executionDeps.checkMergeConflict = mock(async () => false);
+
+    const config = makeConfig({});
+    const chain = makeChain("abort");
+    const ctx = makeCtx(config, chain);
+
+    const result = await executionStage.execute(ctx);
+
+    expect(result.action).toBe("continue");
+    expect(_executionDeps.checkMergeConflict).not.toHaveBeenCalled();
+  });
+
+  test("does not call trigger when no conflict detected", async () => {
+    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
+    const agent = makeSuccessfulAgent();
+    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
+    _executionDeps.detectMergeConflict = mock(() => false);
+    _executionDeps.checkMergeConflict = mock(async () => false);
+
+    const config = makeConfig({ "merge-conflict": { enabled: true } });
+    const chain = makeChain("abort");
+    const ctx = makeCtx(config, chain);
+
+    const result = await executionStage.execute(ctx);
+
+    expect(result.action).toBe("continue");
+    expect(_executionDeps.checkMergeConflict).not.toHaveBeenCalled();
+  });
+
+  test("does not call trigger when no interaction chain", async () => {
+    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
+    const agent = makeSuccessfulAgent();
+    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
+    _executionDeps.detectMergeConflict = mock(() => true);
+    _executionDeps.checkMergeConflict = mock(async () => false);
+
+    const config = makeConfig({ "merge-conflict": { enabled: true } });
+    const ctx = makeCtx(config); // no chain
+
+    const result = await executionStage.execute(ctx);
+
+    expect(result.action).toBe("continue");
+    expect(_executionDeps.checkMergeConflict).not.toHaveBeenCalled();
+  });
+});

package/test/unit/pipeline/stages/review.test.ts

@@ -0,0 +1,201 @@
+/**
+ * Unit tests for security-review trigger wiring in review stage (TC-003)
+ *
+ * Covers:
+ * - Plugin reviewer failure with no trigger → always fail
+ * - Plugin reviewer failure + trigger abort → fail
+ * - Plugin reviewer failure + trigger non-abort → escalate
+ * - Built-in check failure → escalate (unchanged)
+ */
+
+import { afterEach, describe, expect, mock, test } from "bun:test";
+import type { NaxConfig } from "../../../../src/config";
+import { InteractionChain } from "../../../../src/interaction/chain";
+import type { InteractionPlugin, InteractionResponse } from "../../../../src/interaction/types";
+import { _reviewDeps, reviewStage } from "../../../../src/pipeline/stages/review";
+import type { PipelineContext } from "../../../../src/pipeline/types";
+import type { PRD, UserStory } from "../../../../src/prd";
+
+// ─────────────────────────────────────────────────────────────────────────────
+// Helpers
+// ─────────────────────────────────────────────────────────────────────────────
+
+const originalCheckSecurityReview = _reviewDeps.checkSecurityReview;
+
+function makeChain(action: InteractionResponse["action"]): InteractionChain {
+  const chain = new InteractionChain({ defaultTimeout: 5000, defaultFallback: "abort" });
+  const plugin: InteractionPlugin = {
+    name: "test",
+    send: mock(async () => {}),
+    receive: mock(async (id: string): Promise<InteractionResponse> => ({
+      requestId: id,
+      action,
+      respondedBy: "user",
+      respondedAt: Date.now(),
+    })),
+  };
+  chain.register(plugin);
+  return chain;
+}
+
+function makeConfig(triggers: Record<string, unknown>): NaxConfig {
+  return {
+    review: { enabled: true },
+    interaction: {
+      plugin: "cli",
+      defaults: { timeout: 30000, fallback: "abort" as const },
+      triggers,
+    },
+  } as unknown as NaxConfig;
+}
+
+function makeStory(overrides?: Partial<UserStory>): UserStory {
+  return {
+    id: "US-001",
+    title: "Test Story",
+    description: "Test",
+    acceptanceCriteria: [],
+    tags: [],
+    dependencies: [],
+    status: "in-progress",
+    passes: false,
+    escalations: [],
+    attempts: 1,
+    ...overrides,
+  };
+}
+
+function makePRD(): PRD {
+  return {
+    project: "test",
+    feature: "my-feature",
+    branchName: "test-branch",
+    createdAt: new Date().toISOString(),
+    updatedAt: new Date().toISOString(),
+    userStories: [makeStory()],
+  };
+}
+
+function makeCtx(overrides: Partial<PipelineContext>): PipelineContext {
+  return {
+    config: makeConfig({}),
+    prd: makePRD(),
+    story: makeStory(),
+    stories: [makeStory()],
+    routing: { complexity: "simple", modelTier: "fast", testStrategy: "test-after", reasoning: "" },
+    workdir: "/tmp/test",
+    hooks: {} as PipelineContext["hooks"],
+    ...overrides,
+  } as unknown as PipelineContext;
+}
+
+afterEach(() => {
+  mock.restore();
+  _reviewDeps.checkSecurityReview = originalCheckSecurityReview;
+});
+
+// ─────────────────────────────────────────────────────────────────────────────
+// Plugin reviewer failure — no trigger configured (today behavior)
+// ─────────────────────────────────────────────────────────────────────────────
+
+describe("reviewStage — plugin failure, no trigger", () => {
+  test("returns fail when plugin reviewer fails and trigger not enabled", async () => {
+    const reviewResult = { success: false, pluginFailed: true, failureReason: "semgrep found issues", builtIn: { totalDurationMs: 0 } };
+    const orchestratorMock = mock(async () => reviewResult);
+    // biome-ignore lint/suspicious/noExplicitAny: test-only import override
+    const { reviewOrchestrator } = await import("../../../../src/review/orchestrator");
+    const original = reviewOrchestrator.review;
+    reviewOrchestrator.review = orchestratorMock as typeof reviewOrchestrator.review;
+
+    const ctx = makeCtx({ config: makeConfig({}) });
+    const result = await reviewStage.execute(ctx);
+
+    expect(result.action).toBe("fail");
+    reviewOrchestrator.review = original;
+  });
+});
+
+// ─────────────────────────────────────────────────────────────────────────────
+// Plugin reviewer failure — trigger wired via _reviewDeps
+// ─────────────────────────────────────────────────────────────────────────────
+
+describe("reviewStage — security-review trigger via _reviewDeps", () => {
+  test("returns fail when trigger responds abort (checkSecurityReview returns false)", async () => {
+    _reviewDeps.checkSecurityReview = mock(async () => false);
+
+    const reviewResult = { success: false, pluginFailed: true, failureReason: "semgrep critical", builtIn: { totalDurationMs: 0 } };
+    const { reviewOrchestrator } = await import("../../../../src/review/orchestrator");
+    const original = reviewOrchestrator.review;
+    reviewOrchestrator.review = mock(async () => reviewResult) as typeof reviewOrchestrator.review;
+
+    const chain = makeChain("abort");
+    const ctx = makeCtx({
+      config: makeConfig({ "security-review": { enabled: true } }),
+      interaction: chain,
+    });
+    const result = await reviewStage.execute(ctx);
+
+    expect(result.action).toBe("fail");
+    expect(_reviewDeps.checkSecurityReview).toHaveBeenCalledTimes(1);
+    reviewOrchestrator.review = original;
+  });
+
+  test("returns escalate when trigger responds non-abort (checkSecurityReview returns true)", async () => {
+    _reviewDeps.checkSecurityReview = mock(async () => true);
+
+    const reviewResult = { success: false, pluginFailed: true, failureReason: "semgrep warning", builtIn: { totalDurationMs: 0 } };
+    const { reviewOrchestrator } = await import("../../../../src/review/orchestrator");
+    const original = reviewOrchestrator.review;
+    reviewOrchestrator.review = mock(async () => reviewResult) as typeof reviewOrchestrator.review;
+
+    const chain = makeChain("approve");
+    const ctx = makeCtx({
+      config: makeConfig({ "security-review": { enabled: true } }),
+      interaction: chain,
+    });
+    const result = await reviewStage.execute(ctx);
+
+    expect(result.action).toBe("escalate");
+    expect(_reviewDeps.checkSecurityReview).toHaveBeenCalledTimes(1);
+    reviewOrchestrator.review = original;
+  });
+
+  test("does not call trigger when no interaction chain present", async () => {
+    _reviewDeps.checkSecurityReview = mock(async () => true);
+
+    const reviewResult = { success: false, pluginFailed: true, failureReason: "semgrep error", builtIn: { totalDurationMs: 0 } };
+    const { reviewOrchestrator } = await import("../../../../src/review/orchestrator");
+    const original = reviewOrchestrator.review;
+    reviewOrchestrator.review = mock(async () => reviewResult) as typeof reviewOrchestrator.review;
+
+    const ctx = makeCtx({
+      config: makeConfig({ "security-review": { enabled: true } }),
+      // no interaction
+    });
+    const result = await reviewStage.execute(ctx);
+
+    expect(result.action).toBe("fail");
+    expect(_reviewDeps.checkSecurityReview).not.toHaveBeenCalled();
+    reviewOrchestrator.review = original;
+  });
+
+  test("built-in check failure still returns escalate (unchanged behavior)", async () => {
+    _reviewDeps.checkSecurityReview = mock(async () => false);
+
+    const reviewResult = { success: false, pluginFailed: false, failureReason: "lint failed", builtIn: { totalDurationMs: 0 } };
+    const { reviewOrchestrator } = await import("../../../../src/review/orchestrator");
+    const original = reviewOrchestrator.review;
+    reviewOrchestrator.review = mock(async () => reviewResult) as typeof reviewOrchestrator.review;
+
+    const ctx = makeCtx({
+      config: makeConfig({ "security-review": { enabled: true } }),
+      interaction: makeChain("abort"),
+    });
+    const result = await reviewStage.execute(ctx);
+
+    expect(result.action).toBe("escalate");
+    // security-review trigger should NOT fire for built-in check failures
+    expect(_reviewDeps.checkSecurityReview).not.toHaveBeenCalled();
+    reviewOrchestrator.review = original;
+  });
+});

package/test/unit/pipeline/stages/routing-idempotence.test.ts

@@ -0,0 +1,139 @@
+/**
+ * Routing Stage — RRP-001: Idempotence and Dependencies
+ *
+ * AC-4: Tests for idempotent persistence and dependency exposure.
+ */
+
+import { afterEach, beforeEach, describe, expect, mock, test } from "bun:test";
+import { DEFAULT_CONFIG } from "../../../../src/config/defaults";
+import type { NaxConfig } from "../../../../src/config";
+import type { PRD, UserStory } from "../../../../src/prd";
+import type { PipelineContext } from "../../../../src/pipeline/types";
+
+// ---------------------------------------------------------------------------
+// Helpers
+// ---------------------------------------------------------------------------
+
+function makeStory(overrides?: Partial<UserStory>): UserStory {
+  return {
+    id: "US-001",
+    title: "Test Story",
+    description: "Test description",
+    acceptanceCriteria: [],
+    tags: [],
+    dependencies: [],
+    status: "in-progress",
+    passes: false,
+    escalations: [],
+    attempts: 0,
+    ...overrides,
+  };
+}
+
+function makePRD(story: UserStory): PRD {
+  return {
+    project: "test-project",
+    feature: "test-feature",
+    branchName: "feat/test",
+    createdAt: new Date().toISOString(),
+    updatedAt: new Date().toISOString(),
+    userStories: [story],
+  };
+}
+
+function makeConfig(): NaxConfig {
+  return {
+    ...DEFAULT_CONFIG,
+    tdd: {
+      ...DEFAULT_CONFIG.tdd,
+      greenfieldDetection: false,
+    },
+  };
+}
+
+function makeCtx(story: UserStory, overrides?: Partial<PipelineContext>): PipelineContext & { prdPath: string } {
+  const prd = makePRD(story);
+  return {
+    config: makeConfig(),
+    prd,
+    story,
+    stories: [story],
+    routing: {
+      complexity: "simple",
+      modelTier: "fast",
+      testStrategy: "test-after",
+      reasoning: "test",
+    },
+    workdir: "/tmp/nax-routing-test",
+    hooks: { hooks: {} },
+    prdPath: "/tmp/nax-routing-test/nax/prd.json",
+    ...overrides,
+  } as PipelineContext & { prdPath: string };
+}
+
+const FRESH_ROUTING_RESULT = {
+  complexity: "medium" as const,
+  modelTier: "balanced" as const,
+  testStrategy: "three-session-tdd" as const,
+  reasoning: "classified by routeStory",
+};
+
+// ---------------------------------------------------------------------------
+// AC-4: savePRD called once per story, not on every iteration
+// ---------------------------------------------------------------------------
+
+describe("routingStage - savePRD called exactly once per story (not per iteration)", () => {
+  let origRoutingDeps: typeof import("../../../../src/pipeline/stages/routing")["_routingDeps"];
+
+  afterEach(() => {
+    mock.restore();
+    if (origRoutingDeps) {
+      const { _routingDeps } = require("../../../../src/pipeline/stages/routing");
+      Object.assign(_routingDeps, origRoutingDeps);
+    }
+  });
+
+  test("calling routingStage twice with routing already set only triggers savePRD once (first call)", async () => {
+    const { routingStage, _routingDeps } = await import(
+      "../../../../src/pipeline/stages/routing"
+    );
+
+    origRoutingDeps = { ..._routingDeps };
+
+    let savePRDCallCount = 0;
+
+    _routingDeps.routeStory = mock(() =>
+      Promise.resolve({ ...FRESH_ROUTING_RESULT }),
+    );
+    _routingDeps.isGreenfieldStory = mock(() => Promise.resolve(false));
+    _routingDeps.savePRD = mock((_prd: PRD, _path: string) => {
+      savePRDCallCount++;
+      return Promise.resolve();
+    });
+
+    // First iteration: story.routing is undefined → should persist
+    const story = makeStory({ routing: undefined });
+    const ctx = makeCtx(story);
+
+    await routingStage.execute(ctx as Parameters<typeof routingStage.execute>[0]);
+
+    // After first execution, story.routing is populated (simulating resume after crash)
+    // Second iteration: story.routing is now set → should NOT persist again
+    await routingStage.execute(ctx as Parameters<typeof routingStage.execute>[0]);
+
+    expect(savePRDCallCount).toBe(1);
+  });
+});
+
+// ---------------------------------------------------------------------------
+// Sanity: _routingDeps exposes savePRD (fail if not added to deps object)
+// ---------------------------------------------------------------------------
+
+describe("routingStage - _routingDeps exposes savePRD", () => {
+  test("_routingDeps has a savePRD function", async () => {
+    const { _routingDeps } = await import(
+      "../../../../src/pipeline/stages/routing"
+    );
+    expect(typeof _routingDeps.savePRD).toBe("function");
+  });
+});