@nathapp/nax 0.18.5 → 0.18.6

package/.gitlab-ci.yml

@@ -17,7 +17,7 @@ test:
   stage: test
   image: 
     name: nathapp/node-bun:22.21.0-1.3.9-alpine
-    pull_policy: if-not-present
+    pull_policy: always
   before_script:
     - apk add --no-cache git 
     - git config --global safe.directory '*'
@@ -47,7 +47,7 @@ release:
   stage: release
   image: 
     name: nathapp/node-bun:22.21.0-1.3.9-alpine
-    pull_policy: if-not-present
+    pull_policy: always
   cache:
     key:
       files:
@@ -86,7 +86,7 @@ notify:
   stage: notify
   image: 
     name: registry-intl.cn-hongkong.aliyuncs.com/gkci/node:22.14.0-alpine-ci
-    pull_policy: if-not-present
+    pull_policy: always
   needs: [release]
   script:
     - VERSION=$(node -e "console.log(require('./package.json').version)")

package/CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.18.6] - 2026-03-04
+
+### Fixed
+- **BUG-2:** Infinite PTY respawn loop in `usePty` hook by destructuring object-identity dependencies.
+- **MEM-1 & MEM-3:** Prevented child process hangs on full `stderr` pipes by switching to `stderr: "inherit"`.
+- **BUG-21 & BUG-22:** Added missing error handling and `.catch()` chains to process `stdout` streaming and exit handlers.
+
 ## [0.18.5] - 2026-03-04
 
 ### Changed

package/docs/ROADMAP.md

@@ -134,7 +134,7 @@
 
 ---
 
-## v0.19.0 — Verification Architecture v2
+## v0.19.0 — Hardening & Compliance
 
 **Theme:** Eliminate duplicate test runs, deferred regression gate, structured escalation context
 **Status:** 🔲 Planned
@@ -166,6 +166,7 @@
 | Version | Theme | Date | Details |
 |:---|:---|:---|:---|
 | v0.18.1 | Type Safety + CI Pipeline | 2026-03-03 | 60 TS errors + 12 lint errors fixed, GitLab CI green (1952/56/0) |
+| v0.19.0 | Hardening & Compliance | TBD | SEC-1 to SEC-5, BUG-1, Node.js API removal, _deps rollout |
 | v0.18.5 | Bun PTY Migration | 2026-03-04 | BUN-001: node-pty → Bun.spawn, CI cleanup, flaky test fix |
 | v0.18.4 | Routing Stability | 2026-03-04 | BUG-031 keyword drift, BUG-033 LLM retry, pre-commit hook |
 | v0.18.3 | Execution Reliability + Smart Runner | 2026-03-04 | BUG-026/028/029/030/032 + SFC-001/002 + STR-007, all items complete |

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nathapp/nax",
-  "version": "0.18.5",
+  "version": "0.18.6",
   "description": "AI Coding Agent Orchestrator \u2014 loops until done",
   "type": "module",
   "bin": {

package/src/agents/claude.ts

@@ -172,7 +172,7 @@ export class ClaudeCodeAdapter implements AgentAdapter {
     const proc = Bun.spawn(cmd, {
       cwd: options.workdir,
       stdout: "pipe",
-      stderr: "pipe",
+      stderr: "inherit", // MEM-3: Inherit stderr to avoid blocking on unread pipe
       env: this.buildAllowedEnv(options),
     });
 
@@ -255,7 +255,7 @@ export class ClaudeCodeAdapter implements AgentAdapter {
     const proc = Bun.spawn(cmd, {
       cwd: options.workdir,
       stdout: "pipe",
-      stderr: "pipe",
+      stderr: "inherit", // MEM-3: Inherit stderr to avoid blocking on unread pipe
       env: this.buildAllowedEnv({
         workdir: options.workdir,
         modelDef: options.modelDef || { provider: "anthropic", model: "claude-sonnet-4-5", env: {} },
@@ -295,7 +295,7 @@ export class ClaudeCodeAdapter implements AgentAdapter {
       env: { ...this.buildAllowedEnv(options), TERM: "xterm-256color", FORCE_COLOR: "1" },
       stdin: "pipe",
       stdout: "pipe",
-      stderr: "pipe",
+      stderr: "inherit", // MEM-3: Inherit stderr to avoid blocking on unread pipe
     });
 
     const pidRegistry = this.getPidRegistry(options.workdir);
@@ -303,16 +303,26 @@ export class ClaudeCodeAdapter implements AgentAdapter {
 
     // Stream stdout to onOutput callback
     (async () => {
-      for await (const chunk of proc.stdout) {
-        options.onOutput(Buffer.from(chunk));
+      try {
+        for await (const chunk of proc.stdout) {
+          options.onOutput(Buffer.from(chunk));
+        }
+      } catch (err) {
+        // BUG-21: Handle stream errors to avoid unhandled rejections
+        getLogger()?.error("agent", "runInteractive stdout error", { err });
       }
     })();
 
     // Fire onExit when process completes
-    proc.exited.then((code) => {
-      pidRegistry.unregister(proc.pid).catch(() => {});
-      options.onExit(code ?? 1);
-    });
+    proc.exited
+      .then((code) => {
+        pidRegistry.unregister(proc.pid).catch(() => {});
+        options.onExit(code ?? 1);
+      })
+      .catch((err) => {
+        // BUG-22: Guard against onExit or unregister throws
+        getLogger()?.error("agent", "runInteractive exit error", { err });
+      });
 
     return {
       write: (data: string) => {

package/src/tui/hooks/usePty.ts

@@ -84,19 +84,25 @@ export function usePty(options: PtySpawnOptions | null): PtyState & { handle: Pt
   const [ptyProcess, setPtyProcess] = useState<ReturnType<typeof Bun.spawn> | null>(null);
 
   // Spawn PTY process
+  // BUG-2: Destructure options to prevent infinite respawn loop due to object identity
+  const command = options?.command;
+  const argsJson = JSON.stringify(options?.args);
+  const cwd = options?.cwd;
+  const envJson = JSON.stringify(options?.env);
+
   useEffect(() => {
-    if (!options) {
+    if (!command) {
       return;
     }
 
     // BUN-001: Replaced node-pty with Bun.spawn (piped stdio).
     // TERM + FORCE_COLOR preserve Claude Code output formatting.
-    const proc = Bun.spawn([options.command, ...(options.args || [])], {
-      cwd: options.cwd || process.cwd(),
-      env: { ...process.env, ...options.env, TERM: "xterm-256color", FORCE_COLOR: "1" },
+    const proc = Bun.spawn([command, ...(JSON.parse(argsJson) || [])], {
+      cwd: cwd || process.cwd(),
+      env: { ...process.env, ...JSON.parse(envJson), TERM: "xterm-256color", FORCE_COLOR: "1" },
       stdin: "pipe",
       stdout: "pipe",
-      stderr: "pipe",
+      stderr: "inherit", // MEM-1: Inherit stderr to avoid blocking on unread pipe
     });
 
     setPtyProcess(proc);
@@ -128,9 +134,14 @@ export function usePty(options: PtySpawnOptions | null): PtyState & { handle: Pt
     })();
 
     // Handle exit
-    proc.exited.then((code) => {
-      setState((prev) => ({ ...prev, isRunning: false, exitCode: code ?? undefined }));
-    });
+    proc.exited
+      .then((code) => {
+        setState((prev) => ({ ...prev, isRunning: false, exitCode: code ?? undefined }));
+      })
+      .catch(() => {
+        // BUG-22: Guard against setState throws (e.g. on unmount)
+        setState((prev) => ({ ...prev, isRunning: false }));
+      });
 
     // Create handle
     const ptyHandle: PtyHandle = {
@@ -152,7 +163,7 @@ export function usePty(options: PtySpawnOptions | null): PtyState & { handle: Pt
     return () => {
       proc.kill();
     };
-  }, [options]);
+  }, [command, argsJson, cwd, envJson]);
 
   // Handle terminal resize
   // resize is a no-op with Bun.spawn (no PTY) — kept for API compatibility