@nathapp/nax 0.18.1

package/test/unit/run-lifecycle.test.ts

@@ -0,0 +1,140 @@
+/**
+ * Tests for src/execution/run-lifecycle.ts
+ *
+ * Covers: RunLifecycle teardown critical paths
+ */
+
+import { describe, expect, it, mock } from "bun:test";
+import type { NaxConfig } from "../../src/config";
+import { RunLifecycle } from "../../src/execution/lifecycle";
+import type { LoadedHooksConfig } from "../../src/hooks";
+
+// ─────────────────────────────────────────────────────────────────────────────
+// Test fixtures
+// ─────────────────────────────────────────────────────────────────────────────
+
+const mockConfig: NaxConfig = {
+  autoMode: { defaultAgent: "claude" },
+  routing: { strategy: "complexity", llm: { mode: "hybrid" } },
+  execution: {
+    maxStoriesPerFeature: 100,
+    sessionTimeoutSeconds: 600,
+    maxIterations: 50,
+    costLimitUSD: 10.0,
+  },
+  models: {
+    fast: { provider: "anthropic", name: "claude-3-haiku-20240307" },
+    balanced: { provider: "anthropic", name: "claude-3-5-sonnet-20241022" },
+    powerful: { provider: "anthropic", name: "claude-opus-4-20250514" },
+  },
+  tierOrder: [
+    { tier: "fast", attempts: 3 },
+    { tier: "balanced", attempts: 2 },
+    { tier: "powerful", attempts: 1 },
+  ],
+  plugins: [],
+  tdd: { enabled: true },
+} as NaxConfig;
+
+const mockHooks: LoadedHooksConfig = {
+  "on-start": [],
+  "on-story-start": [],
+  "on-story-end": [],
+  "on-error": [],
+  "on-escalate": [],
+  "on-end": [],
+};
+
+const mockStatusWriter = {
+  setPrd: mock(() => {}),
+  setRunStatus: mock(() => {}),
+  setCurrentStory: mock(() => {}),
+  update: mock(async () => {}),
+};
+
+// ─────────────────────────────────────────────────────────────────────────────
+// RunLifecycle.teardown()
+// ─────────────────────────────────────────────────────────────────────────────
+
+describe("RunLifecycle.teardown", () => {
+  it("calls plugin teardownAll during teardown", async () => {
+    const teardownAllMock = mock(async () => {});
+    const mockPluginRegistry = {
+      teardownAll: teardownAllMock,
+      plugins: [],
+      getReporters: () => [],
+    } as any;
+
+    const lifecycle = new RunLifecycle(
+      "/tmp/prd.json",
+      "/tmp",
+      mockConfig,
+      mockHooks,
+      "test-feature",
+      false,
+      false,
+      // @ts-expect-error - partial mock
+      mockStatusWriter,
+      "run-001",
+      new Date().toISOString(),
+    );
+
+    await lifecycle.teardown({
+      runId: "run-001",
+      feature: "test-feature",
+      startedAt: new Date().toISOString(),
+      prd: { feature: "test-feature", userStories: [] },
+      allStoryMetrics: [],
+      totalCost: 0,
+      storiesCompleted: 0,
+      startTime: Date.now(),
+      workdir: "/tmp",
+      pluginRegistry: mockPluginRegistry,
+      statusWriter: mockStatusWriter as any,
+      iterations: 0,
+    });
+
+    expect(teardownAllMock).toHaveBeenCalledTimes(1);
+  });
+
+  it("updates status writer during teardown", async () => {
+    const mockPluginRegistry = {
+      teardownAll: async () => {},
+      plugins: [],
+      getReporters: () => [],
+    } as any;
+
+    const lifecycle = new RunLifecycle(
+      "/tmp/prd.json",
+      "/tmp",
+      mockConfig,
+      mockHooks,
+      "test-feature",
+      false,
+      false,
+      // @ts-expect-error - partial mock
+      mockStatusWriter,
+      "run-001",
+      new Date().toISOString(),
+    );
+
+    await lifecycle.teardown({
+      runId: "run-001",
+      feature: "test-feature",
+      startedAt: new Date().toISOString(),
+      prd: { feature: "test-feature", userStories: [] },
+      allStoryMetrics: [],
+      totalCost: 1.5,
+      storiesCompleted: 5,
+      startTime: Date.now(),
+      workdir: "/tmp",
+      pluginRegistry: mockPluginRegistry,
+      statusWriter: mockStatusWriter as any,
+      iterations: 10,
+    });
+
+    expect(mockStatusWriter.setPrd).toHaveBeenCalled();
+    expect(mockStatusWriter.setRunStatus).toHaveBeenCalled();
+    expect(mockStatusWriter.update).toHaveBeenCalled();
+  });
+});

package/test/unit/storyid-events.test.ts

@@ -0,0 +1,224 @@
+/**
+ * BUG-020: Verify storyId is present in JSONL event logger calls.
+ *
+ * Tests three key stages: verify, execution, tdd orchestrator.
+ * Uses mocks — does NOT spawn nax processes.
+ */
+
+import { afterEach, beforeEach, describe, expect, mock, spyOn, test } from "bun:test";
+import type { NaxConfig } from "../../src/config";
+import { getLogger, initLogger, resetLogger } from "../../src/logger";
+import type { PipelineContext } from "../../src/pipeline/types";
+import type { UserStory } from "../../src/prd/types";
+import { ALL_AGENTS } from "../../src/agents/registry";
+import {
+  validateAgentForTier as realValidateAgentForTier,
+  validateAgentFeature,
+  describeAgentCapabilities,
+} from "../../src/agents/validation";
+
+// ── Module mocks (must be set up before dynamic imports) ──────────────────────
+
+const mockAgentRun = mock(async () => ({
+  success: true,
+  rateLimited: false,
+  estimatedCost: 0.01,
+  output: "done",
+  exitCode: 0,
+  durationMs: 100,
+}));
+
+mock.module("../../src/agents", () => ({
+  getAgent: (name: string) => {
+    if (name === "claude") {
+      return {
+        name: "claude",
+        // Only supports "balanced"/"powerful" — triggers tier mismatch when ctx.routing.modelTier="fast"
+        capabilities: { supportedTiers: ["balanced", "powerful"] },
+        run: mockAgentRun,
+        isInstalled: async () => true,
+        buildCommand: () => ["claude"],
+      };
+    }
+    // Delegate all other names to the real registry so integration tests that
+    // push their own mock agents to ALL_AGENTS (via beforeAll/afterAll) can
+    // still find them even when this module mock is active.
+    return ALL_AGENTS.find((a) => a.name === name);
+  },
+  validateAgentForTier: realValidateAgentForTier,
+  validateAgentFeature,
+  describeAgentCapabilities,
+}));
+
+// ── Dynamic imports after mock setup ─────────────────────────────────────────
+
+const { verifyStage } = await import("../../src/pipeline/stages/verify");
+const { executionStage } = await import("../../src/pipeline/stages/execution");
+const { runThreeSessionTdd } = await import("../../src/tdd/orchestrator");
+
+// ── Shared fixtures ───────────────────────────────────────────────────────────
+
+const STORY_ID = "story-bug020-test";
+
+const mockStory: UserStory = {
+  id: STORY_ID,
+  title: "Test story for BUG-020",
+  description: "Verifies storyId appears in event payloads",
+  acceptanceCriteria: [],
+  status: "pending",
+};
+
+/**
+ * Build a minimal PipelineContext with configurable quality overrides.
+ */
+function makeCtx(
+  qualityOverrides: Partial<{ requireTests: boolean; testCommand: string | undefined }> = {},
+): PipelineContext {
+  const { requireTests = false, testCommand = undefined } = qualityOverrides;
+  return {
+    config: {
+      quality: {
+        requireTests,
+        commands: { test: testCommand },
+      },
+      review: undefined,
+      execution: {
+        sessionTimeoutSeconds: 60,
+        verificationTimeoutSeconds: 60,
+        dangerouslySkipPermissions: false,
+        costLimit: 10,
+        maxIterations: 50,
+        iterationDelayMs: 0,
+      },
+      models: {
+        fast: "claude-3-haiku-20240307",
+        balanced: "claude-3-5-sonnet-20241022",
+        powerful: "claude-opus-4-20250514",
+      },
+      autoMode: { defaultAgent: "claude" },
+      tdd: { rollbackOnFailure: false },
+      routing: { strategy: "complexity", llm: { mode: "per-story" } },
+    } as unknown as NaxConfig,
+    story: mockStory,
+    stories: [mockStory],
+    routing: {
+      complexity: "simple",
+      modelTier: "fast",
+      testStrategy: "test-after",
+      reasoning: "test fixture",
+    },
+    workdir: "/tmp/nax-test-storyid",
+    prd: { feature: "test", userStories: [mockStory] },
+    hooks: {} as any,
+  } as PipelineContext;
+}
+
+// ── Logger lifecycle ──────────────────────────────────────────────────────────
+
+beforeEach(() => {
+  resetLogger();
+  initLogger({ level: "debug", useChalk: false });
+  mockAgentRun.mockClear();
+});
+
+afterEach(() => {
+  resetLogger();
+});
+
+// ── Tests ─────────────────────────────────────────────────────────────────────
+
+describe("BUG-020: storyId in JSONL event payloads", () => {
+  // ── Verify stage ────────────────────────────────────────────────────────────
+
+  describe("verify stage", () => {
+    test("skip log (requireTests=false) includes storyId", async () => {
+      const logger = getLogger();
+      const debugSpy = spyOn(logger, "debug").mockImplementation(() => {});
+
+      const ctx = makeCtx({ requireTests: false });
+      await verifyStage.execute(ctx);
+
+      const call = debugSpy.mock.calls.find(
+        ([, msg]) => msg === "Skipping verification (quality.requireTests = false)",
+      );
+      expect(call).toBeDefined();
+      expect(call![2]).toEqual(expect.objectContaining({ storyId: STORY_ID }));
+    });
+
+    test("skip log (no test command) includes storyId", async () => {
+      const logger = getLogger();
+      const debugSpy = spyOn(logger, "debug").mockImplementation(() => {});
+
+      const ctx = makeCtx({ requireTests: true, testCommand: undefined });
+      await verifyStage.execute(ctx);
+
+      const call = debugSpy.mock.calls.find(
+        ([, msg]) => msg === "Skipping verification (no test command configured)",
+      );
+      expect(call).toBeDefined();
+      expect(call![2]).toEqual(expect.objectContaining({ storyId: STORY_ID }));
+    });
+  });
+
+  // ── Execution stage ─────────────────────────────────────────────────────────
+
+  describe("execution stage", () => {
+    test("agent tier mismatch warn includes storyId", async () => {
+      const logger = getLogger();
+      const warnSpy = spyOn(logger, "warn").mockImplementation(() => {});
+      spyOn(logger, "info").mockImplementation(() => {});
+      spyOn(logger, "error").mockImplementation(() => {});
+
+      const ctx = makeCtx();
+      ctx.prompt = "implement the feature";
+      await executionStage.execute(ctx);
+
+      const call = warnSpy.mock.calls.find(([, msg]) => msg === "Agent tier mismatch");
+      expect(call).toBeDefined();
+      expect(call![2]).toEqual(
+        expect.objectContaining({
+          storyId: STORY_ID,
+          agentName: "claude",
+          requestedTier: "fast",
+        }),
+      );
+    });
+  });
+
+  // ── TDD orchestrator ────────────────────────────────────────────────────────
+
+  describe("tdd orchestrator", () => {
+    test("dry-run info log includes storyId", async () => {
+      const logger = getLogger();
+      const infoSpy = spyOn(logger, "info").mockImplementation(() => {});
+
+      const mockAgent = {
+        name: "dry-run-agent",
+        capabilities: { supportedTiers: ["fast"] },
+        run: mock(async () => ({
+          success: true,
+          rateLimited: false,
+          estimatedCost: 0,
+          output: "",
+          exitCode: 0,
+          durationMs: 0,
+        })),
+      };
+
+      await runThreeSessionTdd({
+        agent: mockAgent as any,
+        story: mockStory,
+        config: makeCtx().config,
+        workdir: "/tmp/nax-test-storyid",
+        modelTier: "fast",
+        dryRun: true,
+      });
+
+      const dryRunCall = infoSpy.mock.calls.find(
+        ([, msg]) => msg === "[DRY RUN] Would run 3-session TDD",
+      );
+      expect(dryRunCall).toBeDefined();
+      expect(dryRunCall![2]).toEqual(expect.objectContaining({ storyId: STORY_ID }));
+    });
+  });
+});