@narumitw/pi-subagents 2.1.3 → 3.0.0

package/src/process.ts

@@ -0,0 +1,688 @@
+import { type ChildProcess, spawn } from "node:child_process";
+import * as fs from "node:fs";
+import * as path from "node:path";
+import { StringDecoder } from "node:string_decoder";
+import { fileURLToPath } from "node:url";
+import { getPackageDir } from "@earendil-works/pi-coding-agent";
+import {
+	BROKER_CREDENTIAL_FD,
+	brokerCredentialEnvironment,
+	serializeBrokerCredentials,
+} from "./broker-credentials.js";
+import { CHILD_COMMUNICATION_TOOL_NAMES } from "./child-communication-tools.js";
+import type { ChildControl, ChildRequest, ChildResult } from "./types.js";
+
+const CORE_PACKAGE_NAME = "@earendil-works/pi-coding-agent";
+const MAX_TIMEOUT_MS = 2_147_483_647;
+const MAX_TIMEOUT_SECONDS = MAX_TIMEOUT_MS / 1000;
+const MAX_OUTPUT_BYTES = 32 * 1024;
+const MAX_ERROR_BYTES = 8 * 1024;
+const MAX_EVENT_LINE_BYTES = 256 * 1024;
+const RPC_RESPONSE_TIMEOUT_MS = 30_000;
+const KILL_GRACE_MS = 1_000;
+
+interface ProcessSettlement {
+	code: number;
+	cancelled: boolean;
+	timedOut: boolean;
+	completed: boolean;
+	launchError?: string;
+}
+
+interface AssistantEvent {
+	type?: string;
+	id?: string;
+	success?: boolean;
+	error?: string;
+	message?: {
+		role?: string;
+		content?: Array<{ type?: string; text?: string }>;
+		stopReason?: string;
+		errorMessage?: string;
+	};
+}
+
+interface PendingRpcCommand {
+	command: string;
+	resolve: () => void;
+	reject: (error: Error) => void;
+	timer: NodeJS.Timeout;
+	onAccepted?: () => void;
+	signal?: AbortSignal;
+	onAbort?: () => void;
+}
+
+export function resolveTimeoutMs(timeout: number | undefined): number | undefined {
+	if (timeout === undefined) return undefined;
+	if (!Number.isFinite(timeout) || timeout <= 0) {
+		throw new Error("Invalid timeout: must be a finite number of seconds");
+	}
+	const timeoutMs = timeout * 1000;
+	if (timeoutMs > MAX_TIMEOUT_MS) {
+		throw new Error(`Invalid timeout: maximum is ${MAX_TIMEOUT_SECONDS} seconds`);
+	}
+	return timeoutMs;
+}
+
+export async function runChild(request: ChildRequest): Promise<ChildResult> {
+	if (request.signal.aborted) return cancelledResult();
+	try {
+		const invocation = resolvePiInvocation(buildPiArgs(request));
+		return await executeProcess(invocation, request);
+	} catch (error) {
+		if (request.signal.aborted) return cancelledResult();
+		return {
+			state: "failed",
+			error: truncateText(error instanceof Error ? error.message : String(error), MAX_ERROR_BYTES)
+				.text,
+			limitations: [],
+			truncated: false,
+		};
+	}
+}
+
+export function buildPiArgs(request: ChildRequest): string[] {
+	const args = [
+		"--mode",
+		"rpc",
+		"--no-session",
+		"--no-extensions",
+		"--no-skills",
+		"--no-prompt-templates",
+		"-e",
+		childCommunicationBridgePath(),
+		"--model",
+		request.model,
+		"--thinking",
+		request.thinkingLevel,
+		request.projectTrusted ? "--approve" : "--no-approve",
+	];
+	const tools = [...new Set([...request.tools, ...CHILD_COMMUNICATION_TOOL_NAMES])];
+	args.push("--tools", tools.join(","));
+	return args;
+}
+
+export function childCommunicationBridgePath(): string {
+	return fileURLToPath(new URL("./child-communication-bridge.ts", import.meta.url));
+}
+
+async function executeProcess(
+	invocation: { command: string; args: string[] },
+	request: ChildRequest,
+): Promise<ChildResult> {
+	const timeoutMs = resolveTimeoutMs(request.timeout);
+	let latestOutput = "";
+	let terminalOutput: string | undefined;
+	let terminalStopReason: "stop" | "length" | undefined;
+	let errorMessage = "";
+	let assistantFailed = false;
+	let stderr = "";
+	let truncated = false;
+	let malformedEvents = 0;
+	let rpcCounter = 0;
+	const pendingCommands = new Map<string, PendingRpcCommand>();
+	let rpcInputError: Error | undefined;
+	let sendCommand: (
+		command: { type: "prompt" | "steer"; message: string },
+		onAccepted?: () => void,
+		signal?: AbortSignal,
+	) => Promise<void> = () => Promise.reject(new Error("Subagent RPC process is unavailable."));
+	let onAgentSettled: () => void = () => undefined;
+
+	const takePendingCommand = (id: string): PendingRpcCommand | undefined => {
+		const pending = pendingCommands.get(id);
+		if (!pending) return undefined;
+		pendingCommands.delete(id);
+		clearTimeout(pending.timer);
+		if (pending.signal && pending.onAbort) {
+			pending.signal.removeEventListener("abort", pending.onAbort);
+		}
+		return pending;
+	};
+	const rejectPendingCommand = (id: string, error: Error) => {
+		takePendingCommand(id)?.reject(error);
+	};
+	const rejectPendingCommands = (error: Error) => {
+		for (const id of [...pendingCommands.keys()]) rejectPendingCommand(id, error);
+	};
+	const resolvePendingCommand = (id: string) => {
+		const pending = takePendingCommand(id);
+		if (!pending) return;
+		try {
+			pending.onAccepted?.();
+			pending.resolve();
+		} catch (error) {
+			pending.reject(error instanceof Error ? error : new Error(String(error)));
+		}
+	};
+	const failRpcInput = (error: Error) => {
+		rpcInputError ??= error;
+		rejectPendingCommands(rpcInputError);
+	};
+
+	const decoder = new JsonLineDecoder(
+		(value) => {
+			const event = value as AssistantEvent;
+			if (event.type === "response" && typeof event.id === "string") {
+				const pending = pendingCommands.get(event.id);
+				if (!pending) return;
+				if (event.success === true) {
+					resolvePendingCommand(event.id);
+				} else {
+					rejectPendingCommand(
+						event.id,
+						new Error(
+							typeof event.error === "string"
+								? event.error
+								: `Subagent RPC ${pending.command} command failed.`,
+						),
+					);
+				}
+				return;
+			}
+			if (event.type === "agent_settled") {
+				onAgentSettled();
+				return;
+			}
+			if (event.type === "message_end" && event.message?.role === "assistant") {
+				const text = (event.message.content ?? [])
+					.filter((part) => part.type === "text" && typeof part.text === "string")
+					.map((part) => part.text)
+					.join("\n")
+					.trim();
+				if (text) {
+					const limited = truncateText(text, MAX_OUTPUT_BYTES);
+					latestOutput = limited.text;
+					truncated ||= limited.truncated;
+					if (event.message.stopReason === "stop" || event.message.stopReason === "length") {
+						terminalOutput = limited.text;
+						terminalStopReason = event.message.stopReason;
+					}
+				}
+				if (event.message.stopReason === "error" || event.message.stopReason === "aborted") {
+					assistantFailed = true;
+				}
+				if (event.message.errorMessage) {
+					const limited = truncateText(event.message.errorMessage, MAX_ERROR_BYTES);
+					errorMessage = limited.text;
+					truncated ||= limited.truncated;
+				}
+			}
+		},
+		() => {
+			malformedEvents++;
+		},
+	);
+
+	const settlement = await new Promise<ProcessSettlement>((resolve) => {
+		let process: ChildProcess;
+		let settled = false;
+		let finishRequested = false;
+		let spawned = false;
+		let terminating = false;
+		let cancelled = false;
+		let timedOut = false;
+		let completed = false;
+		let ready = false;
+		let deadline: NodeJS.Timeout | undefined;
+		let forceClose: NodeJS.Timeout | undefined;
+		let escalation: NodeJS.Timeout | undefined;
+		let termination: Promise<void> | undefined;
+
+		const finish = (code: number, launchError?: string) => {
+			if (settled || finishRequested) return;
+			finishRequested = true;
+			const complete = () => {
+				if (settled) return;
+				settled = true;
+				if (deadline) clearTimeout(deadline);
+				if (forceClose) clearTimeout(forceClose);
+				if (escalation) clearTimeout(escalation);
+				request.signal.removeEventListener("abort", onAbort);
+				rejectPendingCommands(new Error("Subagent RPC process closed."));
+				resolve({ code, cancelled, timedOut, completed, launchError });
+			};
+			if (termination) void termination.then(complete, complete);
+			else complete();
+		};
+		const terminate = (code: number) => {
+			if (settled || terminating) return;
+			terminating = true;
+			if (deadline) {
+				clearTimeout(deadline);
+				deadline = undefined;
+			}
+			if (globalThis.process.platform === "win32") {
+				termination = terminateWindowsProcessTree(process);
+			} else {
+				signalPosixProcess(process, "SIGTERM");
+				escalation = setTimeout(() => signalPosixProcess(process, "SIGKILL"), KILL_GRACE_MS);
+				escalation.unref();
+			}
+			forceClose = setTimeout(() => {
+				decoder.finish();
+				process.stdin?.destroy();
+				process.stdout?.destroy();
+				process.stderr?.destroy();
+				finish(code);
+			}, KILL_GRACE_MS * 2);
+			forceClose.unref();
+		};
+		const onAbort = () => {
+			if (settled) return;
+			cancelled = true;
+			terminate(130);
+		};
+		const completeNormally = () => {
+			if (settled || terminating || !ready) return;
+			completed = true;
+			terminate(0);
+		};
+		onAgentSettled = completeNormally;
+
+		try {
+			process = spawn(invocation.command, invocation.args, {
+				cwd: request.cwd,
+				detached: globalThis.process.platform !== "win32",
+				shell: false,
+				stdio: ["pipe", "pipe", "pipe", "pipe"],
+				env: {
+					...globalThis.process.env,
+					...brokerCredentialEnvironment(),
+					PI_SUBAGENT_DEPTH: String(
+						(Number.parseInt(globalThis.process.env.PI_SUBAGENT_DEPTH ?? "0", 10) || 0) + 1,
+					),
+				},
+			});
+		} catch (error) {
+			finish(1, error instanceof Error ? error.message : String(error));
+			return;
+		}
+
+		process.stdin?.on("error", failRpcInput);
+		sendCommand = (command, onAccepted, signal) => {
+			if (settled || terminating || process.exitCode !== null) {
+				return Promise.reject(new Error("Subagent RPC process is no longer active."));
+			}
+			if (signal?.aborted) {
+				return Promise.reject(abortError("Subagent RPC command was cancelled."));
+			}
+			if (rpcInputError) return Promise.reject(rpcInputError);
+			const stdin = process.stdin;
+			if (!stdin || stdin.destroyed || !stdin.writable) {
+				return Promise.reject(new Error("Subagent RPC stdin is unavailable."));
+			}
+			const id = `rpc_${++rpcCounter}`;
+			return new Promise<void>((resolveCommand, rejectCommand) => {
+				const timer = setTimeout(
+					() =>
+						rejectPendingCommand(id, new Error(`Subagent RPC ${command.type} response timed out.`)),
+					RPC_RESPONSE_TIMEOUT_MS,
+				);
+				timer.unref();
+				const pending: PendingRpcCommand = {
+					command: command.type,
+					resolve: resolveCommand,
+					reject: rejectCommand,
+					timer,
+					onAccepted,
+					signal,
+				};
+				if (signal) {
+					pending.onAbort = () =>
+						rejectPendingCommand(id, abortError("Subagent RPC command was cancelled."));
+				}
+				pendingCommands.set(id, pending);
+				if (signal && pending.onAbort) {
+					signal.addEventListener("abort", pending.onAbort, { once: true });
+					if (signal.aborted) {
+						pending.onAbort();
+						return;
+					}
+				}
+				try {
+					stdin.write(`${JSON.stringify({ id, ...command })}\n`, (error) => {
+						if (error) failRpcInput(error);
+					});
+				} catch (error) {
+					failRpcInput(error instanceof Error ? error : new Error(String(error)));
+				}
+			});
+		};
+
+		request.signal.addEventListener("abort", onAbort, { once: true });
+		if (request.signal.aborted) onAbort();
+		process.once("spawn", () => {
+			spawned = true;
+			if (settled || cancelled) return;
+			void sendCommand(
+				{ type: "prompt", message: `Task: ${request.task}` },
+				() => {
+					if (settled || terminating || request.signal.aborted) {
+						throw new Error("Subagent RPC prompt was superseded.");
+					}
+					ready = true;
+					if (timeoutMs !== undefined) {
+						deadline = setTimeout(() => {
+							timedOut = true;
+							terminate(124);
+						}, timeoutMs);
+						deadline.unref();
+					}
+					const control: ChildControl = {
+						send: async (message, signal) => {
+							if (!ready || completed || terminating) {
+								throw new Error("Subagent job is no longer accepting messages.");
+							}
+							await sendCommand({ type: "steer", message }, undefined, signal);
+						},
+					};
+					request.onControl?.(control);
+				},
+				request.signal,
+			).catch((error) => {
+				if (settled || terminating) return;
+				errorMessage = truncateText(
+					error instanceof Error ? error.message : String(error),
+					MAX_ERROR_BYTES,
+				).text;
+				terminate(1);
+			});
+		});
+		process.stdout?.on("data", (chunk) => decoder.push(chunk));
+		process.stderr?.on("data", (chunk) => {
+			const limited = truncateTail(`${stderr}${chunk.toString()}`, MAX_ERROR_BYTES);
+			stderr = limited.text;
+			truncated ||= limited.truncated;
+		});
+		process.once("close", (code) => {
+			decoder.finish();
+			finish(cancelled ? 130 : timedOut ? 124 : completed ? 0 : (code ?? 1));
+		});
+		process.once("error", (error) => {
+			const limited = truncateText(error.message, MAX_ERROR_BYTES);
+			errorMessage = limited.text;
+			truncated ||= limited.truncated;
+			if (spawned) terminate(1);
+			else finish(1, error.message);
+		});
+		const credentialPipe = process.stdio[BROKER_CREDENTIAL_FD];
+		if (!credentialPipe || !("end" in credentialPipe)) {
+			errorMessage = "Subagent broker credential pipe is unavailable.";
+			terminate(1);
+		} else {
+			const onCredentialError = () => {
+				if (settled || finishRequested) return;
+				errorMessage = "Subagent broker credential transfer failed.";
+				terminate(1);
+			};
+			const removeCredentialListeners = () => {
+				credentialPipe.removeListener("error", onCredentialError);
+				credentialPipe.removeListener("close", removeCredentialListeners);
+			};
+			credentialPipe.on("error", onCredentialError);
+			credentialPipe.once("close", removeCredentialListeners);
+			try {
+				credentialPipe.end(serializeBrokerCredentials(request.communication));
+			} catch {
+				onCredentialError();
+			}
+		}
+	});
+
+	const output = terminalOutput ?? latestOutput;
+	const limitations =
+		malformedEvents > 0
+			? [`Ignored ${malformedEvents} malformed or oversized child event(s).`]
+			: [];
+	if (truncated) limitations.push("Child output was truncated to runtime limits.");
+	if (terminalStopReason === "length") {
+		limitations.push("Child output ended at the model output limit and may be incomplete.");
+	}
+	if (settlement.cancelled) return cancelledResult(output, limitations, truncated);
+	if (settlement.timedOut) {
+		return {
+			state: "timed_out",
+			...(output ? { result: output } : {}),
+			error: "Subagent execution timed out.",
+			limitations,
+			truncated,
+		};
+	}
+	const error = settlement.launchError || errorMessage || stderr.trim();
+	if (settlement.completed && terminalStopReason === "stop" && !assistantFailed && !errorMessage) {
+		return {
+			state: "completed",
+			result: terminalOutput,
+			limitations,
+			truncated,
+		};
+	}
+	const failure =
+		error ||
+		(terminalStopReason === "length"
+			? "Subagent output reached the model limit."
+			: assistantFailed
+				? "Subagent model turn failed."
+				: settlement.completed
+					? "Subagent settled without a terminal assistant result."
+					: settlement.code === 0
+						? "Subagent exited without settling."
+						: `Subagent exited with code ${settlement.code}.`);
+	if (output) {
+		return {
+			state: "partial",
+			result: output,
+			error: failure,
+			limitations,
+			truncated,
+		};
+	}
+	return {
+		state: "failed",
+		error: failure,
+		limitations,
+		truncated,
+	};
+}
+
+function resolvePiInvocation(args: string[]): { command: string; args: string[] } {
+	const packageDirectory = fs.realpathSync(getPackageDir());
+	const manifestPath = path.join(packageDirectory, "package.json");
+	const manifest = JSON.parse(fs.readFileSync(manifestPath, "utf8")) as {
+		name?: string;
+		bin?: { pi?: string };
+	};
+	if (manifest.name !== CORE_PACKAGE_NAME || typeof manifest.bin?.pi !== "string") {
+		throw new Error("Loaded Pi core package does not declare a valid bin.pi entry.");
+	}
+	const declared = manifest.bin.pi;
+	if (path.isAbsolute(declared)) throw new Error("Pi core bin.pi must be package-relative.");
+	const cliPath = fs.realpathSync(path.resolve(packageDirectory, declared));
+	const relative = path.relative(packageDirectory, cliPath);
+	if (relative === ".." || relative.startsWith(`..${path.sep}`) || path.isAbsolute(relative)) {
+		throw new Error("Pi core bin.pi escapes its package directory.");
+	}
+	if (!fs.statSync(cliPath).isFile()) throw new Error("Pi core bin.pi is not a file.");
+	if (
+		globalThis.process.versions.bun &&
+		/^pi(?:\.exe)?$/iu.test(path.basename(globalThis.process.execPath)) &&
+		path.dirname(fs.realpathSync(globalThis.process.execPath)) === packageDirectory
+	) {
+		return { command: globalThis.process.execPath, args };
+	}
+	return { command: globalThis.process.execPath, args: [cliPath, ...args] };
+}
+
+function signalPosixProcess(process: ChildProcess, signal: NodeJS.Signals): void {
+	if (process.pid) {
+		try {
+			globalThis.process.kill(-process.pid, signal);
+			return;
+		} catch {
+			// Fall back to the immediate child.
+		}
+	}
+	try {
+		process.kill(signal);
+	} catch {
+		// The process may already be terminal.
+	}
+}
+
+export function terminateWindowsProcessTree(
+	process: ChildProcess,
+	spawnProcess: typeof spawn = spawn,
+	taskkillPath = resolveTaskkillPath(),
+	helperTimeoutMs = KILL_GRACE_MS,
+): Promise<void> {
+	if (!process.pid || !taskkillPath) {
+		killImmediateChild(process);
+		return Promise.resolve();
+	}
+	return new Promise((resolve) => {
+		let settled = false;
+		let treeKiller: ChildProcess;
+		let deadline: NodeJS.Timeout | undefined;
+		const onError = () => finish(true, false);
+		const onClose = (code: number | null) => finish(code !== 0, false);
+		const finish = (fallback: boolean, terminateHelper: boolean) => {
+			if (settled) return;
+			settled = true;
+			if (deadline) clearTimeout(deadline);
+			treeKiller.removeListener("error", onError);
+			treeKiller.removeListener("close", onClose);
+			if (terminateHelper) killImmediateChild(treeKiller);
+			if (fallback) killImmediateChild(process);
+			resolve();
+		};
+		try {
+			treeKiller = spawnProcess(taskkillPath, ["/PID", String(process.pid), "/T", "/F"], {
+				stdio: "ignore",
+				windowsHide: true,
+			});
+		} catch {
+			killImmediateChild(process);
+			resolve();
+			return;
+		}
+		treeKiller.once("error", onError);
+		treeKiller.once("close", onClose);
+		deadline = setTimeout(() => finish(true, true), helperTimeoutMs);
+		deadline.unref();
+	});
+}
+
+function resolveTaskkillPath(): string | undefined {
+	const systemRoot = globalThis.process.env.SystemRoot ?? globalThis.process.env.WINDIR;
+	if (!systemRoot || !path.win32.isAbsolute(systemRoot)) return undefined;
+	return path.win32.join(systemRoot, "System32", "taskkill.exe");
+}
+
+function killImmediateChild(process: ChildProcess): void {
+	try {
+		process.kill("SIGKILL");
+	} catch {
+		// The process may already be terminal.
+	}
+}
+
+function abortError(message: string): Error {
+	const error = new Error(message);
+	error.name = "AbortError";
+	return error;
+}
+
+function cancelledResult(
+	result?: string,
+	limitations: string[] = [],
+	truncated = false,
+): ChildResult {
+	return {
+		state: "cancelled",
+		...(result ? { result } : {}),
+		error: "Subagent execution was cancelled.",
+		limitations,
+		truncated,
+	};
+}
+
+function truncateText(text: string, maxBytes: number): { text: string; truncated: boolean } {
+	const bytes = Buffer.from(text, "utf8");
+	if (bytes.length <= maxBytes) return { text, truncated: false };
+	return {
+		text: `${bytes
+			.subarray(0, Math.max(0, maxBytes - 18))
+			.toString("utf8")
+			.replace(/�+$/gu, "")}\n… [truncated]`,
+		truncated: true,
+	};
+}
+
+function truncateTail(text: string, maxBytes: number): { text: string; truncated: boolean } {
+	const bytes = Buffer.from(text, "utf8");
+	if (bytes.length <= maxBytes) return { text, truncated: false };
+	return {
+		text: `… [truncated]\n${bytes
+			.subarray(bytes.length - Math.max(0, maxBytes - 18))
+			.toString("utf8")
+			.replace(/^�+/gu, "")}`,
+		truncated: true,
+	};
+}
+
+class JsonLineDecoder {
+	private buffer = "";
+	private dropping = false;
+	private readonly decoder = new StringDecoder("utf8");
+
+	constructor(
+		private readonly onValue: (value: unknown) => void,
+		private readonly onMalformed: () => void,
+	) {}
+
+	push(chunk: Buffer | string): void {
+		this.buffer += typeof chunk === "string" ? chunk : this.decoder.write(chunk);
+		this.drain(false);
+	}
+
+	finish(): void {
+		this.buffer += this.decoder.end();
+		this.drain(true);
+		this.buffer = "";
+		this.dropping = false;
+	}
+
+	private drain(flush: boolean): void {
+		while (true) {
+			const newline = this.buffer.indexOf("\n");
+			if (newline < 0) break;
+			const line = this.buffer.slice(0, newline).replace(/\r$/u, "");
+			this.buffer = this.buffer.slice(newline + 1);
+			if (this.dropping) {
+				this.dropping = false;
+				continue;
+			}
+			this.parse(line);
+		}
+		if (!flush && Buffer.byteLength(this.buffer, "utf8") > MAX_EVENT_LINE_BYTES) {
+			this.onMalformed();
+			this.buffer = "";
+			this.dropping = true;
+		}
+		if (flush && this.buffer && !this.dropping) this.parse(this.buffer.replace(/\r$/u, ""));
+	}
+
+	private parse(line: string): void {
+		if (!line.trim()) return;
+		if (Buffer.byteLength(line, "utf8") > MAX_EVENT_LINE_BYTES) {
+			this.onMalformed();
+			return;
+		}
+		try {
+			this.onValue(JSON.parse(line));
+		} catch {
+			this.onMalformed();
+		}
+	}
+}