@narmi/design_system 4.27.0 → 4.28.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +29 -8
- package/dist/index.js +1 -1
- package/dist/index.js.map +1 -1
- package/dist/style.css +3 -3
- package/dist/style.css.map +1 -1
- package/dist/tokens/css/rgbColors.css +1 -1
- package/dist/tokens/css/tokens.css +1 -1
- package/dist/tokens/js/colors.js +1 -1
- package/dist/tokens/js/manifest.js +1 -1
- package/dist/tokens/js/reactNativeWeb.js +1 -1
- package/dist/types/ContentCard/index.d.ts +5 -1
- package/dist/types/ContentCard/index.d.ts.map +1 -1
- package/dist/types/ContextMenu/ContextMenuItem.d.ts +1 -1
- package/dist/types/ContextMenu/ContextMenuItem.d.ts.map +1 -1
- package/dist/types/ContextMenu/index.d.ts.map +1 -1
- package/dist/types/Dialog/index.d.ts.map +1 -1
- package/package.json +2 -2
package/README.md
CHANGED
|
@@ -169,17 +169,38 @@ In order for your PR to merge it must:
|
|
|
169
169
|
- Pass all unit tests
|
|
170
170
|
- Pass Chromatic snapshot tests
|
|
171
171
|
|
|
172
|
-
#### Working with snapshot tests
|
|
172
|
+
#### 📸 Working with snapshot tests
|
|
173
173
|
|
|
174
|
-
|
|
175
|
-
you must manually resolve them by either fixing your code OR accepting the change in
|
|
176
|
-
the Chromatic app if the visual diff was intentional.
|
|
174
|
+
The workflow that runs visual snapshot testing is "Chromatic PR Checks"/`run_chromatic`. All pull requests will block merging until this workflow passes.
|
|
177
175
|
|
|
178
|
-
|
|
179
|
-
Links to the snapshot review and the storybook preview build will be provided by narmibot in a PR comment.
|
|
176
|
+
Passing conditions for tests:
|
|
180
177
|
|
|
181
|
-
|
|
182
|
-
|
|
178
|
+
- No visual changes detected
|
|
179
|
+
- Visual changes detected, but approved (indicates an intentional change)
|
|
180
|
+
- Visual changes resolved by a code change to match baseline snapshots
|
|
181
|
+
- New stories added in the PR are approved in the Chromatic build
|
|
182
|
+
|
|
183
|
+
Failing conditions for tests:
|
|
184
|
+
|
|
185
|
+
- Chromatic build has unreviewed diffs
|
|
186
|
+
- Chromatic build has denied changes
|
|
187
|
+
- New stories haven't been explicitly approved in the Chromatic build
|
|
188
|
+
|
|
189
|
+
On every push to a PR, this workflow will run snapshots and report results via a
|
|
190
|
+
comment on the PR. Use the provided links to review diffs in the Chromatic build and/or view the Storybook preview build.
|
|
191
|
+
|
|
192
|
+
This workflow must be run again to confirm snapshots are passing, triggered by a new push to the PR or by manually running the job.
|
|
193
|
+
|
|
194
|
+
**🔑 Authentication Required:**
|
|
195
|
+
While the Storybook preview is public, you must log into [Chromatic](chromatic.com/start) with Narmi engineering credentials to view details on the build and approve or deny snapshot changes.
|
|
196
|
+
|
|
197
|
+
**Local Snapshots:**
|
|
198
|
+
When running Storybook locally, you'll see a floating button on the bottom left of the viewport labelled "Run Tests". If you're authenticated with chromatic, this will compare your current stories being served on `localhost:6006` against baseline snapshots in Chromatic. Results will appear in the addons panel.
|
|
199
|
+
|
|
200
|
+
**Baselines:**
|
|
201
|
+
Baselines are managed by Chromatic, using the latest _approved_ build, regardless of the PR that triggered it. Once a build is approved, it immediately becomes the new baseline.
|
|
202
|
+
To keep `main` as the branch that should be tracked as the baseline in Chromatic, we run a workflow on
|
|
203
|
+
merges to `main` that creates an auto-accepted build, designating it as the new baseline.
|
|
183
204
|
|
|
184
205
|
### Testing unpublished changes in a consumer
|
|
185
206
|
|