@nanopm/cli 0.1.17 → 0.1.19

package/dist/index.js

@@ -5335,6 +5335,8 @@ var BUILD_SKILL = "build";
 var BUILD_STEPS_MIN = 1;
 var BUILD_STEPS_MAX = 8;
 var BUILD_STEP_MAX = 120;
+var BUILD_UNDERSTOOD_MIN = 40;
+var BUILD_UNDERSTOOD_MAX = 600;
 var BUILD_RESUMES_MAX = 3;
 var BUILD_TRAILER = "Co-Authored-By: NanoPM <noreply@nanopm.app>";
 var BUILD_COLUMNS = "id, ref, title, status, actor, agent_spec, spec";
@@ -5369,9 +5371,10 @@ function stepsLeft(plan, done) {
 function buildDir(home, jobId) {
   return `${home.replace(/\/+$/, "")}/.cache/nanopm/builds/${jobId}`;
 }
-function buildBranch(ref, title) {
+function buildBranch(ref, title, jobId) {
   const slug = title.toLowerCase().replace(/[^a-z0-9]+/g, "-").replace(/^-+|-+$/g, "").slice(0, 40).replace(/-+$/, "");
-  return `nano/${ref.toLowerCase()}${slug ? `-${slug}` : ""}`;
+  const own = jobId.replace(/[^a-z0-9]/gi, "").slice(0, 6).toLowerCase();
+  return `nano/${ref.toLowerCase()}${slug ? `-${slug}` : ""}-${own}`;
 }
 var REGISTRIES = {
   "package-lock.json": ["registry.npmjs.org"],
@@ -5420,7 +5423,7 @@ var isDecideForMe = (answer) => /^\s*decide(\s+for\s+me)?\s*\.?\s*$/i.test(answe
 function answerForAgent(answer) {
   return isDecideForMe(answer) ? DECIDE_FOR_ME : answer;
 }
-var BUILD_HISTORY_KINDS = ["worktree", "plan", "step", "question", "answer", "paused", "pr", "handed", "throw", "thrown"];
+var BUILD_HISTORY_KINDS = ["worktree", "plan", "step", "question", "answer", "paused", "pr", "handed", "throw", "thrown", "closed"];
 function originOf(job) {
   const named = (job.params ?? {}).origin;
   return typeof named === "string" && /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/.test(named) ? named : job.id;
@@ -5662,11 +5665,12 @@ async function ghReady(cwd) {
     return /ENOENT/.test(errorMessage(err)) ? "the GitHub CLI is not installed on this machine: brew install gh, then gh auth login" : "the GitHub CLI is not signed in on this machine: run gh auth login in your terminal";
   }
 }
-async function pullRequestMerged(cwd, number) {
+async function pullRequestState(cwd, number) {
   try {
-    return await gh(cwd, ["pr", "view", String(number), "--json", "state", "--jq", ".state"]) === "MERGED";
+    const { state, headRefName } = JSON.parse(await gh(cwd, ["pr", "view", String(number), "--json", "state,headRefName"]));
+    return (state === "MERGED" || state === "CLOSED" || state === "OPEN") && typeof headRefName === "string" ? { state, head: headRefName } : null;
   } catch {
-    return false;
+    return null;
   }
 }
 async function openPullRequest(cwd, pr) {
@@ -11226,7 +11230,7 @@ async function prepareBuild(client, job, clone, adapter) {
       await startSolution(client, job.project_id, solution.ref, job.id);
       return { ok: true, build: { solution, clone, ...place, worktree: worktree2, network: await network(place.dir), history } };
     }
-    const branch = buildBranch(solution.ref, solution.title);
+    const branch = buildBranch(solution.ref, solution.title, job.id);
     await mkdir5(join13(dir, ".."), { recursive: true, mode: 448 });
     const { base, fork, worktree } = await addWorktree(clone, dir, branch);
     made = true;
@@ -11269,9 +11273,10 @@ async function runBuildJob(input) {
     let end = { stop: failed("the agent produced no result") };
     for await (const event of adapter.run({ ...spec2, prompt, resumeSessionId: resume3 ? spec2.sessionId : void 0 })) {
       await input.onEvent(event);
-      if (event.type === "tool_use" && event.tool === PLAN_TOOL && !plan) {
+      if (event.type === "tool_result" && event.tool === PLAN_TOOL && !event.isError && !plan) {
         plan = stepsOf(event.input);
-        if (plan) await events.write("plan", { steps: plan });
+        const understood = event.input?.understood;
+        if (plan) await events.write("plan", { steps: plan, ...typeof understood === "string" && understood.trim() ? { understood: understood.trim().slice(0, BUILD_UNDERSTOOD_MAX) } : {} });
       } else if (event.type === "tool_result" && event.tool === STEP_TOOL && !event.isError) {
         const { step, summary } = event.input ?? {};
         const index = Number(step) - 1;
@@ -11513,26 +11518,40 @@ async function throwAwayBuilds(client, daemonId, userId) {
   }
   return thrown;
 }
-async function shippedBuilds(client, daemonId, userId) {
-  const { data: building } = await client.from("solutions").select("id, ref, project_id").eq("status", "building");
+async function settledBuilds(client, daemonId, userId) {
+  const { data: building } = await client.from("solutions").select("id, ref, project_id").eq("status", "building").is("superseded_by", null);
   if (!building?.length) return [];
   const [{ data: built }, { data: clones }] = await Promise.all([
-    client.from("jobs").select("id, params, pr:result->pr").eq("skill", BUILD_SKILL).eq("status", "succeeded").eq("assigned_daemon_id", daemonId).eq("requested_by", userId).in("params->>solution_id", building.map((s) => s.id)),
+    client.from("jobs").select("id, project_id, params, created_at, pr:result->pr").eq("skill", BUILD_SKILL).eq("status", "succeeded").eq("assigned_daemon_id", daemonId).eq("requested_by", userId).in("params->>solution_id", building.map((s) => s.id)).order("created_at", { ascending: false }),
     client.from("clones").select("project_id, repo_path").eq("daemon_id", daemonId)
   ]);
+  const newest = [...new Map((built ?? []).reverse().map((j) => [j.params?.solution_id, j])).values()];
+  const { data: closed } = newest.length ? await client.from("job_events").select("job_id").in("job_id", newest.map((j) => j.id)).eq("kind", "closed") : { data: [] };
   const cloneOf = new Map((clones ?? []).map((c) => [c.project_id, c.repo_path]));
-  const shipped = [];
-  for (const j of built ?? []) {
+  const settled2 = [];
+  for (const j of newest.filter((n) => !closed?.some((c) => c.job_id === n.id))) {
     const solution = building.find((s) => s.id === j.params?.solution_id);
     const number = j.pr?.number;
     const clone = solution ? cloneOf.get(solution.project_id) : void 0;
-    if (!solution || typeof number !== "number" || number <= 0 || !clone || !existsSync5(clone) || !await pullRequestMerged(clone, number)) continue;
-    const { error } = await client.rpc("finish_solution", { p_project_id: solution.project_id, p_ref: solution.ref, p_job_id: j.id });
-    if (error) continue;
-    await logActivity({ client }, { id: j.id, project_id: solution.project_id }, "shipped", `Pull request #${number} merged: ${solution.ref} shipped`);
-    shipped.push(j.id);
-  }
-  return shipped;
+    if (!solution || typeof number !== "number" || number <= 0 || !clone || !existsSync5(clone)) continue;
+    const [{ place }, pr] = await Promise.all([loadHistory(client, j), pullRequestState(clone, number)]);
+    if (!place || !pr || pr.head !== place.branch) continue;
+    const at = { id: j.id, project_id: solution.project_id };
+    if (pr.state === "MERGED") {
+      const { error } = await client.rpc("finish_solution", { p_project_id: solution.project_id, p_ref: solution.ref, p_job_id: j.id });
+      if (error) continue;
+      await logActivity({ client }, at, "shipped", `Pull request #${number} merged: ${solution.ref} shipped`);
+      settled2.push({ id: j.id, ref: solution.ref, merged: true });
+    } else if (pr.state === "CLOSED") {
+      const { error } = await client.rpc("unstart_solution", { p_project_id: solution.project_id, p_ref: solution.ref, p_to: wasOf(j.params) });
+      if (error) continue;
+      await deleteBranch(clone, place.branch);
+      await appendJobEvent(client, j.id, "closed", { number }, "nanopm");
+      await logActivity({ client }, at, "closed", `Pull request #${number} closed without merging: ${solution.ref} back on the roadmap`);
+      settled2.push({ id: j.id, ref: solution.ref, merged: false });
+    }
+  }
+  return settled2;
 }
 async function tellTheApp(accessToken, jobId, fetchImpl = fetch) {
   try {
@@ -11696,7 +11715,7 @@ async function runDaemon(options = {}) {
       }
       if (!options.once && Date.now() - lastShipCheck > SHIP_CHECK_MS) {
         lastShipCheck = Date.now();
-        for (const id of await shippedBuilds(auth.client, daemonId, auth.userId).catch(() => [])) log(`build ${id}: its pull request merged, shipped`);
+        for (const b of await settledBuilds(auth.client, daemonId, auth.userId).catch(() => [])) log(`build ${b.id}: its pull request ${b.merged ? `merged, ${b.ref} shipped` : `closed without merging, ${b.ref} back on the roadmap`}`);
       }
       if (!options.once && Date.now() - lastDeployCheck > DEPLOY_CHECK_MS) {
         lastDeployCheck = Date.now();
@@ -12811,8 +12830,8 @@ ${renderMap()}`,
   server.registerTool(
     "build_plan",
     {
-      description: `Say the plan before you change anything: ${BUILD_STEPS_MIN} to ${BUILD_STEPS_MAX} steps, in order, each one change the founder can recognise, in their words (at most ${BUILD_STEP_MAX} characters). The last step is your own check of the whole change. Call it once; the founder sees it as a checklist.`,
-      inputSchema: { steps: z21.array(z21.string().min(3).max(BUILD_STEP_MAX)).min(BUILD_STEPS_MIN).max(BUILD_STEPS_MAX) }
+      description: `Say what you understood and your plan before you change anything. \`understood\`: in your own words and plain language, the problem, what you will change, and what you will not touch \u2014 a short paragraph the founder reads first, so a misunderstanding shows before any code (at most ${BUILD_UNDERSTOOD_MAX} characters). \`steps\`: ${BUILD_STEPS_MIN} to ${BUILD_STEPS_MAX}, in order, each one change the founder can recognise, in their words (at most ${BUILD_STEP_MAX} characters); the last is your own check of the whole change. Call it once; the founder sees the paragraph, then the steps as a checklist.`,
+      inputSchema: { understood: z21.string().min(BUILD_UNDERSTOOD_MIN).max(BUILD_UNDERSTOOD_MAX), steps: z21.array(z21.string().min(3).max(BUILD_STEP_MAX)).min(BUILD_STEPS_MIN).max(BUILD_STEPS_MAX) }
     },
     async ({ steps }) => ctx.workspace ? json({ recorded: steps.length, note: "Recorded. Build step 1 now; call build_step when it is done." }) : failure("this job builds nothing")
   );
@@ -14651,7 +14670,7 @@ import { promisify as promisify8 } from "util";
 // package.json
 var package_default = {
   name: "@nanopm/cli",
-  version: "0.1.17",
+  version: "0.1.19",
   description: "An autonomous product manager for builders who run several small products. Runs on your machine, drives your own coding harness.",
   type: "module",
   license: "MIT",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nanopm/cli",
-  "version": "0.1.17",
+  "version": "0.1.19",
   "description": "An autonomous product manager for builders who run several small products. Runs on your machine, drives your own coding harness.",
   "type": "module",
   "license": "MIT",

package/skills/build/SKILL.md

@@ -24,8 +24,11 @@ NanoPM commits each step for you and opens the pull request when you are done.
 2. If the code contradicts the spec — what it asks already exists, a step it assumes is not
    there, the size does not hold — `ask_user` before you plan: what the spec says, what the code
    has, what it changes, and the options. Do not guess what the founder decided.
-3. `build_plan`: your plan, 1 to 8 steps, in order, each a change the founder can recognise, in
-   their words. The last step is your check of the whole change.
+3. `build_plan`: first, in `understood`, what you understood, in your own words and plain
+   language — the problem, what you will change, what you will not touch. The founder reads it
+   before anything else; a misunderstanding must show there, not in the pull request. Then your
+   plan, 1 to 8 steps, in order, each a change the founder can recognise, in their words. The last
+   step is your check of the whole change.
 4. Build one step at a time. After each: run its tests and the project's own checks (the ones
    CLAUDE.md, the README or `package.json` name), fix what they report, then `build_step` with the
    step's number and one line on what you did. NanoPM commits right then, so a step is committed