@nanobpm/urban 0.72.0 → 0.72.1

package/dist/runtime/core/modules/connectors.js

@@ -85,11 +85,19 @@ export async function resolveInstalledConnectors(ctx) {
  *  error boundary by the engine adapter); `job.fail(msg)` a plain throw (retry). */
 export function adaptConnectorHandler(worker) {
     return async (job) => {
+        // A connector job always belongs to a process instance; a missing key is a
+        // protocol fault. Fail loud (the engine retries / raises an incident) rather
+        // than handing the connector a fabricated "" that would silently corrupt any
+        // instance-scoped call it makes.
+        const processInstanceKey = job.processInstanceKey;
+        if (processInstanceKey === undefined || processInstanceKey === "") {
+            throw new Error(`connector job '${job.jobType}' (${job.jobKey}) has no processInstanceKey`);
+        }
         let outcome;
         const facade = {
             jobKey: job.jobKey,
             type: job.jobType,
-            processInstanceKey: job.processInstanceKey ?? "",
+            processInstanceKey,
             elementId: job.elementId,
             variables: job.variables,
             async complete(vars) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@nanobpm/urban",
-	"version": "0.72.0",
+	"version": "0.72.1",
 	"description": "Urban: build and run code-first apps on Nano — runtime, derivation toolkit, and CLI in one. Author durable processes with @nanobpm/workflow (defineFlow), a typed datasource, forms, triggers and surfaces from a nano.app.json manifest, on Node or Deno.",
 	"license": "Apache-2.0",
 	"type": "module",

package/src/runtime/core/modules/connectors.test.ts

@@ -145,6 +145,7 @@ test("mountConnectors imports the pack entry and registers the drained worker",
   const out = await engine.deliver("slack:send-message", {
     jobKey: "j1",
     jobType: "slack:send-message",
+    processInstanceKey: "pi1",
     variables: { text: "hi" },
   });
   assert.deepEqual(out, { echoed: "hi" });
@@ -214,7 +215,7 @@ test("mountConnectors fails closed on a duplicate worker type in one pack entry"
 });
 
 test("adaptConnectorHandler maps complete/fail/error(BpmnError) and a returned value", async () => {
-  const job: EngineJob = { jobKey: "j", jobType: "t", variables: {} };
+  const job: EngineJob = { jobKey: "j", jobType: "t", processInstanceKey: "pi", variables: {} };
 
   const completes = adaptConnectorHandler({ type: "t", handle: async (j) => void (await j.complete({ a: 1 })) });
   assert.deepEqual(await completes(job), { a: 1 });
@@ -231,3 +232,22 @@ test("adaptConnectorHandler maps complete/fail/error(BpmnError) and a returned v
     (e: unknown) => e instanceof BpmnError && e.errorCode === "CODE",
   );
 });
+
+test("adaptConnectorHandler fails loud on a job with no processInstanceKey (no masking to '')", async () => {
+  // Guard for the decode-boundary defect class (Magikcraft/nano-bpm#940): a
+  // keyless job must reject, never invoke the connector with a fabricated "".
+  let handlerRan = false;
+  const h = adaptConnectorHandler({
+    type: "t",
+    handle: async () => {
+      handlerRan = true;
+    },
+  });
+  const keyless: EngineJob = { jobKey: "j", jobType: "t", variables: {} };
+  await assert.rejects(() => Promise.resolve(h(keyless)), /no processInstanceKey/);
+  assert.equal(handlerRan, false, "connector handler must not run for a keyless job");
+
+  // An empty-string key is the exact masking source and is rejected too.
+  const emptyKey: EngineJob = { jobKey: "j", jobType: "t", processInstanceKey: "", variables: {} };
+  await assert.rejects(() => Promise.resolve(h(emptyKey)), /no processInstanceKey/);
+});

package/src/runtime/core/modules/connectors.ts

@@ -134,6 +134,14 @@ export async function resolveInstalledConnectors(
  *  error boundary by the engine adapter); `job.fail(msg)` a plain throw (retry). */
 export function adaptConnectorHandler(worker: DefinedConnectorWorker): JobHandler {
   return async (job: EngineJob) => {
+    // A connector job always belongs to a process instance; a missing key is a
+    // protocol fault. Fail loud (the engine retries / raises an incident) rather
+    // than handing the connector a fabricated "" that would silently corrupt any
+    // instance-scoped call it makes.
+    const processInstanceKey = job.processInstanceKey;
+    if (processInstanceKey === undefined || processInstanceKey === "") {
+      throw new Error(`connector job '${job.jobType}' (${job.jobKey}) has no processInstanceKey`);
+    }
     let outcome:
       | { kind: "complete"; vars?: Record<string, unknown> }
       | { kind: "fail"; message: string }
@@ -142,7 +150,7 @@ export function adaptConnectorHandler(worker: DefinedConnectorWorker): JobHandle
     const facade: ConnectorWorkerJob = {
       jobKey: job.jobKey,
       type: job.jobType,
-      processInstanceKey: job.processInstanceKey ?? "",
+      processInstanceKey,
       elementId: job.elementId,
       variables: job.variables,
       async complete(vars) {