@nanobpm/urban 0.40.1 → 0.40.2

package/dist/runtime/core/modules/pages.js

@@ -1084,6 +1084,19 @@ function renderDataGrid(node) {
           try { selStart = active.selectionStart; selEnd = active.selectionEnd; } catch (e) { /* non-text field */ }
         }
       }
+      // Capture scroll offsets of scrolled descendants before the swap. An open detail node is
+      // reused (same element instance), but replaceChildren() detaches it, which resets the
+      // scrollTop/scrollLeft of any inner scroll container (e.g. a scrolled-into .pc-transcript,
+      // max-height + overflow:auto) back to 0. Only built (open) detail subtrees are re-attached
+      // by the rebuild, so walk just those — not the whole grid — to keep this O(open panels)
+      // rather than O(grid size). Restoration below skips any node that isn't re-attached.
+      const scrollSaved = [];
+      for (const entry of detailNodes.values()) {
+        if (!entry.built) continue;
+        for (const sc of entry.dtr.querySelectorAll("*")) {
+          if (sc.scrollTop || sc.scrollLeft) scrollSaved.push([sc, sc.scrollTop, sc.scrollLeft]);
+        }
+      }
       tbody.replaceChildren();
       for (const row of rows) renderRow(row);
       if (!rows.length) tbody.append(el("tr", {}, el("td", { colspan: span }, "No rows")));
@@ -1095,6 +1108,10 @@ function renderDataGrid(node) {
           try { active.setSelectionRange(selStart, selEnd); } catch (e) { /* non-text field */ }
         }
       }
+      // Restore scroll depth on the reused nodes that survived the swap (still connected).
+      for (const [sc, top, left] of scrollSaved) {
+        if (sc.isConnected) { sc.scrollTop = top; sc.scrollLeft = left; }
+      }
     } catch (e) {
       tbody.replaceChildren(el("tr", {}, el("td", { colspan: span }, String(e.message || e))));
     }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@nanobpm/urban",
-	"version": "0.40.1",
+	"version": "0.40.2",
 	"description": "Urban: build and run code-first apps on Nano — runtime, derivation toolkit, and CLI in one. Author durable processes with @nanobpm/workflow (defineFlow), a typed datasource, forms, triggers and surfaces from a nano.app.json manifest, on Node or Deno.",
 	"license": "Apache-2.0",
 	"type": "module",

package/src/runtime/core/modules/pages.test.ts

@@ -234,6 +234,21 @@ test("renderer keeps the detail input focused across the refresh poll", async ()
   assert.match(js, /s\.addRange\(savedRange\)/);
 });
 
+test("renderer preserves inner scroll depth across the refresh poll", async () => {
+  // Regression: an open detail row is reused across the 5s poll, but tbody.replaceChildren()
+  // detaches it, which resets the scrollTop of any inner overflow:auto container — so a
+  // scrolled-into transcript (.pc-transcript, max-height + overflow:auto) jumped back to the
+  // top every refreshMs. The client now captures scroll offsets of scrolled descendants
+  // before the swap and restores them on the nodes that stay connected afterwards.
+  const res = await dispatch("GET", "/app/runtime.js");
+  const js = res.body ?? "";
+  // Offsets are captured from scrolled descendants before replaceChildren()…
+  assert.match(js, /const scrollSaved = \[\]/);
+  assert.match(js, /if\s*\(\s*sc\.scrollTop\s*\|\|\s*sc\.scrollLeft\s*\)\s*scrollSaved\.push/);
+  // …and restored only on nodes re-attached by the rebuild (still connected).
+  assert.match(js, /if\s*\(\s*sc\.isConnected\s*\)\s*\{\s*sc\.scrollTop\s*=\s*top\s*;\s*sc\.scrollLeft\s*=\s*left\s*;\s*\}/);
+});
+
 test("renderer wires a column's linkField to a new-tab anchor", async () => {
   const res = await dispatch("GET", "/app/runtime.js");
   const js = res.body ?? "";

package/src/runtime/core/modules/pages.ts

@@ -1132,6 +1132,19 @@ function renderDataGrid(node) {
           try { selStart = active.selectionStart; selEnd = active.selectionEnd; } catch (e) { /* non-text field */ }
         }
       }
+      // Capture scroll offsets of scrolled descendants before the swap. An open detail node is
+      // reused (same element instance), but replaceChildren() detaches it, which resets the
+      // scrollTop/scrollLeft of any inner scroll container (e.g. a scrolled-into .pc-transcript,
+      // max-height + overflow:auto) back to 0. Only built (open) detail subtrees are re-attached
+      // by the rebuild, so walk just those — not the whole grid — to keep this O(open panels)
+      // rather than O(grid size). Restoration below skips any node that isn't re-attached.
+      const scrollSaved = [];
+      for (const entry of detailNodes.values()) {
+        if (!entry.built) continue;
+        for (const sc of entry.dtr.querySelectorAll("*")) {
+          if (sc.scrollTop || sc.scrollLeft) scrollSaved.push([sc, sc.scrollTop, sc.scrollLeft]);
+        }
+      }
       tbody.replaceChildren();
       for (const row of rows) renderRow(row);
       if (!rows.length) tbody.append(el("tr", {}, el("td", { colspan: span }, "No rows")));
@@ -1143,6 +1156,10 @@ function renderDataGrid(node) {
           try { active.setSelectionRange(selStart, selEnd); } catch (e) { /* non-text field */ }
         }
       }
+      // Restore scroll depth on the reused nodes that survived the swap (still connected).
+      for (const [sc, top, left] of scrollSaved) {
+        if (sc.isConnected) { sc.scrollTop = top; sc.scrollLeft = left; }
+      }
     } catch (e) {
       tbody.replaceChildren(el("tr", {}, el("td", { colspan: span }, String(e.message || e))));
     }