@nanobpm/nano-workforce 0.40.0 → 0.40.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [0.40.1](https://github.com/nanobpm/nano-workforce/compare/v0.40.0...v0.40.1) (2026-08-11)
+
+
+### Bug Fixes
+
+* **convergence:** safe default for resultless review rounds ([#116](https://github.com/nanobpm/nano-workforce/issues/116)) ([de85188](https://github.com/nanobpm/nano-workforce/commit/de85188f57b69496596f4c41cf555c9f6f2090da))
+
 # [0.40.0](https://github.com/nanobpm/nano-workforce/compare/v0.39.3...v0.40.0) (2026-08-11)
 
 

package/app/persist-escalation.test.ts

@@ -95,11 +95,17 @@ test("a padded question is persisted trimmed (no whitespace drift)", async () =>
   assertEquals((updates.pull_requests![0] as any).patch.open_escalation_question, "needs a decision", "denormalised question is trimmed too");
 });
 
-// A round that fell through the `gw-status` default (no `converged`/`addressed` status and no
-// question — the prompt-less-agent failure behind the empty "(no question provided)" escalations
-// on Magikcraft/nano-bpm #597/#599) must NOT throw (which parked an un-remediable JobNoRetries
-// incident). It now opens an *answerable* escalation with a fabricated, concrete question and the
-// agent's transcript attached, so a human can unblock the loop entirely from the UI.
+// Defence-in-depth for the persist-escalation worker: if the gateway ever DOES route a
+// blank-status / blank-question job here (an agent-raised `needs_input`/`blocked` with no
+// question, or the max-rounds / review-stalled arms), the worker must NOT throw — throwing
+// parked an un-remediable JobNoRetries incident (the empty "(no question provided)" escalations
+// on Magikcraft/nano-bpm #597/#599). It opens an *answerable* escalation with a fabricated,
+// concrete question and the agent's transcript attached, so a human can unblock the loop from
+// the UI.
+//
+// NOTE: the `gw-status` gateway no longer routes an empty/unknown status here — that now
+// defaults to `f_addressed` and re-enters the review wait (see roundResultDefault.test.ts).
+// This fabrication path stays as a worker-level backstop for the explicit escalation arms.
 test("blank question fabricates an answerable escalation (no throw, no incident)", async () => {
   for (const question of [undefined, "", "   "]) {
     const { app, inserts, updates } = fakeApp();

package/app/roundResultDefault.test.ts

@@ -0,0 +1,94 @@
+// Structural regression guard for the review-round "safe default" routing.
+//
+// A review round that exits without a machine-readable result (empty/unknown status)
+// used to fall through the `gw-status` exclusive gateway's `default="f_escalate"`
+// arm and escalate to a human — even after a benign rebase/force-push with no
+// reviewer comments. That is premature: the round-cap gate (`gw-guard`) and the
+// review-wait timeout already provide the human-escalation safety nets, and
+// `persist-round` defaults an absent status to `addressed`.
+//
+// The fix inverts the gateway: escalation is now an EXPLICIT arm gated on
+// `needs_input`/`blocked`, and `f_addressed` is the default, so any unknown/empty
+// status re-enters the durable review wait instead of paging a human.
+//
+// This is a pure text assertion over the committed BPMN (no engine), matching the
+// repo's lightweight model-guard style (see mergeRebaseArm.test.ts).
+
+import { test } from "node:test";
+import { assert, assertStringIncludes } from "#test-assert";
+import { readFileSync } from "node:fs";
+
+const bpmn = readFileSync("resources/processes/convergence-loop.bpmn", "utf8");
+
+// Collapse whitespace so attribute-order / line-wrapping churn doesn't make the assertions brittle.
+const flat = bpmn.replace(/\s+/g, " ");
+
+// The `<sequenceFlow id="...">` element (whole element, up to its close), whether
+// self-closing or with children. Returns the matched text or null.
+//
+// The body branch uses a tempered negative lookahead — `(?:(?!<bpmn:sequenceFlow\b).)*?`
+// — so it can never over-match across a following `<bpmn:sequenceFlow>` element; it
+// captures only up to *this* element's own close.
+function flowElement(id: string): string | null {
+  const re = new RegExp(
+    `<bpmn:sequenceFlow\\b[^>]*?\\bid="${id}"[^>]*?(?:/>|>(?:(?!<bpmn:sequenceFlow\\b).)*?</bpmn:sequenceFlow>)`,
+  );
+  const m = flat.match(re);
+  return m ? m[0] : null;
+}
+
+// Every `<bpmn:sequenceFlow>` element (whole element, self-closing or with children),
+// using the same tempered-lookahead boundary as flowElement() so a captured element can
+// never bleed into the next one.
+function allFlows(): string[] {
+  const re = new RegExp(
+    "<bpmn:sequenceFlow\\b[^>]*?(?:/>|>(?:(?!<bpmn:sequenceFlow\\b).)*?</bpmn:sequenceFlow>)",
+    "g",
+  );
+  return flat.match(re) ?? [];
+}
+
+test("gw-status defaults to the addressed arm, not escalation", () => {
+  const gw = flat.match(/<bpmn:exclusiveGateway\b[^>]*\bid="gw-status"[^>]*>/);
+  assert(gw, "gw-status gateway missing");
+  assertStringIncludes(gw[0], 'default="f_addressed"');
+  // The old premature-escalation default must be gone.
+  assert(
+    !/id="gw-status"[^>]*default="f_escalate"/.test(flat),
+    "gw-status must no longer default to escalation",
+  );
+});
+
+test("escalation is an explicit needs_input/blocked arm", () => {
+  const esc = flowElement("f_escalate");
+  assert(esc, "f_escalate flow missing");
+  assertStringIncludes(esc, 'targetRef="persist-escalation"');
+  // Escalation now only fires on an explicit human-blocking status.
+  assertStringIncludes(esc, 'status = "needs_input" or status = "blocked"');
+});
+
+test("the default (addressed) arm carries no condition and re-enters the guard", () => {
+  const addressed = flowElement("f_addressed");
+  assert(addressed, "f_addressed flow missing");
+  assertStringIncludes(addressed, 'targetRef="gw-guard"');
+  // A default flow must have NO conditionExpression.
+  assert(
+    !/conditionExpression/.test(addressed),
+    "f_addressed is the default flow and must not carry a conditionExpression",
+  );
+});
+
+test("regression: an empty/unknown status no longer routes to persist-escalation", () => {
+  // Escalation is reachable ONLY via an explicit condition (the needs_input/blocked arm),
+  // never as a catch-all default. Enumerate EVERY sequenceFlow into `persist-escalation`
+  // and assert each one carries a conditionExpression — so no future edit can slip an
+  // unconditional (default) arm into escalation.
+  const intoEscalation = allFlows().filter((f) => /targetRef="persist-escalation"/.test(f));
+  assert(intoEscalation.length > 0, "no flow targets persist-escalation");
+  for (const f of intoEscalation) {
+    assertStringIncludes(f, "conditionExpression");
+  }
+  // The addressed default must land on the guard (which re-solicits the review), not escalation.
+  const addressed = flowElement("f_addressed");
+  assert(addressed && /targetRef="gw-guard"/.test(addressed), "default arm must re-enter gw-guard");
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nanobpm/nano-workforce",
-  "version": "0.40.0",
+  "version": "0.40.1",
   "description": "Nano Workforce — an Agent Graph Orchestration application for Agentic SDLC: durable BPMN processes that coordinate a graph of AI agents across the software delivery lifecycle.",
   "type": "module",
   "main": "main.ts",

package/prompts/review-round.md

@@ -58,7 +58,11 @@ Because several agents may run on the same host at once:
 3. **Act.** Make the code changes for all fixes + nitpicks in your workspace (`cwd`)
    in one coherent, signed-off commit (`git commit -s`). Run the repo's
    build/test/lint locally before pushing. Push to the PR's head branch (the branch
-   you are already on) — do not open a new branch or PR.
+   you are already on) — do not open a new branch or PR. If the branch has drifted
+   behind its base and you need to **rebase / resolve a merge conflict** to keep it
+   mergeable, that is allowed: do it in place on this branch and **force-push**
+   (`--force-with-lease`). Any push this round — including a rebase/force-push with
+   no reviewer comments to act on — is an **`addressed`** round (see the return table).
 4. **Reply in-thread** to each comment you addressed or pushed back on, one reply
    per comment, so the trail lives on the PR.
 5. **Resolve the thread** for every comment you handled — every *fix*, *nitpick*,
@@ -128,7 +132,7 @@ Return **one** of:
 | `status`      | when                                                          | also set        |
 |---------------|---------------------------------------------------------------|-----------------|
 | `converged`   | nothing actionable left (see above)                           | `summary`       |
-| `addressed`   | you made changes + pushed this round                          | `summary`       |
+| `addressed`   | you pushed anything this round — code fixes, nitpicks, **or** a rebase/force-push to resolve a conflict | `summary`       |
 | `waiting`     | nothing to triage yet — you are awaiting a pending review (typically round 1) | `summary` |
 | `needs_input` | you hit a decision only a human can make                      | `summary`, `question` |
 | `blocked`     | you are stuck on something external (auth, failing push, missing secret) | `summary`, `question` |
@@ -143,7 +147,8 @@ Never guess on a `needs_input` decision — raise it and let a human answer.
 
 Your result variables only reach the process if you emit them through the harness's
 result channel. Prose in your normal output is **not** parsed — if you only "say"
-your status in the transcript, the round escalates with an empty question. So:
+your status in the transcript, the process can't read it, falls back to a safe
+default, and you waste a round. So emit a machine-readable result one of two ways:
 
 1. **Write a JSON object to the file at `$AGENT_RESULT_FILE`** (an env var the
    harness sets for you). The object's keys become process variables. Example for a
@@ -169,3 +174,12 @@ your status in the transcript, the round escalates with an empty question. So:
 Do not put the result file inside the repo checkout or `git add` it — it lives
 outside your workspace. Exit `0` for every status (including `blocked`/`needs_input`);
 a non-zero exit means a genuine crash and the job is retried.
+
+**Emitting a machine-readable result is your mandatory final step — never exit
+silently.** Emitting a result (the `$AGENT_RESULT_FILE` write, or the stdout fallback
+above if you truly cannot write the file) is the last thing you do on every path out of
+this round (including after a rebase/force-push, or when nothing needed doing). If you
+are ever unsure which status applies and you are not blocked on a human decision,
+return **`addressed`** (or **`waiting`** if you are still awaiting the first review) —
+never leave without a result. A missing result is treated as a safe `addressed` and
+re-enters the review wait, but relying on that instead of emitting one wastes a round.

package/resources/processes/convergence-loop.bpmn

@@ -90,7 +90,7 @@
       <bpmn:incoming>f_answerLoop</bpmn:incoming>
       <bpmn:outgoing>f_toStatus</bpmn:outgoing>
     </bpmn:serviceTask>
-    <bpmn:exclusiveGateway id="gw-status" name="status?" default="f_escalate">
+    <bpmn:exclusiveGateway id="gw-status" name="status?" default="f_addressed">
       <bpmn:incoming>f_toStatus</bpmn:incoming>
       <bpmn:outgoing>f_converged</bpmn:outgoing>
       <bpmn:outgoing>f_addressed</bpmn:outgoing>
@@ -202,13 +202,13 @@
     <bpmn:sequenceFlow id="f_converged" name="converged" sourceRef="gw-status" targetRef="persist-converged">
       <bpmn:conditionExpression xsi:type="bpmn:tFormalExpression">=status = "converged"</bpmn:conditionExpression>
     </bpmn:sequenceFlow>
-    <bpmn:sequenceFlow id="f_addressed" name="addressed" sourceRef="gw-status" targetRef="gw-guard">
-      <bpmn:conditionExpression xsi:type="bpmn:tFormalExpression">=status = "addressed"</bpmn:conditionExpression>
-    </bpmn:sequenceFlow>
+    <bpmn:sequenceFlow id="f_addressed" name="addressed / default" sourceRef="gw-status" targetRef="gw-guard" />
     <bpmn:sequenceFlow id="f_waiting" name="waiting" sourceRef="gw-status" targetRef="gw-guard">
       <bpmn:conditionExpression xsi:type="bpmn:tFormalExpression">=status = "waiting"</bpmn:conditionExpression>
     </bpmn:sequenceFlow>
-    <bpmn:sequenceFlow id="f_escalate" name="needs_input / blocked" sourceRef="gw-status" targetRef="persist-escalation" />
+    <bpmn:sequenceFlow id="f_escalate" name="needs_input / blocked" sourceRef="gw-status" targetRef="persist-escalation">
+      <bpmn:conditionExpression xsi:type="bpmn:tFormalExpression">=status = "needs_input" or status = "blocked"</bpmn:conditionExpression>
+    </bpmn:sequenceFlow>
     <bpmn:sequenceFlow id="f_guardMax" name="max rounds" sourceRef="gw-guard" targetRef="persist-escalation-maxrounds">
       <bpmn:conditionExpression xsi:type="bpmn:tFormalExpression">=round &gt;= maxRounds</bpmn:conditionExpression>
     </bpmn:sequenceFlow>
@@ -337,7 +337,7 @@
         <di:waypoint x="441" y="280" />
         <di:waypoint x="591" y="280" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="446" y="206" width="67" height="14" />
+          <dc:Bounds x="446" y="199" width="78" height="28" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNEdge id="BPMNEdge_f_waiting" bpmnElement="f_waiting">