@nanobpm/nano-workforce 0.36.0 → 0.38.0

package/app/taskDelta.test.ts

@@ -1,5 +1,6 @@
 // Unit tests for the structured scope/impl-change report (D5, issue #55 / #49).
-import { assert, assertEquals } from "jsr:@std/assert@1";
+import { test } from "node:test";
+import { assert, assertEquals } from "#test-assert";
 import type { DataLayer } from "@nanobpm/urban";
 import {
   aggregateEpicDeltas,
@@ -11,49 +12,39 @@ import {
 
 // A tiny in-memory stand-in for the record gateway (insert/find/findOne/update/delete), mirroring
 // the fake-app style used across the app tests (see app/blackboard.test.ts).
-// deno-lint-ignore no-explicit-any
 function memData(): { data: DataLayer; stores: Record<string, any[]> } {
-  // deno-lint-ignore no-explicit-any
   const stores: Record<string, any[]> = {};
   const seq: Record<string, number> = {};
   function tbl(name: string, pk = "id") {
-    // deno-lint-ignore no-explicit-any
     const rows = (stores[name] ??= [] as any[]);
-    // deno-lint-ignore no-explicit-any
     const match = (r: any, where: any) => Object.entries(where).every(([k, v]) => r[k] === v);
     return {
-      // deno-lint-ignore no-explicit-any require-await
       async insert(row: any) {
         const id = (seq[name] = (seq[name] ?? 0) + 1);
         rows.push(pk === "id" ? { id, ...row } : { ...row });
         return pk === "id" ? id : row[pk];
       },
-      // deno-lint-ignore no-explicit-any require-await
       async find(where: any = {}) {
         return rows.filter((r) => match(r, where));
       },
-      // deno-lint-ignore no-explicit-any require-await
       async findOne(where: any = {}) {
         return rows.find((r) => match(r, where));
       },
-      // deno-lint-ignore no-explicit-any require-await
       async update(id: any, patch: any) {
         const r = rows.find((row) => row[pk] === id);
         if (r) Object.assign(r, patch);
       },
-      // deno-lint-ignore no-explicit-any require-await
       async delete(id: any) {
         const i = rows.findIndex((row) => row[pk] === id);
         if (i >= 0) rows.splice(i, 1);
       },
     };
   }
-  // deno-lint-ignore no-explicit-any
   const data = { table: (n: string, pk?: string) => tbl(n, pk) } as any as DataLayer;
   return { data, stores };
 }
 
-Deno.test("parseTaskDelta: trims, dedupes arrays, and drops empties", () => {
+test("parseTaskDelta: trims, dedupes arrays, and drops empties", () => {
   const d = parseTaskDelta({
     contractChange: "  new signature  ",
     newlyTouches: ["a.rs", " a.rs ", "", "b.rs"],
@@ -67,14 +58,14 @@ Deno.test("parseTaskDelta: trims, dedupes arrays, and drops empties", () => {
   assertEquals(d.constraint, undefined, "a blank constraint is dropped");
 });
 
-Deno.test("parseTaskDelta: a delta with nothing actionable is null", () => {
+test("parseTaskDelta: a delta with nothing actionable is null", () => {
   assertEquals(parseTaskDelta(undefined), null);
   assertEquals(parseTaskDelta({}), null);
   assertEquals(parseTaskDelta({ newlyTouches: [], affectsTasks: [], contractChange: "  " }), null);
   assertEquals(parseTaskDelta("not an object"), null);
 });
 
-Deno.test("recordTaskDelta: upserts per (plan, task) — a resume overwrites, not duplicates", async () => {
+test("recordTaskDelta: upserts per (plan, task) — a resume overwrites, not duplicates", async () => {
   const { data, stores } = memData();
   const first = await recordTaskDelta(data, "o/r#1", "gap-2", {
     newlyTouches: ["a.rs"],
@@ -99,7 +90,7 @@ Deno.test("recordTaskDelta: upserts per (plan, task) — a resume overwrites, no
   assertEquals(entry.wave, 1);
 });
 
-Deno.test("readTaskDeltas: scoped to a plan, in write order, arrays decoded", async () => {
+test("readTaskDeltas: scoped to a plan, in write order, arrays decoded", async () => {
   const { data } = memData();
   await recordTaskDelta(data, "o/r#1", "gap-2", { newlyTouches: ["a.rs"], affectsTasks: [] });
   await recordTaskDelta(data, "o/r#1", "gap-8", { newlyTouches: [], affectsTasks: ["gap-2"], constraint: "x" });
@@ -111,7 +102,7 @@ Deno.test("readTaskDeltas: scoped to a plan, in write order, arrays decoded", as
   assertEquals(entries[1].affectsTasks, ["gap-2"]);
 });
 
-Deno.test("aggregateEpicDeltas: unions touched files + affected tasks, lists changes/constraints", async () => {
+test("aggregateEpicDeltas: unions touched files + affected tasks, lists changes/constraints", async () => {
   const { data } = memData();
   await recordTaskDelta(data, "p", "gap-2", {
     newlyTouches: ["engine/state.rs"],
@@ -132,7 +123,7 @@ Deno.test("aggregateEpicDeltas: unions touched files + affected tasks, lists cha
   assertEquals(report.deltas.length, 2);
 });
 
-Deno.test("clearTaskDeltas: drops a plan's whole set (re-plan cleanup), leaving other plans intact", async () => {
+test("clearTaskDeltas: drops a plan's whole set (re-plan cleanup), leaving other plans intact", async () => {
   const { data, stores } = memData();
   await recordTaskDelta(data, "p", "gap-2", { newlyTouches: ["a.rs"], affectsTasks: [] });
   await recordTaskDelta(data, "p", "gap-8", { newlyTouches: ["b.rs"], affectsTasks: [] });

package/app/trialMerge.test.ts

@@ -1,13 +1,14 @@
-import { assertEquals } from "jsr:@std/assert@1";
+import { test } from "node:test";
+import { assertEquals } from "#test-assert";
 import { shouldRunTrialMerge, trialMergeDecision } from "./trialMerge.ts";
 
-Deno.test("trialMergeDecision only escalates clean-merge suite failures", () => {
+test("trialMergeDecision only escalates clean-merge suite failures", () => {
   assertEquals(trialMergeDecision("clean"), "proceed");
   assertEquals(trialMergeDecision("merge-conflict"), "proceed");
   assertEquals(trialMergeDecision("suite-failed"), "escalate");
 });
 
-Deno.test("shouldRunTrialMerge skips lone heads and mergify queues", () => {
+test("shouldRunTrialMerge skips lone heads and mergify queues", () => {
   assertEquals(shouldRunTrialMerge(0, { land: { method: "gh-merge" } }), false);
   assertEquals(shouldRunTrialMerge(1, { land: { method: "gh-merge" } }), false);
   assertEquals(shouldRunTrialMerge(2, { land: { method: "mergify-queue" } }), false);

package/app/version.ts

@@ -5,7 +5,7 @@
 // inspecting the working tree at runtime. This module gathers that identity — the app's package
 // version, the resolved `@nanobpm/urban` version, the git commit (read from `.git`, handling both
 // an ordinary `.git` directory and the `gitdir:` file pointer used by worktrees/submodules, with
-// an env override for detached deploys), plus the Node/Deno runtime, pid and start time — so an operator
+// an env override for detached deploys), plus the Node runtime, pid and start time — so an operator
 // debugging a stuck instance can confirm the process is on the code they think it is.
 //
 // Every probe is best-effort: a missing file or unavailable `.git` yields `null` for that field
@@ -39,20 +39,11 @@ function readJson(path: string): Record<string, unknown> | null {
 }
 
 /**
- * Read an env var across runtimes: Node exposes `process.env`; Deno may not populate it, so fall
- * back to `Deno.env.get` (guarded — reading env can throw without `--allow-env`).
+ * Read an env var from `process.env`, trimmed; returns null when unset or blank.
  */
 export function envVar(name: string): string | null {
-  const fromProcess = globalThis.process?.env?.[name];
+  const fromProcess = process.env[name];
   if (typeof fromProcess === "string" && fromProcess.trim()) return fromProcess.trim();
-  // biome-ignore lint/plugin: runtime/framework contract boundary for external data shape
-  const deno = (globalThis as { Deno?: { env?: { get?(k: string): string | undefined } } }).Deno;
-  try {
-    const fromDeno = deno?.env?.get?.(name);
-    if (typeof fromDeno === "string" && fromDeno.trim()) return fromDeno.trim();
-  } catch {
-    // Env access denied — treat as unset.
-  }
   return null;
 }
 
@@ -159,13 +150,8 @@ function gitBranch(): string | null {
 }
 
 function runtime(): string {
-  const proc = globalThis.process;
-  // Deno exposes `Deno.version.deno`; Node exposes `process.version` (e.g. "v24.15.0").
-  // biome-ignore lint/plugin: runtime/framework contract boundary for external data shape
-  const deno = (globalThis as { Deno?: { version?: { deno?: string } } }).Deno;
-  if (deno?.version?.deno) return `deno ${deno.version.deno}`;
-  if (proc?.version) return `node ${proc.version}`;
-  return "unknown";
+  // Node exposes `process.version` (e.g. "v24.15.0").
+  return process.version ? `node ${process.version}` : "unknown";
 }
 
 export interface VersionInfo {
@@ -185,7 +171,6 @@ export interface VersionInfo {
  * tree ONCE at module load rather than re-reading files (`.git`, package.jsons) on every request.
  */
 const STATIC: Omit<VersionInfo, "uptimeSeconds"> = (() => {
-  const proc = globalThis.process;
   const pkg = appPackage();
   return Object.freeze({
     name: appName(pkg),
@@ -194,7 +179,7 @@ const STATIC: Omit<VersionInfo, "uptimeSeconds"> = (() => {
     gitSha: gitSha(),
     gitBranch: gitBranch(),
     runtime: runtime(),
-    pid: typeof proc?.pid === "number" ? proc.pid : null,
+    pid: typeof process.pid === "number" ? process.pid : null,
     startedAt: STARTED_AT.toISOString(),
   });
 })();

package/app/waves.test.ts

@@ -1,20 +1,21 @@
-// Red/green regression for the plan levelizer (issue #20). Run with `deno test`.
+// Red/green regression for the plan levelizer (issue #20). Run with `node --test`.
 //
-// One `Deno.test` = one named property of computeWaves. These encode the wave
+// One `test` = one named property of computeWaves. These encode the wave
 // contract: independent tasks share wave 0 (all-parallel), a chain steps 0,1,2…
 // (all-sequential), a diamond re-converges, and a malformed graph is rejected
 // rather than silently mis-levelized.
-import { assertEquals, assertThrows } from "jsr:@std/assert@1";
+import { test } from "node:test";
+import { assertEquals, assertThrows } from "#test-assert";
 import { computeWaves, WaveError, type WaveGateTask, type WaveTask, waveMergeTargets } from "./waves.ts";
 
-Deno.test("no dependencies → every task in wave 0 (fully parallel)", () => {
+test("no dependencies → every task in wave 0 (fully parallel)", () => {
   const tasks: WaveTask[] = [{ id: "a" }, { id: "b" }, { id: "c" }];
   const { waves, waveCount } = computeWaves(tasks);
   assertEquals(waveCount, 1);
   assertEquals(waves, [["a", "b", "c"]]);
 });
 
-Deno.test("linear chain → one task per wave (fully sequential)", () => {
+test("linear chain → one task per wave (fully sequential)", () => {
   const tasks: WaveTask[] = [
     { id: "a" },
     { id: "b", dependsOn: ["a"] },
@@ -26,7 +27,7 @@ Deno.test("linear chain → one task per wave (fully sequential)", () => {
   assertEquals([waveOf.get("a"), waveOf.get("b"), waveOf.get("c")], [0, 1, 2]);
 });
 
-Deno.test("diamond → longest-path level; join waits for both arms", () => {
+test("diamond → longest-path level; join waits for both arms", () => {
   const tasks: WaveTask[] = [
     { id: "a" },
     { id: "b", dependsOn: ["a"] },
@@ -38,7 +39,7 @@ Deno.test("diamond → longest-path level; join waits for both arms", () => {
   assertEquals(waves, [["a"], ["b", "c"], ["d"]]);
 });
 
-Deno.test("mixed graph → level is 1 + max(dep level), not 1 + min", () => {
+test("mixed graph → level is 1 + max(dep level), not 1 + min", () => {
   // e depends on a (wave 0) and d (wave 2) → must land in wave 3, behind the deeper dep.
   const tasks: WaveTask[] = [
     { id: "a" },
@@ -52,20 +53,20 @@ Deno.test("mixed graph → level is 1 + max(dep level), not 1 + min", () => {
   assertEquals(waveOf.get("e"), 4);
 });
 
-Deno.test("empty plan → zero waves", () => {
+test("empty plan → zero waves", () => {
   const { waves, waveCount } = computeWaves([]);
   assertEquals(waveCount, 0);
   assertEquals(waves, []);
 });
 
-Deno.test("blank / whitespace dependsOn entries are ignored", () => {
+test("blank / whitespace dependsOn entries are ignored", () => {
   const tasks: WaveTask[] = [{ id: "a", dependsOn: ["", "  "] }];
   const { waves, waveCount } = computeWaves(tasks);
   assertEquals(waveCount, 1);
   assertEquals(waves, [["a"]]);
 });
 
-Deno.test("dependency cycle → WaveError", () => {
+test("dependency cycle → WaveError", () => {
   const tasks: WaveTask[] = [
     { id: "a", dependsOn: ["b"] },
     { id: "b", dependsOn: ["a"] },
@@ -73,11 +74,11 @@ Deno.test("dependency cycle → WaveError", () => {
   assertThrows(() => computeWaves(tasks), WaveError, "cycle");
 });
 
-Deno.test("self-dependency → WaveError", () => {
+test("self-dependency → WaveError", () => {
   assertThrows(() => computeWaves([{ id: "a", dependsOn: ["a"] }]), WaveError, "itself");
 });
 
-Deno.test("unknown dependency id → WaveError", () => {
+test("unknown dependency id → WaveError", () => {
   assertThrows(
     () => computeWaves([{ id: "a", dependsOn: ["ghost"] }]),
     WaveError,
@@ -85,7 +86,7 @@ Deno.test("unknown dependency id → WaveError", () => {
   );
 });
 
-Deno.test("duplicate task id → WaveError", () => {
+test("duplicate task id → WaveError", () => {
   assertThrows(
     () => computeWaves([{ id: "a" }, { id: "a" }]),
     WaveError,
@@ -98,7 +99,7 @@ Deno.test("duplicate task id → WaveError", () => {
 // opened/waiting-with-a-PR tasks of the gate wave, ignore other waves, and treat blocked/skipped
 // and keyless tasks as nothing-to-wait-on so no non-mergeable PR state can wedge the barrier.
 
-Deno.test("waveMergeTargets → only opened PRs of the gate wave", () => {
+test("waveMergeTargets → only opened PRs of the gate wave", () => {
   const tasks: WaveGateTask[] = [
     { wave: 0, status: "opened", pr_key: "o/r#1" },
     { wave: 0, status: "opened", pr_key: "o/r#2" },
@@ -107,7 +108,7 @@ Deno.test("waveMergeTargets → only opened PRs of the gate wave", () => {
   assertEquals(waveMergeTargets(tasks, 0), ["o/r#1", "o/r#2"]);
 });
 
-Deno.test("waveMergeTargets → mergeable waiting tasks are waited on; failed/keyless tasks are not", () => {
+test("waveMergeTargets → mergeable waiting tasks are waited on; failed/keyless tasks are not", () => {
   const tasks: WaveGateTask[] = [
     { wave: 0, status: "opened", pr_key: "o/r#1" },
     { wave: 0, status: "blocked", pr_key: null },
@@ -119,7 +120,7 @@ Deno.test("waveMergeTargets → mergeable waiting tasks are waited on; failed/ke
   assertEquals(waveMergeTargets(tasks, 0), ["o/r#1", "o/r#2"]);
 });
 
-Deno.test("waveMergeTargets → a wave with no opened PRs clears vacuously (empty)", () => {
+test("waveMergeTargets → a wave with no opened PRs clears vacuously (empty)", () => {
   const tasks: WaveGateTask[] = [
     { wave: 0, status: "blocked", pr_key: null },
     { wave: 0, status: "skipped", pr_key: null },

package/biome.json

@@ -4,7 +4,6 @@
     "includes": [
       "app/**/*.ts",
       "operations/**/*.ts",
-      "actions/**/*.ts",
       "workers/**/*.ts",
       "pages/**/*.ts",
       "components/**/*.ts",
@@ -20,7 +19,6 @@
     "includes": [
       "app/**/*.ts",
       "operations/**/*.ts",
-      "actions/**/*.ts",
       "workers/**/*.ts",
       "pages/**/*.ts",
       "components/**/*.ts",

package/main.ts

@@ -1,12 +1,12 @@
 // nano-workforce — Urban App entrypoint (ADR 0055).
 //
 // The whole app is declared in `nano.app.json` (models, sqlite datasource, app-hosted record
-// workers, the schema-driven pages surface, and the action overrides) and materialized by the
+// workers, the schema-driven pages surface, and the OpenAPI control surface) and materialized by the
 // `@nanobpm/urban` runtime via `runFromEnv`:
 //   • deploys the BPMN + hosts the `pr.*` record workers (workers/*/worker.ts),
 //   • serves the schema-driven page runtime (ADR 0042) from `pages/home.page.json`,
-//   • mounts the app-specific action overrides (actions/*.ts) that wrap the generic
-//     start/cancel/message actions, plus the `/hooks/submit` webhook.
+//   • mounts the OpenAPI operations (openapi.yaml → operations/*.ts) — the start/cancel/message
+//     control endpoints plus the webhook operations under `/app/api/hooks/*` (ADR 0059).
 //
 // The only thing that isn't declarative is the review-ready poller: it does arbitrary GitHub
 // polling and then correlates a `review-ready` message. A cron trigger can only fire an engine

package/nano.app.json

@@ -140,31 +140,8 @@
     "icon": "assets/icon.svg"
   },
   "api": {
-    "spec": "openapi.json",
+    "spec": "openapi.yaml",
     "dir": "operations",
     "validateResponses": "dev"
-  },
-  "actions": [
-    {
-      "path": "/hooks/submit",
-      "module": "actions/webhook-submit.ts"
-    },
-    {
-      "path": "/hooks/plan",
-      "module": "actions/plan-hook.ts"
-    },
-    {
-      "path": "/hooks/feature-answer",
-      "module": "actions/feature-answer-hook.ts"
-    },
-    {
-      "path": "/hooks/blackboard",
-      "module": "actions/blackboard.ts"
-    },
-    {
-      "path": "/hooks/abandon",
-      "module": "actions/abandon.ts",
-      "method": "GET"
-    }
-  ]
+  }
 }