@nanobpm/nano-workforce 0.200.8 → 0.201.0

package/e2e/plan-fanout.e2e.ts

@@ -587,11 +587,84 @@ describe("plan-fanout escalations (U2 — task + plan-review + trial-merge → u
 
         const answered = takenFlows(app);
         assert.ok(
-          answered.includes("w_gw_answer->implement-cell-call") && answered.includes("Start->implement-task"),
-          `answering the caps escalation released the barrier into the implement cell (flows: ${answered.join(", ")})`,
+          answered.includes("w_gw_answer->record-task-implementing") &&
+            answered.includes("record-task-implementing->implement-cell-call") &&
+            answered.includes("Start->implement-task"),
+          `answering the caps escalation reset the stale question and released the barrier into the implement cell (flows: ${answered.join(", ")})`,
         );
         assert.equal(featureRan, true, "the agent was dispatched once the operator answered the caps escalation");
       },
     );
   });
+
+  // Regression (review: "Reset stale result fields on initial implementation entry"). The capability
+  // barrier's timeout seeds an operator `question` (`wait-caps-timeout`), and answering the
+  // `feature-escalation` loops back into the implement cell (`w_answerLoop`). The cell's
+  // `record-implementing` reset clears the result fields only on its OWN retry/answer re-entry — the
+  // INITIAL `Start -> implement-task` entry bypasses it, so the inherited caps-timeout question would
+  // still be in scope. If the agent then returns an off-vocabulary `completed` (no PR delivered), a
+  // stale question makes `shouldReconcileImplement` honour it as a genuine escalation — skipping the
+  // auto-retry and re-escalating the ALREADY-ANSWERED caps question. The fix clears `question` on the
+  // plan-fanout answer loop-back, so the cell is entered clean and the claimed completion auto-retries.
+  test("capability edge: an answered caps escalation enters the cell clean — a claimed completion auto-retries, not re-escalates the stale question", async () => {
+    const capTaskPlan: Stub = () => ({
+      tasks: [
+        {
+          id: "t1",
+          title: "T1",
+          prompt: "do t1",
+          // A bare handle names no owner/repo releases source — unresolvable, so the barrier times out.
+          needs: [{ capabilityRef: "#274", package: "@nanobpm/urban" }],
+        },
+      ],
+    });
+    let featureCalls = 0;
+    await withApp(
+      {
+        "senior:plan": capTaskPlan,
+        "senior:plan-review": approveReview,
+        // The implement agent claims completion WITHOUT opening a PR (the github stub lists none) — the
+        // #865 claimed-completion-without-delivery the reconcile step auto-retries ONCE.
+        "senior:feature": () => {
+          featureCalls += 1;
+          return { status: "completed", summary: "done, no PR" };
+        },
+      },
+      async ({ app, processKey }) => {
+        // Let the unresolvable barrier time out into the operator escalation.
+        await advancePastTimer(app, 25 * 60 * 60 * 1000);
+        const task = await openTask(app, processKey, "feature-escalation");
+        await app.engine.completeUserTask(task.userTaskKey, { resolution: "answer", answer: "shipped it manually" });
+        await settleFully(app);
+
+        // The answered barrier released the token through the answer loop-back's reset into the
+        // implement cell, and the agent ran.
+        const entered = takenFlows(app);
+        assert.ok(
+          entered.includes("w_gw_answer->record-task-implementing") &&
+            entered.includes("record-task-implementing->implement-cell-call") &&
+            entered.includes("Start->implement-task"),
+          `answering the caps escalation reset the stale question and released the barrier into the implement cell (flows: ${entered.join(", ")})`,
+        );
+
+        // With the stale caps-timeout question cleared on cell entry, the off-vocabulary `completed`
+        // (no adoptable PR) takes the reconcile AUTO-RETRY arm — re-dispatching the agent once — rather
+        // than re-escalating the ALREADY-ANSWERED caps question. `settleFully` above drove the whole
+        // loop to quiescence: the agent ran exactly TWICE (the initial dispatch + the one bounded
+        // auto-retry), and only then — the retry consumed — did the cell escalate (the bounded
+        // claimed-completion behaviour of #865). The retry is the proof the stale question was cleared:
+        // an inherited question would have routed the FIRST `completed` straight to escalation.
+        const flows = takenFlows(app);
+        assert.ok(
+          flows.includes("ic_reconcile_gw->record-implementing"),
+          `the claimed completion auto-retried through the cell's reset (flows: ${flows.join(", ")})`,
+        );
+        assert.ok(
+          flows.includes("record-implementing->implement-task"),
+          `the retry re-entered the implement task (flows: ${flows.join(", ")})`,
+        );
+        assert.equal(featureCalls, 2, "the auto-retry re-dispatched the implement agent exactly once");
+      },
+    );
+  });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nanobpm/nano-workforce",
-  "version": "0.200.8",
+  "version": "0.201.0",
   "description": "Nano Workforce — an Agent Graph Orchestration application for Agentic SDLC: durable BPMN processes that coordinate a graph of AI agents across the software delivery lifecycle.",
   "type": "module",
   "main": "main.ts",

package/resources/processes/implement-cell.bpmn

@@ -7,6 +7,10 @@
           <nano:extend name="subjectKey" type="string" />
           <nano:extend name="status" type="string" optional="true" />
           <nano:extend name="question" type="string" optional="true" />
+          <nano:extend name="summary" type="string" optional="true" />
+          <nano:extend name="transcriptUrl" type="string" optional="true" />
+          <nano:extend name="pr" type="string" optional="true" />
+          <nano:extend name="deliveryVerified" type="boolean" optional="true" />
         </nano:shape>
       </nano:shapes>
     </bpmn:extensionElements>
@@ -21,10 +25,11 @@
           <zeebe:linkedResource resourceId="prompts/feature.md" bindingType="latest" resourceType="GenericScript" linkName="prompt" />
         </zeebe:linkedResources>
         <zeebe:ioMapping>
-          <zeebe:input source="=&#34;&#10;&#10;---&#10;&#10;&#34; + task.prompt + (if (is defined(baseBranchBrief) and baseBranchBrief != null) then baseBranchBrief else &#34;&#34;) + (if (is defined(blackboardBrief) and blackboardBrief != null) then blackboardBrief else &#34;&#34;) + (if (is defined(resolvedDepsBrief) and resolvedDepsBrief != null) then resolvedDepsBrief else &#34;&#34;) + (if (is defined(resolvedArtifacts) = false or resolvedArtifacts = null or count(resolvedArtifacts[item != null]) = 0) then &#34;&#34; else (&#34;&#10;&#10;---&#10;&#10;**Bound upstream readiness.** Build/install/clone against EXACTLY these resolved published versions (the ones first carrying the awaited capability), and bump the consumer dependency to them — never merely the newest:&#10;&#10;&#34; + string join(resolvedArtifacts[item != null], &#34;&#10;&#34;))) + (if (is defined(customInstructions) = false or customInstructions = null) then &#34;&#34; else &#34;&#10;&#10;---&#10;&#10;## Operator custom instructions&#10;&#10;The operator supplied these instructions for this run — follow them:&#10;&#10;&#34; + customInstructions)" target="appendPrompt" />
+          <zeebe:input source="=&#34;&#10;&#10;---&#10;&#10;&#34; + task.prompt + (if (is defined(baseBranchBrief) and baseBranchBrief != null) then baseBranchBrief else &#34;&#34;) + (if (is defined(blackboardBrief) and blackboardBrief != null) then blackboardBrief else &#34;&#34;) + (if (is defined(resolvedDepsBrief) and resolvedDepsBrief != null) then resolvedDepsBrief else &#34;&#34;) + (if (is defined(resolvedArtifacts) = false or resolvedArtifacts = null or count(resolvedArtifacts[item != null]) = 0) then &#34;&#34; else (&#34;&#10;&#10;---&#10;&#10;**Bound upstream readiness.** Build/install/clone against EXACTLY these resolved published versions (the ones first carrying the awaited capability), and bump the consumer dependency to them — never merely the newest:&#10;&#10;&#34; + string join(resolvedArtifacts[item != null], &#34;&#10;&#34;))) + (if (is defined(customInstructions) = false or customInstructions = null) then &#34;&#34; else &#34;&#10;&#10;---&#10;&#10;## Operator custom instructions&#10;&#10;The operator supplied these instructions for this run — follow them:&#10;&#10;&#34; + customInstructions) + (if (is defined(retryNudge) and retryNudge != null) then retryNudge else &#34;&#34;)" target="appendPrompt" />
           <zeebe:input source="=if (is defined(transcriptUrlBase)) then transcriptUrlBase else null" target="transcriptUrlBase" />
           <zeebe:output source="=status" target="status" />
           <zeebe:output source="=question" target="question" />
+          <zeebe:output source="=if (is defined(summary)) then summary else null" target="summary" />
           <zeebe:output source="=if (is defined(transcriptUrl)) then transcriptUrl else null" target="transcriptUrl" />
         </zeebe:ioMapping>
       </bpmn:extensionElements>
@@ -50,6 +55,10 @@
           <zeebe:output source="=reconciled" target="reconciled" />
           <zeebe:output source="=status" target="status" />
           <zeebe:output source="=pr" target="pr" />
+          <zeebe:output source="=retry" target="retry" />
+          <zeebe:output source="=retryNudge" target="retryNudge" />
+          <zeebe:output source="=retried" target="implementRetried" />
+          <zeebe:output source="=deliveryVerified" target="deliveryVerified" />
         </zeebe:ioMapping>
       </bpmn:extensionElements>
       <bpmn:incoming>ic_escalate</bpmn:incoming>
@@ -58,6 +67,7 @@
     <bpmn:exclusiveGateway id="ic_reconcile_gw" name="reconciled?" default="ic_toRecordEscalation">
       <bpmn:incoming>ic_toReconcileGw</bpmn:incoming>
       <bpmn:outgoing>ic_reconciled</bpmn:outgoing>
+      <bpmn:outgoing>ic_retry</bpmn:outgoing>
       <bpmn:outgoing>ic_toRecordEscalation</bpmn:outgoing>
     </bpmn:exclusiveGateway>
     <bpmn:callActivity id="escalate" name="Human escalation">
@@ -112,8 +122,16 @@
         <zeebe:properties>
           <zeebe:property name="io.nanobpm.dataEnvelope.in" value="RecordFeatureImplementingIn" />
         </zeebe:properties>
+        <zeebe:ioMapping>
+          <zeebe:output source="=null" target="status" />
+          <zeebe:output source="=null" target="question" />
+          <zeebe:output source="=null" target="summary" />
+          <zeebe:output source="=null" target="transcriptUrl" />
+          <zeebe:output source="=null" target="deliveryVerified" />
+        </zeebe:ioMapping>
       </bpmn:extensionElements>
       <bpmn:incoming>ic_answerLoop</bpmn:incoming>
+      <bpmn:incoming>ic_retry</bpmn:incoming>
       <bpmn:outgoing>ic_reImplement</bpmn:outgoing>
     </bpmn:serviceTask>
     <bpmn:endEvent id="ic_end" name="Task done">
@@ -134,6 +152,9 @@
     <bpmn:sequenceFlow id="ic_toRecordEscalation" name="escalated" sourceRef="ic_reconcile_gw" targetRef="record-escalation" />
     <bpmn:sequenceFlow id="ic_sla" name="agent SLA elapsed" sourceRef="be_implement_sla" targetRef="record-escalation-sla" />
     <bpmn:sequenceFlow id="ic_slaToEscalate" sourceRef="record-escalation-sla" targetRef="escalate" />
+    <bpmn:sequenceFlow id="ic_retry" name="retry" sourceRef="ic_reconcile_gw" targetRef="record-implementing">
+      <bpmn:conditionExpression xsi:type="bpmn:tFormalExpression">=retry = true</bpmn:conditionExpression>
+    </bpmn:sequenceFlow>
     <bpmn:sequenceFlow id="ic_toEscalate" sourceRef="record-escalation" targetRef="escalate" />
     <bpmn:sequenceFlow id="ic_toAnswerGw" sourceRef="escalate" targetRef="ic_gw_answer" />
     <bpmn:sequenceFlow id="ic_answerLoop" name="answer" sourceRef="ic_gw_answer" targetRef="record-implementing">
@@ -156,7 +177,7 @@
       <bpmndi:BPMNShape id="BPMNShape_ic_gw" bpmnElement="ic_gw" isMarkerVisible="true">
         <dc:Bounds x="441" y="95" width="50" height="50" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="391" y="150" width="70" height="28" />
+          <dc:Bounds x="431" y="62" width="70" height="28" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="BPMNShape_reconcile-implement" bpmnElement="reconcile-implement">
@@ -175,7 +196,7 @@
         <dc:Bounds x="966" y="80" width="100" height="80" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="BPMNShape_record-escalation-sla" bpmnElement="record-escalation-sla">
-        <dc:Bounds x="416" y="240" width="100" height="80" />
+        <dc:Bounds x="416" y="400" width="100" height="80" />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="BPMNShape_ic_gw_answer" bpmnElement="ic_gw_answer" isMarkerVisible="true">
         <dc:Bounds x="1366" y="95" width="50" height="50" />
@@ -239,12 +260,20 @@
           <dc:Bounds x="1456" y="98" width="53" height="14" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
+      <bpmndi:BPMNEdge id="BPMNEdge_ic_retry" bpmnElement="ic_retry">
+        <di:waypoint x="841" y="145" />
+        <di:waypoint x="841" y="280" />
+        <di:waypoint x="1516" y="280" />
+        <bpmndi:BPMNLabel>
+          <dc:Bounds x="846" y="223" width="39" height="14" />
+        </bpmndi:BPMNLabel>
+      </bpmndi:BPMNEdge>
       <bpmndi:BPMNEdge id="BPMNEdge_ic_answerLoop" bpmnElement="ic_answerLoop">
         <di:waypoint x="1391" y="145" />
         <di:waypoint x="1391" y="280" />
         <di:waypoint x="1516" y="280" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="1337" y="206" width="49" height="14" />
+          <dc:Bounds x="1396" y="206" width="49" height="14" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNEdge id="BPMNEdge_ic_done" bpmnElement="ic_done">
@@ -266,27 +295,23 @@
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNEdge id="BPMNEdge_ic_slaToEscalate" bpmnElement="ic_slaToEscalate">
-        <di:waypoint x="516" y="300" />
-        <di:waypoint x="536" y="300" />
-        <di:waypoint x="536" y="340" />
-        <di:waypoint x="1436" y="340" />
-        <di:waypoint x="1436" y="220" />
-        <di:waypoint x="1604" y="220" />
-        <di:waypoint x="1604" y="82" />
+        <di:waypoint x="516" y="440" />
+        <di:waypoint x="1636" y="440" />
+        <di:waypoint x="1636" y="82" />
         <di:waypoint x="1266" y="82" />
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNEdge id="BPMNEdge_ic_sla" bpmnElement="ic_sla">
         <di:waypoint x="266" y="178" />
-        <di:waypoint x="266" y="280" />
-        <di:waypoint x="416" y="280" />
+        <di:waypoint x="266" y="440" />
+        <di:waypoint x="416" y="440" />
         <bpmndi:BPMNLabel>
-          <dc:Bounds x="271" y="215" width="70" height="28" />
+          <dc:Bounds x="271" y="295" width="70" height="28" />
         </bpmndi:BPMNLabel>
       </bpmndi:BPMNEdge>
       <bpmndi:BPMNEdge id="BPMNEdge_ic_reImplement" bpmnElement="ic_reImplement">
-        <di:waypoint x="1616" y="280" />
-        <di:waypoint x="1636" y="280" />
-        <di:waypoint x="1636" y="60" />
+        <di:waypoint x="1516" y="280" />
+        <di:waypoint x="60" y="280" />
+        <di:waypoint x="60" y="60" />
         <di:waypoint x="266" y="60" />
         <di:waypoint x="266" y="80" />
       </bpmndi:BPMNEdge>