@nanobpm/nano-workforce 0.187.2 → 0.187.4

package/CHANGELOG.md

@@ -1,3 +1,15 @@
+## [0.187.4](https://github.com/nanobpm/nano-workforce/compare/v0.187.3...v0.187.4) (2026-09-14)
+
+### Bug Fixes
+
+* raise default review-wait timeout to PT30M ([#792](https://github.com/nanobpm/nano-workforce/issues/792)) ([042573d](https://github.com/nanobpm/nano-workforce/commit/042573dc5e691dc97efebc12da6a63f2cf398c2a)), closes [#783](https://github.com/nanobpm/nano-workforce/issues/783) [#791](https://github.com/nanobpm/nano-workforce/issues/791)
+
+## [0.187.3](https://github.com/nanobpm/nano-workforce/compare/v0.187.2...v0.187.3) (2026-09-14)
+
+### Bug Fixes
+
+* pr-escalation Tasks form no longer renders a blank question field ([#785](https://github.com/nanobpm/nano-workforce/issues/785)) ([eb6bc0e](https://github.com/nanobpm/nano-workforce/commit/eb6bc0e9a677effed0e4d93a3c37033f7819d943)), closes [#767](https://github.com/nanobpm/nano-workforce/issues/767)
+
 ## [0.187.2](https://github.com/nanobpm/nano-workforce/compare/v0.187.1...v0.187.2) (2026-09-13)
 
 ### Bug Fixes

package/README.md

@@ -360,7 +360,7 @@ agent at that URL to author, compile, and submit a graph unaided. See
 | `NANO_PR_MERGE_METHOD` | `squash` | merge method: `squash`, `merge`, or `rebase` |
 | `NANO_PR_MERGE_ADMIN` | `0` | pass `--admin` to override failing non-required checks (use with care) |
 | `NANO_PR_MAX_CI_FIX_ROUNDS` | `3` | max `senior:fix-ci` attempts to green a `blocked` PR before escalating; `0` disables (escalate immediately), clamped 0–20 |
-| `NANO_PR_REVIEW_WAIT_TIMEOUT` | `PT20M` | ISO-8601 duration the loop waits for a fresh review before escalating a stalled review (timer arm of the `wait-review` gateway) |
+| `NANO_PR_REVIEW_WAIT_TIMEOUT` | `PT30M` | ISO-8601 duration the loop waits for a fresh review before escalating a stalled review (timer arm of the `wait-review` gateway) |
 | `NANO_PR_REVIEW_NUDGE_MINUTES` | `5` | cooldown between the poller's automatic reviewer re-request nudges for one waiting PR (clamped 1–1440) |
 | `NANO_WORKFORCE_BASE_URL` | `http://localhost:3000` | externally-reachable base URL for the capability hooks (`/app/api/hooks/*`). Must resolve from **wherever the agent runs** — set it to the app's LAN address (or console-proxy URL) for a remote fleet. See [Fleet networking](#fleet-networking-remote-workers) |
 | `NANO_AGENTIC_SECRET` | — | enables **secure mode** for the agentic visibility channel (`/agentic`): every peer must present the **same** `NANO_AGENTIC_SECRET` value (set the identical env var on the server and every worker box — Tab A → Slot A). Unset = on-by-default **LOCAL mode** — the well-known token is honoured from **any origin** (open on the trusted LAN, matching the engine's posture); exposure is governed by the server bind address, not a shared secret. Also accepts `NANO_PR_WEBHOOK_SECRET` |

package/SPEC.md

@@ -133,7 +133,7 @@ Notes:
   canonical `readiness-ready` wait-gate message (ADR 0001 §2; correlated by the
   poller when a fresh review lands)
   against a `=reviewWaitTimeout` timer (seeded at submit from
-  `NANO_PR_REVIEW_WAIT_TIMEOUT`, default `PT20M`). Whichever fires first
+  `NANO_PR_REVIEW_WAIT_TIMEOUT`, default `PT30M`). Whichever fires first
   withdraws the other — the message arm advances `round`, the timer arm escalates
   a **stalled review** (`blocked`) so a human decides rather than the instance
   hanging forever. Because `persist-round` already recorded this `round` as
@@ -544,7 +544,7 @@ queries skip (`merging`), so a slow pass can't double-signal.
 | `NANO_PR_AUTO_MERGE` | 1 | run the merge stage after convergence (`0` = review-only; per-submit `convergeOnly: true` override) |
 | `NANO_PR_MERGE_METHOD` | squash | `squash` \| `merge` \| `rebase` |
 | `NANO_PR_MERGE_ADMIN` | 0 | pass `--admin` on merge |
-| `NANO_PR_REVIEW_WAIT_TIMEOUT` | PT20M | ISO-8601 wait before a stalled review escalates (timer arm of the `wait-review` event-based gateway); malformed → default |
+| `NANO_PR_REVIEW_WAIT_TIMEOUT` | PT30M | ISO-8601 wait before a stalled review escalates (timer arm of the `wait-review` event-based gateway); malformed → default |
 | `NANO_PR_REVIEW_NUDGE_MINUTES` | 5 | cooldown between poller Copilot re-request nudges per PR (clamped 1–1440) |
 
 ## 13. Planning fan-out (`plan-fanout.bpmn`) — issue #14

package/app/contracts.ts

@@ -145,6 +145,7 @@ export const ENV_CONTRACTS = {
     name: "NANO_PR_REVIEW_WAIT_TIMEOUT",
     owner: "app/service.ts",
     semantics: "How long to wait for a review before nudging/escalating (FEEL/ISO-8601 duration).",
+    default: "PT30M",
   },
   NANO_PR_REVIEW_NUDGE_MINUTES: {
     category: "env",

package/app/persist-escalation.test.ts

@@ -190,7 +190,7 @@ test("persist-escalation heals from the prKey when repo/prNumber are absent", as
 // never a dead wait with a null question (the #333 defect).
 test("a control-flow arm with a concrete question opens an escalation gw-escalated can park", async () => {
   const { app, inserts } = fakeApp();
-  const question = "No review arrived within the review-wait timeout (PT20M). A human must decide how to proceed.";
+  const question = "No review arrived within the review-wait timeout (PT30M). A human must decide how to proceed.";
   const job = { variables: { prKey: "o/r#5", round: 2, status: "blocked", question, recordRound: false } };
   const out = await handler(job as any, app as any);
   assertEquals((out as any).escalated, true, "a real control-flow escalation reports escalated:true");

package/app/prEscalationForm.test.ts

@@ -0,0 +1,84 @@
+// Regression guard for issue #767 — the shared PR-escalation Tasks form must not render a blank
+// read-only "Escalation question" field. The Tasks surface (`detail.engineForm`) seeds NO form
+// variables, so the form's `question` control could never be populated at render time: it showed up
+// blank while the actual request was already rendered separately as "Decision context" (the
+// `user_tasks.question` read-model column, sourced from `latestOpenEscalationQuestion`). This mirrors
+// the fix for the sibling `delivery-human-generic.form` (#773): make the form static / input-only —
+// no `{{tokens}}`, no data-dependent `conditional`, and exactly one editable, required `answer` — and
+// rely on the already-populated Decision context as the read-only prompt.
+//
+// This is the task/form-boundary guard the issue asks for, distinct from the durable `user_tasks`
+// projection coverage in `pollUserTasks.test.ts`: it ties the committed `.form`, the BPMN
+// `formDefinition` linkage, and the completer's typed contract together so none can drift back to a
+// blank-question render.
+
+import { test } from "node:test";
+import { readFileSync } from "node:fs";
+import { assert, assertEquals } from "#test-assert";
+import { validateEscalationVariables } from "./agentCompletion.ts";
+
+// biome-ignore lint/suspicious/noExplicitAny: form-js component shape is untyped JSON.
+type FormComponent = { type: string; key?: string; readonly?: boolean; conditional?: unknown; validate?: any };
+type Form = { id: string; components: FormComponent[] };
+
+const formText = readFileSync("resources/forms/pr-escalation.form", "utf8");
+const form = JSON.parse(formText) as Form;
+
+test("pr-escalation.form: has exactly one editable, required input — `answer` — and no blank readonly question field", () => {
+  assertEquals(form.id, "pr-escalation");
+  // Only ONE keyed (data-bearing) control, and it is the editable required `answer`.
+  const inputs = form.components.filter((c) => typeof c.key === "string");
+  assertEquals(
+    inputs.map((c) => c.key),
+    ["answer"],
+    "the form must expose exactly one input control, keyed `answer`",
+  );
+  const answer = inputs[0];
+  assert(answer.readonly !== true, "the `answer` control must be editable, not read-only");
+  assertEquals(answer.validate?.required, true, "the `answer` control must be required");
+  // The blank read-only `question` field the operator could never fill (issue #767) must be gone —
+  // Decision context is the canonical read-only prompt now.
+  assert(
+    !form.components.some((c) => c.key === "question"),
+    "the blank readonly `question` field must be removed (Decision context is the prompt)",
+  );
+});
+
+test("pr-escalation.form: is static — no `{{token}}` templating and no data-dependent `conditional`", () => {
+  // Deploy-time `{{token}}` templating is removed repo-wide (AGENTS.md), and the Tasks `engineForm`
+  // seeds no variables, so any data-dependent gate would never resolve — the exact failure mode #773
+  // fixed for the sibling form. Guard against a reappearance on this one.
+  assert(!/\{\{[^}]*\}\}/.test(formText), "the form must not contain `{{token}}` templating");
+  assert(
+    !form.components.some((c) => c.conditional !== undefined),
+    "the form must not use a data-dependent `conditional` the Tasks surface can never resolve",
+  );
+});
+
+test("pr-escalation.form: both PR escalation elements still complete with the `{ answer }` contract", () => {
+  // Preserve the existing typed completion contract: `wait-answer` and `wait-merge-answer` both map to
+  // this form and require a non-blank `answer` (validated via `validateEscalationVariables`). A missing
+  // answer is rejected; a present one accepted — proving the input-only rewrite kept the contract.
+  for (const element of ["wait-answer", "wait-merge-answer"]) {
+    assert(
+      validateEscalationVariables(element, {}) !== null,
+      `${element} must reject a missing answer (pr-escalation form contract)`,
+    );
+    assert(
+      validateEscalationVariables(element, { answer: "rerun the round" }) === null,
+      `${element} must accept a valid { answer }`,
+    );
+  }
+});
+
+test("drift guard: both PR escalation user tasks link the pr-escalation form", () => {
+  // The form the code validates against must be the SAME one both models render, or the operator sees
+  // a different (blank-question) form than the contract guards.
+  for (const model of ["convergence-loop", "merge-loop"]) {
+    const bpmn = readFileSync(`resources/processes/${model}.bpmn`, "utf8");
+    assert(
+      /formId="pr-escalation"/.test(bpmn),
+      `${model}.bpmn must link the pr-escalation form`,
+    );
+  }
+});

package/app/reviewWait.test.ts

@@ -13,6 +13,13 @@ import {
   reviewWaitTimeout,
 } from "./reviewWait.ts";
 
+test("DEFAULT_REVIEW_WAIT_TIMEOUT: pins the user-visible default to PT30M", () => {
+  // A direct regression guard on the literal default — the fallback-based assertions below compare
+  // against DEFAULT_REVIEW_WAIT_TIMEOUT itself, so they would still pass if it were accidentally
+  // reverted to PT20M. This anchors the intended value so that change is caught.
+  assertEquals(DEFAULT_REVIEW_WAIT_TIMEOUT, "PT30M");
+});
+
 test("reviewWaitTimeout: blank / absent / malformed → default", () => {
   assertEquals(reviewWaitTimeout(undefined), DEFAULT_REVIEW_WAIT_TIMEOUT);
   assertEquals(reviewWaitTimeout(""), DEFAULT_REVIEW_WAIT_TIMEOUT);

package/app/reviewWait.ts

@@ -12,7 +12,7 @@
 
 /** Default review-wait timeout (ISO-8601 duration): how long the loop waits for a fresh review
  * before the timer arm of the event-based gateway fires and it escalates to a human. */
-export const DEFAULT_REVIEW_WAIT_TIMEOUT = "PT20M";
+export const DEFAULT_REVIEW_WAIT_TIMEOUT = "PT30M";
 
 // A pragmatic ISO-8601 duration matcher: requires a leading `P`, at least one component, and a
 // `T` before any time components (with at least one time component after it). Good enough to

package/docs/agent-guide.md

@@ -470,7 +470,7 @@ Work through this order:
 3. **Check for an open escalation** (§3) — the process may simply be waiting for a
    human answer. Answer it.
 4. **A review that never arrives** escalates on its own after
-   `NANO_PR_REVIEW_WAIT_TIMEOUT` (default `PT20M`); the poller also re-nudges the
+   `NANO_PR_REVIEW_WAIT_TIMEOUT` (default `PT30M`); the poller also re-nudges the
    reviewer periodically. If the reviewer bot is not provisioned on the repo, no
    review will ever land — that is a repo-config problem, not an app bug.
 5. **Cancel + resubmit** as a last resort. Cancel through the **app-owned** door —

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nanobpm/nano-workforce",
-  "version": "0.187.2",
+  "version": "0.187.4",
   "description": "Nano Workforce — an Agent Graph Orchestration application for Agentic SDLC: durable BPMN processes that coordinate a graph of AI agents across the software delivery lifecycle.",
   "type": "module",
   "main": "main.ts",

package/resources/forms/pr-escalation.form

@@ -4,17 +4,15 @@
   "type": "default",
   "components": [
     {
-      "type": "textarea",
-      "key": "question",
-      "label": "Escalation question",
-      "description": "A human decision is needed to resume the PR review-convergence loop.",
-      "readonly": true
+      "type": "text",
+      "label": "Respond to this escalation",
+      "text": "A human decision is needed to resume the PR process. The requested decision is shown as **Decision context** above. Read it, then enter your reply below."
     },
     {
       "type": "textarea",
       "key": "answer",
       "label": "Your answer",
-      "description": "Your reply resumes the review loop and is handed to the next review round.",
+      "description": "Your reply resumes the PR process and is handed to its next step. Answer the request shown in Decision context above.",
       "validate": {
         "required": true
       }