@nanobpm/nano-workforce 0.183.0 → 0.183.2

package/operations/getAgenticSupply.test.ts

@@ -12,6 +12,7 @@ import { encodeFrame, type Frame } from "@nanobpm/agentic/protocol";
 import type { SqliteDb } from "@nanobpm/agentic/presence";
 import type { AppApi, DataLayer } from "@nanobpm/urban";
 import { assert, assertEquals } from "#test-assert";
+import { composeStreamId, parseStreamId } from "@nanobpm/agentic/emit";
 import { currentClaimRegistry } from "../app/agentic/claim-registry.ts";
 import { currentCorrelation } from "../app/agentic/correlation.ts";
 import { family as claimFamily } from "../app/agentic/families/claim.family.ts";
@@ -172,7 +173,7 @@ test("#713: a claim populates jobKeys and repoints the drill stream with ZERO tr
     assertEquals(res.status, 200);
     const w = res.body.workers[0];
     assertEquals(w.jobKeys, ["8420"], "the claim registry feeds the jobKeys seam");
-    assertEquals(w.stream, "job:8420", "the drill stream repoints at the claimed job, keyed by the claim");
+    assertEquals(w.stream, composeStreamId("wk-a", "8420"), "the drill stream repoints at the claimed job, keyed by the claim");
     assertEquals(res.body.correlations.length, 0, "no correlation context until a terminal lands (drill-in only)");
   } finally {
     claimFamily.teardown?.();
@@ -210,7 +211,7 @@ test("#713: the correlation registry is demoted to drill-in context — a link a
     assertEquals(res.body.correlations.length, 1);
     const c = res.body.correlations[0];
     assertEquals(c.jobKey, "6494");
-    assertEquals(c.stream, "job:6494");
+    assertEquals(c.stream, composeStreamId("wk-a", "6494"));
     assertEquals(c.processInstanceKey, "4612");
     assertEquals(c.bpmnProcessId, "plan-fanout");
     assertEquals(c.planKey, "o/r#142");
@@ -220,3 +221,41 @@ test("#713: the correlation registry is demoted to drill-in context — a link a
     await hub.close();
   }
 });
+
+test("#738 drift: the supply advertises the producer's instance-scoped stream id, round-tripping the shared @nanobpm/agentic codec (not the retired job:<jobKey>)", async () => {
+  // The data-plane naming contract this bug (#738) restores: the producer (c8ctl-plugin-nano) writes a
+  // job's transcript under `composeStreamId(instance, jobKey)`, so the cockpit MUST advertise that exact
+  // id — both the worker drill stream (claim-keyed) and the correlation drill stream — or every
+  // transcript renders empty. This pins the consumer to the ONE shared codec: a regression back to
+  // `job:<jobKey>` (a slash-free id that never round-trips through parseStreamId) fails here.
+  const hub = await mountPresence(memSqlite());
+  const ctx: AgenticContext = { hub, registry: hub.registry, transport: undefined as never, data: undefined, log: noopLog() };
+  claimFamily.mount(ctx);
+  correlationFamily.mount(ctx);
+  const claims = currentClaimRegistry();
+  const correlation = currentCorrelation();
+  assert(claims !== undefined && correlation !== undefined, "both singletons install");
+  claims.claim("wk-a", "12559");
+  correlation.link("wk-a", "12559", { processInstanceKey: "4612", planKey: "o/r#142" });
+  try {
+    const res = (await handler(input(), app)) as {
+      status: number;
+      body: { workers: Array<Record<string, unknown>>; correlations: Array<Record<string, unknown>> };
+    };
+    assertEquals(res.status, 200);
+    const producerStream = composeStreamId("wk-a", "12559");
+    const w = res.body.workers[0];
+    assertEquals(w.stream, producerStream, "the cockpit drills the exact stream the producer writes");
+    const c = res.body.correlations[0];
+    assertEquals(c.stream, producerStream, "the correlation drill stream matches the producer stream");
+    // The shared codec round-trips the advertised id back to its {instance, stream} parts.
+    assertEquals(parseStreamId(producerStream), { instance: "wk-a", stream: "12559" });
+    // And it is emphatically NOT the retired job:<jobKey> scheme that left transcripts empty (#738).
+    assert(typeof w.stream === "string" && !w.stream.startsWith("job:"), "the retired job:<jobKey> data-plane scheme is gone");
+  } finally {
+    correlationFamily.teardown?.();
+    claimFamily.teardown?.();
+    family.teardown?.();
+    await hub.close();
+  }
+});

package/operations/getAgenticSupply.ts

@@ -6,8 +6,9 @@
 // H6/#713 closes the loop with an EXPLICIT claim registry (`app/agentic/claim-registry.ts`): it is the
 // AUTHORITATIVE source the presence snapshot's `jobKeysFor` seam resolves against, so each worker's
 // current jobKeys light up from `claim` frames — not inferred from the relay terminal — and appear even
-// with ZERO transcript. Each worker's drill `stream` is repointed at its claimed jobKey-scoped relay
-// stream (`job:<jobKey>`), keyed by the CLAIM (explicit instance+jobKey), not by a connection. The
+// with ZERO transcript. Each worker's drill `stream` is repointed at its claimed instance-scoped relay
+// stream (`composeStreamId(instance, jobKey)`, issue #738), keyed by the CLAIM (explicit
+// instance+jobKey), not by a connection. The
 // relay correlation registry is DEMOTED to drill-in context only: it still supplies the `correlations`
 // — the process-instance / plan context for a job's terminal — so the cockpit lines a worker's terminal
 // up with "that process instance / this plan", but it is no longer the visibility source.
@@ -31,9 +32,10 @@ import { defineOperation } from "../nano-generated/operations.ts";
 const SECRET = envVar("NANO_PR_WEBHOOK_SECRET") ?? "";
 
 // Project a presence-registry row to the wire worker. The drill `stream` defaults to the worker
-// instance (H5) but is repointed at the worker's claimed jobKey-scoped relay stream (`job:<jobKey>`)
-// when the claim registry knows a current claim for it (#713) — keyed by the CLAIM, not by the
-// connection — so drilling in opens the LIVE job's terminal even before any transcript lands.
+// instance (H5) but is repointed at the worker's claimed instance-scoped relay stream
+// (`composeStreamId(instance, jobKey)`, issue #738) when the claim registry knows a current claim for
+// it (#713) — keyed by the CLAIM, not by the connection — so drilling in opens the LIVE job's terminal
+// (the exact stream the producer writes) even before any transcript lands.
 function toWorker(w: SupplyWorker, claims: ClaimRegistry | undefined): AgenticSupplyWorker {
   const out: AgenticSupplyWorker = {
     instance: w.instance,

package/operations/getAgenticTranscript.test.ts

@@ -9,6 +9,7 @@ import type { Frame } from "@nanobpm/agentic/protocol";
 import type { SqliteDb } from "@nanobpm/agentic/transcript";
 import type { AppApi, DataLayer } from "@nanobpm/urban";
 import { assert, assertEquals } from "#test-assert";
+import { composeStreamId } from "@nanobpm/agentic/emit";
 import { createRelayFamily, currentRelayTranscriptService } from "../app/agentic/families/relay.family.ts";
 import type { AgenticContext } from "../app/agentic/registry.ts";
 import { noopLog } from "../test/log.ts";
@@ -82,17 +83,17 @@ test("returns the whole transcript from offset 0, then a resume slice from a lat
   const store = currentRelayTranscriptService()?.store;
   assert(store !== undefined);
   store.flush(
-    "job:6494",
+    composeStreamId("wk", "6494"),
     { since: () => ({ entries: [{ offset: 0, chunk: "aa" }, { offset: 1, chunk: "bb" }, { offset: 2, chunk: "cc" }] }), nextOffset: 3 },
     "ephemeral",
   );
   try {
-    const whole = (await handler(input("job:6494"), app)) as {
+    const whole = (await handler(input(composeStreamId("wk", "6494")), app)) as {
       status: number;
       body: { stream: string; from: number; gap: boolean; nextOffset: number; chunkCount: number; byteLength: number; entries: Array<{ offset: number; chunk: string }>; jobKey?: string };
     };
     assertEquals(whole.status, 200);
-    assertEquals(whole.body.stream, "job:6494");
+    assertEquals(whole.body.stream, composeStreamId("wk", "6494"));
     assertEquals(whole.body.jobKey, "6494");
     assertEquals(whole.body.from, 0);
     assertEquals(whole.body.gap, false);
@@ -101,7 +102,7 @@ test("returns the whole transcript from offset 0, then a resume slice from a lat
     assertEquals(whole.body.byteLength, 6);
     assertEquals(whole.body.entries.map((e) => e.offset), [0, 1, 2]);
 
-    const resume = (await handler(input("job:6494", { from: 2 }), app)) as {
+    const resume = (await handler(input(composeStreamId("wk", "6494"), { from: 2 }), app)) as {
       body: { from: number; chunkCount: number; entries: Array<{ offset: number; chunk: string }> };
     };
     assertEquals(resume.body.from, 2);

package/operations/listAgenticTranscripts.test.ts

@@ -11,6 +11,7 @@ import type { Frame } from "@nanobpm/agentic/protocol";
 import type { SqliteDb } from "@nanobpm/agentic/transcript";
 import type { AppApi, DataLayer } from "@nanobpm/urban";
 import { assert, assertEquals } from "#test-assert";
+import { composeStreamId } from "@nanobpm/agentic/emit";
 import { currentCorrelation } from "../app/agentic/correlation.ts";
 import { family as correlationFamily } from "../app/agentic/families/correlation.family.ts";
 import { createRelayFamily, currentRelayTranscriptService } from "../app/agentic/families/relay.family.ts";
@@ -78,8 +79,8 @@ test("projects the TranscriptStore rows into the list (byteLength, chunkCount, l
   relayFamily.mount(mountCtx(memSqlite()));
   const store = currentRelayTranscriptService()?.store;
   assert(store !== undefined, "the relay family installs a persisted store");
-  // Seed one completed ephemeral session on a jobKey-scoped stream.
-  store.flush("job:6494", { since: () => ({ entries: [{ offset: 0, chunk: "hello " }, { offset: 1, chunk: "world" }] }), nextOffset: 2 }, "ephemeral");
+  // Seed one completed ephemeral session on an instance-scoped stream (issue #738).
+  store.flush(composeStreamId("wk", "6494"), { since: () => ({ entries: [{ offset: 0, chunk: "hello " }, { offset: 1, chunk: "world" }] }), nextOffset: 2 }, "ephemeral");
   try {
     const res = (await handler(input(), app)) as {
       status: number;
@@ -89,8 +90,8 @@ test("projects the TranscriptStore rows into the list (byteLength, chunkCount, l
     assertEquals(res.body.count, 1);
     assert(typeof res.body.retentionMs === "number", "the list surfaces the retention window");
     const t = res.body.transcripts[0];
-    assertEquals(t.stream, "job:6494");
-    assertEquals(t.jobKey, "6494", "the jobKey is decoded from the job: stream id");
+    assertEquals(t.stream, composeStreamId("wk", "6494"));
+    assertEquals(t.jobKey, "6494", "the jobKey is decoded from the instance-scoped stream id");
     assertEquals(t.lifecycle, "ephemeral");
     assertEquals(t.status, "completed");
     assertEquals(t.chunkCount, 2);
@@ -105,7 +106,7 @@ test("enriches with the H6 correlation (process instance / plan) when it is stil
   relayFamily.mount(mountCtx(memSqlite()));
   const store = currentRelayTranscriptService()?.store;
   assert(store !== undefined);
-  store.flush("job:6494", { since: () => ({ entries: [{ offset: 0, chunk: "x" }] }), nextOffset: 1 }, "ephemeral");
+  store.flush(composeStreamId("wk-a", "6494"), { since: () => ({ entries: [{ offset: 0, chunk: "x" }] }), nextOffset: 1 }, "ephemeral");
   correlationFamily.mount({ hub: undefined as never, registry: undefined as never, transport: undefined as never, data: undefined, log: noopLog() });
   currentCorrelation()?.link("wk-a", "6494", { processInstanceKey: "4612", bpmnProcessId: "plan-fanout", planKey: "o/r#142" });
   try {
@@ -124,18 +125,18 @@ test("filters by jobKey and plan", async () => {
   relayFamily.mount(mountCtx(memSqlite()));
   const store = currentRelayTranscriptService()?.store;
   assert(store !== undefined);
-  store.flush("job:1", { since: () => ({ entries: [{ offset: 0, chunk: "a" }] }), nextOffset: 1 }, "ephemeral");
-  store.flush("job:2", { since: () => ({ entries: [{ offset: 0, chunk: "b" }] }), nextOffset: 1 }, "ephemeral");
+  store.flush(composeStreamId("wk", "1"), { since: () => ({ entries: [{ offset: 0, chunk: "a" }] }), nextOffset: 1 }, "ephemeral");
+  store.flush(composeStreamId("wk", "2"), { since: () => ({ entries: [{ offset: 0, chunk: "b" }] }), nextOffset: 1 }, "ephemeral");
   correlationFamily.mount({ hub: undefined as never, registry: undefined as never, transport: undefined as never, data: undefined, log: noopLog() });
   currentCorrelation()?.link("wk", "2", { planKey: "o/r#9" });
   try {
     const byJob = (await handler(input({ jobKey: "1" }), app)) as { body: { count: number; transcripts: Array<Record<string, unknown>> } };
     assertEquals(byJob.body.count, 1);
-    assertEquals(byJob.body.transcripts[0]?.stream, "job:1");
+    assertEquals(byJob.body.transcripts[0]?.stream, composeStreamId("wk", "1"));
 
     const byPlan = (await handler(input({ planKey: "o/r#9" }), app)) as { body: { count: number; transcripts: Array<Record<string, unknown>> } };
     assertEquals(byPlan.body.count, 1);
-    assertEquals(byPlan.body.transcripts[0]?.stream, "job:2");
+    assertEquals(byPlan.body.transcripts[0]?.stream, composeStreamId("wk", "2"));
   } finally {
     correlationFamily.teardown?.();
     relayFamily.teardown?.();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nanobpm/nano-workforce",
-  "version": "0.183.0",
+  "version": "0.183.2",
   "description": "Nano Workforce — an Agent Graph Orchestration application for Agentic SDLC: durable BPMN processes that coordinate a graph of AI agents across the software delivery lifecycle.",
   "type": "module",
   "main": "main.ts",

package/test/agentic-e2e.test.ts

@@ -27,6 +27,7 @@ import type { SqliteDb } from "@nanobpm/agentic/presence";
 import { decodeFrame, encodeFrame, type Frame } from "@nanobpm/agentic/protocol";
 import type { AppApi, DataLayer } from "@nanobpm/urban";
 import { assert, assertEquals } from "#test-assert";
+import { composeStreamId } from "@nanobpm/agentic/emit";
 import { currentCorrelation } from "../app/agentic/correlation.ts";
 import { loadAgenticFamilies } from "../app/agentic/loader.ts";
 import { type AgenticContext, AgenticFamilyRegistry } from "../app/agentic/registry.ts";
@@ -146,7 +147,9 @@ function supplyInput() {
 test("E2E: the whole visibility plane wires up — presence, correlation, supply report, relay drill, and resume across a hub restart", async () => {
   const db = memSqlite();
   const JOB = "6494";
-  const STREAM = `job:${JOB}`;
+  // The producer writes a job's terminal on the instance-scoped stream (issue #738); the drill stream
+  // the supply advertises MUST be this exact id, or the cockpit reads a stream that never existed.
+  const STREAM = composeStreamId("wk-a", JOB);
 
   // Sanity: the fleet the seam discovers really includes presence, relay, and correlation.
   const fleet = await mountFleet(db);