@nanobpm/nano-workforce 0.179.0 → 0.179.2

package/CHANGELOG.md

@@ -1,3 +1,15 @@
+## [0.179.2](https://github.com/nanobpm/nano-workforce/compare/v0.179.1...v0.179.2) (2026-09-04)
+
+### Code Refactoring
+
+* drop redundant testkit engine-client shim in e2e ([#734](https://github.com/nanobpm/nano-workforce/issues/734)) ([8ea7ccd](https://github.com/nanobpm/nano-workforce/commit/8ea7ccd5c38a2b0e363cac74b126dd86bee0f0b1)), closes [#336](https://github.com/nanobpm/nano-workforce/issues/336)
+
+## [0.179.1](https://github.com/nanobpm/nano-workforce/compare/v0.179.0...v0.179.1) (2026-09-04)
+
+### Bug Fixes
+
+* **tasks:** route Tasks-page completion through the canonical complete-user-task door ([#732](https://github.com/nanobpm/nano-workforce/issues/732)) ([98b59a5](https://github.com/nanobpm/nano-workforce/commit/98b59a5a30fb6c6038466da9ec71fc0557eb72e5)), closes [461/#484](https://github.com/461/nano-workforce/issues/484) [nano-ide#552](https://github.com/nanobpm/nano-ide/issues/552) [#728](https://github.com/nanobpm/nano-workforce/issues/728)
+
 ## [0.179.0](https://github.com/nanobpm/nano-workforce/compare/v0.178.5...v0.179.0) (2026-09-04)
 
 ### Features

package/app/tasksPage.test.ts

@@ -39,6 +39,11 @@ test("Tasks grid completes each row via its engine-declared form (nano-ide#457),
   assert(detail?.engineForm, "the grid detail must opt into engineForm rendering");
   assertEquals(detail.engineForm.formKeyField, "form_key");
   assertEquals(detail.engineForm.userTaskKeyField, "user_task_key");
+  // Completion routes through nwf's canonical completion door (operations/completeUserTask.ts,
+  // issue #728 / nano-ide#552) — NOT the runtime's generic `/app/actions/complete` seam — so it
+  // records `task_completions` attribution, enforces HUMAN_COMPLETABLE_ELEMENTS, and drops the
+  // answered `user_tasks` row immediately instead of after a poll cycle.
+  assertEquals(detail.engineForm.completePath, "/app/api/actions/complete-user-task");
   // The seven bespoke per-type detail.form blocks (each a copy of a deployed `.form`) are gone.
   for (const g of grids) assert(!g.props.detail?.form, "no grid may carry a page-local detail.form");
 });

package/e2e/agent-answerable.e2e.ts

@@ -26,7 +26,6 @@ import { fileURLToPath } from "node:url";
 import type { EngineJob } from "@nanobpm/urban/runtime";
 import { bootTestApp, type TestApp } from "@nanobpm/urban-testkit";
 import { admitGithubState, installAdmitGithub } from "./support/github-admit.ts";
-import { asEngineClient } from "./support/engine-client.ts";
 import {
   completeEscalationAsAgent,
   latestCompletion,
@@ -142,7 +141,7 @@ describe("agent-answerable escalations (U6 — same form, agent completer, attri
 
         // Complete AS AN AGENT through the host-side completer — the same typed `{resolution, answer}`
         // a human submits through the inbox, only the caller differs.
-        const r = await completeEscalationAsAgent(app.db, asEngineClient(app.engine), {
+        const r = await completeEscalationAsAgent(app.db, app.engine, {
           userTaskKey: task.userTaskKey,
           agentId: "senior:answer-bot",
           variables: { resolution: "answer", answer: "use v2" },

package/e2e/convergence-escalation.e2e.ts

@@ -29,7 +29,6 @@ import { after, before, describe, test } from "node:test";
 import { fileURLToPath } from "node:url";
 import { bootTestApp, type TestApp } from "@nanobpm/urban-testkit";
 import { pollUserTasks } from "../app/service.ts";
-import { asEngineClient } from "./support/engine-client.ts";
 
 const APP_ROOT = resolve(dirname(fileURLToPath(import.meta.url)), "..");
 const DB_DIR = mkdtempSync(join(tmpdir(), "nwf-u4-"));
@@ -159,7 +158,7 @@ describe("nano-workforce PR review-loop escalation (U4 userTask)", () => {
     // denormalised `open_escalation_*` pointer is written or read. That read model is projected by
     // `pollUserTasks` (part of the imperative main.ts poll loop the testkit does not run), so drive it
     // explicitly (mirrors feature-run.e2e.ts) to project the parked `wait-answer` task first.
-    await pollUserTasks(app.db, asEngineClient(app.engine));
+    await pollUserTasks(app.db, app.engine);
     const status = await app.callRoute<StatusBody>({ method: "GET", path: "/app/api/status" });
     assert.equal(status.status, 200, "the status endpoint responds");
     const statusRow = status.body.prs.find((p) => p.prKey === prKey);
@@ -198,7 +197,7 @@ describe("nano-workforce PR review-loop escalation (U4 userTask)", () => {
     // reconciles away, so no open escalation lingers on the status endpoint once answered + resumed.
     // Re-run the projection (as the durable poller would) so the closed task's read-model row is
     // deleted before re-reading /status.
-    await pollUserTasks(app.db, asEngineClient(app.engine));
+    await pollUserTasks(app.db, app.engine);
     const afterStatus = await app.callRoute<StatusBody>({ method: "GET", path: "/app/api/status" });
     const afterRow = afterStatus.body.prs.find((p) => p.prKey === prKey);
     if (afterRow) {

package/e2e/feature-run.e2e.ts

@@ -23,7 +23,6 @@ import { fileURLToPath } from "node:url";
 import type { EngineJob } from "@nanobpm/urban/runtime";
 import { bootTestApp, type TestApp } from "@nanobpm/urban-testkit";
 import { admitGithubState, installAdmitGithub } from "./support/github-admit.ts";
-import { asEngineClient } from "./support/engine-client.ts";
 import { pollUserTasks } from "../app/service.ts";
 
 const APP_ROOT = resolve(dirname(fileURLToPath(import.meta.url)), "..");
@@ -208,7 +207,7 @@ describe("single-issue feature run (#172 — feature.bpmn)", () => {
         // read-model (issue #332 dropped the denormalised `feature_runs.blocked_user_task_key` pointer),
         // so `pollUserTasks` projects the parked `feature-blocked` task onto `user_tasks` by reading the
         // engine directly — no per-run column write.
-        await pollUserTasks(app.db, asEngineClient(app.engine));
+        await pollUserTasks(app.db, app.engine);
         const inboxRow = await app.db
           .table<{ user_task_key: string; element_id: string }>("user_tasks", "user_task_key")
           .findOne({ user_task_key: task!.userTaskKey });
@@ -233,7 +232,7 @@ describe("single-issue feature run (#172 — feature.bpmn)", () => {
 
         // A further poll pass is an idempotent no-op — the task is completed, so the read-model row is
         // reconciled away and a terminal run is not a candidate.
-        await pollUserTasks(app.db, asEngineClient(app.engine));
+        await pollUserTasks(app.db, app.engine);
         assert.equal((await featureRow(app, featureKey)).status, "blocked");
       },
     );
@@ -385,7 +384,7 @@ describe("single-issue feature run (#172 — feature.bpmn)", () => {
 
         // The poller projects the parked task onto the Tasks inbox `user_tasks` read-model by reading
         // the engine directly, sourcing the question from the `feature_escalations` audit log.
-        await pollUserTasks(app.db, asEngineClient(app.engine));
+        await pollUserTasks(app.db, app.engine);
         const inboxRow = await app.db
           .table<{ user_task_key: string; element_id: string; question: string | null }>("user_tasks", "user_task_key")
           .findOne({ user_task_key: task!.userTaskKey });
@@ -414,7 +413,7 @@ describe("single-issue feature run (#172 — feature.bpmn)", () => {
         assert.equal(settled.status, "opened", "the resumed run opened its PR");
 
         // A further poll pass reconciles the completed task's read-model row away.
-        await pollUserTasks(app.db, asEngineClient(app.engine));
+        await pollUserTasks(app.db, app.engine);
         const gone = await app.db
           .table<{ user_task_key: string }>("user_tasks", "user_task_key")
           .findOne({ user_task_key: task!.userTaskKey });

package/e2e/retire-escalation-subsystem.e2e.ts

@@ -26,7 +26,6 @@ import { after, before, describe, test } from "node:test";
 import { fileURLToPath } from "node:url";
 import { bootTestApp, type TestApp } from "@nanobpm/urban-testkit";
 import { pollUserTasks } from "../app/service.ts";
-import { asEngineClient } from "./support/engine-client.ts";
 
 const APP_ROOT = resolve(dirname(fileURLToPath(import.meta.url)), "..");
 const DB_DIR = mkdtempSync(join(tmpdir(), "nwf-u7-"));
@@ -237,7 +236,7 @@ describe("retire escalation subsystem (U7 — destructive contract phase)", () =
     // written. That read model is projected by `pollUserTasks` (part of the imperative main.ts poll
     // loop the testkit does not run), so drive it explicitly (mirrors feature-run.e2e.ts) to project
     // the parked `wait-answer` task before reading /status.
-    await pollUserTasks(app.db, asEngineClient(app.engine));
+    await pollUserTasks(app.db, app.engine);
     const status = await app.callRoute<StatusBody>({ method: "GET", path: "/app/api/status" });
     const statusRow = status.body.prs.find((p) => p.prKey === prKey);
     assert.equal(statusRow?.status, "escalated", "the PR reads as escalated");
@@ -265,7 +264,7 @@ describe("retire escalation subsystem (U7 — destructive contract phase)", () =
     // No addressed escalation lingers — the completed task's `user_tasks` row reconciles away. Re-run
     // the projection (as the durable poller would) so the closed task's read-model row is deleted
     // before re-reading /status.
-    await pollUserTasks(app.db, asEngineClient(app.engine));
+    await pollUserTasks(app.db, app.engine);
     const afterStatus = await app.callRoute<StatusBody>({ method: "GET", path: "/app/api/status" });
     const afterRow = afterStatus.body.prs.find((p) => p.prKey === prKey);
     if (afterRow) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nanobpm/nano-workforce",
-  "version": "0.179.0",
+  "version": "0.179.2",
   "description": "Nano Workforce — an Agent Graph Orchestration application for Agentic SDLC: durable BPMN processes that coordinate a graph of AI agents across the software delivery lifecycle.",
   "type": "module",
   "main": "main.ts",
@@ -65,7 +65,7 @@
   },
   "dependencies": {
     "@nanobpm/agentic": "^0.12.0",
-    "@nanobpm/urban": "^0.90.1",
+    "@nanobpm/urban": "^0.91.0",
     "bpmn-auto-layout": "^2.0.0-alpha.2"
   },
   "devDependencies": {

package/pages/tasks.page.json

@@ -74,7 +74,7 @@
       "type": "text",
       "id": "subtitle",
       "props": {
-        "text": "Every open native user-task escalation awaiting a human decision — feature runs, epics, PR review/merge loops, conformance reviews, and delivery-graph human/escalation gates — in one list. The \"Type\" column tells them apart; open a row to complete it via the process's own deployed form, on the same canonical path Urban's task inbox uses. This list is exactly the set the nav badge counts, so a badge always maps to a visible, completable row. Rows disappear once completed (here, via the inbox, or out-of-band).",
+        "text": "Every open native user-task escalation awaiting a human decision — feature runs, epics, PR review/merge loops, conformance reviews, and delivery-graph human/escalation gates — in one list. The \"Type\" column tells them apart; open a row to complete it via the process's own deployed form, through the nwf canonical completion door (operations/completeUserTask.ts) — recording who answered and dropping the row immediately. This list is exactly the set the nav badge counts, so a badge always maps to a visible, completable row. Rows disappear once completed (here, or out-of-band).",
         "variant": "sub"
       }
     },
@@ -116,7 +116,8 @@
           ],
           "engineForm": {
             "formKeyField": "form_key",
-            "userTaskKeyField": "user_task_key"
+            "userTaskKeyField": "user_task_key",
+            "completePath": "/app/api/actions/complete-user-task"
           }
         },
         "refreshMs": 5000

package/e2e/support/engine-client.ts

@@ -1,33 +0,0 @@
-import type { EngineClient } from "@nanobpm/urban";
-import type { TestApp } from "@nanobpm/urban-testkit";
-
-// `@nanobpm/urban-testkit`'s `WasmEngineClient` has historically lagged urban's `EngineClient`
-// interface: a method lands on the real seam a release or two before the testkit fake grows it. Both
-// guards below defensively COMPLETE the contract for any method the *installed* testkit hasn't
-// implemented yet — each is an idempotent `if (typeof … !== "function")`, so it no-ops the moment a
-// testkit release ships the real method (no version pins to drift). Scoped to the test harness;
-// production adapters (`SdkEngineClient`) implement both for real.
-//
-//  - `getForm` (urban 0.49.0, ADR 0062): the original instance of this lag. Now implemented by the
-//    currently pinned testkit, so this guard is a no-op there; kept as defence against version skew.
-//    These hermetic flows drive completion directly and never resolve a form schema, so the fallback
-//    returns `null` — the documented "no matching form" path.
-//  - `openUserTasks` (issue #294 moved the pollers onto it): the CURRENT gap — the pinned testkit has
-//    `searchUserTasks` but not the open-task-scoped `openUserTasks`, so a poller call throws
-//    `not a function` (swallowed by the poller's try/catch) and the read-model denormalisation
-//    silently no-ops. Polyfill it as `searchUserTasks({ state: "CREATED" })` — byte-for-byte what
-//    urban's real `SdkEngineClient.openUserTasks` does, so the two cannot drift. Fix: nano-workforce
-//    #309; categorical (testkit) fix upstream in nanobpm/nano-ide#341.
-export function asEngineClient(engine: TestApp["engine"]): EngineClient {
-  const e = engine as unknown as EngineClient & {
-    getForm?: EngineClient["getForm"];
-    openUserTasks?: EngineClient["openUserTasks"];
-  };
-  if (typeof e.getForm !== "function") {
-    e.getForm = async () => null;
-  }
-  if (typeof e.openUserTasks !== "function") {
-    e.openUserTasks = (filter) => e.searchUserTasks({ ...filter, state: "CREATED" });
-  }
-  return e;
-}