@nanobpm/nano-workforce 0.167.1 → 0.167.3

package/operations/acknowledgeDeliveryGraph.test.ts

@@ -1,93 +0,0 @@
-// Tests for the POST /app/api/actions/acknowledge-delivery-graph operation `acknowledgeDeliveryGraph`
-// (issue #641). The nwf UI's "Dismiss" (Done ✓) affordance for a TERMINAL delivery-graph run. It stamps
-// `acknowledged_at`, which the `delivery_graph_read_model` VIEW (096) derives into `list_bucket` =
-// 'history' and `ack_open` = 0, dropping the finished run from the Active list into History. The
-// delivery-graph twin of acknowledge-done / acknowledge-epic / acknowledge-pr.
-//
-// The op's only write is the `acknowledged_at` (+ `updated_at`) stamp, gated on the base `status`
-// belonging to the terminal tier (`DELIVERY_GRAPH_TERMINAL_STATUSES`). These tests seed an in-memory
-// `delivery_graph_runs` store and assert the 400/404/409/200 gate + the stamp; the bucket derivation
-// itself is proven in app/deliveryGraphReadModel.test.ts.
-import { test } from "node:test";
-import { assertEquals } from "#test-assert";
-import type { AppApi } from "@nanobpm/urban";
-import { noopLog } from "../test/log.ts";
-import { DELIVERY_GRAPH_TERMINAL_STATUSES } from "../app/deliveryGraphRun.ts";
-import handler from "./acknowledgeDeliveryGraph.ts";
-
-// biome-ignore lint/suspicious/noExplicitAny: test-only fake data layer over dynamic row shapes.
-function memApp(seed: any[]): { app: AppApi; rows: any[] } {
-  // biome-ignore lint/suspicious/noExplicitAny: test-only store.
-  const stores: Record<string, any[]> = { delivery_graph_runs: seed };
-  function tbl(name: string, pk = "id") {
-    // biome-ignore lint/suspicious/noExplicitAny: test-only.
-    const rows = (stores[name] ??= [] as any[]);
-    return {
-      // biome-ignore lint/suspicious/noExplicitAny: test-only.
-      async get(id: any) {
-        return rows.find((r) => r[pk] === id);
-      },
-      // biome-ignore lint/suspicious/noExplicitAny: test-only.
-      async update(id: any, patch: any) {
-        const r = rows.find((row) => row[pk] === id);
-        if (r) Object.assign(r, patch);
-        return r ? 1 : 0;
-      },
-    };
-  }
-  const app = {
-    data: { table: (n: string, pk?: string) => tbl(n, pk) },
-    log: noopLog(),
-  } as unknown as AppApi;
-  return { app, rows: stores.delivery_graph_runs };
-}
-
-async function call(app: AppApi, body: unknown) {
-  // biome-ignore lint/suspicious/noExplicitAny: test-only op invocation.
-  return (await handler({ req: {} as any, params: {}, query: {}, body } as any, app)) as any;
-}
-
-test("acknowledge-delivery-graph: stamps acknowledged_at on a terminal run and returns 200", async () => {
-  const { app, rows } = memApp([{ run_key: "run-1", status: "done", acknowledged_at: null }]);
-  const res = await call(app, { run_key: "run-1" });
-  assertEquals(res.status, 200);
-  assertEquals(res.body.ok, true);
-  assertEquals(typeof rows[0].acknowledged_at, "string");
-  assertEquals(typeof rows[0].updated_at, "string");
-});
-
-test("acknowledge-delivery-graph: every terminal status is dismissable", async () => {
-  for (const status of DELIVERY_GRAPH_TERMINAL_STATUSES) {
-    const { app, rows } = memApp([{ run_key: "run-1", status, acknowledged_at: null }]);
-    const res = await call(app, { run_key: "run-1" });
-    assertEquals(res.status, 200, `status ${status} must be dismissable`);
-    assertEquals(typeof rows[0].acknowledged_at, "string");
-  }
-});
-
-test("acknowledge-delivery-graph: a live (running) run is rejected (409) and stays unstamped", async () => {
-  const { app, rows } = memApp([{ run_key: "run-2", status: "running", acknowledged_at: null }]);
-  const res = await call(app, { run_key: "run-2" });
-  assertEquals(res.status, 409);
-  assertEquals(res.body.ok, false);
-  assertEquals(rows[0].acknowledged_at, null);
-});
-
-test("acknowledge-delivery-graph: a missing run_key → 400", async () => {
-  const { app } = memApp([]);
-  assertEquals((await call(app, {})).status, 400);
-  assertEquals((await call(app, { run_key: "  " })).status, 400);
-});
-
-test("acknowledge-delivery-graph: no matching run → 404", async () => {
-  const { app } = memApp([]);
-  assertEquals((await call(app, { run_key: "run-404" })).status, 404);
-});
-
-test("acknowledge-delivery-graph: idempotent — re-acknowledging a terminal run re-stamps and returns 200", async () => {
-  const { app, rows } = memApp([{ run_key: "run-5", status: "failed", acknowledged_at: null }]);
-  assertEquals((await call(app, { run_key: "run-5" })).status, 200);
-  assertEquals(typeof rows[0].acknowledged_at, "string");
-  assertEquals((await call(app, { run_key: "run-5" })).status, 200);
-  assertEquals(typeof rows[0].acknowledged_at, "string");
-});

package/operations/acknowledgeDone.test.ts

@@ -1,110 +0,0 @@
-// Tests for the POST /app/api/actions/acknowledge-done operation `acknowledgeDone` (issue #254 §5).
-// The nwf UI's "tick off" affordance for a TERMINAL feature run: it stamps `acknowledged_at`, which
-// the `feature_read_model` VIEW (073, issue #439) derives into `list_bucket` = 'history', dropping the
-// run from Active into History. Unlike acknowledgeBlocked it completes NO user task (a terminal run is
-// not parked). Since `list_bucket` is now a VIEW over `status`/`acknowledged_at` (no stored column),
-// these tests assert the operation's real write — the `acknowledged_at` stamp — and cross-check the
-// resulting bucket through the pure `deriveListBucket` oracle the VIEW mirrors.
-import { test } from "node:test";
-import { assertEquals } from "#test-assert";
-import type { AppApi } from "@nanobpm/urban";
-import { deriveListBucket } from "../app/stage.ts";
-import { noopLog } from "../test/log.ts";
-import handler from "./acknowledgeDone.ts";
-
-// An in-memory data layer wired through the `featureRuns` gateway (now a plain record table), so the
-// test exercises the operation's write path exactly as production does.
-function memApp(seed: any[]): { app: AppApi; rows: any[] } {
-  const stores: Record<string, any[]> = { feature_runs: seed };
-  function tbl(name: string, pk = "id") {
-    const rows = (stores[name] ??= [] as any[]);
-    const match = (r: any, where: any) => Object.entries(where).every(([k, v]) => r[k] === v);
-    return {
-      async all() {
-        return rows.slice();
-      },
-      async get(id: any) {
-        return rows.find((r) => r[pk] === id);
-      },
-      async find(where: any = {}) {
-        return rows.filter((r) => match(r, where));
-      },
-      async insert(row: any) {
-        rows.push({ ...row });
-        return row[pk];
-      },
-      async update(id: any, patch: any) {
-        const r = rows.find((row) => row[pk] === id);
-        if (r) Object.assign(r, patch);
-        return r ? 1 : 0;
-      },
-    };
-  }
-  const app = {
-    data: { table: (n: string, pk?: string) => tbl(n, pk) },
-    log: noopLog(),
-  } as any as AppApi;
-  return { app, rows: stores.feature_runs };
-}
-
-async function call(app: AppApi, body: unknown) {
-  return (await handler({ req: {} as any, params: {}, query: {}, body } as any, app)) as any;
-}
-
-test("acknowledge-done: stamps acknowledged_at and (via the VIEW) buckets a terminal row into History", async () => {
-  const { app, rows } = memApp([{ feature_key: "o/r#1", status: "merged", converge: 1, auto_merge: 1, acknowledged_at: null }]);
-  // Before dismissal a terminal-but-unacknowledged run reads as Active through the VIEW.
-  assertEquals(deriveListBucket(rows[0].status, rows[0].acknowledged_at), "active");
-
-  const res = await call(app, { feature_key: "o/r#1" });
-
-  assertEquals(res.status, 200);
-  assertEquals(res.body.ok, true);
-  assertEquals(typeof rows[0].acknowledged_at, "string");
-  // The op's only write is the stamp; the VIEW derives 'history' from (terminal status + acknowledged).
-  assertEquals(deriveListBucket(rows[0].status, rows[0].acknowledged_at), "history");
-});
-
-test("acknowledge-done: idempotent-safe — re-acknowledging keeps the row in History", async () => {
-  const { app, rows } = memApp([{ feature_key: "o/r#2", status: "failed", converge: 1, auto_merge: 1, acknowledged_at: null }]);
-  const first = await call(app, { feature_key: "o/r#2" });
-  assertEquals(first.status, 200);
-  assertEquals(deriveListBucket(rows[0].status, rows[0].acknowledged_at), "history");
-  const firstStamp = rows[0].acknowledged_at;
-  // Re-acknowledge — still 200, still history.
-  const second = await call(app, { feature_key: "o/r#2" });
-  assertEquals(second.status, 200);
-  assertEquals(deriveListBucket(rows[0].status, rows[0].acknowledged_at), "history");
-  assertEquals(typeof firstStamp, "string");
-});
-
-test("acknowledge-done: a missing feature_key → 400", async () => {
-  const { app } = memApp([]);
-  const res = await call(app, {});
-  assertEquals(res.status, 400);
-  assertEquals(res.body.ok, false);
-});
-
-test("acknowledge-done: no such feature run → 404", async () => {
-  const { app } = memApp([]);
-  const res = await call(app, { feature_key: "o/r#gone" });
-  assertEquals(res.status, 404);
-  assertEquals(res.body.ok, false);
-});
-
-test("acknowledge-done: a non-terminal run → 409, no acknowledged_at stamped", async () => {
-  const { app, rows } = memApp([{ feature_key: "o/r#live", status: "running", converge: 1, auto_merge: 1, acknowledged_at: null }]);
-  const res = await call(app, { feature_key: "o/r#live" });
-  assertEquals(res.status, 409);
-  assertEquals(res.body.ok, false);
-  assertEquals(rows[0].acknowledged_at, null);
-  // A live run stays Active through the VIEW (no stamp → not History).
-  assertEquals(deriveListBucket(rows[0].status, rows[0].acknowledged_at), "active");
-});
-
-test("acknowledge-done: a converging (redispatch-terminal but live) run → 409", async () => {
-  const { app, rows } = memApp([{ feature_key: "o/r#conv", status: "converging", converge: 1, auto_merge: 1, acknowledged_at: null }]);
-  const res = await call(app, { feature_key: "o/r#conv" });
-  assertEquals(res.status, 409);
-  assertEquals(rows[0].acknowledged_at, null);
-});

package/operations/acknowledgeEpic.test.ts

@@ -1,173 +0,0 @@
-// Tests for the POST /app/api/actions/acknowledge-epic operation `acknowledgeEpic` (issue #298).
-// The nwf UI's "Dismiss" affordance for a RESOLVED epic — landed (delivery=landed) or
-// resolved-not-landed (delivery=null); only still-`converging` epics are rejected. It stamps
-// `acknowledged_at`, which the `plan_read_model` VIEW (074, issue #439) derives into `list_bucket` =
-// 'history' and `ack_open` = 0, dropping the resolved epic from Active into History. Unlike
-// acknowledge-blocked it completes NO user task (a resolved epic is not parked). The epic twin of
-// acknowledge-done.
-//
-// Since epic #412 retired the stored `plans.delivery` column, the op derives the delivery signal at
-// READ TIME (`derivePlanDelivery` → the pure `deriveDelivery`) by joining the epic's slice
-// `plan_tasks.pr_key` → `pull_requests.status`. So these tests seed `plan_tasks` + `pull_requests`
-// (not a `plans.delivery` column) to model a landed / converging / resolved-not-landed epic. Because
-// `list_bucket`/`ack_open` are now a VIEW (no stored column), the tests assert the operation's real
-// write — the `acknowledged_at` stamp and the 200/409 gate — and cross-check the resulting bucket
-// through the pure `deriveEpicBucket` / `epicIsAcknowledgeable` oracles the VIEW mirrors.
-import { test } from "node:test";
-import { assertEquals } from "#test-assert";
-import type { AppApi } from "@nanobpm/urban";
-import { deriveEpicBucket, epicIsAcknowledgeable } from "../app/delivery.ts";
-import { noopLog } from "../test/log.ts";
-import { withTrackingViews } from "../test/trackingViews.ts";
-import handler from "./acknowledgeEpic.ts";
-
-// An in-memory data layer wired through the `plans` gateway (now a plain record table). `extra` seeds
-// the join surfaces (`plan_tasks` / `pull_requests`) the read-time delivery derivation reads.
-function memApp(
-  seed: any[],
-  extra: Record<string, any[]> = {},
-): { app: AppApi; rows: any[] } {
-  const stores: Record<string, any[]> = { plans: seed, ...extra };
-  function tbl(name: string, pk = "id") {
-    const rows = (stores[name] ??= [] as any[]);
-    const match = (r: any, where: any) => Object.entries(where).every(([k, v]) => r[k] === v);
-    return {
-      async all() {
-        return rows.slice();
-      },
-      async get(id: any) {
-        return rows.find((r) => r[pk] === id);
-      },
-      async find(where: any = {}) {
-        return rows.filter((r) => match(r, where));
-      },
-      async insert(row: any) {
-        rows.push({ ...row });
-        return row[pk];
-      },
-      async update(id: any, patch: any) {
-        const r = rows.find((row) => row[pk] === id);
-        if (r) Object.assign(r, patch);
-        return r ? 1 : 0;
-      },
-    };
-  }
-  const app = {
-    data: { table: withTrackingViews((n: string, pk?: string) => tbl(n, pk)) },
-    log: noopLog(),
-  } as any as AppApi;
-  return { app, rows: stores.plans };
-}
-
-async function call(app: AppApi, body: unknown) {
-  return (await handler({ req: {} as any, params: {}, query: {}, body } as any, app)) as any;
-}
-
-test("acknowledge-epic: stamps acknowledged_at and (via the VIEW) buckets a landed epic into History", async () => {
-  const { app, rows } = memApp(
-    [{ plan_key: "o/r#1", status: "done", acknowledged_at: null }],
-    {
-      plan_tasks: [{ id: 1, plan_key: "o/r#1", pr_key: "o/r#100" }],
-      pull_requests: [{ pr_key: "o/r#100", status: "merged" }], // landed
-    },
-  );
-  // Before dismissal a landed-but-unacknowledged epic reads as Active with Dismiss open through the VIEW.
-  assertEquals(deriveEpicBucket("done", "landed", rows[0].acknowledged_at), "active");
-  assertEquals(epicIsAcknowledgeable("done", "landed"), true);
-
-  const res = await call(app, { plan_key: "o/r#1" });
-
-  assertEquals(res.status, 200);
-  assertEquals(res.body.ok, true);
-  assertEquals(typeof rows[0].acknowledged_at, "string");
-  // The op's only write is the stamp; the VIEW derives 'history' + ack_open 0 from the acknowledged row.
-  assertEquals(deriveEpicBucket("done", "landed", rows[0].acknowledged_at), "history");
-});
-
-test("acknowledge-epic: a still-converging epic is rejected (409) and stays Active", async () => {
-  const { app, rows } = memApp(
-    [{ plan_key: "o/r#2", status: "done", acknowledged_at: null }],
-    {
-      plan_tasks: [
-        { id: 1, plan_key: "o/r#2", pr_key: "o/r#200" },
-        { id: 2, plan_key: "o/r#2", pr_key: "o/r#201" },
-      ],
-      pull_requests: [
-        { pr_key: "o/r#200", status: "merged" },
-        { pr_key: "o/r#201", status: "converging" }, // still in flight → converging
-      ],
-    },
-  );
-
-  const res = await call(app, { plan_key: "o/r#2" });
-
-  assertEquals(res.status, 409);
-  assertEquals(res.body.ok, false);
-  // Untouched: no premature acknowledged_at; still Active through the VIEW (converging → active).
-  assertEquals(rows[0].acknowledged_at, null);
-  assertEquals(deriveEpicBucket("done", "converging", rows[0].acknowledged_at), "active");
-});
-
-test("acknowledge-epic: a resolved-not-landed epic (delivery=null) is accepted (200) and flips to History", async () => {
-  const { app, rows } = memApp(
-    [{ plan_key: "o/r#2b", status: "done", acknowledged_at: null }],
-    {
-      plan_tasks: [
-        { id: 1, plan_key: "o/r#2b", pr_key: "o/r#210" },
-        { id: 2, plan_key: "o/r#2b", pr_key: "o/r#211" },
-      ],
-      pull_requests: [
-        { pr_key: "o/r#210", status: "merged" },
-        { pr_key: "o/r#211", status: "abandoned" }, // all terminal, not all merged → delivery null
-      ],
-    },
-  );
-  assertEquals(deriveEpicBucket("done", null, rows[0].acknowledged_at), "active");
-  assertEquals(epicIsAcknowledgeable("done", null), true);
-
-  const res = await call(app, { plan_key: "o/r#2b" });
-
-  assertEquals(res.status, 200);
-  assertEquals(res.body.ok, true);
-  assertEquals(typeof rows[0].acknowledged_at, "string");
-  assertEquals(deriveEpicBucket("done", null, rows[0].acknowledged_at), "history");
-});
-
-test("acknowledge-epic: a live (dispatched) epic is rejected (409)", async () => {
-  const { app } = memApp([{ plan_key: "o/r#3", status: "dispatched", acknowledged_at: null }]);
-  const res = await call(app, { plan_key: "o/r#3" });
-  assertEquals(res.status, 409);
-});
-
-test("acknowledge-epic: a missing plan_key → 400", async () => {
-  const { app } = memApp([]);
-  const res = await call(app, {});
-  assertEquals(res.status, 400);
-});
-
-test("acknowledge-epic: no matching epic → 404", async () => {
-  const { app } = memApp([]);
-  const res = await call(app, { plan_key: "o/r#404" });
-  assertEquals(res.status, 404);
-});
-
-test("acknowledge-epic: idempotent — re-acknowledging a landed epic keeps it in History", async () => {
-  const { app, rows } = memApp(
-    [{ plan_key: "o/r#5", status: "done", acknowledged_at: null }],
-    {
-      plan_tasks: [{ id: 1, plan_key: "o/r#5", pr_key: "o/r#500" }],
-      pull_requests: [{ pr_key: "o/r#500", status: "merged" }], // landed
-    },
-  );
-
-  assertEquals((await call(app, { plan_key: "o/r#5" })).status, 200);
-  const firstStamp = rows[0].acknowledged_at;
-  assertEquals(deriveEpicBucket("done", "landed", rows[0].acknowledged_at), "history");
-
-  const res2 = await call(app, { plan_key: "o/r#5" });
-  assertEquals(res2.status, 200);
-  assertEquals(deriveEpicBucket("done", "landed", rows[0].acknowledged_at), "history");
-  // Re-stamped (a fresh timestamp) but still resolved.
-  assertEquals(typeof rows[0].acknowledged_at, "string");
-  void firstStamp;
-});

package/operations/acknowledgePr.test.ts

@@ -1,94 +0,0 @@
-// Tests for the POST /app/api/actions/acknowledge-pr operation `acknowledgePr` (issue #641).
-// The nwf UI's "Dismiss" (Done ✓) affordance for a TERMINAL pull request. It stamps `acknowledged_at`,
-// which the `pull_requests_read_model` VIEW (094) derives into `list_bucket` = 'history' and `ack_open`
-// = 0, dropping the finished PR from the Active convergence list into History. Unlike acknowledge-
-// blocked it completes NO user task (a terminal PR is not parked). The PR twin of acknowledge-done /
-// acknowledge-epic.
-//
-// The op's only write is the `acknowledged_at` (+ `updated_at`) stamp, gated on the base `status`
-// belonging to the terminal tier (`PR_TERMINAL_STATUSES`). These tests seed an in-memory `pull_requests`
-// store and assert the 400/404/409/200 gate + the stamp; the bucket derivation itself is proven in
-// app/pullRequestReadModel.test.ts.
-import { test } from "node:test";
-import { assertEquals } from "#test-assert";
-import type { AppApi } from "@nanobpm/urban";
-import { noopLog } from "../test/log.ts";
-import { PR_TERMINAL_STATUSES } from "../app/pullRequestReadModel.ts";
-import handler from "./acknowledgePr.ts";
-
-// biome-ignore lint/suspicious/noExplicitAny: test-only fake data layer over dynamic row shapes.
-function memApp(seed: any[]): { app: AppApi; rows: any[] } {
-  // biome-ignore lint/suspicious/noExplicitAny: test-only store.
-  const stores: Record<string, any[]> = { pull_requests: seed };
-  function tbl(name: string, pk = "id") {
-    // biome-ignore lint/suspicious/noExplicitAny: test-only.
-    const rows = (stores[name] ??= [] as any[]);
-    return {
-      // biome-ignore lint/suspicious/noExplicitAny: test-only.
-      async get(id: any) {
-        return rows.find((r) => r[pk] === id);
-      },
-      // biome-ignore lint/suspicious/noExplicitAny: test-only.
-      async update(id: any, patch: any) {
-        const r = rows.find((row) => row[pk] === id);
-        if (r) Object.assign(r, patch);
-        return r ? 1 : 0;
-      },
-    };
-  }
-  const app = {
-    data: { table: (n: string, pk?: string) => tbl(n, pk) },
-    log: noopLog(),
-  } as unknown as AppApi;
-  return { app, rows: stores.pull_requests };
-}
-
-async function call(app: AppApi, body: unknown) {
-  // biome-ignore lint/suspicious/noExplicitAny: test-only op invocation.
-  return (await handler({ req: {} as any, params: {}, query: {}, body } as any, app)) as any;
-}
-
-test("acknowledge-pr: stamps acknowledged_at on a terminal PR and returns 200", async () => {
-  const { app, rows } = memApp([{ pr_key: "o/r#1", status: "merged", acknowledged_at: null }]);
-  const res = await call(app, { pr_key: "o/r#1" });
-  assertEquals(res.status, 200);
-  assertEquals(res.body.ok, true);
-  assertEquals(typeof rows[0].acknowledged_at, "string");
-  assertEquals(typeof rows[0].updated_at, "string");
-});
-
-test("acknowledge-pr: every terminal status is dismissable", async () => {
-  for (const status of PR_TERMINAL_STATUSES) {
-    const { app, rows } = memApp([{ pr_key: "o/r#1", status, acknowledged_at: null }]);
-    const res = await call(app, { pr_key: "o/r#1" });
-    assertEquals(res.status, 200, `status ${status} must be dismissable`);
-    assertEquals(typeof rows[0].acknowledged_at, "string");
-  }
-});
-
-test("acknowledge-pr: a live (still-converging) PR is rejected (409) and stays unstamped", async () => {
-  const { app, rows } = memApp([{ pr_key: "o/r#2", status: "converging", acknowledged_at: null }]);
-  const res = await call(app, { pr_key: "o/r#2" });
-  assertEquals(res.status, 409);
-  assertEquals(res.body.ok, false);
-  assertEquals(rows[0].acknowledged_at, null);
-});
-
-test("acknowledge-pr: a missing pr_key → 400", async () => {
-  const { app } = memApp([]);
-  assertEquals((await call(app, {})).status, 400);
-  assertEquals((await call(app, { pr_key: "  " })).status, 400);
-});
-
-test("acknowledge-pr: no matching PR → 404", async () => {
-  const { app } = memApp([]);
-  assertEquals((await call(app, { pr_key: "o/r#404" })).status, 404);
-});
-
-test("acknowledge-pr: idempotent — re-acknowledging a terminal PR re-stamps and returns 200", async () => {
-  const { app, rows } = memApp([{ pr_key: "o/r#5", status: "converged", acknowledged_at: null }]);
-  assertEquals((await call(app, { pr_key: "o/r#5" })).status, 200);
-  assertEquals(typeof rows[0].acknowledged_at, "string");
-  assertEquals((await call(app, { pr_key: "o/r#5" })).status, 200);
-  assertEquals(typeof rows[0].acknowledged_at, "string");
-});