@nanobpm/nano-workforce 0.136.0 → 0.138.0

package/test/delivery-graphs-embed.test.ts

@@ -1,25 +1,30 @@
-// Contract guard for the Delivery Graphs compose → preview → STAGE App View (issues #441 + #460).
+// Contract guard for the Delivery Graphs compose → PREVIEW / STAGE App View (issues #441 + #460 + #516).
 //
 // The rich compile preview (mermaid diagram + humanNodes[] stop-points + sideEffects[] + inline
-// path-qualified errors) is surfaced by an `appView` embed (pages/delivery-graphs/) over the EXISTING
-// previewDeliveryGraph door — a bare `actionForm` discards its response and so can render none of that.
-// Dispatch is deliberately NOT in this view (issue #460): it is an OPERATOR row-action on the Staged
-// proposals grid on the same page. This test pins the wiring so it can't silently regress: the
-// sidecars exist, mount.js hits the preview door with a base-relative default (the #279 App-View
-// resolution class — a leading-slash path 404s through the console iframe), it renders each preview
-// facet, and it exposes NO dispatch/approval affordance (the self-approval hole #460 closes).
+// path-qualified errors) is surfaced by an `appView` embed (pages/delivery-graphs/) over the preview /
+// stage doors — a bare `actionForm` discards its response and so can render none of that. Preview and
+// Stage are SEPARATE operator actions (#516): Preview compiles without persisting; Stage persists a
+// proposal. Dispatch is deliberately NOT in this view (issue #460): it is an OPERATOR row-action on the
+// Staged proposals grid on the same page. This test pins the wiring so it can't silently regress: the
+// sidecars exist, mount.js hits the preview + stage doors with base-relative defaults (the #279
+// App-View resolution class — a leading-slash path 404s), it renders each preview facet, its compose
+// panel is collapsible, and it exposes NO dispatch/approval affordance (the self-approval hole #460
+// closes).
 import { test } from "node:test";
 import { assert } from "#test-assert";
 import { readFileSync } from "node:fs";
+import { parseAndCompileText } from "../app/deliveryGraphTextIngress.ts";
+import { EXAMPLE_GRAPH } from "../pages/delivery-graphs/mount.js";
 
 const ROOT = decodeURIComponent(new URL("../", import.meta.url).pathname);
 const DIR = `${ROOT}pages/delivery-graphs`;
 const MOUNT_JS = readFileSync(`${DIR}/mount.js`, "utf8");
 const EMBED_HTML = readFileSync(`${DIR}/embed.html`, "utf8");
 const STANDALONE_HTML = readFileSync(`${DIR}/standalone.html`, "utf8");
+const CSS = readFileSync(`${DIR}/delivery-graphs.css`, "utf8");
 const PAGE_JSON = readFileSync(`${ROOT}pages/delivery-graphs.page.json`, "utf8");
 
-// Pull the string default out of `const <name> = config.<name> ?? "<default>";` (or a module const).
+// Pull the string default out of `const <name> = config.<name> ?? <CONST>;` (a module const).
 function defaultUrl(name: string): string {
   const m = MOUNT_JS.match(new RegExp(`${name}\\s*=\\s*config\\.\\w+\\s*\\?\\?\\s*(\\w+);`));
   assert(m, `mount.js must default ${name} from config with a fallback constant`);
@@ -36,33 +41,39 @@ test("#441: the delivery-graphs App View mounts the same module standalone and e
   }
 });
 
-test("#441: mount.js wires the preview+stage door", () => {
+test("#516: mount.js wires SEPARATE preview and stage doors (base-relative)", () => {
   const previewUrl = defaultUrl("previewUrl");
   assert(previewUrl.endsWith("actions/delivery-graph/preview"), `previewUrl default "${previewUrl}" must hit the previewDeliveryGraph door`);
+  assert(!previewUrl.startsWith("/"), `default previewUrl "${previewUrl}" must be base-relative (App-View #279 resolution class)`);
+  const stageUrl = defaultUrl("stageUrl");
+  assert(stageUrl.endsWith("actions/delivery-graph/stage"), `stageUrl default "${stageUrl}" must hit the stageDeliveryGraph door`);
+  assert(!stageUrl.startsWith("/"), `default stageUrl "${stageUrl}" must be base-relative (App-View #279 resolution class)`);
+  // Preview and Stage are distinct buttons wired to distinct actions.
+  assert(/id="dg-preview"/.test(MOUNT_JS) && /id="dg-stage"/.test(MOUNT_JS), "mount.js must render distinct Preview and Stage buttons");
+  assert(/submit\(previewUrl,\s*false\)/.test(MOUNT_JS), "the Preview button must submit to the preview door WITHOUT staging");
+  assert(/submit\(stageUrl,\s*true\)/.test(MOUNT_JS), "the Stage button must submit to the stage door");
 });
 
-test("DI preview: mount.js wires the proposal-bpmn door (base-relative) and hands the XML to the host explorer", () => {
-  const url = defaultUrl("proposalBpmnUrl");
-  assert(url.endsWith("actions/delivery-graph/proposal-bpmn"), `proposalBpmnUrl default "${url}" must hit the previewProposalBpmn door`);
-  assert(!url.startsWith("/"), `default proposalBpmnUrl "${url}" must be base-relative (App-View #279 resolution class)`);
-  // The staged banner exposes a Preview-DI affordance, and clicking it hands the compiled XML to the
-  // host console over the nano-navigate bridge with the definitionPreview target (never a dispatch).
-  assert(/data-preview-di=/.test(MOUNT_JS), "mount.js must render a Preview-DI affordance carrying the proposal digest");
-  assert(/target:\s*"definitionPreview"/.test(MOUNT_JS), "mount.js must post nano-navigate to the definitionPreview target");
-  assert(/params:\s*\{\s*xml:/.test(MOUNT_JS), "mount.js must carry the compiled BPMN xml in the bridge message");
+test("#516: the compose panel is collapsible", () => {
+  // Native <details> disclosure: keyboard-accessible, and the textarea is only hidden (never destroyed)
+  // when collapsed, so its value survives.
+  assert(/<details[^>]*class="[^"]*\bcompose\b/.test(MOUNT_JS), "the compose panel must be a collapsible <details class=compose>");
+  assert(/<summary>/.test(MOUNT_JS), "the collapsible compose panel must have a <summary> disclosure header");
+  assert(/\.compose\[open\]/.test(CSS), "the CSS must style the open/closed disclosure state");
 });
 
-// The #279 App-View resolution class: a default endpoint must be BASE-RELATIVE (no leading slash) so
-// it resolves under the console app-view base, not the console origin root (which 404s the door).
-test("#441/#279: default previewUrl is base-relative (no leading slash)", () => {
-  const def = defaultUrl("previewUrl");
-  assert(!def.startsWith("/"), `default previewUrl "${def}" must not start with "/" — a leading-slash path resolves against the console iframe ORIGIN, not the app-view base, so the door 404s`);
+test("#516 DI preview: the compose view bridges the previewed BPMN to the host explorer WITHOUT staging", () => {
+  // The pure preview door returns the laid-out `bpmn`, so DI preview needs no proposal-bpmn round-trip
+  // (and therefore no staging). The compose view stashes the previewed BPMN and hands it to the host
+  // console over the nano-navigate bridge with the definitionPreview target (never a dispatch).
+  assert(!/proposal-bpmn/.test(MOUNT_JS), "mount.js must NOT round-trip the proposal-bpmn door — the preview door returns the BPMN directly (#516)");
+  assert(/lastBpmn/.test(MOUNT_JS), "mount.js must stash the previewed BPMN to bridge on demand");
+  assert(/data-preview-di/.test(MOUNT_JS), "mount.js must render a Preview-DI affordance");
+  assert(/target:\s*"definitionPreview"/.test(MOUNT_JS), "mount.js must post nano-navigate to the definitionPreview target");
+  assert(/params:\s*\{\s*xml:\s*lastBpmn\s*\}/.test(MOUNT_JS), "mount.js must carry the previewed BPMN xml in the bridge message");
 });
 
 test("#441: the preview render consumes every compile facet the door returns", () => {
-  // The whole point of #441: the preview data (diagram / humanNodes / sideEffects / errors) is rich
-  // but was consumed by nothing. Assert the renderer touches each facet at a CONCRETE call site (not a
-  // bare word, which a comment/string could satisfy) so a renderer that stops reading a field fails.
   const facetUse: Record<string, RegExp> = {
     diagram: /esc\(result\.diagram\)/,
     humanNodes: /renderHumanNodes\(result\.humanNodes\)/,
@@ -74,10 +85,16 @@ test("#441: the preview render consumes every compile facet the door returns", (
   }
 });
 
+test("#516: the built-in 'Load example' graph compiles clean (regression: it used to fail)", async () => {
+  // The example shipped a `soak` wait node missing its required `wait.kind`, so 'Load example' →
+  // Preview always 400'd. Drive the EXACT string the button injects through the SAME compiler the
+  // preview/stage doors use, and assert it is accepted — so a future edit to EXAMPLE_GRAPH can't
+  // silently re-break the one graph an operator reaches for first.
+  const result = await parseAndCompileText({ graphJson: EXAMPLE_GRAPH });
+  assert(result.ok, result.ok ? "" : `the built-in example must compile, got: ${JSON.stringify(result.body)}`);
+});
+
 test("#460: the compose view exposes NO dispatch or approval affordance — it only previews + stages", () => {
-  // Issue #460 removes the agent-reachable dispatch door. The compose view must not smuggle it back:
-  // no dispatch door wiring, no approval two-step, no replayable approvalToken. Dispatch is the
-  // operator's Staged-proposals row-action instead.
   assert(!/dispatchUrl/.test(MOUNT_JS), "mount.js must NOT wire a dispatch door (dispatch is an operator row-action, issue #460)");
   assert(!/delivery-graph\/dispatch/.test(MOUNT_JS), "mount.js must NOT post to the dispatch door");
   assert(!/awaiting-approval/.test(MOUNT_JS), "mount.js must NOT implement the removed awaiting-approval two-step");
@@ -85,11 +102,6 @@ test("#460: the compose view exposes NO dispatch or approval affordance — it o
 });
 
 test("#460/#511: dispatch is the operator's action on the Staged-proposals App-View", () => {
-  // Dispatch is NOT in the compose view (asserted above). It lives on the Staged-proposals surface,
-  // which is now an App-View (issue #511) rather than a declarative grid: a grid row-action can POST but
-  // cannot hand the recompiled BPMN up to the host explorer, so a staged proposal had a Dispatch button
-  // but no way to SEE the graph. The App-View carries BOTH Preview-DI and Dispatch. The wiring itself
-  // (which doors staged.mount.js posts to) is pinned by delivery-graphs-staged-embed.test.ts.
   const page = JSON.parse(PAGE_JSON) as { nodes: Array<Record<string, any>> };
   const staged = page.nodes.find((n) => n.id === "delivery-graphs-staged");
   assert(staged, "the page must carry a Staged proposals surface");

package/app/delivery.test.ts

@@ -1,76 +0,0 @@
-// Read-model derivation test for the epic delivery signal (issue #171). `deriveDelivery` is the
-// single source of truth the `plan_delivery` VIEW (061) encodes and the pollers derive at READ TIME
-// (epic #412 retired the stored `plans.delivery` / `plans.delivery_label` columns). It must cleanly
-// distinguish an epic whose fan-out is `done` but whose slices are still CONVERGING from one where
-// every slice PR has LANDED, and count abandoned/converged PRs as resolved-not-landed (never
-// `landed`). The delivery-aware `list_bucket`/`ack_open` bucket derivation now lives in the
-// `plan_read_model` VIEW (074), cross-checked against the pure helpers in app/plansReadModel.test.ts.
-import { test } from "node:test";
-import { assert, assertEquals } from "#test-assert";
-import { deriveDelivery, TERMINAL_STATUSES } from "./delivery.ts";
-
-test("all slice PRs merged -> landed", () => {
-  const r = deriveDelivery("done", ["merged", "merged", "merged"]);
-  assertEquals(r.delivery, "landed");
-  assertEquals(r.prsOpened, 3);
-  assertEquals(r.prsMerged, 3);
-  assertEquals(r.prsInFlight, 0);
-  assertEquals(r.label, "3/3 slices merged");
-});
-
-test("one slice PR still in flight -> converging", () => {
-  const r = deriveDelivery("done", ["merged", "converging", "merged"]);
-  assertEquals(r.delivery, "converging");
-  assertEquals(r.prsOpened, 3);
-  assertEquals(r.prsMerged, 2);
-  assertEquals(r.prsInFlight, 1);
-  assertEquals(r.label, "2/3 slices merged, 1 converging");
-});
-
-test("mixed merged/abandoned (all terminal, not all merged) -> resolved-not-landed (null)", () => {
-  const r = deriveDelivery("done", ["merged", "abandoned", "merged"]);
-  assertEquals(r.delivery, null);
-  assertEquals(r.label, null);
-  assertEquals(r.prsOpened, 3);
-  assertEquals(r.prsMerged, 2);
-  // abandoned is terminal, so it is NOT counted as in flight.
-  assertEquals(r.prsInFlight, 0);
-});
-
-test("a converged (review-only, unmerged) slice keeps the epic out of landed", () => {
-  // `converged` is terminal but not `merged`: resolved-not-landed, like abandoned.
-  const r = deriveDelivery("done", ["merged", "converged"]);
-  assertEquals(r.delivery, null);
-  assertEquals(r.prsInFlight, 0);
-  assertEquals(r.prsMerged, 1);
-});
-
-test("plan not yet done -> no delivery signal even with slice PRs", () => {
-  for (const status of ["planning", "dispatched"]) {
-    const r = deriveDelivery(status, ["merged", "converging"]);
-    assertEquals(r.delivery, null, `status=${status}`);
-    assertEquals(r.label, null, `status=${status}`);
-  }
-});
-
-test("done but zero slice PRs -> no delivery signal", () => {
-  const r = deriveDelivery("done", []);
-  assertEquals(r.delivery, null);
-  assertEquals(r.prsOpened, 0);
-});
-
-test("a single in-flight slice on a done plan is converging, not landed", () => {
-  const r = deriveDelivery("done", ["waiting_review"]);
-  assertEquals(r.delivery, "converging");
-  assertEquals(r.label, "0/1 slices merged, 1 converging");
-});
-
-test("every non-terminal status counts as in flight", () => {
-  const inFlight = ["converging", "waiting_review", "escalated", "queued", "open", "opened"];
-  for (const s of inFlight) {
-    assert(!TERMINAL_STATUSES.includes(s), `${s} must not be terminal`);
-    const r = deriveDelivery("done", [s]);
-    assertEquals(r.delivery, "converging", `status ${s}`);
-    assertEquals(r.prsInFlight, 1, `status ${s}`);
-  }
-});

package/app/planWaveSummary.test.ts

@@ -1,170 +0,0 @@
-// Coverage for the Epic-detail wave visualization + task→representation links (issue #411).
-//
-// Two guards, mirroring the repo's split between a derived-read-model test (migration042.test.ts —
-// apply the migration to a real in-memory DB and assert its output) and a page-projection guard
-// (waitGateVisibility.test.ts — pure text assertions that the declarative page wires the surface):
-//
-//   1. The VIEW rollup over sample `plan_tasks` × `pull_requests` rows: the six-way per-wave count
-//      partition and the pre-formatted `bar` string. Because `plan_wave_summary` is a VIEW (the whole
-//      point of #411 — a single derived source of truth, enabled by nano-ide#424) this exercises the
-//      real SQLite view, not a re-implementation.
-//   2. The epic-detail page projects the wave banner, the per-wave summary section, and the
-//      task→representation links (PR url + processExplorer instance) on the wave-state grid.
-import { readFileSync } from "node:fs";
-import { DatabaseSync } from "node:sqlite";
-import { test } from "node:test";
-import { fileURLToPath } from "node:url";
-import { assert, assertEquals } from "#test-assert";
-
-const MIGRATION = fileURLToPath(new URL("../db/migrations/059_plan_wave_summary.sql", import.meta.url));
-const PAGE = fileURLToPath(new URL("../pages/epic-detail.page.json", import.meta.url));
-
-/** A DB with the base `plan_tasks` / `pull_requests` shapes the views read, plus the views applied. */
-function viewDb(): DatabaseSync {
-  const db = new DatabaseSync(":memory:");
-  db.exec(
-    `CREATE TABLE plan_tasks (
-       id INTEGER PRIMARY KEY, plan_key TEXT, task_index INTEGER, task_id TEXT, title TEXT,
-       prompt TEXT, status TEXT, pr_key TEXT, summary TEXT, created_at TEXT, updated_at TEXT,
-       wave INTEGER, open_question TEXT, answer TEXT, draft_pr_key TEXT, corr_key TEXT);
-     CREATE TABLE pull_requests (pr_key TEXT PRIMARY KEY, url TEXT, status TEXT, process_key TEXT);`,
-  );
-  db.exec(readFileSync(MIGRATION, "utf8"));
-  return db;
-}
-
-function addTask(
-  db: DatabaseSync,
-  plan_key: string,
-  task_index: number,
-  status: string,
-  wave: number,
-  pr?: { pr_key: string; url: string; status: string; process_key: string },
-): void {
-  db.prepare(
-    "INSERT INTO plan_tasks (plan_key, task_index, task_id, status, pr_key, wave) VALUES (?, ?, ?, ?, ?, ?)",
-  ).run(plan_key, task_index, `t${task_index}`, status, pr?.pr_key ?? null, wave);
-  if (pr) {
-    db.prepare(
-      "INSERT INTO pull_requests (pr_key, url, status, process_key) VALUES (?, ?, ?, ?)",
-    ).run(pr.pr_key, pr.url, pr.status, pr.process_key);
-  }
-}
-
-test("plan_wave_summary partitions each wave's tasks and pre-formats the progress bar", () => {
-  const db = viewDb();
-  const plan = "o/r#1";
-  // Wave 0 — 5 tasks: 3 merged, 1 converging (in-flight), 1 blocked (no PR).
-  addTask(db, plan, 0, "opened", 0, { pr_key: "o/r#10", url: "https://gh/10", status: "merged", process_key: "P10" });
-  addTask(db, plan, 1, "opened", 0, { pr_key: "o/r#11", url: "https://gh/11", status: "merged", process_key: "P11" });
-  addTask(db, plan, 2, "opened", 0, { pr_key: "o/r#12", url: "https://gh/12", status: "merged", process_key: "P12" });
-  addTask(db, plan, 3, "opened", 0, { pr_key: "o/r#13", url: "https://gh/13", status: "converging", process_key: "P13" });
-  addTask(db, plan, 4, "blocked", 0);
-  // Wave 1 — an escalated slice (with a draft PR) and a skipped slice.
-  addTask(db, plan, 5, "escalated", 1, { pr_key: "o/r#14", url: "https://gh/14", status: "escalated", process_key: "P14" });
-  addTask(db, plan, 6, "skipped", 1);
-
-  const rows = db
-    .prepare("SELECT * FROM plan_wave_summary WHERE plan_key = ? ORDER BY wave")
-    .all(plan) as Array<Record<string, unknown>>;
-  assertEquals(rows.length, 2);
-
-  const w0 = rows[0];
-  assertEquals(w0.total, 5);
-  assertEquals(w0.merged, 3);
-  assertEquals(w0.in_flight, 1);
-  assertEquals(w0.blocked, 1);
-  assertEquals(w0.escalated, 0);
-  assertEquals(w0.skipped, 0);
-  // 3 filled + 2 empty glyphs (width = total), then the named non-zero categories.
-  assertEquals(w0.bar, "▓▓▓░░ 3/5 merged · 1 in-flight · 1 blocked");
-
-  const w1 = rows[1];
-  assertEquals(w1.total, 2);
-  assertEquals(w1.merged, 0);
-  assertEquals(w1.in_flight, 0);
-  assertEquals(w1.escalated, 1);
-  assertEquals(w1.skipped, 1);
-  assertEquals(w1.bar, "░░ 0/2 merged · 1 escalated · 1 skipped");
-});
-
-test("a merged PR wins over the task's own status, and unlevelized tasks are excluded", () => {
-  const db = viewDb();
-  const plan = "o/r#2";
-  // An escalated task whose PR nonetheless merged counts as merged, not escalated (PR wins).
-  addTask(db, plan, 0, "escalated", 0, { pr_key: "o/r#20", url: "https://gh/20", status: "merged", process_key: "P20" });
-  // A task with no wave yet (not levelized) must not appear in any wave row.
-  db.prepare(
-    "INSERT INTO plan_tasks (plan_key, task_index, task_id, status, wave) VALUES (?, ?, ?, ?, NULL)",
-  ).run(plan, 1, "t1", "pending");
-
-  const rows = db
-    .prepare("SELECT wave, total, merged, escalated FROM plan_wave_summary WHERE plan_key = ?")
-    .all(plan) as Array<Record<string, unknown>>;
-  assertEquals(rows.length, 1);
-  assertEquals(rows[0].wave, 0);
-  assertEquals(rows[0].total, 1);
-  assertEquals(rows[0].merged, 1);
-  assertEquals(rows[0].escalated, 0);
-});
-
-test("plan_wave_tasks carries each task's PR url + process_key link targets", () => {
-  const db = viewDb();
-  addTask(db, "o/r#3", 0, "opened", 0, { pr_key: "o/r#30", url: "https://gh/30", status: "converging", process_key: "P30" });
-  addTask(db, "o/r#3", 1, "blocked", 0); // no PR → null link targets
-
-  const rows = db
-    .prepare("SELECT task_id, pr_key, pr_url, process_key FROM plan_wave_tasks WHERE plan_key = ? ORDER BY task_index")
-    .all("o/r#3") as Array<Record<string, unknown>>;
-  assertEquals(rows[0].pr_url, "https://gh/30");
-  assertEquals(rows[0].process_key, "P30");
-  assertEquals(rows[1].pr_url, null);
-  assertEquals(rows[1].process_key, null);
-});
-
-test("epic-detail projects the wave banner, the per-wave summary, and task→representation links", () => {
-  const page = JSON.parse(readFileSync(PAGE, "utf8"));
-  const byId = (id: string) => page.nodes.find((n: { id: string }) => n.id === id);
-
-  // 1. The epic-level wave banner: a prose node reading wave_label + epic_phase off the derived
-  //    `plan_read_model` VIEW (epic #412 — retiring the worker-maintained plans.wave_label column;
-  //    the banner now reads the single-source-of-truth view instead of the raw `plans` table).
-  const banner = byId("wave-banner");
-  assert(banner, "epic detail must show the epic-level wave banner");
-  assertEquals(banner.props.data.table, "plan_read_model");
-  assert(
-    banner.props.data.filter.some((f: { field: string; eqParam?: boolean }) => f.field === "plan_key" && f.eqParam),
-    "the banner is scoped to this epic",
-  );
-  assert(/\{\{\s*wave_label\s*\}\}/.test(banner.props.header), "the banner surfaces the wave_label");
-  assert(/\{\{\s*epic_phase\s*\}\}/.test(banner.props.header), "the banner surfaces the epic phase");
-
-  // 2. The per-wave summary section: a grid over the derived VIEW, ordered by wave, with the bar.
-  const summary = byId("wave-summary");
-  assert(summary, "epic detail must show the per-wave progress summary");
-  assertEquals(summary.props.data.table, "plan_wave_summary");
-  assertEquals(summary.props.data.orderBy.field, "wave");
-  const summaryCols: string[] = summary.props.columns.map((c: { field: string }) => c.field);
-  for (const f of ["wave", "bar", "merged", "in_flight", "blocked", "escalated", "skipped", "total"]) {
-    assert(summaryCols.includes(f), `the summary grid shows ${f}`);
-  }
-
-  // 3. The wave-state grid links each in-flight task to its representation (PR + process instance).
-  const waveState = byId("wave-state");
-  assert(waveState, "epic detail must keep the wave-state grid");
-  assertEquals(waveState.props.data.table, "plan_wave_tasks");
-  const cols: Array<Record<string, unknown>> = waveState.props.columns;
-  const prCol = cols.find((c) => c.field === "pr_key");
-  assertEquals(prCol?.linkField, "pr_url", "the PR cell links to the GitHub PR url");
-  const statusCol = cols.find((c) => c.field === "status") as {
-    link?: { kind?: string; keyField?: string };
-  };
-  assertEquals(statusCol.link?.kind, "processExplorer", "the status cell links to the process instance");
-  assertEquals(statusCol.link?.keyField, "process_key");
-  // The existing tabs (Active / Skipped / All) and detail drawer must still be present.
-  assertEquals(waveState.props.tabs.length, 3);
-  const detailFields: string[] = waveState.props.detail.fields.map((f: { field: string }) => f.field);
-  for (const f of ["open_question", "answer", "draft_pr_key", "prompt"]) {
-    assert(detailFields.includes(f), `the detail drawer keeps ${f}`);
-  }
-});