@nanobpm/nano-workforce 0.136.0 → 0.137.0

package/app/planRollups.ts

@@ -0,0 +1,127 @@
+// The plan-family GROUP-BY rollups — DECLARED ONCE and compiled to BOTH backends via Urban's ADR-0065
+// rollup primitive (`defineRollup`, `@nanobpm/urban`, capability nano-ide#468 / `@nanobpm/urban@0.82.0`).
+//
+// Background (issues #411 → #412 → #493). The Epic surfaces render DERIVED aggregate state — each epic's
+// per-wave six-way task partition (059's `plan_wave_counts`), its wave FRONTIER (`wave_count`/
+// `current_wave`, 060's `plan_wave_progress`), and its slice-PR landing counts (061's
+// `plan_delivery_counts`). None of these are ground truth: each is a pure GROUP BY over `plan_tasks`
+// joined to `pull_requests`. 059/060/061 expressed them as hand-authored SQL VIEWs *and* the runtime
+// TS (`deriveDelivery` folded the same counts; the wave frontier was reproduced in the poller), kept in
+// lockstep by hand-written parity tests — the ADR-0065 drift surface #2 (each aggregate authored twice).
+//
+// This module closes surface #2 for the aggregates STRUCTURALLY: each rollup is declared ONCE in Urban's
+// closed GROUP-BY spec (`defineRollup`), and Urban compiles it to BOTH the managed `*_counts` VIEW
+// (`viewDdl`/`sqlAggFor`, emitted verbatim into the superseding migration, drift-guarded) AND the
+// runtime TS group-reduce (`reduce`, the sole engine behind the `deriveDelivery` façade in app/
+// delivery.ts). The two lowerings fall out of the SAME closed spec, and `assertRollupParity` (app/
+// planReadModel.test.ts) is the framework-owned regression guard that they agree.
+//
+// The per-row signals that CONSUME these counts (delivery / list_bucket / ack_open) live in
+// app/planReadModel.ts (`defineReadModel` + key-correlated rollup lookups); the pre-formatted display
+// strings (`bar`, `wave_label`, `delivery_label`) stay hand-authored over these derived columns (D3 —
+// display formatting is out of the framework AST). Use app/featureReadModel.ts as the exemplar.
+
+import { add, and, coalesce, col, count, countWhere, defineRollup, eq, fromRollup, gt, isNotNull, joinSource, lit, max, minWhere, not, or, type Rollup } from "@nanobpm/urban";
+import { TERMINAL_STATUSES } from "./deliveryStatuses.ts";
+
+/** The slice-PR relation the delivery/wave rollups join: the auto-provisioned `pull_requests__tracking`
+ * derived VIEW (ADR-0065), NOT the raw `pull_requests` table. It re-exports `pull_requests.*` plus a
+ * terminal-folded `derived_status` (`abandoned` on an out-of-band-terminated PR instance, else the base
+ * `pull_requests.status`). Reading `derived_status` here — the SAME column the canonical runtime reads
+ * via `prsTracking` (app/service.ts `derivePlanDelivery`) — keeps the SQL VIEW counts and the runtime
+ * in agreement: an out-of-band-terminated converging slice reads `abandoned` (resolved), so the VIEW
+ * can never wedge an epic at `delivery = 'converging'` after its PR was cancelled. Exported so the
+ * app/delivery.ts adapter feeds its synthesised leaf rows under the same relation name. */
+export const PR_TRACKING_RELATION = "pull_requests__tracking";
+
+/** `plan_tasks t LEFT JOIN pull_requests__tracking p ON p.pr_key = t.pr_key` as a rollup source, with a
+ * FLAT output namespace so the closed aggregate/predicate machinery reads unqualified column names.
+ * `pr_status` is the tracking VIEW's terminal-folded `derived_status` (see {@link PR_TRACKING_RELATION}).
+ * The two plan-family count rollups both fold over this two-hop join (D4). */
+const planTasksJoinPrs = joinSource({
+  left: { relation: "plan_tasks", alias: "t" },
+  right: { relation: PR_TRACKING_RELATION, alias: "p" },
+  on: [{ left: "pr_key", right: "pr_key" }],
+  columns: {
+    plan_key: ["left", "plan_key"],
+    wave: ["left", "wave"],
+    task_status: ["left", "status"],
+    pr_key: ["left", "pr_key"],
+    pr_status: ["right", "derived_status"],
+  },
+});
+
+/** `<pr_status> <> 'merged'` under the shared "NULL → not-merged" rule: `not(eq(...))` compiles to
+ * `NOT COALESCE((pr_status = 'merged'), 0)` in SQL and the nullish-guarded negation in TS, so a task
+ * whose PR row is absent (`pr_status` NULL) is treated as NOT merged in BOTH backends — matching 059's
+ * `WHEN p.status = 'merged' THEN 0 …` fall-through (a NULL `p.status` never matches the merged arm). */
+const prNotMerged = not(eq(col("pr_status"), lit("merged")));
+
+/** `<task_status> = <value>` for a NON-merged task — the priority-ordered five-way bucket predicate the
+ * 059 partition uses (`WHEN p.status = 'merged' THEN 0 WHEN t.status = '<b>' THEN 1 ELSE 0`), so the
+ * five named buckets stay DISJOINT with `merged` and sum to `total`. */
+const nonMergedTaskIs = (bucket: string) => and(prNotMerged, eq(col("task_status"), lit(bucket)));
+
+/**
+ * `plan_wave_counts` — one row per `(plan_key, wave)` with the six-way task partition (059). A task is
+ * `merged` iff its PR reached `pull_requests.status = 'merged'`; otherwise it falls to its
+ * `plan_tasks.status` bucket, and everything else (pending/opened/waiting-for-lane/abandoned) is
+ * `in_flight`. The CASE priority (encoded as disjoint `countWhere` predicates) keeps the five named
+ * buckets DISJOINT so they always sum to `total`. `WHERE wave IS NOT NULL` drops un-levelized tasks.
+ */
+export const planWaveCounts: Rollup = defineRollup({
+  name: "plan_wave_counts",
+  source: planTasksJoinPrs,
+  groupBy: ["plan_key", "wave"],
+  where: isNotNull(col("wave")),
+  aggregates: {
+    total: count(),
+    merged: countWhere(eq(col("pr_status"), lit("merged"))),
+    skipped: countWhere(nonMergedTaskIs("skipped")),
+    blocked: countWhere(nonMergedTaskIs("blocked")),
+    escalated: countWhere(nonMergedTaskIs("escalated")),
+    in_flight: countWhere(and(prNotMerged, not(or(eq(col("task_status"), lit("skipped")), eq(col("task_status"), lit("blocked")), eq(col("task_status"), lit("escalated")))))),
+  },
+});
+
+/**
+ * `plan_wave_progress` — one row per `plan_key` with the two wave-frontier projections (060), COMPOSED
+ * over `plan_wave_counts` (a rollup source — D1's composability):
+ *   - `wave_count`   = `MAX(wave) + 1` (the levelizer emits contiguous waves 0..N-1).
+ *   - `current_wave` = the live FRONTIER: the lowest wave that still has an `in_flight` task, else —
+ *                      once every wave has settled — pinned to the last index `MAX(wave)`.
+ * A plan with no levelized tasks contributes no `plan_wave_counts` row, so it is absent here and reads
+ * NULL through the downstream read-model LEFT JOIN — matching the workers' taskless-plan behaviour.
+ */
+export const planWaveProgress: Rollup = defineRollup({
+  name: "plan_wave_progress",
+  source: fromRollup(planWaveCounts),
+  groupBy: ["plan_key"],
+  aggregates: {
+    wave_count: add(max("wave"), 1),
+    current_wave: coalesce(minWhere("wave", gt(col("in_flight"), lit(0))), max("wave")),
+  },
+});
+
+/**
+ * `plan_delivery_counts` — one row per `plan_key` with the three counts `deriveDelivery` folds over the
+ * slice PRs (061). Only tasks that OPENED a PR count (`prs_opened = COUNT(pr_key)`, non-NULL). A
+ * `pr_key` with no `pull_requests` row (`pr_status` NULL, the poller's `MISSING_PR_STATUS` sentinel) is
+ * non-terminal, so it counts as `prs_in_flight` — a DB desync can never wrongly promote an epic to
+ * `landed`. `prs_in_flight` = opened PRs whose status is NOT in {@link TERMINAL_STATUSES}
+ * (a NULL status is not terminal), exactly `deriveDelivery`'s in-flight fold.
+ */
+export const planDeliveryCounts: Rollup = defineRollup({
+  name: "plan_delivery_counts",
+  source: planTasksJoinPrs,
+  groupBy: ["plan_key"],
+  aggregates: {
+    prs_opened: count("pr_key"),
+    prs_merged: countWhere(and(isNotNull(col("pr_key")), eq(col("pr_status"), lit("merged")))),
+    prs_in_flight: countWhere(and(isNotNull(col("pr_key")), not(or(...TERMINAL_STATUSES.map((s) => eq(col("pr_status"), lit(s))))))),
+  },
+});
+
+/** Every plan-family rollup, in managed-VIEW dependency order (a composed rollup after the rollup it
+ * reads). The superseding migration emits their VIEW DDL in this order; the parity guard iterates it. */
+export const PLAN_ROLLUPS: readonly Rollup[] = [planWaveCounts, planDeliveryCounts, planWaveProgress];

package/db/migrations/082_plan_rollups_declare_once.sql

@@ -0,0 +1,74 @@
+-- Plan-family GROUP-BY rollups, authored ONCE via Urban's ADR-0065 rollup primitive (`defineRollup`,
+-- app/planRollups.ts, `@nanobpm/urban@0.82.0` / nano-ide#468) — issue #493 (the plan-family twin of
+-- 076's feature read-model declare-once).
+--
+-- 059_plan_wave_summary.sql, 060_plan_wave_rollup.sql and 061_plan_delivery_rollup.sql hand-authored
+-- the three plan-family aggregates — `plan_wave_counts` (per-(plan_key, wave) six-way task partition),
+-- `plan_wave_progress` (the wave frontier `wave_count`/`current_wave`), and `plan_delivery_counts` (the
+-- slice-PR landing counts) — as SQL VIEWs, AND folded the SAME counts a SECOND time in the runtime TS
+-- (`deriveDelivery` folded the delivery counts; the poller reproduced the wave frontier). That is the
+-- ADR-0065 drift surface #2 (each aggregate authored twice, kept in lockstep by hand-written parity
+-- tests). This migration SUPERSEDES the three VIEW bodies with the VERBATIM DDL Urban compiles from the
+-- ONE `defineRollup` declaration for each (app/planRollups.ts) — which ALSO drives the runtime TS
+-- group-reduce (`reduce`, the sole engine behind `deriveDelivery` in app/delivery.ts). The two
+-- lowerings fall out of the same closed GROUP-BY spec and cannot diverge; the drift guard
+-- (app/planReadModel.test.ts) fails if this file stops matching the declaration, and
+-- `assertRollupParity` proves the VIEW and TS reduce agree. 059/060/061 are MERGED, IMMUTABLE
+-- migrations — never edited; this is a NEW migration superseding their VIEW bodies (the pattern by
+-- which 081 superseded 076's feature VIEW).
+--
+-- SEMANTICS are unchanged from 059/060/061 (validated byte-identical over a random corpus): a task is
+-- `merged` iff its PR reached `pull_requests__tracking.derived_status = 'merged'`, otherwise it falls to its
+-- `plan_tasks.status` bucket; the five named buckets stay DISJOINT and sum to `total`; the delivery
+-- counts fold only tasks that OPENED a PR, and a dangling `pr_key` (NULL status) counts as in-flight so
+-- a DB desync can never wrongly promote an epic to `landed`. Each rollup emits `CREATE VIEW <name> AS
+-- SELECT … FROM … GROUP BY …` (aggregates aliased in the select-list) so the static pages↔schema
+-- contract guard (scripts/pages-contract.test.ts) still reads each VIEW's output columns.
+--
+-- Layered in dependency order: `plan_wave_counts` first (the leaf GROUP BY over `plan_tasks` LEFT JOIN
+-- `pull_requests__tracking` (ADR-0065 derived VIEW; reads the terminal-folded `derived_status`, the
+-- SAME column the canonical runtime reads), then `plan_delivery_counts` (a sibling GROUP BY over the same join), then
+-- `plan_wave_progress` (COMPOSED over `plan_wave_counts` — D1's composability). The retained
+-- `plan_wave_summary` (059, the `bar` glyph) and `plan_wave_label` (060) VIEWs read the recreated
+-- `plan_wave_counts`/`plan_wave_progress` unchanged. A merged VIEW is not editable in place, so each is
+-- DROP+CREATE; nothing structural changes, so every dependent VIEW and page binding stays valid.
+--
+-- Forward-only VIEW redefinition (DROP then CREATE). The runner wraps each file in its own transaction,
+-- so this file must NOT contain BEGIN/COMMIT. Numbered after 081.
+
+DROP VIEW IF EXISTS plan_wave_counts;
+
+CREATE VIEW IF NOT EXISTS "plan_wave_counts" AS
+SELECT
+  "t"."plan_key" AS "plan_key",
+  "t"."wave" AS "wave",
+  SUM(CASE WHEN COALESCE(((NOT COALESCE(COALESCE(("p"."derived_status" = 'merged'), 0), 0)) AND COALESCE(("t"."status" = 'blocked'), 0)), 0) THEN 1 ELSE 0 END) AS "blocked",
+  SUM(CASE WHEN COALESCE(((NOT COALESCE(COALESCE(("p"."derived_status" = 'merged'), 0), 0)) AND COALESCE(("t"."status" = 'escalated'), 0)), 0) THEN 1 ELSE 0 END) AS "escalated",
+  SUM(CASE WHEN COALESCE(((NOT COALESCE(COALESCE(("p"."derived_status" = 'merged'), 0), 0)) AND (NOT COALESCE(COALESCE((COALESCE(("t"."status" = 'skipped'), 0) OR COALESCE(("t"."status" = 'blocked'), 0) OR COALESCE(("t"."status" = 'escalated'), 0)), 0), 0))), 0) THEN 1 ELSE 0 END) AS "in_flight",
+  SUM(CASE WHEN COALESCE(("p"."derived_status" = 'merged'), 0) THEN 1 ELSE 0 END) AS "merged",
+  SUM(CASE WHEN COALESCE(((NOT COALESCE(COALESCE(("p"."derived_status" = 'merged'), 0), 0)) AND COALESCE(("t"."status" = 'skipped'), 0)), 0) THEN 1 ELSE 0 END) AS "skipped",
+  COUNT(*) AS "total"
+FROM "plan_tasks" "t" LEFT JOIN "pull_requests__tracking" "p" ON "t"."pr_key" = "p"."pr_key"
+WHERE (NOT COALESCE(("t"."wave" IS NULL), 0))
+GROUP BY "t"."plan_key", "t"."wave";
+
+DROP VIEW IF EXISTS plan_delivery_counts;
+
+CREATE VIEW IF NOT EXISTS "plan_delivery_counts" AS
+SELECT
+  "t"."plan_key" AS "plan_key",
+  SUM(CASE WHEN COALESCE(((NOT COALESCE(("t"."pr_key" IS NULL), 0)) AND (NOT COALESCE(COALESCE((COALESCE(("p"."derived_status" = 'converged'), 0) OR COALESCE(("p"."derived_status" = 'merged'), 0) OR COALESCE(("p"."derived_status" = 'abandoned'), 0)), 0), 0))), 0) THEN 1 ELSE 0 END) AS "prs_in_flight",
+  SUM(CASE WHEN COALESCE(((NOT COALESCE(("t"."pr_key" IS NULL), 0)) AND COALESCE(("p"."derived_status" = 'merged'), 0)), 0) THEN 1 ELSE 0 END) AS "prs_merged",
+  COUNT("t"."pr_key") AS "prs_opened"
+FROM "plan_tasks" "t" LEFT JOIN "pull_requests__tracking" "p" ON "t"."pr_key" = "p"."pr_key"
+GROUP BY "t"."plan_key";
+
+DROP VIEW IF EXISTS plan_wave_progress;
+
+CREATE VIEW IF NOT EXISTS "plan_wave_progress" AS
+SELECT
+  "__urban_rollup_src"."plan_key" AS "plan_key",
+  COALESCE(MIN(CASE WHEN COALESCE(("__urban_rollup_src"."in_flight" > 0), 0) THEN "__urban_rollup_src"."wave" END), MAX("__urban_rollup_src"."wave")) AS "current_wave",
+  (MAX("__urban_rollup_src"."wave") + 1) AS "wave_count"
+FROM "plan_wave_counts" "__urban_rollup_src"
+GROUP BY "__urban_rollup_src"."plan_key";

package/db/migrations/083_plan_read_model_declare_once.sql

@@ -0,0 +1,84 @@
+-- Epic `plan_read_model` per-row signals, authored ONCE via Urban's ADR-0065 reconciling-read-model
+-- primitive (`defineReadModel` + key-correlated rollup lookups, app/planReadModel.ts,
+-- `@nanobpm/urban@0.82.0` / nano-ide#468) — issue #493 (the plan-family twin of 076/081's feature
+-- read-model declare-once; the exemplar is app/featureReadModel.ts).
+--
+-- 061_plan_delivery_rollup.sql, 074_plan_read_model_derive_bucket.sql and
+-- 080_plan_read_model_derive_terminal.sql hand-authored the epic per-row signals — `delivery`
+-- (converging/landed/NULL), the Active/History `list_bucket`, and the operator-Dismiss `ack_open`
+-- flag — as SQL `CASE` expressions inside the `plan_delivery` / `plan_read_model` VIEWs, AND a SECOND
+-- time in the runtime TS (`deriveDelivery`/`deriveEpicBucket`/`epicIsAcknowledgeable`, app/delivery.ts),
+-- kept in lockstep by hand-written parity tests (ADR-0065 drift surface #2). This migration SUPERSEDES
+-- 080's `plan_read_model` VIEW body: every DERIVED column below is emitted VERBATIM from the ONE
+-- `planReadModel` declaration (`planReadModel.sqlSelectFor(col, { baseAlias: "pl" })`), which ALSO
+-- drives the runtime TS via `fnFor` (behind the app/delivery.ts adapters). The two lowerings fall out
+-- of the same closed-DSL AST and cannot diverge; the drift guard (app/planReadModel.test.ts) fails if
+-- this file stops matching the declaration, and `assertReadModelParity` proves the SQL and TS lowerings
+-- agree. 061/074/080 are MERGED, IMMUTABLE migrations — never edited; this is a NEW migration
+-- superseding 080's VIEW body (the pattern by which 080 superseded 074).
+--
+-- SEMANTICS are unchanged from 080 (validated byte-identical over a random corpus): the status-
+-- classifying `list_bucket`/`ack_open` arms read the terminal-folded `derived_status` off the
+-- auto-provisioned `plans__tracking` derived VIEW (so a cancelled epic drops out of Active with no
+-- worker write, issue #503); `delivery` reads the base `plans.status` (`done` is already terminal, so
+-- base and effective agree on the `= 'done'` gate, and this keeps `delivery` byte-identical to the
+-- retired `plan_delivery` VIEW and to `deriveDelivery(plan.status, …)`'s call sites). The single-valued
+-- rollup lookups the CASEs consume are `LEFT JOIN plan_delivery_counts dc` (slice-PR counts, defaulted
+-- to 0 on a miss) and `LEFT JOIN plan_wave_progress wp` (the wave frontier), the D1 per-row half over
+-- the rollups single-sourced in 082.
+--
+-- The pre-formatted DISPLAY strings stay hand-authored over these derived structured columns (D3 —
+-- display formatting is out of the framework AST, so they carry no TS twin): `delivery_label` mirrors
+-- the retired `plan_delivery` label CASE (over the base status + `dc` counts) and `wave_label` is the
+-- 1-based "X/N" string over the `wp` frontier. The wave `bar` glyph stays in the retained
+-- `plan_wave_summary` VIEW (059). Base columns stay aliased pass-throughs (so the static pages↔schema
+-- contract guard still reads the VIEW's columns), sourced off `plans__tracking`'s re-export of the base
+-- `plans.*`; `plans__tracking pl` is the sole top-level FROM.
+--
+-- The retired intermediate VIEWs `plan_delivery` (061) and `plan_wave_label` (060) were consumed ONLY
+-- by `plan_read_model`; this migration folds their derivations/display into the composite and DROPs
+-- them. `plan_read_model` is a leaf (no VIEW builds on it) and its output column set is UNCHANGED, so
+-- the pages↔schema contract guard and every page binding stay valid. `plans__tracking` is the managed
+-- VIEW urban provisions at mount; SQLite does not validate a view body at CREATE time, so this
+-- migration (which runs before that mount) is created fine and resolves once the managed VIEW exists.
+--
+-- Forward-only VIEW redefinition (DROP then CREATE). The runner wraps each file in its own transaction,
+-- so this file must NOT contain BEGIN/COMMIT. Numbered after 082.
+
+DROP VIEW IF EXISTS plan_read_model;
+DROP VIEW IF EXISTS plan_delivery;
+DROP VIEW IF EXISTS plan_wave_label;
+
+CREATE VIEW plan_read_model AS
+SELECT
+  pl.plan_key AS plan_key,
+  pl.repo AS repo,
+  pl.issue_number AS issue_number,
+  pl.issue_url AS issue_url,
+  pl.title AS title,
+  COALESCE(pl.derived_status, pl.status) AS status,
+  pl.task_count AS task_count,
+  pl.process_key AS process_key,
+  pl.outcome AS outcome,
+  pl.updated_at AS updated_at,
+  pl.epic_phase AS epic_phase,
+  pl.base_branch AS base_branch,
+  pl.wait_gate_label AS wait_gate_label,
+  pl.bound_artifacts AS bound_artifacts,
+  pl.promotion_pr AS promotion_pr,
+  pl.promotion_state AS promotion_state,
+  CASE WHEN COALESCE(((NOT COALESCE(COALESCE(("pl"."status" = 'done'), 0), 0)) OR COALESCE((COALESCE("dc"."prs_opened", 0) = 0), 0)), 0) THEN NULL WHEN COALESCE((COALESCE("dc"."prs_in_flight", 0) > 0), 0) THEN 'converging' WHEN COALESCE((COALESCE("dc"."prs_merged", 0) = COALESCE("dc"."prs_opened", 0)), 0) THEN 'landed' ELSE NULL END AS delivery,
+  "wp"."wave_count" AS wave_count,
+  "wp"."current_wave" AS current_wave,
+  CASE WHEN COALESCE((COALESCE(("pl"."derived_status" = 'planning'), 0) OR COALESCE(("pl"."derived_status" = 'dispatched'), 0)), 0) THEN 'active' WHEN COALESCE((COALESCE(("pl"."derived_status" = 'done'), 0) AND COALESCE((CASE WHEN COALESCE(((NOT COALESCE(COALESCE(("pl"."status" = 'done'), 0), 0)) OR COALESCE((COALESCE("dc"."prs_opened", 0) = 0), 0)), 0) THEN NULL WHEN COALESCE((COALESCE("dc"."prs_in_flight", 0) > 0), 0) THEN 'converging' WHEN COALESCE((COALESCE("dc"."prs_merged", 0) = COALESCE("dc"."prs_opened", 0)), 0) THEN 'landed' ELSE NULL END = 'converging'), 0)), 0) THEN 'active' WHEN COALESCE((COALESCE(("pl"."derived_status" = 'done'), 0) AND ("pl"."acknowledged_at" IS NULL)), 0) THEN 'active' WHEN COALESCE(("pl"."derived_status" = 'done'), 0) THEN 'history' ELSE 'history' END AS list_bucket,
+  CASE WHEN COALESCE((COALESCE(("pl"."derived_status" = 'done'), 0) AND (NOT COALESCE(COALESCE((CASE WHEN COALESCE(((NOT COALESCE(COALESCE(("pl"."status" = 'done'), 0), 0)) OR COALESCE((COALESCE("dc"."prs_opened", 0) = 0), 0)), 0) THEN NULL WHEN COALESCE((COALESCE("dc"."prs_in_flight", 0) > 0), 0) THEN 'converging' WHEN COALESCE((COALESCE("dc"."prs_merged", 0) = COALESCE("dc"."prs_opened", 0)), 0) THEN 'landed' ELSE NULL END = 'converging'), 0), 0)) AND ("pl"."acknowledged_at" IS NULL)), 0) THEN 1 ELSE 0 END AS ack_open,
+  CASE
+    WHEN pl.status IS NOT 'done' OR COALESCE(dc.prs_opened, 0) = 0 THEN NULL
+    WHEN COALESCE(dc.prs_in_flight, 0) > 0 THEN dc.prs_merged || '/' || dc.prs_opened || ' slices merged, ' || dc.prs_in_flight || ' converging'
+    WHEN dc.prs_merged = dc.prs_opened THEN dc.prs_opened || '/' || dc.prs_opened || ' slices merged'
+    ELSE NULL
+  END AS delivery_label,
+  (wp.current_wave + 1) || '/' || wp.wave_count AS wave_label
+FROM plans__tracking pl
+LEFT JOIN plan_delivery_counts dc ON pl.plan_key = dc.plan_key
+LEFT JOIN plan_wave_progress wp ON pl.plan_key = wp.plan_key;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nanobpm/nano-workforce",
-  "version": "0.136.0",
+  "version": "0.137.0",
   "description": "Nano Workforce — an Agent Graph Orchestration application for Agentic SDLC: durable BPMN processes that coordinate a graph of AI agents across the software delivery lifecycle.",
   "type": "module",
   "main": "main.ts",

package/app/delivery.test.ts

@@ -1,76 +0,0 @@
-// Read-model derivation test for the epic delivery signal (issue #171). `deriveDelivery` is the
-// single source of truth the `plan_delivery` VIEW (061) encodes and the pollers derive at READ TIME
-// (epic #412 retired the stored `plans.delivery` / `plans.delivery_label` columns). It must cleanly
-// distinguish an epic whose fan-out is `done` but whose slices are still CONVERGING from one where
-// every slice PR has LANDED, and count abandoned/converged PRs as resolved-not-landed (never
-// `landed`). The delivery-aware `list_bucket`/`ack_open` bucket derivation now lives in the
-// `plan_read_model` VIEW (074), cross-checked against the pure helpers in app/plansReadModel.test.ts.
-import { test } from "node:test";
-import { assert, assertEquals } from "#test-assert";
-import { deriveDelivery, TERMINAL_STATUSES } from "./delivery.ts";
-
-test("all slice PRs merged -> landed", () => {
-  const r = deriveDelivery("done", ["merged", "merged", "merged"]);
-  assertEquals(r.delivery, "landed");
-  assertEquals(r.prsOpened, 3);
-  assertEquals(r.prsMerged, 3);
-  assertEquals(r.prsInFlight, 0);
-  assertEquals(r.label, "3/3 slices merged");
-});
-
-test("one slice PR still in flight -> converging", () => {
-  const r = deriveDelivery("done", ["merged", "converging", "merged"]);
-  assertEquals(r.delivery, "converging");
-  assertEquals(r.prsOpened, 3);
-  assertEquals(r.prsMerged, 2);
-  assertEquals(r.prsInFlight, 1);
-  assertEquals(r.label, "2/3 slices merged, 1 converging");
-});
-
-test("mixed merged/abandoned (all terminal, not all merged) -> resolved-not-landed (null)", () => {
-  const r = deriveDelivery("done", ["merged", "abandoned", "merged"]);
-  assertEquals(r.delivery, null);
-  assertEquals(r.label, null);
-  assertEquals(r.prsOpened, 3);
-  assertEquals(r.prsMerged, 2);
-  // abandoned is terminal, so it is NOT counted as in flight.
-  assertEquals(r.prsInFlight, 0);
-});
-
-test("a converged (review-only, unmerged) slice keeps the epic out of landed", () => {
-  // `converged` is terminal but not `merged`: resolved-not-landed, like abandoned.
-  const r = deriveDelivery("done", ["merged", "converged"]);
-  assertEquals(r.delivery, null);
-  assertEquals(r.prsInFlight, 0);
-  assertEquals(r.prsMerged, 1);
-});
-
-test("plan not yet done -> no delivery signal even with slice PRs", () => {
-  for (const status of ["planning", "dispatched"]) {
-    const r = deriveDelivery(status, ["merged", "converging"]);
-    assertEquals(r.delivery, null, `status=${status}`);
-    assertEquals(r.label, null, `status=${status}`);
-  }
-});
-
-test("done but zero slice PRs -> no delivery signal", () => {
-  const r = deriveDelivery("done", []);
-  assertEquals(r.delivery, null);
-  assertEquals(r.prsOpened, 0);
-});
-
-test("a single in-flight slice on a done plan is converging, not landed", () => {
-  const r = deriveDelivery("done", ["waiting_review"]);
-  assertEquals(r.delivery, "converging");
-  assertEquals(r.label, "0/1 slices merged, 1 converging");
-});
-
-test("every non-terminal status counts as in flight", () => {
-  const inFlight = ["converging", "waiting_review", "escalated", "queued", "open", "opened"];
-  for (const s of inFlight) {
-    assert(!TERMINAL_STATUSES.includes(s), `${s} must not be terminal`);
-    const r = deriveDelivery("done", [s]);
-    assertEquals(r.delivery, "converging", `status ${s}`);
-    assertEquals(r.prsInFlight, 1, `status ${s}`);
-  }
-});

package/app/planWaveSummary.test.ts

@@ -1,170 +0,0 @@
-// Coverage for the Epic-detail wave visualization + task→representation links (issue #411).
-//
-// Two guards, mirroring the repo's split between a derived-read-model test (migration042.test.ts —
-// apply the migration to a real in-memory DB and assert its output) and a page-projection guard
-// (waitGateVisibility.test.ts — pure text assertions that the declarative page wires the surface):
-//
-//   1. The VIEW rollup over sample `plan_tasks` × `pull_requests` rows: the six-way per-wave count
-//      partition and the pre-formatted `bar` string. Because `plan_wave_summary` is a VIEW (the whole
-//      point of #411 — a single derived source of truth, enabled by nano-ide#424) this exercises the
-//      real SQLite view, not a re-implementation.
-//   2. The epic-detail page projects the wave banner, the per-wave summary section, and the
-//      task→representation links (PR url + processExplorer instance) on the wave-state grid.
-import { readFileSync } from "node:fs";
-import { DatabaseSync } from "node:sqlite";
-import { test } from "node:test";
-import { fileURLToPath } from "node:url";
-import { assert, assertEquals } from "#test-assert";
-
-const MIGRATION = fileURLToPath(new URL("../db/migrations/059_plan_wave_summary.sql", import.meta.url));
-const PAGE = fileURLToPath(new URL("../pages/epic-detail.page.json", import.meta.url));
-
-/** A DB with the base `plan_tasks` / `pull_requests` shapes the views read, plus the views applied. */
-function viewDb(): DatabaseSync {
-  const db = new DatabaseSync(":memory:");
-  db.exec(
-    `CREATE TABLE plan_tasks (
-       id INTEGER PRIMARY KEY, plan_key TEXT, task_index INTEGER, task_id TEXT, title TEXT,
-       prompt TEXT, status TEXT, pr_key TEXT, summary TEXT, created_at TEXT, updated_at TEXT,
-       wave INTEGER, open_question TEXT, answer TEXT, draft_pr_key TEXT, corr_key TEXT);
-     CREATE TABLE pull_requests (pr_key TEXT PRIMARY KEY, url TEXT, status TEXT, process_key TEXT);`,
-  );
-  db.exec(readFileSync(MIGRATION, "utf8"));
-  return db;
-}
-
-function addTask(
-  db: DatabaseSync,
-  plan_key: string,
-  task_index: number,
-  status: string,
-  wave: number,
-  pr?: { pr_key: string; url: string; status: string; process_key: string },
-): void {
-  db.prepare(
-    "INSERT INTO plan_tasks (plan_key, task_index, task_id, status, pr_key, wave) VALUES (?, ?, ?, ?, ?, ?)",
-  ).run(plan_key, task_index, `t${task_index}`, status, pr?.pr_key ?? null, wave);
-  if (pr) {
-    db.prepare(
-      "INSERT INTO pull_requests (pr_key, url, status, process_key) VALUES (?, ?, ?, ?)",
-    ).run(pr.pr_key, pr.url, pr.status, pr.process_key);
-  }
-}
-
-test("plan_wave_summary partitions each wave's tasks and pre-formats the progress bar", () => {
-  const db = viewDb();
-  const plan = "o/r#1";
-  // Wave 0 — 5 tasks: 3 merged, 1 converging (in-flight), 1 blocked (no PR).
-  addTask(db, plan, 0, "opened", 0, { pr_key: "o/r#10", url: "https://gh/10", status: "merged", process_key: "P10" });
-  addTask(db, plan, 1, "opened", 0, { pr_key: "o/r#11", url: "https://gh/11", status: "merged", process_key: "P11" });
-  addTask(db, plan, 2, "opened", 0, { pr_key: "o/r#12", url: "https://gh/12", status: "merged", process_key: "P12" });
-  addTask(db, plan, 3, "opened", 0, { pr_key: "o/r#13", url: "https://gh/13", status: "converging", process_key: "P13" });
-  addTask(db, plan, 4, "blocked", 0);
-  // Wave 1 — an escalated slice (with a draft PR) and a skipped slice.
-  addTask(db, plan, 5, "escalated", 1, { pr_key: "o/r#14", url: "https://gh/14", status: "escalated", process_key: "P14" });
-  addTask(db, plan, 6, "skipped", 1);
-
-  const rows = db
-    .prepare("SELECT * FROM plan_wave_summary WHERE plan_key = ? ORDER BY wave")
-    .all(plan) as Array<Record<string, unknown>>;
-  assertEquals(rows.length, 2);
-
-  const w0 = rows[0];
-  assertEquals(w0.total, 5);
-  assertEquals(w0.merged, 3);
-  assertEquals(w0.in_flight, 1);
-  assertEquals(w0.blocked, 1);
-  assertEquals(w0.escalated, 0);
-  assertEquals(w0.skipped, 0);
-  // 3 filled + 2 empty glyphs (width = total), then the named non-zero categories.
-  assertEquals(w0.bar, "▓▓▓░░ 3/5 merged · 1 in-flight · 1 blocked");
-
-  const w1 = rows[1];
-  assertEquals(w1.total, 2);
-  assertEquals(w1.merged, 0);
-  assertEquals(w1.in_flight, 0);
-  assertEquals(w1.escalated, 1);
-  assertEquals(w1.skipped, 1);
-  assertEquals(w1.bar, "░░ 0/2 merged · 1 escalated · 1 skipped");
-});
-
-test("a merged PR wins over the task's own status, and unlevelized tasks are excluded", () => {
-  const db = viewDb();
-  const plan = "o/r#2";
-  // An escalated task whose PR nonetheless merged counts as merged, not escalated (PR wins).
-  addTask(db, plan, 0, "escalated", 0, { pr_key: "o/r#20", url: "https://gh/20", status: "merged", process_key: "P20" });
-  // A task with no wave yet (not levelized) must not appear in any wave row.
-  db.prepare(
-    "INSERT INTO plan_tasks (plan_key, task_index, task_id, status, wave) VALUES (?, ?, ?, ?, NULL)",
-  ).run(plan, 1, "t1", "pending");
-
-  const rows = db
-    .prepare("SELECT wave, total, merged, escalated FROM plan_wave_summary WHERE plan_key = ?")
-    .all(plan) as Array<Record<string, unknown>>;
-  assertEquals(rows.length, 1);
-  assertEquals(rows[0].wave, 0);
-  assertEquals(rows[0].total, 1);
-  assertEquals(rows[0].merged, 1);
-  assertEquals(rows[0].escalated, 0);
-});
-
-test("plan_wave_tasks carries each task's PR url + process_key link targets", () => {
-  const db = viewDb();
-  addTask(db, "o/r#3", 0, "opened", 0, { pr_key: "o/r#30", url: "https://gh/30", status: "converging", process_key: "P30" });
-  addTask(db, "o/r#3", 1, "blocked", 0); // no PR → null link targets
-
-  const rows = db
-    .prepare("SELECT task_id, pr_key, pr_url, process_key FROM plan_wave_tasks WHERE plan_key = ? ORDER BY task_index")
-    .all("o/r#3") as Array<Record<string, unknown>>;
-  assertEquals(rows[0].pr_url, "https://gh/30");
-  assertEquals(rows[0].process_key, "P30");
-  assertEquals(rows[1].pr_url, null);
-  assertEquals(rows[1].process_key, null);
-});
-
-test("epic-detail projects the wave banner, the per-wave summary, and task→representation links", () => {
-  const page = JSON.parse(readFileSync(PAGE, "utf8"));
-  const byId = (id: string) => page.nodes.find((n: { id: string }) => n.id === id);
-
-  // 1. The epic-level wave banner: a prose node reading wave_label + epic_phase off the derived
-  //    `plan_read_model` VIEW (epic #412 — retiring the worker-maintained plans.wave_label column;
-  //    the banner now reads the single-source-of-truth view instead of the raw `plans` table).
-  const banner = byId("wave-banner");
-  assert(banner, "epic detail must show the epic-level wave banner");
-  assertEquals(banner.props.data.table, "plan_read_model");
-  assert(
-    banner.props.data.filter.some((f: { field: string; eqParam?: boolean }) => f.field === "plan_key" && f.eqParam),
-    "the banner is scoped to this epic",
-  );
-  assert(/\{\{\s*wave_label\s*\}\}/.test(banner.props.header), "the banner surfaces the wave_label");
-  assert(/\{\{\s*epic_phase\s*\}\}/.test(banner.props.header), "the banner surfaces the epic phase");
-
-  // 2. The per-wave summary section: a grid over the derived VIEW, ordered by wave, with the bar.
-  const summary = byId("wave-summary");
-  assert(summary, "epic detail must show the per-wave progress summary");
-  assertEquals(summary.props.data.table, "plan_wave_summary");
-  assertEquals(summary.props.data.orderBy.field, "wave");
-  const summaryCols: string[] = summary.props.columns.map((c: { field: string }) => c.field);
-  for (const f of ["wave", "bar", "merged", "in_flight", "blocked", "escalated", "skipped", "total"]) {
-    assert(summaryCols.includes(f), `the summary grid shows ${f}`);
-  }
-
-  // 3. The wave-state grid links each in-flight task to its representation (PR + process instance).
-  const waveState = byId("wave-state");
-  assert(waveState, "epic detail must keep the wave-state grid");
-  assertEquals(waveState.props.data.table, "plan_wave_tasks");
-  const cols: Array<Record<string, unknown>> = waveState.props.columns;
-  const prCol = cols.find((c) => c.field === "pr_key");
-  assertEquals(prCol?.linkField, "pr_url", "the PR cell links to the GitHub PR url");
-  const statusCol = cols.find((c) => c.field === "status") as {
-    link?: { kind?: string; keyField?: string };
-  };
-  assertEquals(statusCol.link?.kind, "processExplorer", "the status cell links to the process instance");
-  assertEquals(statusCol.link?.keyField, "process_key");
-  // The existing tabs (Active / Skipped / All) and detail drawer must still be present.
-  assertEquals(waveState.props.tabs.length, 3);
-  const detailFields: string[] = waveState.props.detail.fields.map((f: { field: string }) => f.field);
-  for (const f of ["open_question", "answer", "draft_pr_key", "prompt"]) {
-    assert(detailFields.includes(f), `the detail drawer keeps ${f}`);
-  }
-});