@nanobpm/nano-workforce 0.122.0 → 0.123.1

package/app/featureGateway.test.ts

@@ -1,202 +0,0 @@
-// Tests for the feature_runs gateway's write-time pipeline projection (issue #254 §1/§3) and the
-// one-shot backfill. The gateway wraps the plain table so EVERY writer — no matter which module —
-// automatically gets a fresh `stage`/`stage_state`/`stage_skipped`/`attention`/`list_bucket`
-// projection, without passing them: the single write path is the only place `deriveStage` /
-// `deriveListBucket` are applied.
-import { test } from "node:test";
-import { assert, assertEquals } from "#test-assert";
-import type { DataLayer } from "@nanobpm/urban";
-import { backfillFeatureStages, featureRuns } from "./feature.ts";
-
-// An in-memory record gateway with the same semantics the real Table exposes (get/all/find/insert/
-// update). The featureRuns proxy wraps whatever data.table returns, so this exercises the real proxy.
-function memData(): { data: DataLayer; rows: any[] } {
-  const rows: any[] = [];
-  function tbl(_name: string, pk = "id") {
-    const match = (r: any, where: any) => Object.entries(where).every(([k, v]) => r[k] === v);
-    return {
-      async all() {
-        return rows.slice();
-      },
-      async get(id: any) {
-        return rows.find((r) => r[pk] === id);
-      },
-      async find(where: any = {}) {
-        return rows.filter((r) => match(r, where));
-      },
-      async insert(row: any) {
-        rows.push({ ...row });
-        return row[pk];
-      },
-      async update(id: any, patch: any) {
-        const r = rows.find((row) => row[pk] === id);
-        if (r) Object.assign(r, patch);
-        return r ? 1 : 0;
-      },
-    };
-  }
-  const data = { table: (n: string, pk?: string) => tbl(n, pk) } as any as DataLayer;
-  return { data, rows };
-}
-
-test("update with only {status:'opened'} projects PR open / null / active without the caller passing them", async () => {
-  const { data, rows } = memData();
-  rows.push({ feature_key: "o/r#1", status: "running", pr_key: null, converge: 1, auto_merge: 1 });
-  await featureRuns(data).update("o/r#1", { status: "opened" });
-  assertEquals(rows[0].stage, "PR open");
-  assertEquals(rows[0].stage_state, null);
-  assertEquals(rows[0].list_bucket, "active");
-});
-
-test("update {status:'failed'} projects Done / failed", async () => {
-  const { data, rows } = memData();
-  rows.push({ feature_key: "o/r#2", status: "running", converge: 1, auto_merge: 1 });
-  await featureRuns(data).update("o/r#2", { status: "failed" });
-  assertEquals(rows[0].stage, "Done");
-  assertEquals(rows[0].stage_state, "failed");
-});
-
-test("update {status:'blocked'} projects Done / blocked", async () => {
-  const { data, rows } = memData();
-  rows.push({ feature_key: "o/r#3", status: "running", converge: 1, auto_merge: 1 });
-  await featureRuns(data).update("o/r#3", { status: "blocked" });
-  assertEquals(rows[0].stage, "Done");
-  assertEquals(rows[0].stage_state, "blocked");
-});
-
-test("update {status:'escalated'} on a row with no pr_key projects Implementing / null", async () => {
-  const { data, rows } = memData();
-  rows.push({ feature_key: "o/r#4", status: "running", pr_key: null, converge: 1, auto_merge: 1 });
-  await featureRuns(data).update("o/r#4", { status: "escalated" });
-  assertEquals(rows[0].stage, "Implementing");
-  assertEquals(rows[0].stage_state, null);
-});
-
-test("a run with converge=false projects stage_skipped containing Converging and Merging", async () => {
-  const { data, rows } = memData();
-  rows.push({ feature_key: "o/r#5", status: "running", converge: 0, auto_merge: 0 });
-  await featureRuns(data).update("o/r#5", { status: "running" });
-  assert(rows[0].stage_skipped.includes("Converging"));
-  assert(rows[0].stage_skipped.includes("Merging"));
-});
-
-test("insert projects the pipeline columns from status", async () => {
-  const { data, rows } = memData();
-  await featureRuns(data).insert({ feature_key: "o/r#6", status: "running", converge: 1, auto_merge: 1 } as any);
-  assertEquals(rows[0].stage, "Implementing");
-  assertEquals(rows[0].stage_state, null);
-  assertEquals(rows[0].list_bucket, "active");
-});
-
-test("setting acknowledged_at on a terminal row flips list_bucket to 'history'", async () => {
-  const { data, rows } = memData();
-  rows.push({ feature_key: "o/r#7", status: "merged", converge: 1, auto_merge: 1, acknowledged_at: null });
-  // Terminal but unacknowledged → still Active.
-  await featureRuns(data).update("o/r#7", { status: "merged" });
-  assertEquals(rows[0].list_bucket, "active");
-  // Acknowledge → History.
-  await featureRuns(data).update("o/r#7", { acknowledged_at: "2024-01-01T00:00:00Z" });
-  assertEquals(rows[0].list_bucket, "history");
-  assertEquals(rows[0].stage, "Done");
-});
-
-test("update touching only projection-irrelevant fields skips the read-back and reproject", async () => {
-  const { data, rows } = memData();
-  rows.push({
-    feature_key: "o/r#skip",
-    status: "merged",
-    converge: 1,
-    auto_merge: 1,
-    acknowledged_at: null,
-    stage: "Done",
-    stage_state: "ok",
-    stage_skipped: "",
-    attention: null,
-    list_bucket: "active",
-  });
-  // Count get() calls to prove the projection-irrelevant path does no read-back roundtrip.
-  let gets = 0;
-  const raw = (data as any).table;
-  (data as any).table = (n: string, pk?: string) => {
-    const t = raw(n, pk);
-    const origGet = t.get;
-    t.get = async (id: any) => {
-      gets++;
-      return origGet.call(t, id);
-    };
-    return t;
-  };
-  await featureRuns(data).update("o/r#skip", { updated_at: "2024-06-01T00:00:00Z" });
-  assertEquals(gets, 0);
-  assertEquals(rows[0].updated_at, "2024-06-01T00:00:00Z");
-  // Untouched projection stays as stored.
-  assertEquals(rows[0].list_bucket, "active");
-
-  // A projection-input change (acknowledged_at) DOES read back and reproject.
-  await featureRuns(data).update("o/r#skip", { acknowledged_at: "2024-06-01T00:00:00Z" });
-  assertEquals(gets, 1);
-  assertEquals(rows[0].list_bucket, "history");
-});
-
-test("a direct write of a projection output field forces reprojection and overrides the raw value", async () => {
-  const { data, rows } = memData();
-  rows.push({
-    feature_key: "o/r#bypass",
-    status: "running",
-    pr_key: null,
-    converge: 1,
-    auto_merge: 1,
-    stage: "Implementing",
-    stage_state: null,
-    list_bucket: "active",
-  });
-  // A caller tries to bypass derivation by writing the derived column directly. The gateway must NOT
-  // persist the raw value: it re-reads, recomputes from the merged inputs, and overrides it.
-  await featureRuns(data).update("o/r#bypass", { stage: "Done", list_bucket: "history" });
-  assertEquals(rows[0].stage, "Implementing");
-  assertEquals(rows[0].list_bucket, "active");
-});
-
-test("backfillFeatureStages stamps legacy terminal and live rows with helper-derived values", async () => {
-  const { data, rows } = memData();
-  // Legacy rows written before migration 039 → projection columns absent/NULL.
-  rows.push({ feature_key: "o/r#8", status: "merged", converge: 1, auto_merge: 1, acknowledged_at: "2024-01-01T00:00:00Z" });
-  rows.push({ feature_key: "o/r#9", status: "running", pr_key: null, converge: 0, auto_merge: 0 });
-  // A legacy row parked at a LIVE escalation: its projection columns are absent/NULL, so backfill MUST
-  // reproject its pipeline stage (issue #254). Issue #332 dropped the escalation_* denormalisation.
-  rows.push({ feature_key: "o/r#esc", status: "escalated", pr_key: null, converge: 1, auto_merge: 1 });
-
-  const stamped = await backfillFeatureStages(data);
-  assertEquals(stamped, 3);
-
-  const terminal = rows.find((r) => r.feature_key === "o/r#8");
-  assertEquals(terminal.stage, "Done");
-  assertEquals(terminal.stage_state, "ok");
-  assertEquals(terminal.list_bucket, "history");
-
-  const live = rows.find((r) => r.feature_key === "o/r#9");
-  assertEquals(live.stage, "Implementing");
-  assertEquals(live.stage_state, null);
-  assertEquals(live.stage_skipped, "Converging Merging");
-  assertEquals(live.list_bucket, "active");
-
-  const escalated = rows.find((r) => r.feature_key === "o/r#esc");
-  assertEquals(escalated.stage, "Implementing");
-  assertEquals(escalated.attention, "⚠");
-});
-
-test("backfillFeatureStages skips already-projected rows and counts only rows it stamps", async () => {
-  const { data, rows } = memData();
-  // One legacy row (no projection) + one already-projected row (gateway kept it fresh).
-  rows.push({ feature_key: "o/r#legacy", status: "merged", converge: 1, auto_merge: 1, acknowledged_at: null });
-  rows.push({ feature_key: "o/r#fresh", status: "merged", converge: 1, auto_merge: 1, acknowledged_at: null, stage: "Done", stage_state: "ok", stage_skipped: "", attention: null, list_bucket: "active", updated_at: "0" });
-
-  const stamped = await backfillFeatureStages(data);
-  // Only the legacy row is stamped; the already-projected row is skipped.
-  assertEquals(stamped, 1);
-  const legacy = rows.find((r) => r.feature_key === "o/r#legacy");
-  assertEquals(legacy.stage, "Done");
-  // The already-projected row was not re-written (its sentinel updated_at is untouched).
-  const fresh = rows.find((r) => r.feature_key === "o/r#fresh");
-  assertEquals(fresh.updated_at, "0");
-});

package/app/planGateway.test.ts

@@ -1,112 +0,0 @@
-// Tests for the `plans` gateway's write-time epic-bucket projection (issue #298) and its one-shot
-// backfill. The gateway wraps the plain table so EVERY writer — startPlan, the record workers, the
-// acknowledge-epic op — automatically gets a fresh `list_bucket`/`ack_open` projection without
-// passing them: the single write path is the only place `deriveEpicBucket` / `epicIsAcknowledgeable`
-// are applied. Mirrors app/featureGateway.test.ts.
-//
-// Since epic #412 retired the stored `plans.delivery` column, the gateway projects with `delivery`
-// treated as UNKNOWN (null): `list_bucket` is provably identical to the delivery-aware value for
-// every reachable state, and `ack_open` becomes a *candidate* (any unacknowledged `done` epic) that
-// the `pollPlanBucket` read-model pass (implemented in app/service.ts, tested in app/delivery.test.ts)
-// corrects with the read-time signal.
-import { test } from "node:test";
-import { assert, assertEquals } from "#test-assert";
-import type { DataLayer } from "@nanobpm/urban";
-import { backfillPlanBuckets, plans } from "./plan.ts";
-
-// In-memory record gateway with the same semantics the real Table exposes. The `plans` proxy wraps
-// whatever data.table returns, so this exercises the real proxy.
-function memData(): { data: DataLayer; rows: any[] } {
-  const rows: any[] = [];
-  function tbl(_name: string, pk = "id") {
-    const match = (r: any, where: any) => Object.entries(where).every(([k, v]) => r[k] === v);
-    return {
-      async all() {
-        return rows.slice();
-      },
-      async get(id: any) {
-        return rows.find((r) => r[pk] === id);
-      },
-      async find(where: any = {}) {
-        return rows.filter((r) => match(r, where));
-      },
-      async insert(row: any) {
-        rows.push({ ...row });
-        return row[pk];
-      },
-      async update(id: any, patch: any) {
-        const r = rows.find((row) => row[pk] === id);
-        if (r) Object.assign(r, patch);
-        return r ? 1 : 0;
-      },
-    };
-  }
-  const data = { table: (n: string, pk?: string) => tbl(n, pk) } as any as DataLayer;
-  return { data, rows };
-}
-
-test("insert projects list_bucket/ack_open from status without the caller passing them", async () => {
-  const { data, rows } = memData();
-  await plans(data).insert({ plan_key: "o/r#1", status: "planning" });
-  assertEquals(rows[0].list_bucket, "active");
-  assertEquals(rows[0].ack_open, 0);
-});
-
-test("status flip to done keeps the epic Active and marks a Dismiss candidate (delivery-free gateway)", async () => {
-  const { data, rows } = memData();
-  rows.push({ plan_key: "o/r#2", status: "dispatched" });
-  // record-results marks the epic done. The delivery-free gateway keeps it Active and — not seeing
-  // the read-time delivery signal — marks it a Dismiss candidate (ack_open=1); `pollPlanBucket`
-  // clears ack_open while the epic is still converging.
-  await plans(data).update("o/r#2", { status: "done" });
-  assertEquals(rows[0].list_bucket, "active");
-  assertEquals(rows[0].ack_open, 1);
-});
-
-test("acknowledging a done epic flips it to History and closes the Dismiss affordance", async () => {
-  const { data, rows } = memData();
-  await plans(data).insert({ plan_key: "o/r#3", status: "done" });
-  assertEquals(rows[0].list_bucket, "active");
-  assertEquals(rows[0].ack_open, 1);
-  // Operator dismisses → gateway reprojects to History, ack_open closes.
-  await plans(data).update("o/r#3", { acknowledged_at: "2024-01-01T00:00:00Z" });
-  assertEquals(rows[0].list_bucket, "history");
-  assertEquals(rows[0].ack_open, 0);
-});
-
-test("a projection-irrelevant patch (epic_phase only) does not disturb the stored bucket", async () => {
-  const { data, rows } = memData();
-  rows.push({ plan_key: "o/r#4", status: "done", list_bucket: "active", ack_open: 1 });
-  await plans(data).update("o/r#4", { epic_phase: "Finalizing" });
-  assertEquals(rows[0].list_bucket, "active");
-  assertEquals(rows[0].ack_open, 1);
-});
-
-test("a direct write to list_bucket is overridden by the canonical derivation (no bypass)", async () => {
-  const { data, rows } = memData();
-  rows.push({ plan_key: "o/r#5", status: "done" });
-  // A caller tries to force History; the gateway re-derives from status (delivery-free) and overrides it.
-  await plans(data).update("o/r#5", { list_bucket: "history" });
-  assertEquals(rows[0].list_bucket, "active");
-});
-
-test("backfillPlanBuckets stamps only legacy (NULL list_bucket) rows, idempotently", async () => {
-  const { data, rows } = memData();
-  rows.push({ plan_key: "o/r#legacy", status: "done", list_bucket: null, ack_open: null });
-  rows.push({ plan_key: "o/r#fresh", status: "planning", list_bucket: "active", ack_open: 0 });
-  const stamped = await backfillPlanBuckets(data);
-  assertEquals(stamped, 1);
-  assertEquals(rows[0].list_bucket, "active");
-  // Delivery-free gateway marks the done epic a Dismiss candidate; pollPlanBucket corrects it later.
-  assertEquals(rows[0].ack_open, 1);
-  // Second pass is a no-op: every row is now projected.
-  assertEquals(await backfillPlanBuckets(data), 0);
-});
-
-test("terminal failed epic buckets to History", async () => {
-  const { data, rows } = memData();
-  rows.push({ plan_key: "o/r#6", status: "dispatched" });
-  await plans(data).update("o/r#6", { status: "failed" });
-  assertEquals(rows[0].list_bucket, "history");
-  assert(!rows[0].ack_open);
-});