@namzu/sdk 0.4.2 → 0.4.3

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.4.3
+
+### Patch Changes
+
+- ddd0aad: Test-side hardening from ses_006 pre-freeze fix.
+
+  - **New test: `runtime/query/iteration/phases/advisory.test.ts`** — pins the advisory-phase mutation boundary where fired advisories inject user messages via `runMgr.pushMessage(createUserMessage(...))`. 13 assertions covering early-return paths, happy-path exactly-once calls, envelope format, warnings + decisions rendering, and trigger-selection semantics. Before this test a regression removing the `pushMessage` call at `advisory.ts:154` would pass typecheck, lint, the coverage gate, and every existing `src/advisory/*` test. It now fails deterministically.
+  - **`LogLevel` gains `'silent'`** — purely additive; the value short-circuits every `log()` call. Used by the SDK's vitest setup to suppress unmocked `getRootLogger()` stderr writes so GitHub Actions stops annotating `[ERROR]`-level log lines as workflow errors. Consumer impact: zero unless you pass `'silent'` to `configureLogger()` yourself.
+  - No runtime behavior change. No public surface additions beyond the one `LogLevel` union member.
+
 ## 0.4.2
 
 ### Patch Changes

package/dist/advisory/context.test.d.ts

@@ -0,0 +1,16 @@
+/**
+ * Current-code invariants asserted (2026-04-21, ses_006 Phase 6):
+ *
+ *   - `AdvisoryContext` composes a registry + executor + evaluator +
+ *     optional budget. It is a dumb container + a call-history log.
+ *   - `recordCall(record)` appends to `callHistory` in call order.
+ *   - `getBudgetStatus()`:
+ *     - `used` = `callHistory.length`.
+ *     - `total` = `budget?.maxCallsPerRun` (undefined when no budget).
+ *     - `remaining` = total − used when total defined; undefined else.
+ *   - `checkBudget()`:
+ *     - Allowed when no budget OR remaining > 0.
+ *     - Denied with reason when remaining ≤ 0.
+ */
+export {};
+//# sourceMappingURL=context.test.d.ts.map

package/dist/advisory/context.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"context.test.d.ts","sourceRoot":"","sources":["../../src/advisory/context.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;GAaG"}

package/dist/advisory/context.test.js

@@ -0,0 +1,92 @@
+/**
+ * Current-code invariants asserted (2026-04-21, ses_006 Phase 6):
+ *
+ *   - `AdvisoryContext` composes a registry + executor + evaluator +
+ *     optional budget. It is a dumb container + a call-history log.
+ *   - `recordCall(record)` appends to `callHistory` in call order.
+ *   - `getBudgetStatus()`:
+ *     - `used` = `callHistory.length`.
+ *     - `total` = `budget?.maxCallsPerRun` (undefined when no budget).
+ *     - `remaining` = total − used when total defined; undefined else.
+ *   - `checkBudget()`:
+ *     - Allowed when no budget OR remaining > 0.
+ *     - Denied with reason when remaining ≤ 0.
+ */
+import { describe, expect, it } from 'vitest';
+import { AdvisoryContext } from './context.js';
+function stubRegistry() {
+    return {};
+}
+function stubExecutor() {
+    return {};
+}
+function stubEvaluator() {
+    return {};
+}
+function callRecord(id) {
+    return {
+        advisorId: id,
+        request: { question: 'q' },
+        result: { advice: 'a' },
+        usage: {
+            promptTokens: 0,
+            completionTokens: 0,
+            totalTokens: 0,
+            cachedTokens: 0,
+            cacheWriteTokens: 0,
+        },
+        cost: { inputCostPer1M: 0, outputCostPer1M: 0, totalCost: 0, cacheDiscount: 0 },
+        durationMs: 0,
+        iteration: 0,
+        timestamp: Date.now(),
+    };
+}
+describe('AdvisoryContext', () => {
+    it('starts with empty callHistory', () => {
+        const ctx = new AdvisoryContext(stubRegistry(), stubExecutor(), stubEvaluator());
+        expect(ctx.callHistory).toEqual([]);
+    });
+    it('recordCall appends in order', () => {
+        const ctx = new AdvisoryContext(stubRegistry(), stubExecutor(), stubEvaluator());
+        ctx.recordCall(callRecord('a'));
+        ctx.recordCall(callRecord('b'));
+        expect(ctx.callHistory.map((r) => r.advisorId)).toEqual(['a', 'b']);
+    });
+    describe('getBudgetStatus', () => {
+        it('no budget → total + remaining undefined; used reflects history length', () => {
+            const ctx = new AdvisoryContext(stubRegistry(), stubExecutor(), stubEvaluator());
+            ctx.recordCall(callRecord('a'));
+            expect(ctx.getBudgetStatus()).toEqual({ used: 1, total: undefined, remaining: undefined });
+        });
+        it('with budget → total + remaining computed', () => {
+            const ctx = new AdvisoryContext(stubRegistry(), stubExecutor(), stubEvaluator(), {
+                maxCallsPerRun: 3,
+            });
+            ctx.recordCall(callRecord('a'));
+            expect(ctx.getBudgetStatus()).toEqual({ used: 1, total: 3, remaining: 2 });
+        });
+    });
+    describe('checkBudget', () => {
+        it('allowed when no budget', () => {
+            const ctx = new AdvisoryContext(stubRegistry(), stubExecutor(), stubEvaluator());
+            expect(ctx.checkBudget()).toEqual({ allowed: true });
+        });
+        it('allowed when remaining > 0', () => {
+            const ctx = new AdvisoryContext(stubRegistry(), stubExecutor(), stubEvaluator(), {
+                maxCallsPerRun: 2,
+            });
+            ctx.recordCall(callRecord('a'));
+            expect(ctx.checkBudget()).toEqual({ allowed: true });
+        });
+        it('denied when remaining <= 0', () => {
+            const ctx = new AdvisoryContext(stubRegistry(), stubExecutor(), stubEvaluator(), {
+                maxCallsPerRun: 1,
+            });
+            ctx.recordCall(callRecord('a'));
+            const result = ctx.checkBudget();
+            expect(result.allowed).toBe(false);
+            expect(result.reason).toMatch(/budget exhausted/);
+        });
+    });
+});
+//# sourceMappingURL=context.test.js.map

package/dist/advisory/context.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"context.test.js","sourceRoot":"","sources":["../../src/advisory/context.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;GAaG;AAEH,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAA;AAI7C,OAAO,EAAE,eAAe,EAAE,MAAM,cAAc,CAAA;AAK9C,SAAS,YAAY;IACpB,OAAO,EAAgC,CAAA;AACxC,CAAC;AAED,SAAS,YAAY;IACpB,OAAO,EAAiC,CAAA;AACzC,CAAC;AAED,SAAS,aAAa;IACrB,OAAO,EAAiC,CAAA;AACzC,CAAC;AAED,SAAS,UAAU,CAAC,EAAU;IAC7B,OAAO;QACN,SAAS,EAAE,EAAE;QACb,OAAO,EAAE,EAAE,QAAQ,EAAE,GAAG,EAAE;QAC1B,MAAM,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE;QACvB,KAAK,EAAE;YACN,YAAY,EAAE,CAAC;YACf,gBAAgB,EAAE,CAAC;YACnB,WAAW,EAAE,CAAC;YACd,YAAY,EAAE,CAAC;YACf,gBAAgB,EAAE,CAAC;SACnB;QACD,IAAI,EAAE,EAAE,cAAc,EAAE,CAAC,EAAE,eAAe,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,aAAa,EAAE,CAAC,EAAE;QAC/E,UAAU,EAAE,CAAC;QACb,SAAS,EAAE,CAAC;QACZ,SAAS,EAAE,IAAI,CAAC,GAAG,EAAE;KACrB,CAAA;AACF,CAAC;AAED,QAAQ,CAAC,iBAAiB,EAAE,GAAG,EAAE;IAChC,EAAE,CAAC,+BAA+B,EAAE,GAAG,EAAE;QACxC,MAAM,GAAG,GAAG,IAAI,eAAe,CAAC,YAAY,EAAE,EAAE,YAAY,EAAE,EAAE,aAAa,EAAE,CAAC,CAAA;QAChF,MAAM,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;IACpC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,6BAA6B,EAAE,GAAG,EAAE;QACtC,MAAM,GAAG,GAAG,IAAI,eAAe,CAAC,YAAY,EAAE,EAAE,YAAY,EAAE,EAAE,aAAa,EAAE,CAAC,CAAA;QAChF,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAA;QAC/B,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAA;QAC/B,MAAM,CAAC,GAAG,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,EAAE,GAAG,CAAC,CAAC,CAAA;IACpE,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,iBAAiB,EAAE,GAAG,EAAE;QAChC,EAAE,CAAC,uEAAuE,EAAE,GAAG,EAAE;YAChF,MAAM,GAAG,GAAG,IAAI,eAAe,CAAC,YAAY,EAAE,EAAE,YAAY,EAAE,EAAE,aAAa,EAAE,CAAC,CAAA;YAChF,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAA;YAC/B,MAAM,CAAC,GAAG,CAAC,eAAe,EAAE,CAAC,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,KAAK,EAAE,SAAS,EAAE,SAAS,EAAE,SAAS,EAAE,CAAC,CAAA;QAC3F,CAAC,CAAC,CAAA;QAEF,EAAE,CAAC,0CAA0C,EAAE,GAAG,EAAE;YACnD,MAAM,GAAG,GAAG,IAAI,eAAe,CAAC,YAAY,EAAE,EAAE,YAAY,EAAE,EAAE,aAAa,EAAE,EAAE;gBAChF,cAAc,EAAE,CAAC;aACjB,CAAC,CAAA;YACF,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAA;YAC/B,MAAM,CAAC,GAAG,CAAC,eAAe,EAAE,CAAC,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,KAAK,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC,CAAA;QAC3E,CAAC,CAAC,CAAA;IACH,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,aAAa,EAAE,GAAG,EAAE;QAC5B,EAAE,CAAC,wBAAwB,EAAE,GAAG,EAAE;YACjC,MAAM,GAAG,GAAG,IAAI,eAAe,CAAC,YAAY,EAAE,EAAE,YAAY,EAAE,EAAE,aAAa,EAAE,CAAC,CAAA;YAChF,MAAM,CAAC,GAAG,CAAC,WAAW,EAAE,CAAC,CAAC,OAAO,CAAC,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CAAA;QACrD,CAAC,CAAC,CAAA;QAEF,EAAE,CAAC,4BAA4B,EAAE,GAAG,EAAE;YACrC,MAAM,GAAG,GAAG,IAAI,eAAe,CAAC,YAAY,EAAE,EAAE,YAAY,EAAE,EAAE,aAAa,EAAE,EAAE;gBAChF,cAAc,EAAE,CAAC;aACjB,CAAC,CAAA;YACF,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAA;YAC/B,MAAM,CAAC,GAAG,CAAC,WAAW,EAAE,CAAC,CAAC,OAAO,CAAC,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CAAA;QACrD,CAAC,CAAC,CAAA;QAEF,EAAE,CAAC,4BAA4B,EAAE,GAAG,EAAE;YACrC,MAAM,GAAG,GAAG,IAAI,eAAe,CAAC,YAAY,EAAE,EAAE,YAAY,EAAE,EAAE,aAAa,EAAE,EAAE;gBAChF,cAAc,EAAE,CAAC;aACjB,CAAC,CAAA;YACF,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAA;YAC/B,MAAM,MAAM,GAAG,GAAG,CAAC,WAAW,EAAE,CAAA;YAChC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;YAClC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC,kBAAkB,CAAC,CAAA;QAClD,CAAC,CAAC,CAAA;IACH,CAAC,CAAC,CAAA;AACH,CAAC,CAAC,CAAA"}

package/dist/advisory/evaluator.test.d.ts

@@ -0,0 +1,34 @@
+/**
+ * Current-code invariants asserted (2026-04-21, ses_006 Phase 6):
+ *
+ *   - Constructor filters OUT triggers with `enabled: false` + sorts
+ *     by `priority` desc (higher first). Triggers without priority
+ *     sort at 0.
+ *   - `evaluate(state)` returns every trigger whose condition matches
+ *     AND whose cooldown has elapsed. Order reflects the sorted
+ *     trigger list.
+ *   - Budget exhausted (callCount ≥ maxCallsPerRun) → evaluate returns [].
+ *   - `recordFiring(id, iteration)` updates both `lastFiredMap` (for
+ *     cooldown) and `callCount` (for budget).
+ *   - Condition matchers:
+ *     - `on_error`: matches iff state.lastError is set; if categories
+ *       are given, requires at least one category substring match.
+ *     - `on_iteration`: `state.iteration % everyN === 0`.
+ *     - `on_context_percent`: `state.contextWindowPercent >= threshold`.
+ *     - `on_tool_category`: `state.lastToolCategory` present + in
+ *       `condition.categories`.
+ *     - `on_cost_percent`: costBudgetPercent present + ≥ threshold.
+ *     - `on_complexity`: totalToolCalls ≥ toolCallThreshold.
+ *     - `custom`: calls the predicate.
+ *   - Cooldown: trigger does NOT fire if `iteration - lastFired <
+ *     cooldownIterations`. No cooldown → always eligible.
+ *
+ *   - **Purity:** evaluate() is pure relative to the advisory phase —
+ *     it returns triggers; it does NOT inject messages or mutate
+ *     external state. The injection happens in the advisory phase
+ *     (runtime/query/iteration/phases/advisory.ts), which pushes a
+ *     user message via `runMgr.pushMessage`. That file is OUT of
+ *     scope for this test file (covered by the phase test).
+ */
+export {};
+//# sourceMappingURL=evaluator.test.d.ts.map

package/dist/advisory/evaluator.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"evaluator.test.d.ts","sourceRoot":"","sources":["../../src/advisory/evaluator.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA+BG"}

package/dist/advisory/evaluator.test.js

@@ -0,0 +1,172 @@
+/**
+ * Current-code invariants asserted (2026-04-21, ses_006 Phase 6):
+ *
+ *   - Constructor filters OUT triggers with `enabled: false` + sorts
+ *     by `priority` desc (higher first). Triggers without priority
+ *     sort at 0.
+ *   - `evaluate(state)` returns every trigger whose condition matches
+ *     AND whose cooldown has elapsed. Order reflects the sorted
+ *     trigger list.
+ *   - Budget exhausted (callCount ≥ maxCallsPerRun) → evaluate returns [].
+ *   - `recordFiring(id, iteration)` updates both `lastFiredMap` (for
+ *     cooldown) and `callCount` (for budget).
+ *   - Condition matchers:
+ *     - `on_error`: matches iff state.lastError is set; if categories
+ *       are given, requires at least one category substring match.
+ *     - `on_iteration`: `state.iteration % everyN === 0`.
+ *     - `on_context_percent`: `state.contextWindowPercent >= threshold`.
+ *     - `on_tool_category`: `state.lastToolCategory` present + in
+ *       `condition.categories`.
+ *     - `on_cost_percent`: costBudgetPercent present + ≥ threshold.
+ *     - `on_complexity`: totalToolCalls ≥ toolCallThreshold.
+ *     - `custom`: calls the predicate.
+ *   - Cooldown: trigger does NOT fire if `iteration - lastFired <
+ *     cooldownIterations`. No cooldown → always eligible.
+ *
+ *   - **Purity:** evaluate() is pure relative to the advisory phase —
+ *     it returns triggers; it does NOT inject messages or mutate
+ *     external state. The injection happens in the advisory phase
+ *     (runtime/query/iteration/phases/advisory.ts), which pushes a
+ *     user message via `runMgr.pushMessage`. That file is OUT of
+ *     scope for this test file (covered by the phase test).
+ */
+import { describe, expect, it, vi } from 'vitest';
+import { TriggerEvaluator } from './evaluator.js';
+function trigger(id, overrides = {}) {
+    return {
+        id,
+        condition: { type: 'on_iteration', everyN: 1 },
+        ...overrides,
+    };
+}
+function state(overrides = {}) {
+    return {
+        iteration: 1,
+        totalToolCalls: 0,
+        totalTokens: 0,
+        contextWindowPercent: 0,
+        totalCostUsd: 0,
+        costBudgetPercent: undefined,
+        lastError: undefined,
+        lastToolCategory: undefined,
+        advisoryCallCount: 0,
+        ...overrides,
+    };
+}
+describe('TriggerEvaluator — constructor', () => {
+    it('filters out triggers with enabled: false', () => {
+        const e = new TriggerEvaluator([trigger('a'), trigger('b', { enabled: false })]);
+        expect(e.evaluate(state()).map((t) => t.id)).toEqual(['a']);
+    });
+    it('sorts triggers by priority descending', () => {
+        const e = new TriggerEvaluator([
+            trigger('low', { priority: 1 }),
+            trigger('high', { priority: 10 }),
+            trigger('mid', { priority: 5 }),
+        ]);
+        expect(e.evaluate(state()).map((t) => t.id)).toEqual(['high', 'mid', 'low']);
+    });
+});
+describe('TriggerEvaluator — budget', () => {
+    it('returns [] when callCount >= maxCallsPerRun', () => {
+        const e = new TriggerEvaluator([trigger('a')], { maxCallsPerRun: 1 });
+        e.recordFiring('a', 1);
+        expect(e.evaluate(state({ iteration: 2 }))).toEqual([]);
+    });
+    it('ignores budget when maxCallsPerRun is not set', () => {
+        const e = new TriggerEvaluator([trigger('a')]);
+        e.recordFiring('a', 1);
+        e.recordFiring('a', 2);
+        expect(e.evaluate(state({ iteration: 3 })).length).toBeGreaterThan(0);
+    });
+});
+describe('TriggerEvaluator — cooldown', () => {
+    it('blocks triggers in their cooldown window', () => {
+        const e = new TriggerEvaluator([trigger('a', { cooldownIterations: 3 })]);
+        e.recordFiring('a', 1);
+        expect(e.evaluate(state({ iteration: 2 })).map((t) => t.id)).toEqual([]);
+        expect(e.evaluate(state({ iteration: 3 })).map((t) => t.id)).toEqual([]);
+        expect(e.evaluate(state({ iteration: 4 })).map((t) => t.id)).toEqual(['a']);
+    });
+    it('always fires when no cooldown is configured', () => {
+        const e = new TriggerEvaluator([trigger('a')]);
+        e.recordFiring('a', 1);
+        expect(e.evaluate(state({ iteration: 2 })).map((t) => t.id)).toEqual(['a']);
+    });
+});
+describe('TriggerEvaluator — condition matchers', () => {
+    it('on_error: requires lastError to be set', () => {
+        const e = new TriggerEvaluator([trigger('t', { condition: { type: 'on_error' } })]);
+        expect(e.evaluate(state())).toEqual([]);
+        expect(e.evaluate(state({ lastError: 'boom' })).map((t) => t.id)).toEqual(['t']);
+    });
+    it('on_error with categories: at least one substring match', () => {
+        const e = new TriggerEvaluator([
+            trigger('t', { condition: { type: 'on_error', categories: ['timeout', 'permission'] } }),
+        ]);
+        expect(e.evaluate(state({ lastError: 'Connection timeout' })).map((t) => t.id)).toEqual(['t']);
+        expect(e.evaluate(state({ lastError: 'Syntax error' }))).toEqual([]);
+    });
+    it('on_iteration: iteration % everyN === 0', () => {
+        const e = new TriggerEvaluator([
+            trigger('t', { condition: { type: 'on_iteration', everyN: 3 } }),
+        ]);
+        expect(e.evaluate(state({ iteration: 1 }))).toEqual([]);
+        expect(e.evaluate(state({ iteration: 3 })).map((t) => t.id)).toEqual(['t']);
+        expect(e.evaluate(state({ iteration: 6 })).map((t) => t.id)).toEqual(['t']);
+    });
+    it('on_context_percent: contextWindowPercent >= threshold', () => {
+        const e = new TriggerEvaluator([
+            trigger('t', { condition: { type: 'on_context_percent', threshold: 80 } }),
+        ]);
+        expect(e.evaluate(state({ contextWindowPercent: 70 }))).toEqual([]);
+        expect(e.evaluate(state({ contextWindowPercent: 80 })).map((t) => t.id)).toEqual(['t']);
+    });
+    it('on_tool_category: lastToolCategory present + in categories list', () => {
+        const e = new TriggerEvaluator([
+            trigger('t', {
+                condition: { type: 'on_tool_category', categories: ['network', 'filesystem'] },
+            }),
+        ]);
+        expect(e.evaluate(state())).toEqual([]);
+        expect(e.evaluate(state({ lastToolCategory: 'other' }))).toEqual([]);
+        expect(e.evaluate(state({ lastToolCategory: 'network' })).map((t) => t.id)).toEqual(['t']);
+    });
+    it('on_cost_percent: costBudgetPercent present + >= threshold', () => {
+        const e = new TriggerEvaluator([
+            trigger('t', { condition: { type: 'on_cost_percent', threshold: 75 } }),
+        ]);
+        expect(e.evaluate(state())).toEqual([]); // undefined costBudgetPercent
+        expect(e.evaluate(state({ costBudgetPercent: 50 }))).toEqual([]);
+        expect(e.evaluate(state({ costBudgetPercent: 80 })).map((t) => t.id)).toEqual(['t']);
+    });
+    it('on_complexity: totalToolCalls >= toolCallThreshold', () => {
+        const e = new TriggerEvaluator([
+            trigger('t', { condition: { type: 'on_complexity', toolCallThreshold: 10 } }),
+        ]);
+        expect(e.evaluate(state({ totalToolCalls: 5 }))).toEqual([]);
+        expect(e.evaluate(state({ totalToolCalls: 10 })).map((t) => t.id)).toEqual(['t']);
+    });
+    it('custom: calls the predicate with state', () => {
+        const predicate = vi.fn(() => true);
+        const e = new TriggerEvaluator([trigger('t', { condition: { type: 'custom', predicate } })]);
+        const s = state({ iteration: 42 });
+        expect(e.evaluate(s).map((t) => t.id)).toEqual(['t']);
+        expect(predicate).toHaveBeenCalledWith(s);
+    });
+});
+describe('TriggerEvaluator — recordFiring', () => {
+    it('updates lastFiredMap + callCount', () => {
+        const e = new TriggerEvaluator([trigger('a', { cooldownIterations: 5 })], {
+            maxCallsPerRun: 2,
+        });
+        e.recordFiring('a', 1);
+        // cooldown active: no fires in iterations 2–5
+        expect(e.evaluate(state({ iteration: 2 }))).toEqual([]);
+        // cooldown lifted at 6, but budget allows one more
+        e.recordFiring('a', 6);
+        // budget exhausted
+        expect(e.evaluate(state({ iteration: 11 }))).toEqual([]);
+    });
+});
+//# sourceMappingURL=evaluator.test.js.map

package/dist/advisory/evaluator.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"evaluator.test.js","sourceRoot":"","sources":["../../src/advisory/evaluator.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA+BG;AAEH,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAA;AAIjD,OAAO,EAAE,gBAAgB,EAAE,MAAM,gBAAgB,CAAA;AAEjD,SAAS,OAAO,CAAC,EAAU,EAAE,YAAsC,EAAE;IACpE,OAAO;QACN,EAAE;QACF,SAAS,EAAE,EAAE,IAAI,EAAE,cAAc,EAAE,MAAM,EAAE,CAAC,EAAE;QAC9C,GAAG,SAAS;KACZ,CAAA;AACF,CAAC;AAED,SAAS,KAAK,CAAC,YAA6C,EAAE;IAC7D,OAAO;QACN,SAAS,EAAE,CAAC;QACZ,cAAc,EAAE,CAAC;QACjB,WAAW,EAAE,CAAC;QACd,oBAAoB,EAAE,CAAC;QACvB,YAAY,EAAE,CAAC;QACf,iBAAiB,EAAE,SAAS;QAC5B,SAAS,EAAE,SAAS;QACpB,gBAAgB,EAAE,SAAS;QAC3B,iBAAiB,EAAE,CAAC;QACpB,GAAG,SAAS;KACZ,CAAA;AACF,CAAC;AAED,QAAQ,CAAC,gCAAgC,EAAE,GAAG,EAAE;IAC/C,EAAE,CAAC,0CAA0C,EAAE,GAAG,EAAE;QACnD,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,EAAE,OAAO,CAAC,GAAG,EAAE,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC,CAAA;QAChF,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,EAAE,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,CAAA;IAC5D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;QAChD,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC;YAC9B,OAAO,CAAC,KAAK,EAAE,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC;YAC/B,OAAO,CAAC,MAAM,EAAE,EAAE,QAAQ,EAAE,EAAE,EAAE,CAAC;YACjC,OAAO,CAAC,KAAK,EAAE,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC;SAC/B,CAAC,CAAA;QACF,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,EAAE,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,MAAM,EAAE,KAAK,EAAE,KAAK,CAAC,CAAC,CAAA;IAC7E,CAAC,CAAC,CAAA;AACH,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,2BAA2B,EAAE,GAAG,EAAE;IAC1C,EAAE,CAAC,6CAA6C,EAAE,GAAG,EAAE;QACtD,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,cAAc,EAAE,CAAC,EAAE,CAAC,CAAA;QACrE,CAAC,CAAC,YAAY,CAAC,GAAG,EAAE,CAAC,CAAC,CAAA;QACtB,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;IACxD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;QACxD,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,CAAA;QAC9C,CAAC,CAAC,YAAY,CAAC,GAAG,EAAE,CAAC,CAAC,CAAA;QACtB,CAAC,CAAC,YAAY,CAAC,GAAG,EAAE,CAAC,CAAC,CAAA;QACtB,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAA;IACtE,CAAC,CAAC,CAAA;AACH,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,6BAA6B,EAAE,GAAG,EAAE;IAC5C,EAAE,CAAC,0CAA0C,EAAE,GAAG,EAAE;QACnD,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC,CAAC,OAAO,CAAC,GAAG,EAAE,EAAE,kBAAkB,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,CAAA;QACzE,CAAC,CAAC,YAAY,CAAC,GAAG,EAAE,CAAC,CAAC,CAAA;QACtB,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;QACxE,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;QACxE,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,CAAA;IAC5E,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,6CAA6C,EAAE,GAAG,EAAE;QACtD,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,CAAA;QAC9C,CAAC,CAAC,YAAY,CAAC,GAAG,EAAE,CAAC,CAAC,CAAA;QACtB,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,CAAA;IAC5E,CAAC,CAAC,CAAA;AACH,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,uCAAuC,EAAE,GAAG,EAAE;IACtD,EAAE,CAAC,wCAAwC,EAAE,GAAG,EAAE;QACjD,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC,CAAC,OAAO,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,EAAE,CAAC,CAAC,CAAC,CAAA;QACnF,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;QACvC,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,MAAM,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,CAAA;IACjF,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,wDAAwD,EAAE,GAAG,EAAE;QACjE,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC;YAC9B,OAAO,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,EAAE,IAAI,EAAE,UAAU,EAAE,UAAU,EAAE,CAAC,SAAS,EAAE,YAAY,CAAC,EAAE,EAAE,CAAC;SACxF,CAAC,CAAA;QACF,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,oBAAoB,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,CAAA;QAC9F,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,cAAc,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;IACrE,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,wCAAwC,EAAE,GAAG,EAAE;QACjD,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC;YAC9B,OAAO,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,EAAE,IAAI,EAAE,cAAc,EAAE,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;SAChE,CAAC,CAAA;QACF,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;QACvD,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,CAAA;QAC3E,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,CAAA;IAC5E,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;QAChE,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC;YAC9B,OAAO,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,EAAE,IAAI,EAAE,oBAAoB,EAAE,SAAS,EAAE,EAAE,EAAE,EAAE,CAAC;SAC1E,CAAC,CAAA;QACF,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,oBAAoB,EAAE,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;QACnE,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,oBAAoB,EAAE,EAAE,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,CAAA;IACxF,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,iEAAiE,EAAE,GAAG,EAAE;QAC1E,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC;YAC9B,OAAO,CAAC,GAAG,EAAE;gBACZ,SAAS,EAAE,EAAE,IAAI,EAAE,kBAAkB,EAAE,UAAU,EAAE,CAAC,SAAS,EAAE,YAAY,CAAC,EAAE;aAC9E,CAAC;SACF,CAAC,CAAA;QACF,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;QACvC,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,gBAAgB,EAAE,OAAO,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;QACpE,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,CAAA;IAC3F,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,2DAA2D,EAAE,GAAG,EAAE;QACpE,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC;YAC9B,OAAO,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,EAAE,IAAI,EAAE,iBAAiB,EAAE,SAAS,EAAE,EAAE,EAAE,EAAE,CAAC;SACvE,CAAC,CAAA;QACF,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA,CAAC,8BAA8B;QACtE,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,iBAAiB,EAAE,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;QAChE,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,iBAAiB,EAAE,EAAE,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,CAAA;IACrF,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC7D,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC;YAC9B,OAAO,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,EAAE,IAAI,EAAE,eAAe,EAAE,iBAAiB,EAAE,EAAE,EAAE,EAAE,CAAC;SAC7E,CAAC,CAAA;QACF,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,cAAc,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;QAC5D,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,cAAc,EAAE,EAAE,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,CAAA;IAClF,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,wCAAwC,EAAE,GAAG,EAAE;QACjD,MAAM,SAAS,GAAG,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,CAAA;QACnC,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC,CAAC,OAAO,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,SAAS,EAAE,EAAE,CAAC,CAAC,CAAC,CAAA;QAC5F,MAAM,CAAC,GAAG,KAAK,CAAC,EAAE,SAAS,EAAE,EAAE,EAAE,CAAC,CAAA;QAClC,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,CAAA;QACrD,MAAM,CAAC,SAAS,CAAC,CAAC,oBAAoB,CAAC,CAAC,CAAC,CAAA;IAC1C,CAAC,CAAC,CAAA;AACH,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,iCAAiC,EAAE,GAAG,EAAE;IAChD,EAAE,CAAC,kCAAkC,EAAE,GAAG,EAAE;QAC3C,MAAM,CAAC,GAAG,IAAI,gBAAgB,CAAC,CAAC,OAAO,CAAC,GAAG,EAAE,EAAE,kBAAkB,EAAE,CAAC,EAAE,CAAC,CAAC,EAAE;YACzE,cAAc,EAAE,CAAC;SACjB,CAAC,CAAA;QACF,CAAC,CAAC,YAAY,CAAC,GAAG,EAAE,CAAC,CAAC,CAAA;QACtB,8CAA8C;QAC9C,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;QACvD,mDAAmD;QACnD,CAAC,CAAC,YAAY,CAAC,GAAG,EAAE,CAAC,CAAC,CAAA;QACtB,mBAAmB;QACnB,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;IACzD,CAAC,CAAC,CAAA;AACH,CAAC,CAAC,CAAA"}

package/dist/advisory/executor.test.d.ts

@@ -0,0 +1,35 @@
+/**
+ * Current-code invariants asserted (2026-04-21, ses_006 Phase 6):
+ *
+ *   - `AdvisoryExecutor.consult(advisor, request, callCtx)`:
+ *     - Builds a system prompt (see buildSystemPrompt tests).
+ *     - Builds a context message block (see buildContext tests).
+ *     - Concatenates `[system, ...context, user(question)]` and calls
+ *       `advisor.provider.chat(...)` with `toolChoice: 'none'`.
+ *     - Parses the response via a passthrough `{ advice: rawContent }`
+ *       shape (no structured parsing yet — advisor.ts line 166-168).
+ *     - Returns `{result, usage, cost, durationMs}`. `cost` is a
+ *       zero-value `CostInfo` — pricing is provider-specific and not
+ *       applied here.
+ *
+ *   - `buildSystemPrompt` priority:
+ *     1. `advisor.systemPrompt` (verbatim).
+ *     2. `advisor.persona` (via `assembleSystemPrompt`).
+ *     3. Fallback: "You are <name>, an advisory agent." + optional
+ *        domains line + "Provide concise, actionable advice..."
+ *
+ *   - `buildContext`:
+ *     - Returns [] when `request.includeContext === false`.
+ *     - Includes workingStateSummary when present.
+ *     - Includes toolCatalog names when present + non-empty.
+ *     - Includes truncated conversation context (most-recent-first
+ *       walk, bounded by `advisor.maxContextTokens * CHARS_PER_TOKEN`).
+ *     - Returns [] when no context parts were assembled.
+ *
+ *   - `truncateMessages(msgs, maxTokens)` walks right-to-left and
+ *     includes messages until the char budget is exhausted (in token
+ *     terms). Returns the included subset preserving original order.
+ *     No limit when `maxTokens` is undefined.
+ */
+export {};
+//# sourceMappingURL=executor.test.d.ts.map

package/dist/advisory/executor.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"executor.test.d.ts","sourceRoot":"","sources":["../../src/advisory/executor.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAgCG"}

package/dist/advisory/executor.test.js

@@ -0,0 +1,233 @@
+/**
+ * Current-code invariants asserted (2026-04-21, ses_006 Phase 6):
+ *
+ *   - `AdvisoryExecutor.consult(advisor, request, callCtx)`:
+ *     - Builds a system prompt (see buildSystemPrompt tests).
+ *     - Builds a context message block (see buildContext tests).
+ *     - Concatenates `[system, ...context, user(question)]` and calls
+ *       `advisor.provider.chat(...)` with `toolChoice: 'none'`.
+ *     - Parses the response via a passthrough `{ advice: rawContent }`
+ *       shape (no structured parsing yet — advisor.ts line 166-168).
+ *     - Returns `{result, usage, cost, durationMs}`. `cost` is a
+ *       zero-value `CostInfo` — pricing is provider-specific and not
+ *       applied here.
+ *
+ *   - `buildSystemPrompt` priority:
+ *     1. `advisor.systemPrompt` (verbatim).
+ *     2. `advisor.persona` (via `assembleSystemPrompt`).
+ *     3. Fallback: "You are <name>, an advisory agent." + optional
+ *        domains line + "Provide concise, actionable advice..."
+ *
+ *   - `buildContext`:
+ *     - Returns [] when `request.includeContext === false`.
+ *     - Includes workingStateSummary when present.
+ *     - Includes toolCatalog names when present + non-empty.
+ *     - Includes truncated conversation context (most-recent-first
+ *       walk, bounded by `advisor.maxContextTokens * CHARS_PER_TOKEN`).
+ *     - Returns [] when no context parts were assembled.
+ *
+ *   - `truncateMessages(msgs, maxTokens)` walks right-to-left and
+ *     includes messages until the char budget is exhausted (in token
+ *     terms). Returns the included subset preserving original order.
+ *     No limit when `maxTokens` is undefined.
+ */
+import { describe, expect, it, vi } from 'vitest';
+import { AdvisoryExecutor } from './executor.js';
+function mockProvider(response = {}) {
+    const chat = vi.fn(async () => ({
+        id: 'resp_1',
+        model: 'm',
+        message: { role: 'assistant', content: 'advice text' },
+        usage: {
+            promptTokens: 100,
+            completionTokens: 50,
+            totalTokens: 150,
+            cachedTokens: 0,
+            cacheWriteTokens: 0,
+        },
+        finishReason: 'stop',
+        ...response,
+    }));
+    return {
+        id: 'mock',
+        name: 'Mock',
+        chat,
+        chatStream: vi.fn(),
+    };
+}
+function advisor(overrides = {}) {
+    return {
+        id: 'adv',
+        name: 'Adv',
+        provider: mockProvider(),
+        model: 'm',
+        ...overrides,
+    };
+}
+function ctx(overrides = {}) {
+    return {
+        messages: [],
+        iteration: 1,
+        ...overrides,
+    };
+}
+const req = { question: 'what next?' };
+describe('AdvisoryExecutor — consult happy path', () => {
+    it('calls provider.chat with system + question, toolChoice none', async () => {
+        const provider = mockProvider();
+        const e = new AdvisoryExecutor();
+        const a = advisor({ provider, systemPrompt: 'You are Adv.' });
+        await e.consult(a, req, ctx());
+        const call = vi.mocked(provider.chat).mock.calls[0]?.[0];
+        expect(call.model).toBe('m');
+        expect(call.toolChoice).toBe('none');
+        const roles = call.messages.map((m) => m.role);
+        expect(roles[0]).toBe('system');
+        expect(roles.at(-1)).toBe('user');
+    });
+    it('returns {result, usage, cost, durationMs}; cost is zero-valued', async () => {
+        const e = new AdvisoryExecutor();
+        const out = await e.consult(advisor(), req, ctx());
+        expect(out.result.advice).toBe('advice text');
+        expect(out.usage.totalTokens).toBe(150);
+        expect(out.cost).toEqual({
+            inputCostPer1M: 0,
+            outputCostPer1M: 0,
+            totalCost: 0,
+            cacheDiscount: 0,
+        });
+        expect(typeof out.durationMs).toBe('number');
+    });
+    it('parseResult is currently a passthrough — advice = content verbatim', async () => {
+        const provider = mockProvider({
+            message: { role: 'assistant', content: 'Raw text with **markdown**' },
+        });
+        const e = new AdvisoryExecutor();
+        const out = await e.consult(advisor({ provider }), req, ctx());
+        expect(out.result.advice).toBe('Raw text with **markdown**');
+    });
+    it('handles null provider content as empty string', async () => {
+        const provider = mockProvider({
+            message: { role: 'assistant', content: null },
+        });
+        const e = new AdvisoryExecutor();
+        const out = await e.consult(advisor({ provider }), req, ctx());
+        expect(out.result.advice).toBe('');
+    });
+});
+describe('AdvisoryExecutor — buildSystemPrompt', () => {
+    it('uses advisor.systemPrompt verbatim when set', async () => {
+        const provider = mockProvider();
+        const e = new AdvisoryExecutor();
+        await e.consult(advisor({ provider, systemPrompt: 'FIXED PROMPT' }), req, ctx());
+        const call = vi.mocked(provider.chat).mock.calls[0]?.[0];
+        expect(call.messages[0]?.content).toBe('FIXED PROMPT');
+    });
+    it('falls back to name + domains + boilerplate when no systemPrompt or persona', async () => {
+        const provider = mockProvider();
+        const e = new AdvisoryExecutor();
+        await e.consult(advisor({ provider, name: 'Architect', domains: ['security', 'performance'] }), req, ctx());
+        const call = vi.mocked(provider.chat).mock.calls[0]?.[0];
+        const systemContent = call.messages[0]?.content ?? '';
+        expect(systemContent).toContain('Architect');
+        expect(systemContent).toContain('security, performance');
+        expect(systemContent).toContain('concise, actionable advice');
+    });
+    it('fallback without domains omits the domains line', async () => {
+        const provider = mockProvider();
+        const e = new AdvisoryExecutor();
+        await e.consult(advisor({ provider, name: 'Adv' }), req, ctx());
+        const call = vi.mocked(provider.chat).mock.calls[0]?.[0];
+        const systemContent = call.messages[0]?.content ?? '';
+        expect(systemContent).not.toContain('domains of expertise');
+    });
+});
+describe('AdvisoryExecutor — buildContext', () => {
+    it('returns no context message when request.includeContext is false', async () => {
+        const provider = mockProvider();
+        const e = new AdvisoryExecutor();
+        await e.consult(advisor({ provider }), { question: 'q', includeContext: false }, ctx({ workingStateSummary: 'should be ignored' }));
+        const call = vi.mocked(provider.chat).mock.calls[0]?.[0];
+        // Only system + user(question)
+        expect(call.messages).toHaveLength(2);
+    });
+    it('includes workingStateSummary + toolCatalog names when present', async () => {
+        const provider = mockProvider();
+        const e = new AdvisoryExecutor();
+        await e.consult(advisor({ provider }), req, {
+            messages: [],
+            iteration: 1,
+            workingStateSummary: 'state summary here',
+            toolCatalog: [
+                {
+                    type: 'function',
+                    function: { name: 'read_file', description: 'read', parameters: {} },
+                },
+                {
+                    type: 'function',
+                    function: { name: 'write_file', description: 'write', parameters: {} },
+                },
+            ],
+        });
+        const call = vi.mocked(provider.chat).mock.calls[0]?.[0];
+        const contextMsg = call.messages[1]?.content ?? '';
+        expect(contextMsg).toContain('Working State');
+        expect(contextMsg).toContain('state summary here');
+        expect(contextMsg).toContain('Available Tools');
+        expect(contextMsg).toContain('read_file, write_file');
+    });
+    it('includes conversation context (no truncation when no maxContextTokens)', async () => {
+        const provider = mockProvider();
+        const messages = [
+            { role: 'user', content: 'hi' },
+            { role: 'assistant', content: 'hello' },
+        ];
+        const e = new AdvisoryExecutor();
+        await e.consult(advisor({ provider }), req, ctx({ messages }));
+        const call = vi.mocked(provider.chat).mock.calls[0]?.[0];
+        const contextMsg = call.messages[1]?.content ?? '';
+        expect(contextMsg).toContain('Conversation Context');
+        expect(contextMsg).toContain('[user]: hi');
+        expect(contextMsg).toContain('[assistant]: hello');
+    });
+    it('truncates conversation from the back when maxContextTokens is set', async () => {
+        const provider = mockProvider();
+        const messages = [
+            { role: 'user', content: 'a'.repeat(100) }, // oldest — should be dropped
+            { role: 'user', content: 'recent' },
+        ];
+        const e = new AdvisoryExecutor();
+        // maxContextTokens=5 → 5*4=20 char budget; only 'recent' (6 chars) fits.
+        await e.consult(advisor({ provider, maxContextTokens: 5 }), req, ctx({ messages }));
+        const call = vi.mocked(provider.chat).mock.calls[0]?.[0];
+        const contextMsg = call.messages[1]?.content ?? '';
+        expect(contextMsg).toContain('recent');
+        expect(contextMsg).not.toContain('a'.repeat(100));
+    });
+    it('omits the context message entirely when there are no context parts', async () => {
+        const provider = mockProvider();
+        const e = new AdvisoryExecutor();
+        await e.consult(advisor({ provider }), req, ctx());
+        const call = vi.mocked(provider.chat).mock.calls[0]?.[0];
+        expect(call.messages).toHaveLength(2);
+    });
+});
+describe('AdvisoryExecutor — tool calls in context', () => {
+    it('represents assistant messages with tool calls as "(tool calls)" stub', async () => {
+        const provider = mockProvider();
+        const e = new AdvisoryExecutor();
+        await e.consult(advisor({ provider }), req, ctx({
+            messages: [
+                {
+                    role: 'assistant',
+                    content: null,
+                    toolCalls: [{ id: 't1', type: 'function', function: { name: 'x', arguments: '{}' } }],
+                },
+            ],
+        }));
+        const call = vi.mocked(provider.chat).mock.calls[0]?.[0];
+        const contextMsg = call.messages[1]?.content ?? '';
+        expect(contextMsg).toContain('[assistant]: (tool calls)');
+    });
+});
+//# sourceMappingURL=executor.test.js.map