@namewta/speculo 2.0.3 → 2.0.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@namewta/speculo",
-  "version": "2.0.3",
+  "version": "2.0.4",
   "description": "Standard agent skills, commands and project methods with state-safe installation.",
   "type": "module",
   "bin": {

package/template/commands/git-history-squash/scripts/git-history-squash.mjs

@@ -287,11 +287,11 @@ function repositoryRoot(path) {
   if (git(path, ['rev-parse', '--is-inside-work-tree'], { allowed: [0, 128] }).stdout.trim() !== 'true') {
     throw new SquashError('repository path is not a Git worktree');
   }
-  return realpathSync(git(path, ['rev-parse', '--show-toplevel']).stdout.trim());
+  return realpathSync.native(git(path, ['rev-parse', '--show-toplevel']).stdout.trim());
 }
 
 function portable(root, path, externalIndex) {
-  const rel = relative(realpathSync(root), realpathSync(path));
+  const rel = relative(realpathSync.native(root), realpathSync.native(path));
   if (!isAbsolute(rel) && rel !== '..' && !rel.startsWith(`..${sep}`)) return rel ? rel.split(sep).join('/') : '.';
   return `<external-worktree:${externalIndex}>`;
 }
@@ -450,7 +450,7 @@ function inspectRemote(repo, request, oldHead) {
 function inspectRepository(projectRoot, request) {
   const repo = inside(projectRoot, request.path, `${request.id}.path`, { allowRoot: true });
   ensureDirectory(repo, `${request.id}.path`);
-  if (repositoryRoot(repo) !== realpathSync(repo)) throw new SquashError(`${request.id}.path must be the repository toplevel`);
+  if (relative(repositoryRoot(repo), realpathSync.native(repo)) !== '') throw new SquashError(`${request.id}.path must be the repository toplevel`);
   validateRef(repo, request.branch, `${request.id}.branch`);
   git(repo, ['update-ref', '--stdin'], { input: 'start\nabort\n', env: { GIT_OPTIONAL_LOCKS: '0' } });
   git(repo, ['var', 'GIT_AUTHOR_IDENT'], { env: { GIT_OPTIONAL_LOCKS: '0' } });
@@ -765,7 +765,7 @@ function validateRunState(projectRoot, state) {
     safePath(repo.path, `${repo.id}.path`);
     const path = inside(projectRoot, repo.path, `${repo.id}.path`, { allowRoot: true, mustExist: true });
     ensureDirectory(path, `${repo.id}.path`);
-    if (repositoryRoot(path) !== realpathSync(path)) throw new SquashError(`${repo.id}.path must remain a repository toplevel`);
+    if (relative(repositoryRoot(path), realpathSync.native(path)) !== '') throw new SquashError(`${repo.id}.path must remain a repository toplevel`);
     validateRef(path, repo.branch, `${repo.id}.branch`);
     validateOid(repo.start_sha, `${repo.id}.start_sha`);
     validateOid(repo.end_sha, `${repo.id}.end_sha`);

package/template/workflows/specdev/common/tools/review-scope.mjs

@@ -43,8 +43,10 @@ function workingFile(root, path) {
 
 function workingTree(options) {
   if (['head','commit','parent'].some(key => options[key] !== undefined)) throw new Error('review-scope: working-tree accepts base, not head/commit/parent');
-  const root = realpathSync(resolve(options.repo));
-  if (realpathSync(git(root, ['rev-parse','--show-toplevel']).trim()) !== root) throw new Error('review-scope: working-tree requires the actual project Git root');
+  // Native realpath expands Windows short names; relative also handles drive
+  // casing without admitting a nested directory that borrows its parent's Git.
+  const root = realpathSync.native(resolve(options.repo));
+  if (relative(root,realpathSync.native(git(root, ['rev-parse','--show-toplevel']).trim())) !== '') throw new Error('review-scope: working-tree requires the actual project Git root');
   const base = commit(root, options.base, 'base');
   const files = options.files?.map(portableFile);
   if (files && (!files.length || new Set(files).size !== files.length)) throw new Error('review-scope: empty or duplicate working-tree scope');

package/template/workflows/specdev/common/tools/tests/review-working-tree.test.mjs

@@ -11,6 +11,7 @@ function fixture(t) {
   t.after(()=>rmSync(root,{recursive:true,force:true}));
   const git=(...args)=>execFileSync('git',['-C',root,...args],{encoding:'utf8',stdio:['ignore','pipe','pipe']}).trim();
   git('init','-b','main');git('config','user.name','Fixture');git('config','user.email','test@example.invalid');
+  git('config','core.autocrlf','false');
   for(const path of ['one.txt','removed.txt','renamed.txt']) writeFileSync(join(root,path),'original\n');
   writeFileSync(join(root,'.gitignore'),'ignored/\n');git('add','.');git('-c','commit.gpgsign=false','commit','-m','base');
   const base=git('rev-parse','HEAD');
@@ -26,14 +27,14 @@ test('working-tree freezes staged, unstaged, added, deleted, renamed and mode ch
   const scope=f.scope();
   assert.equal(scope.outcome,'changes');assert.equal(scope.observed_head,f.base);assert.equal(scope.head_sha,undefined);
   assert.deepEqual(scope.changed_paths,['new-name.txt','new.bin','one.txt','removed.txt','renamed.txt']);
-  assert.equal(scope.working_snapshot.find(x=>x.path==='one.txt').after.mode,'100755');
+  assert.equal(scope.working_snapshot.find(x=>x.path==='one.txt').after.mode,process.platform === 'win32' ? '100644' : '100755');
   assert.equal(scope.working_snapshot.find(x=>x.path==='removed.txt').after,null);
   assert.equal(scope.working_snapshot.find(x=>x.path==='new.bin').after.bytes,3);
   assert.deepEqual(f.scope(),scope);assert.equal(f.git('status','--porcelain'),status);assert.deepEqual(readFileSync(join(f.root,'.git/index')),before);
   writeFileSync(join(f.root,'new.bin'),Buffer.from([0,255,8]));assert.notEqual(f.scope().input_sha256,scope.input_sha256);
 });
 test('explicit scopes are literal, expose exclusions and retain deleted files',t=>{
-  const f=fixture(t), path='literal [*] $(touch unsafe).txt';
+  const f=fixture(t), path='literal [abc] $(touch unsafe).txt';
   writeFileSync(join(f.root,path),'literal');rmSync(join(f.root,'removed.txt'));writeFileSync(join(f.root,'one.txt'),'changed');
   const scope=f.scope({files:[path,'removed.txt']});
   assert.deepEqual(scope.changed_paths,[path,'removed.txt']);assert.deepEqual(scope.excluded_paths,['one.txt']);
@@ -47,7 +48,7 @@ test('links are read as links and directory links never disclose outside bytes',
   t.after(()=>rmSync(outside,{recursive:true,force:true}));writeFileSync(join(outside,'secret'),'sensitive');
   symlinkSync(join(outside,'secret'),join(f.root,'link'));
   const scope=f.scope({files:['link']});assert.equal(scope.working_snapshot[0].after.kind,'symlink');
-  symlinkSync(outside,join(f.root,'directory'));
+  symlinkSync(outside,join(f.root,'directory'),process.platform === 'win32' ? 'junction' : 'dir');
   assert.throws(()=>f.scope({files:['directory/secret']}),/symlink directory/);
 });
 test('unmerged index and borrowed parent repository are rejected',t=>{