@namewta/speculo 1.0.2 → 1.0.4

package/template/workflows/specdev/common/tools/validate-specdev.mjs

@@ -20,6 +20,11 @@ import { execFileSync } from "node:child_process";
 import { dirname, basename, extname, join, relative, resolve, sep } from "node:path";
 import { fileURLToPath } from "node:url";
 
+import {
+  validateTicketPlan, validatePlanMap, validateInvocationCoverage,
+  validateGoalMap, validateInitiative, resolveProjectSource,
+} from "./plan-contract.mjs";
+
 const DOMAIN_SCHEMA_VERSION = 3;
 const CONFIG_SCHEMA_VERSION = 5;
 const GOAL_PLAN_SCHEMA_VERSION = 6;
@@ -42,7 +47,6 @@ const EXPECTED_WORKS = new Set([
   "I-implement",
   "I-init-setup",
   "L-learn-change",
-  "O-orchestrate-implementation",
   "P-goal-plan",
   "P-prototype",
   "R-review-architecture",
@@ -111,7 +115,6 @@ const VALID_STAGES = new Set([
   "review",
   "prototype",
   "wayfinder",
-  "orchestrate-implementation",
   "complete",
 ]);
 const REQUIRED_TICKET_KEYS = new Set([
@@ -175,10 +178,11 @@ const STATE_ARTIFACT_BASENAMES = new Set([
   "diagnosis.md",
   "source.md",
   "architecture-review.md",
-  "architecture-review.html",
   "wayfinder-map.md",
   "design-tree.json",
   "implementation-orchestration.md",
+  "initiative.json",
+  "goal-delivery.md",
 ]);
 const FORBIDDEN_OBSOLETE_BASENAMES = new Set([
   "source-issue.md",
@@ -240,7 +244,11 @@ function parseScalar(raw) {
     return value.slice(1, -1);
   }
   if (value.startsWith("[") && value.endsWith("]")) {
+    // JSON object arrays are used by the additive Skill invocation contract.
+    // Keep the existing plain YAML scalar-list form for old artifacts.
+    try { return JSON.parse(value); } catch { /* legacy scalar list below */ }
     const inner = value.slice(1, -1).trim();
+    if (inner.startsWith("{")) throw new Error("invalid JSON object array in frontmatter");
     if (!inner) return [];
     return inner.split(",").map((item) => parseScalar(item));
   }
@@ -296,6 +304,9 @@ function parseFrontmatter(path) {
     const colon = line.indexOf(":");
     if (colon < 0) continue;
     const key = line.slice(0, colon).trim();
+    if (["__proto__", "constructor", "prototype"].includes(key) || Object.hasOwn(meta, key)) {
+      throw new Error(`${path}: duplicate or unsafe frontmatter key ${key}`);
+    }
     const raw = line.slice(colon + 1).trim();
     if (!raw) {
       meta[key] = [];
@@ -854,13 +865,6 @@ function capabilityChecks(root) {
         ],
       ],
     ],
-    [
-      "orchestrate-implementation",
-      [
-        join(root, "O-orchestrate-implementation", "O-orchestrate-implementation.md"),
-        ["Ready Spec", "Ready Tickets", "Implementation Map", "Implementation Plan", "lead-directed", "implementation_agent_limit", "serialization", "I-implement"],
-      ],
-    ],
     [
       "implement",
       [
@@ -900,7 +904,14 @@ function capabilityChecks(root) {
       "architecture-review",
       [
         join(root, "R-review-architecture", "R-review-architecture.md"),
-        ["shallow", "interface", "locality", "Tailwind CDN", "Mermaid CDN", "最佳推荐"],
+        ["结构性坏味道", "code-judo", "删除测试", "高置信候选", "最佳推荐"],
+      ],
+    ],
+    [
+      "architecture-review-rubric",
+      [
+        join(root, "R-review-architecture", "review-rubric.md"),
+        ["删除测试", "文件大小", "高置信候选", "spaghetti growth"],
       ],
     ],
     [
@@ -938,15 +949,6 @@ function capabilityChecks(root) {
       errors.push(`capability '${ability}' lost markers: ${JSON.stringify(missing)}`);
     }
   }
-  if (!isFile(join(root, "R-review-architecture", "architecture-review-report-template.html"))) {
-    errors.push("architecture review lost its visual HTML report template");
-  } else {
-    const html = readText(join(root, "R-review-architecture", "architecture-review-report-template.html"));
-    for (const marker of ["cdn.tailwindcss.com", "mermaid", "Before", "After", "top-recommendation"]) {
-      if (!html.includes(marker)) errors.push(`architecture HTML template lost marker ${marker}`);
-    }
-  }
-
   for (const required of [
     "common/rules/codebase-design.md",
     "common/schemas/design-tree.schema.json",
@@ -954,14 +956,9 @@ function capabilityChecks(root) {
     "G-grill-with-docs/design-tree-template.json",
     "W-wayfinder/local-tracker-contract.md",
     "W-wayfinder/solution-comment-template.md",
-    "R-review-architecture/architecture-report-contract.md",
     "common/rules/parent-implementation-orchestration.md",
     "common/schemas/implementation-map.schema.json",
     "common/schemas/implementation-plan.schema.json",
-    "O-orchestrate-implementation/input-readiness.md",
-    "O-orchestrate-implementation/implementation-map-template.md",
-    "O-orchestrate-implementation/implementation-plan-template.md",
-    "O-orchestrate-implementation/implementation-evidence-template.md",
   ]) {
     if (!isFile(join(root, required))) errors.push(`missing architecture/wayfinding contract ${required}`);
   }
@@ -1555,6 +1552,9 @@ function validateProjectSkillMatrix(body, label, errors, repoRoot = null) {
         errors.push(`${label}: project Skill Path escapes the project root: ${skillPath}`);
       } else if (!isFile(resolvedSkill)) {
         errors.push(`${label}: project Skill does not exist under --repo: ${skillPath}`);
+      } else {
+        try { resolveProjectSource(resolvedRepo, `<Path>${skillPath}</Path>`); }
+        catch (error) { errors.push(`${label}: ${error.message}`); }
       }
     }
     entries.push({ appliesTo: new Set(appliesTo), path: skillPath });
@@ -1591,6 +1591,11 @@ function validateMap(path, errors, repoRoot = null) {
     return null;
   }
   const { meta, body } = parseFrontmatter(path);
+  if (meta.artifact === "goal-tickets-map") {
+    errors.push(...validateGoalMap({ path, meta, body }, dirname(path)).map(error => `${basename(path)}: ${error}`));
+    return { path, meta, body, projectSkillMatrix: [], goalMap: true };
+  }
+  errors.push(...validatePlanMap({ path, meta, body }, dirname(path)).map(error => `${basename(path)}: ${error}`));
   if (meta.artifact !== "tickets-map" || meta.schema_version !== DOMAIN_SCHEMA_VERSION) {
     errors.push(`${basename(path)}: artifact/schema_version must be tickets-map/${DOMAIN_SCHEMA_VERSION}`);
   }
@@ -2392,13 +2397,13 @@ function validateGitEvidence(repoRoot, changeStatus, errors) {
   }
 }
 
-function validateParentImplementation(change, parentStatus, stage, errors, warnings) {
-  const required = stage === "orchestrate-implementation";
+function validateParentImplementation(change, parentStatus, stage, errors, warnings, repoRoot = null) {
+  const required = stage === "goal-plan";
   const mapPath = join(change, "implementation-map.md");
   const planPath = join(change, "implementation-plan.md");
   if (!required && !isFile(mapPath) && !isFile(planPath)) return null;
-  if (!isFile(mapPath)) errors.push("orchestrate-implementation stage requires implementation-map.md");
-  if (!isFile(planPath)) errors.push("orchestrate-implementation stage requires implementation-plan.md");
+  if (!isFile(mapPath)) errors.push("goal-plan stage requires implementation-map.md");
+  if (!isFile(planPath)) errors.push("goal-plan stage requires implementation-plan.md");
   if (!isFile(mapPath) || !isFile(planPath)) return null;
 
   const parentName = basename(change);
@@ -2552,7 +2557,7 @@ function validateParentImplementation(change, parentStatus, stage, errors, warni
     }
 
     const childMapPath = join(memberRoot, "tickets-map.md");
-    const childMap = isFile(childMapPath) ? validateMap(childMapPath, memberErrors) : null;
+    const childMap = isFile(childMapPath) ? validateMap(childMapPath, memberErrors, repoRoot) : null;
     if (!childMap) memberErrors.push("Ready Tickets Map is required before parent creation");
     else {
       if (childMap.meta.change !== member) memberErrors.push("tickets-map.md: change must equal member directory name");
@@ -2569,6 +2574,7 @@ function validateParentImplementation(change, parentStatus, stage, errors, warni
     const childTickets = new Map();
     for (const name of ticketFiles) {
       const artifact = validateTicket(join(ticketRoot, name), memberErrors);
+      if (artifact) memberErrors.push(...validateTicketPlan(artifact, { repoRoot }).map(error => `${name}: ${error}`));
       if (!artifact) continue;
       const ticketId = String(artifact.meta.id);
       if (artifact.meta.change !== member) memberErrors.push(`${name}: change must equal member directory name`);
@@ -2592,8 +2598,10 @@ function validateParentImplementation(change, parentStatus, stage, errors, warni
           memberErrors.push(`${ticketId}: parent creation requires status=ready and ready=true`);
         } else if (new Set(["ready", "in_progress", "review"]).has(artifact.meta.status) && artifact.meta.ready !== true) {
           memberErrors.push(`${ticketId}: executable Ticket must keep ready=true`);
-        } else if (new Set(["blocked", "deviated"]).has(artifact.meta.status) && map.meta.status !== "blocked" && plan.meta.status !== "blocked") {
-          memberErrors.push(`${ticketId}: blocked/deviated Ticket requires blocked parent artifacts`);
+        } else if (new Set(["blocked", "deviated"]).has(artifact.meta.status)) {
+          // A local blocker does not revoke unrelated nodes' execution gate.
+          // The controller excludes this node and its dependency closure; only a
+          // global blocker or an empty legal frontier pauses the whole parent.
         } else if (artifact.meta.status === "draft") {
           memberErrors.push(`${ticketId}: draft Ticket cannot belong to a parent implementation`);
         }
@@ -2601,6 +2609,7 @@ function validateParentImplementation(change, parentStatus, stage, errors, warni
     }
 
     if (childMap) {
+      memberErrors.push(...validateInvocationCoverage(childTickets, childMap.projectSkillMatrix));
       validateProjectSkillCoverage(
         childMap.projectSkillMatrix,
         childTickets.keys(),
@@ -2772,8 +2781,8 @@ function validateParentImplementation(change, parentStatus, stage, errors, warni
     if (count > 1) errors.push(`repository/ref integration must be serialized for ${ref}; found ${count}`);
   }
 
-  if (required && parentStatus && new Set(["active", "blocked"]).has(parentStatus.change_status) && parentStatus.current_work !== "specdev/orchestrate-implementation") {
-    errors.push("parent active/blocked status must keep current_work=specdev/orchestrate-implementation");
+  if (required && parentStatus && new Set(["active", "blocked"]).has(parentStatus.change_status) && !new Set(["specdev/goal-plan"]).has(parentStatus.current_work)) {
+    errors.push("parent active/blocked status must keep current_work=specdev/goal-plan");
   }
   if (parentStatus?.change_status === "completed") {
     const incomplete = members.filter((member) => memberStatuses.get(member)?.change_status !== "completed");
@@ -2841,7 +2850,8 @@ function validateChange(change, stage = null, repoRoot = null) {
   }
 
   const changeStatus = validateChangeStatus(join(change, ".status.json"), basename(change), errors);
-  validateParentImplementation(change, changeStatus, stage, errors, warnings);
+  validateParentImplementation(change, changeStatus, stage, errors, warnings, repoRoot);
+  errors.push(...validateInitiative(change));
   if (isFile(join(change, "source-issue.md"))) {
     errors.push("obsolete source-issue.md is forbidden; use source.md without compatibility fallback");
   }
@@ -2862,13 +2872,14 @@ function validateChange(change, stage = null, repoRoot = null) {
   validatePrototypes(change, stage === "prototype", errors);
   validateChangeLearning(change, stage === "learn-change", errors);
 
-  const specRequired = new Set(["spec", "tickets", "goal-plan", "implement", "complete"]).has(stage) && !isFile(join(change, "implementation-map.md"));
+  const isParentImplementation = isFile(join(change, "implementation-map.md"));
+  const specRequired = new Set(["spec", "tickets", "goal-plan", "implement", "complete"]).has(stage) && !isParentImplementation;
   const specPath = join(change, "spec.md");
   const spec = isFile(specPath) || specRequired
     ? validateSpec(specPath, errors, warnings)
     : null;
   const ticketMode = isDirectory(join(change, "ticket"));
-  const mapRequired = new Set(["tickets", "goal-plan"]).has(stage) || (stage === "implement" && ticketMode);
+  const mapRequired = !isParentImplementation && (new Set(["tickets", "goal-plan"]).has(stage) || (stage === "implement" && ticketMode));
   const mapPath = join(change, "tickets-map.md");
   const ticketsMap = isFile(mapPath) || mapRequired ? validateMap(mapPath, errors, repoRoot) : null;
   const goalPlanPath = join(change, "goal-plan.md");
@@ -2892,7 +2903,7 @@ function validateChange(change, stage = null, repoRoot = null) {
   }
 
   const ticketDir = join(change, "ticket");
-  const ticketsRequired = new Set(["tickets", "goal-plan"]).has(stage) || (stage === "implement" && ticketMode);
+  const ticketsRequired = !isParentImplementation && (new Set(["tickets", "goal-plan"]).has(stage) || (stage === "implement" && ticketMode));
   const ticketFiles = isDirectory(ticketDir)
     ? readdirSync(ticketDir)
         .filter((name) => name.endsWith(".md"))
@@ -2909,6 +2920,7 @@ function validateChange(change, stage = null, repoRoot = null) {
   for (const path of ticketFiles) {
     const artifact = validateTicket(path, errors);
     if (!artifact) continue;
+    errors.push(...validateTicketPlan(artifact, { repoRoot, requirePlan: stage === "implement" }).map(error => `${basename(path)}: ${error}`));
     const ticketId = String(artifact.meta.id);
     if (artifact.meta.change !== basename(change)) {
       errors.push(`${basename(path)}: change must equal directory name ${basename(change)}`);
@@ -2931,7 +2943,8 @@ function validateChange(change, stage = null, repoRoot = null) {
     }
   }
 
-  if (ticketsMap) {
+  if (ticketsMap && !ticketsMap.goalMap) {
+    errors.push(...validateInvocationCoverage(tickets, ticketsMap.projectSkillMatrix));
     validateProjectSkillCoverage(
       ticketsMap.projectSkillMatrix,
       tickets.keys(),
@@ -3210,4 +3223,9 @@ function main(argv) {
   return usage();
 }
 
-process.exitCode = main(process.argv.slice(2));
+export { parseFrontmatter, validateChange, validateTicket, validateMap, pathsOverlap, findCycle };
+
+if (process.argv[1] && resolve(process.argv[1]) === fileURLToPath(import.meta.url)) {
+  try { process.exitCode = main(process.argv.slice(2)); }
+  catch (error) { console.error(`ERROR: ${error.message}`); process.exitCode = 1; }
+}

package/template/workflows/specdev/manifest.json

@@ -1 +1,97 @@
-{"schema_version":1,"id":"specdev","version":"1.0.0","persistent_knowledge":["<Path>{roots.state}/specdev/adr/</Path>","<Path>{roots.state}/specdev/context/</Path>"],"stages":[{"id":"intake","after":[],"inputs":["request"],"outputs":["source","triage"],"risk":"read-only","context_budget":12000},{"id":"decide","after":["intake"],"inputs":["source","triage"],"outputs":["spec","adr"],"risk":"read-only","context_budget":20000},{"id":"plan","after":["decide"],"inputs":["spec"],"outputs":["ticket","plan"],"risk":"read-only","context_budget":18000},{"id":"execute","after":["plan"],"inputs":["ticket","plan"],"outputs":["code","evidence"],"risk":"local-reversible","context_budget":24000},{"id":"verify","after":["execute"],"inputs":["code","evidence"],"outputs":["verification"],"risk":"read-only","context_budget":12000},{"id":"learn","after":["verify"],"inputs":["verification"],"outputs":["learning"],"risk":"read-only","context_budget":10000}]}
+{
+  "schema_version": 1,
+  "id": "specdev",
+  "version": "1.0.0",
+  "persistent_knowledge": [
+    "<Path>{roots.state}/specdev/adr/</Path>",
+    "<Path>{roots.state}/specdev/context/</Path>"
+  ],
+  "stages": [
+    {
+      "id": "intake",
+      "after": [],
+      "inputs": [
+        "request"
+      ],
+      "outputs": [
+        "source",
+        "triage"
+      ],
+      "risk": "read-only",
+      "context_budget": 12000
+    },
+    {
+      "id": "decide",
+      "after": [],
+      "inputs": [
+        "request-or-frozen-source"
+      ],
+      "outputs": [
+        "spec",
+        "adr"
+      ],
+      "risk": "read-only",
+      "context_budget": 20000
+    },
+    {
+      "id": "plan",
+      "after": [
+        "decide"
+      ],
+      "inputs": [
+        "spec"
+      ],
+      "outputs": [
+        "ticket",
+        "plan"
+      ],
+      "risk": "read-only",
+      "context_budget": 18000
+    },
+    {
+      "id": "execute",
+      "after": [
+        "plan"
+      ],
+      "inputs": [
+        "ticket",
+        "plan"
+      ],
+      "outputs": [
+        "code",
+        "evidence"
+      ],
+      "risk": "local-reversible",
+      "context_budget": 24000
+    },
+    {
+      "id": "verify",
+      "after": [
+        "execute"
+      ],
+      "inputs": [
+        "code",
+        "evidence"
+      ],
+      "outputs": [
+        "verification"
+      ],
+      "risk": "read-only",
+      "context_budget": 12000
+    },
+    {
+      "id": "learn",
+      "after": [
+        "verify"
+      ],
+      "inputs": [
+        "verification"
+      ],
+      "outputs": [
+        "learning"
+      ],
+      "risk": "read-only",
+      "context_budget": 10000
+    }
+  ]
+}