@nadohq/mobile-client 0.65.0 → 0.67.0

package/src/signing/canonicalize.ts

@@ -12,6 +12,60 @@ export function canonicalizeMobileInner(
   inner: MobileSignedInner,
 ): MobileSignedInner {
   switch (inner.type) {
+    case 'register_expo_token_v2':
+      return {
+        type: inner.type,
+        expo_token: inner.expo_token,
+        platform: inner.platform,
+        locale: inner.locale,
+        app_version: inner.app_version,
+        capabilities: {
+          payload_versions: [...inner.capabilities.payload_versions],
+          type_ids: [...inner.capabilities.type_ids],
+          routes: [...inner.capabilities.routes],
+        },
+      };
+    case 'notification_subscriptions':
+      return { type: inner.type };
+    case 'update_notification_subscriptions':
+      return {
+        type: inner.type,
+        expected_revision: inner.expected_revision,
+        trader_bell:
+          inner.trader_bell == null
+            ? null
+            : {
+                subaccount: inner.trader_bell.subaccount,
+                enabled: inner.trader_bell.enabled,
+              },
+        market:
+          inner.market == null
+            ? null
+            : {
+                product_id: inner.market.product_id,
+                subscribed: inner.market.subscribed,
+              },
+        import_markets:
+          inner.import_markets == null ? null : [...inner.import_markets],
+      };
+    case 'notification_inbox_v2':
+      return {
+        type: inner.type,
+        cursor: inner.cursor,
+        limit: inner.limit,
+      };
+    case 'record_product_events':
+      return {
+        type: inner.type,
+        events: inner.events.map((event) => ({
+          client_event_id: event.client_event_id,
+          event_name: event.event_name,
+          notification_id: event.notification_id,
+          occurred_at: event.occurred_at,
+          product_id: event.product_id,
+          query: event.query,
+        })),
+      };
     case 'create_feed_post':
       return {
         type: inner.type,
@@ -25,6 +79,12 @@ export function canonicalizeMobileInner(
         ...(inner.drawing_data_json === undefined
           ? {}
           : { drawing_data_json: inner.drawing_data_json }),
+        ...(inner.image_ids === undefined
+          ? {}
+          : { image_ids: [...inner.image_ids] }),
+        ...(inner.image_urls === undefined
+          ? {}
+          : { image_urls: [...inner.image_urls] }),
       };
     case 'create_feed_comment':
       return {
@@ -39,6 +99,18 @@ export function canonicalizeMobileInner(
         ...(inner.attached_position_id === undefined
           ? {}
           : { attached_position_id: inner.attached_position_id }),
+        ...(inner.image_ids === undefined
+          ? {}
+          : { image_ids: [...inner.image_ids] }),
+        ...(inner.image_urls === undefined
+          ? {}
+          : { image_urls: [...inner.image_urls] }),
+      };
+    case 'create_feed_post_image_uploads':
+    case 'create_feed_comment_image_uploads':
+      return {
+        type: inner.type,
+        content_hash: inner.content_hash,
       };
     case 'create_feed_chart_drawing':
     case 'update_feed_chart_drawing':

package/src/signing/eip712MethodByType.ts

@@ -7,8 +7,18 @@ export const MOBILE_EIP712_METHOD_BY_TYPE: Record<
   MobileSignedInner['type'],
   string
 > = {
+  register_expo_token_v2: 'mobile:execute_register_expo_token_v2',
+  notification_subscriptions: 'mobile:query_notification_subscriptions',
+  update_notification_subscriptions:
+    'mobile:execute_update_notification_subscriptions',
+  notification_inbox_v2: 'mobile:query_notification_inbox_v2',
+  record_product_events: 'mobile:execute_record_product_events',
   create_feed_post: 'mobile:execute_create_feed_post',
   create_feed_comment: 'mobile:execute_create_feed_comment',
+  create_feed_post_image_uploads:
+    'mobile:execute_create_feed_post_image_uploads',
+  create_feed_comment_image_uploads:
+    'mobile:execute_create_feed_comment_image_uploads',
   create_feed_chart_drawing: 'mobile:execute_create_feed_chart_drawing',
   update_feed_chart_drawing: 'mobile:execute_update_feed_chart_drawing',
   set_feed_like: 'mobile:execute_set_feed_like',

package/src/signing/signing.test.ts

@@ -435,7 +435,9 @@ describe('[mobile-client]: social content signing', () => {
   const drawing = ' { "lines" : [], "enabled": false } ';
 
   it('canonicalizes every post field and nested mention without changing content', () => {
+    const imageIds = ['88888888-8888-4888-8888-888888888888'];
     const input: MobileSignedInner = {
+      image_ids: imageIds,
       drawing_data_json: drawing,
       mentions: [mention],
       text,
@@ -453,6 +455,7 @@ describe('[mobile-client]: social content signing', () => {
       'text',
       'mentions',
       'drawing_data_json',
+      'image_ids',
     ]);
     if (result.type !== 'create_feed_post') throw new Error('Expected post');
     expect(Object.keys(result.mentions[0])).toEqual([
@@ -466,6 +469,8 @@ describe('[mobile-client]: social content signing', () => {
     expect(result.position_id).toBe(positionId);
     expect(result.text).toBe(text);
     expect(result.drawing_data_json).toBe(drawing);
+    expect(result.image_ids).toEqual(imageIds);
+    expect(result.image_ids).not.toBe(imageIds);
     expect(result.mentions[0]).toEqual({
       subaccount: FIXTURE_TARGET_SUBACCOUNT,
       start: 2,
@@ -582,6 +587,16 @@ describe('[mobile-client]: social content signing', () => {
   });
 
   const payloads: MobileSignedInner[] = [
+    {
+      type: 'create_feed_post_image_uploads',
+      content_hash:
+        '0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
+    },
+    {
+      type: 'create_feed_comment_image_uploads',
+      content_hash:
+        '0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
+    },
     {
       type: 'create_feed_post',
       client_request_id: requestId,
@@ -633,8 +648,59 @@ describe('[mobile-client]: social content signing', () => {
         signature: signed.signature,
       });
       expect(recovered.toLowerCase()).toBe(account.address.toLowerCase());
-      expect(signed).toMatchObject(canonical);
+      expect(signed).toMatchObject({ ...canonical });
       expect(signed).not.toHaveProperty('payload');
     },
   );
 });
+
+describe('[mobile-client]: external image signing', () => {
+  it.each(['create_feed_post', 'create_feed_comment'] as const)(
+    'signs ordered original URL arrays after image_ids for %s',
+    (type) => {
+      const base = {
+        client_request_id: '11111111-1111-4111-8111-111111111111',
+        text: 'image test',
+        mentions: [],
+      };
+      const inner: MobileSignedInner =
+        type === 'create_feed_post'
+          ? {
+              type,
+              ...base,
+              position_id: '22222222-2222-4222-8222-222222222222',
+            }
+          : {
+              type,
+              ...base,
+              root_item_id: '22222222-2222-4222-8222-222222222222',
+            };
+      const urls = [
+        'https://example.com/A.png?x=%2f',
+        'https://example.com/b.png',
+      ];
+      const result = canonicalizeMobileInner({
+        image_urls: urls,
+        image_ids: [],
+        ...inner,
+      });
+      expect(Object.keys(result).slice(-2)).toEqual([
+        'image_ids',
+        'image_urls',
+      ]);
+      if (result.type !== type) throw new Error('Unexpected signing type');
+      expect(result.image_urls).toEqual(urls);
+      expect(result.image_urls).not.toBe(urls);
+      const hash = (imageUrls?: string[]) =>
+        getMobilePayloadHash(
+          canonicalizeMobileInner({ ...inner, image_urls: imageUrls }),
+        );
+      expect(hash()).not.toBe(hash([]));
+      expect(hash(urls)).not.toBe(hash([...urls].reverse()));
+      expect(hash(urls)).not.toBe(
+        hash([urls[0].replace('%2f', '%2F'), urls[1]]),
+      );
+      expect(hash(urls)).toBe(hash([...urls]));
+    },
+  );
+});

package/src/signing/types.ts

@@ -2,10 +2,15 @@ import { WalletClientWithAccount } from '@nadohq/shared';
 import { Hex } from 'viem';
 import { MobileSignedRequestParams } from '../types/clientTypes';
 import {
-  MobileNotificationPlatform,
   MobileServerAvatarSelection,
+  MobileServerProductEvent,
   MobileSocialFeedMention,
 } from '../types/serverModelTypes';
+import {
+  MobileServerNotificationSubscriptionsUpdate,
+  MobileServerRegisterExpoTokenParams,
+  MobileServerRegisterExpoTokenV2Params,
+} from '../types/serverRequestTypes';
 
 /**
  * Unsigned inner payloads that can be authenticated against the mobile service API.
@@ -22,6 +27,32 @@ import {
  * lowercases; unlike bytes32, string fields such as `display_name` are hashed as-is and keep their casing.
  */
 export type MobileSignedInner =
+  | ({
+      /** Capability-aware device registration. */
+      type: 'register_expo_token_v2';
+    } & MobileServerRegisterExpoTokenV2Params)
+  | {
+      /** Signed query for wallet markets and Identity bells. */
+      type: 'notification_subscriptions';
+    }
+  | ({
+      /** One revision-guarded subscription operation. */
+      type: 'update_notification_subscriptions';
+    } & MobileServerNotificationSubscriptionsUpdate)
+  | {
+      /** Signed query for the wallet's private notification page. */
+      type: 'notification_inbox_v2';
+      /** Previous page cursor, or nil for the first page. */
+      cursor: string | null;
+      /** Page size, or nil for the server default. */
+      limit: number | null;
+    }
+  | {
+      /** Atomic product analytics batch. */
+      type: 'record_product_events';
+      /** Events in caller order. */
+      events: MobileServerProductEvent[];
+    }
   | {
       /** Atomic post publication. */
       type: 'create_feed_post';
@@ -37,6 +68,10 @@ export type MobileSignedInner =
       mentions: MobileSocialFeedMention[];
       /** Original JSON text; omitted when absent. */
       drawing_data_json?: string;
+      /** Ordered ready image UUIDs; omitted when absent. */
+      image_ids?: string[];
+      /** Up to ten original HTTP/HTTPS URLs in order; omission differs from an empty array. */
+      image_urls?: string[];
     }
   | {
       /** Atomic comment publication. */
@@ -53,6 +88,22 @@ export type MobileSignedInner =
       mentions: MobileSocialFeedMention[];
       /** Optional owned position UUID. */
       attached_position_id?: string;
+      /** Ordered ready image UUIDs; omitted when absent. */
+      image_ids?: string[];
+      /** Up to ten original HTTP/HTTPS URLs in order; omission differs from an empty array. */
+      image_urls?: string[];
+    }
+  | {
+      /** Direct multipart post-image upload; content_hash is Keccak256 of the raw file bytes. */
+      type: 'create_feed_post_image_uploads';
+      /** `0x`-prefixed lowercase Keccak256 of the original file bytes. */
+      content_hash: Hex;
+    }
+  | {
+      /** Direct multipart comment-image upload; content_hash is Keccak256 of the raw file bytes. */
+      type: 'create_feed_comment_image_uploads';
+      /** `0x`-prefixed lowercase Keccak256 of the original file bytes. */
+      content_hash: Hex;
     }
   | {
       /** First attachment. */
@@ -86,15 +137,10 @@ export type MobileSignedInner =
     }
   | { type: 'set_username'; display_name: string }
   | { type: 'set_private_mode'; private_mode: boolean }
-  | {
+  | ({
+      /** Legacy device registration without a capability declaration. */
       type: 'register_expo_token';
-      expo_token: string;
-      platform: MobileNotificationPlatform;
-      // Optional on the wire, but always present (null when unset) so the msgpack payload hash matches the
-      // backend, which serializes `Option::None` as nil under the same key.
-      locale: string | null;
-      app_version: string | null;
-    }
+    } & MobileServerRegisterExpoTokenParams)
   | {
       type: 'set_follow';
       subaccount: Hex;

package/src/socialFeed.test.ts

@@ -82,7 +82,7 @@ const readSession: MobileServerSocialFeedReadSession = {
   session_id: 'OpaqueSession',
   mode: 'feed',
   expires_at_ms: 42,
-  view_tracking: { min_visible_ratio: 0.5, min_duration_ms: 1000 },
+
   update_cursor: null,
   viewer_token: 'OpaqueViewer',
 };
@@ -222,6 +222,7 @@ describe('[mobile-client]: social feed transport', () => {
       expect(requests[3].body.subaccount).not.toBe(requests[3].body.view_as);
       expect(requests[5].body.position_id).toBe(positionId.toUpperCase());
       expect(requests[6].body.item_id).toBe(itemId.toUpperCase());
+      expect(requests[6].body).not.toHaveProperty('view_event_id');
       expect(requests[6].body.comment_preview_limit).toBe(0);
       expect(requests[7].body).toEqual({
         type: 'feed_updates',
@@ -235,6 +236,65 @@ describe('[mobile-client]: social feed transport', () => {
     },
   );
 
+  it('reports multiple IDs and same-request duplicates without session fields or a signature', async () => {
+    const { client, requests } = mockClient({ status: 'success' });
+    client.opts.walletClient = undefined;
+    const itemIds = [itemId, 'cccccccc-cccc-4ccc-8ccc-cccccccccccc', itemId];
+    expect(await client.recordFeedViews({ itemIds })).toEqual({
+      status: 'success',
+    });
+    expect(requests).toEqual([
+      {
+        url: 'https://mobile.example/v1/mobile/public_execute',
+        body: { type: 'record_feed_views', item_ids: itemIds },
+      },
+    ]);
+    // A caller-initiated repeat remains a new report, not a cached or locally deduplicated result.
+    await client.recordFeedViews({ itemIds });
+    expect(requests).toHaveLength(2);
+    expect(requests[1].body).toEqual(requests[0].body);
+  });
+
+  it.each([
+    [400, 6310],
+    [503, 1006],
+    [503, 6320],
+  ])(
+    'preserves batch view failures (%i/%i) without retrying',
+    async (httpStatus, errorCode) => {
+      const { client, requests } = mockClient(
+        {
+          status: 'failure',
+          error: 'Batch rejected',
+          error_code: errorCode,
+          request_type: 'public_execute_record_feed_views',
+        },
+        httpStatus,
+      );
+      await expect(
+        client.recordFeedViews({ itemIds: [itemId] }),
+      ).rejects.toMatchObject({
+        name: 'MobileServerFailureError',
+        errorCode,
+        httpStatus,
+      });
+      expect(requests).toHaveLength(1);
+    },
+  );
+
+  it('does not retry a view report when the response may have been lost', async () => {
+    const { client } = mockClient();
+    let attempts = 0;
+    client.axiosInstance.defaults.adapter = () => {
+      attempts++;
+      return Promise.reject(new Error('Connection closed after sending'));
+    };
+    await expect(client.recordFeedViews({ itemIds: [itemId] })).rejects.toThrow(
+      'Connection closed',
+    );
+    expect(attempts).toBe(1);
+  });
+
   it('preserves update IDs, session credentials, and cursors unchanged', async () => {
     const { client, requests } = mockClient();
     client.opts.walletClient = undefined;
@@ -309,7 +369,7 @@ describe('[mobile-client]: social feed transport', () => {
         session_id: 'Session',
         mode: 'feed',
         expires_at_ms: 42,
-        view_tracking: { min_visible_ratio: 0.5, min_duration_ms: 1000 },
+
         update_cursor: null,
         viewer_token: 'Viewer',
       },
@@ -660,6 +720,7 @@ describe('[mobile-client]: social feed response mapping', () => {
       ...row,
       kind: 'trade_card',
       action: 'opened',
+      images: [],
       text: '',
       mentions: [],
       author: {

package/src/types/MobileUnsupportedNotificationRouteError.ts

@@ -0,0 +1,16 @@
+/**
+ * Error thrown when the mobile service returns a notification route this SDK does not support.
+ */
+export class MobileUnsupportedNotificationRouteError extends Error {
+  /** Unrecognized route name returned by the service. */
+  readonly routeName: string;
+
+  /**
+   * @param routeName - The unrecognized service route name.
+   */
+  constructor(routeName: string) {
+    super(`Unsupported mobile notification route "${routeName}".`);
+    this.name = 'MobileUnsupportedNotificationRouteError';
+    this.routeName = routeName;
+  }
+}