@nadicodeai/ui 12.1.36 → 12.1.38

package/dist/eslint/index.js

@@ -7,6 +7,8 @@ import { confirmDestructiveAction } from "./rules/confirm-destructive-action.js"
 import { drawerOwnsItsEdges } from "./rules/drawer-owns-its-edges.js";
 import { iconControlAccessibleName } from "./rules/icon-control-accessible-name.js";
 import { noAppFeatureComponent } from "./rules/no-app-feature-component.js";
+import { noBarePageNavigation } from "./rules/no-bare-page-navigation.js";
+import { noStoreCast } from "./rules/no-store-cast.js";
 import { noElevatedEdge } from "./rules/no-elevated-edge.js";
 import { noExistenceOnlyAssertion } from "./rules/no-existence-only-assertion.js";
 import { noNestedOverlay } from "./rules/no-nested-overlay.js";
@@ -119,6 +121,8 @@ const plugin = {
     "drawer-owns-its-edges": drawerOwnsItsEdges,
     "icon-control-accessible-name": iconControlAccessibleName,
     "no-app-feature-component": noAppFeatureComponent,
+    "no-bare-page-navigation": noBarePageNavigation,
+    "no-store-cast": noStoreCast,
     "no-elevated-edge": noElevatedEdge,
     "no-existence-only-assertion": noExistenceOnlyAssertion,
     "no-deprecated-zod-api": noDeprecatedZodApi,

package/dist/eslint/rules/no-bare-page-navigation.js

@@ -0,0 +1,46 @@
+/*
+ * The Portal's browser suite navigates through `tests/support/hydration.ts`.
+ * `page.goto` and `page.reload` resolve while React is still hydrating, and the
+ * interaction a spec dispatches next lands on server markup the shell is about
+ * to replace: #2173 lost six open menus that way, #2776 clicked "Create team"
+ * on a page that had not taken over yet, and #2837 read a prefetch as a
+ * refresh. `back` and `forward` are outside the rule, because they restore a
+ * tree the client already owns rather than loading a document.
+ */
+
+const NAVIGATIONS = new Map([
+  ["goto", "bareGoto"],
+  ["reload", "bareReload"],
+]);
+
+function propertyName(member) {
+  if (member.computed) return member.property.type === "Literal" ? member.property.value : null;
+  return member.property.type === "Identifier" ? member.property.name : null;
+}
+
+export const noBarePageNavigation = {
+  meta: {
+    type: "problem",
+    docs: {
+      description:
+        "Disallow a bare page.goto or page.reload in the Portal's browser suite; navigate through the helper that waits for the shell to hydrate",
+    },
+    schema: [],
+    messages: {
+      bareGoto:
+        "`goto()` resolves before React hydrates the page, so the next click or keypress lands on server markup the shell is about to replace (#2173, #2776, #2837). Open the page with `gotoPortal` from `tests/support/hydration`, which waits for the shell's `data-hydrated`, or with `gotoOutsideShell` for an address the dashboard shell never renders, such as login, signup or an app's consent page.",
+      bareReload:
+        "`reload()` resolves before React hydrates the page, so the next click or keypress lands on server markup the shell is about to replace (#2776). Reload with `reloadPortal` from `tests/support/hydration`, which waits for the shell's `data-hydrated`.",
+    },
+  },
+
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (node.callee.type !== "MemberExpression") return;
+        const messageId = NAVIGATIONS.get(propertyName(node.callee));
+        if (messageId) context.report({ node, messageId });
+      },
+    };
+  },
+};

package/dist/eslint/rules/no-store-cast.js

@@ -0,0 +1,46 @@
+/*
+ * A test hands the subject the store methods it calls, as an object typed by
+ * the subject's own parameter. `as PortalStore` (or `as unknown as
+ * PortalStore`) turns a partial object into the whole 227-method store: the
+ * compiler then checks nothing about the methods the fake does implement, and a
+ * subject that grows a call reaches `undefined` at run time instead of failing
+ * to compile. Narrow the subject's parameter to the capability it uses
+ * (`Pick<SomePersistence, "a" | "b">`), then build the fake as that type.
+ */
+
+export const noStoreCast = {
+  meta: {
+    type: "problem",
+    docs: {
+      description:
+        "Disallow casting a partial object to the whole store in a test; type the subject by the store methods it calls and build the fake as that type",
+    },
+    schema: [
+      {
+        type: "object",
+        properties: { types: { type: "array", items: { type: "string" } } },
+        additionalProperties: false,
+      },
+    ],
+    messages: {
+      storeCast:
+        '`as {{name}}` hides which store methods this fake implements, so the compiler checks none of them. Type the subject\'s store parameter as the methods it calls (`Pick<SomePersistence, "a" | "b">`) and build the fake as `Parameters<typeof subject>[0]`.',
+    },
+  },
+
+  create(context) {
+    const names = new Set(context.options[0]?.types ?? ["PortalStore"]);
+    return {
+      TSAsExpression(node) {
+        const type = node.typeAnnotation;
+        if (
+          type.type === "TSTypeReference" &&
+          type.typeName.type === "Identifier" &&
+          names.has(type.typeName.name)
+        ) {
+          context.report({ node, messageId: "storeCast", data: { name: type.typeName.name } });
+        }
+      },
+    };
+  },
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nadicodeai/ui",
-  "version": "12.1.36",
+  "version": "12.1.38",
   "type": "module",
   "publishConfig": {
     "access": "public"
@@ -77,7 +77,7 @@
     "@assistant-ui/react": "0.15.21",
     "@assistant-ui/react-markdown": "0.14.16",
     "@base-ui/react": "^1.8.0",
-    "@nadicodeai/design-system": "12.1.36",
+    "@nadicodeai/design-system": "12.1.38",
     "class-variance-authority": "^0.7.1",
     "clsx": "^2.1.1",
     "cmdk": "^1.1.1",