@nadicodeai/ui 12.1.144 → 12.1.145

package/dist/eslint/rules/server-action-discipline.js

@@ -41,6 +41,12 @@ const AUTH_CALLS = new Set([
  */
 const VALIDATION_CALLS = new Set(["parse", "safeParse"]);
 
+const FUNCTION_TYPES = new Set([
+  "FunctionDeclaration",
+  "FunctionExpression",
+  "ArrowFunctionExpression",
+]);
+
 function hasUseServer(body) {
   return (body ?? []).some(
     (statement) =>
@@ -90,12 +96,40 @@ function exportedIdentifier(node) {
   return undefined;
 }
 
+function inServerActionCode(node, moduleIsServer) {
+  if (moduleIsServer) return true;
+  for (let ancestor = node.parent; ancestor; ancestor = ancestor.parent) {
+    if (FUNCTION_TYPES.has(ancestor.type) && hasUseServer(ancestor.body?.body)) return true;
+  }
+  return false;
+}
+
+function inlineRejectionHandler(node) {
+  const handler = node.arguments[0];
+  if (node.callee.type !== "MemberExpression" || node.callee.property.type !== "Identifier") {
+    return undefined;
+  }
+  if (node.callee.property.name !== "catch" || !FUNCTION_TYPES.has(handler?.type)) return undefined;
+  return handler;
+}
+
+function dropsTheError(sourceCode, node, bindings) {
+  if (bindings.length === 0) return true;
+  return sourceCode
+    .getDeclaredVariables(node)
+    .filter((variable) =>
+      variable.defs.some((def) => def.type === "CatchClause" || def.type === "Parameter"),
+    )
+    .every((variable) => variable.references.length === 0);
+}
+
 /** @type {import("eslint").Rule.RuleModule} */
 export const serverActionDiscipline = {
   meta: {
     type: "problem",
     docs: {
-      description: "An exported server action resolves its viewer and parses its client input.",
+      description:
+        "An exported server action resolves its viewer and parses its client input, and server-action code never drops an error it catches.",
     },
     schema: [],
     messages: {
@@ -103,10 +137,13 @@ export const serverActionDiscipline = {
         "Server action '{{name}}' calls no viewer check. Resolve the viewer first (actionActor, requirePortalViewer, companyActionContext, …), or disable this rule inline with the reason it is public.",
       missingValidation:
         "Server action '{{name}}' takes client input and never parses it. Run the Zod schema's parse/safeParse before trusting the argument.",
+      droppedError:
+        "This catch drops the error it handles, so an outage reaches the form as an ordinary answer and leaves no log line. Name the error and translate it, answer the form's unavailable state with actionUnavailable, which logs it once, or rethrow it.",
     },
   },
   create(context) {
-    const moduleIsServer = hasUseServer(context.sourceCode.ast.body);
+    const { sourceCode } = context;
+    const moduleIsServer = hasUseServer(sourceCode.ast.body);
     /**
      * One frame per function, holding only the calls written in that function's
      * own body. A call parked inside a nested callback is not a call the action
@@ -160,7 +197,21 @@ export const serverActionDiscipline = {
           if (local?.type === "Identifier") specifierExports.add(local.name);
         }
       },
+      CatchClause(node) {
+        const bindings = node.param ? [node.param] : [];
+        if (inServerActionCode(node, moduleIsServer) && dropsTheError(sourceCode, node, bindings)) {
+          context.report({ node, messageId: "droppedError" });
+        }
+      },
       CallExpression(node) {
+        const handler = inlineRejectionHandler(node);
+        if (
+          handler &&
+          inServerActionCode(node, moduleIsServer) &&
+          dropsTheError(sourceCode, handler, handler.params)
+        ) {
+          context.report({ node: handler, messageId: "droppedError" });
+        }
         const name = calleeName(node);
         if (!name) return;
         callStack.at(-1)?.add(name);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nadicodeai/ui",
-  "version": "12.1.144",
+  "version": "12.1.145",
   "type": "module",
   "publishConfig": {
     "access": "public"
@@ -83,7 +83,7 @@
     "@base-ui/react": "^1.9.0",
     "@iconify-icons/logos": "^2.0.3",
     "@iconify/react": "^6.0.2",
-    "@nadicodeai/design-system": "12.1.144",
+    "@nadicodeai/design-system": "12.1.145",
     "@tanstack/react-table": "^9.3.1",
     "@vgpu/wgsl": "0.6.0",
     "class-variance-authority": "^0.7.1",