@n8n/eslint-plugin-community-nodes 0.31.0 → 0.33.0

package/dist/rules/valid-credential-references.js

@@ -1,5 +1,4 @@
-import { TSESTree } from '@typescript-eslint/utils';
-import { isNodeTypeClass, findClassProperty, findArrayLiteralProperty, extractCredentialNameFromArray, findPackageJson, readPackageJsonCredentials, isFileType, findSimilarStrings, createRule, } from '../utils/index.js';
+import { isNodeTypeClass, findNodeDescriptionObject, findArrayLiteralProperty, extractCredentialNameFromArray, findPackageJson, readPackageJsonCredentials, isFileType, findSimilarStrings, createRule, } from '../utils/index.js';
 export const ValidCredentialReferencesRule = createRule({
     name: 'valid-credential-references',
     meta: {
@@ -37,12 +36,11 @@ export const ValidCredentialReferencesRule = createRule({
                 if (!isNodeTypeClass(node)) {
                     return;
                 }
-                const descriptionProperty = findClassProperty(node, 'description');
-                if (!descriptionProperty?.value ||
-                    descriptionProperty.value.type !== TSESTree.AST_NODE_TYPES.ObjectExpression) {
+                const description = findNodeDescriptionObject(node);
+                if (!description) {
                     return;
                 }
-                const credentialsArray = findArrayLiteralProperty(descriptionProperty.value, 'credentials');
+                const credentialsArray = findArrayLiteralProperty(description, 'credentials');
                 if (!credentialsArray) {
                     return;
                 }

package/dist/rules/valid-description.d.ts

@@ -1,2 +1,4 @@
-export declare const ValidDescriptionRule: import("@typescript-eslint/utils/ts-eslint").RuleModule<"emptyDescription" | "missingDescription", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export declare const ValidDescriptionRule: import("@typescript-eslint/utils/ts-eslint").RuleModule<"emptyDescription" | "missingDescription", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
+    name: string;
+};
 //# sourceMappingURL=valid-description.d.ts.map

package/dist/rules/valid-description.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"valid-description.d.ts","sourceRoot":"","sources":["../../src/rules/valid-description.ts"],"names":[],"mappings":"AAKA,eAAO,MAAM,oBAAoB,4KAmD/B,CAAC"}
+{"version":3,"file":"valid-description.d.ts","sourceRoot":"","sources":["../../src/rules/valid-description.ts"],"names":[],"mappings":"AAKA,eAAO,MAAM,oBAAoB;;CAmD/B,CAAC"}

package/dist/rules/valid-peer-dependencies.d.ts

@@ -1,2 +1,4 @@
-export declare const ValidPeerDependenciesRule: import("@typescript-eslint/utils/ts-eslint").RuleModule<"forbiddenPeerDependency" | "invalidPeerDependenciesType" | "missingN8nWorkflow" | "missingPeerDependencies" | "pinnedN8nWorkflow", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export declare const ValidPeerDependenciesRule: import("@typescript-eslint/utils/ts-eslint").RuleModule<"forbiddenPeerDependency" | "invalidPeerDependenciesType" | "missingN8nWorkflow" | "missingPeerDependencies" | "pinnedN8nWorkflow", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
+    name: string;
+};
 //# sourceMappingURL=valid-peer-dependencies.d.ts.map

package/dist/rules/valid-peer-dependencies.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"valid-peer-dependencies.d.ts","sourceRoot":"","sources":["../../src/rules/valid-peer-dependencies.ts"],"names":[],"mappings":"AAWA,eAAO,MAAM,yBAAyB,qQA0GpC,CAAC"}
+{"version":3,"file":"valid-peer-dependencies.d.ts","sourceRoot":"","sources":["../../src/rules/valid-peer-dependencies.ts"],"names":[],"mappings":"AAWA,eAAO,MAAM,yBAAyB;;CA0GpC,CAAC"}

package/dist/rules/webhook-lifecycle-complete.d.ts

@@ -1,2 +1,4 @@
-export declare const WebhookLifecycleCompleteRule: import("@typescript-eslint/utils/ts-eslint").RuleModule<"emptyWebhookMethods" | "missingLifecycleMethod" | "missingWebhookMethods", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export declare const WebhookLifecycleCompleteRule: import("@typescript-eslint/utils/ts-eslint").RuleModule<"emptyWebhookMethods" | "missingLifecycleMethod" | "missingWebhookMethods", [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
+    name: string;
+};
 //# sourceMappingURL=webhook-lifecycle-complete.d.ts.map

package/dist/rules/webhook-lifecycle-complete.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"webhook-lifecycle-complete.d.ts","sourceRoot":"","sources":["../../src/rules/webhook-lifecycle-complete.ts"],"names":[],"mappings":"AA8CA,eAAO,MAAM,4BAA4B,6MAkFvC,CAAC"}
+{"version":3,"file":"webhook-lifecycle-complete.d.ts","sourceRoot":"","sources":["../../src/rules/webhook-lifecycle-complete.ts"],"names":[],"mappings":"AA8CA,eAAO,MAAM,4BAA4B;;CAkFvC,CAAC"}

package/dist/utils/ast-utils.d.ts

@@ -10,6 +10,12 @@ export declare function isTriggerNodeClass(node: TSESTree.ClassDeclaration): boo
  */
 export declare function isTriggerNode(node: TSESTree.ClassDeclaration, descriptionValue: TSESTree.ObjectExpression): boolean;
 export declare function findClassProperty(node: TSESTree.ClassDeclaration, propertyName: string): TSESTree.PropertyDefinition | null;
+/**
+ * Returns the `description` object literal of a node class. Versioned nodes
+ * follow the layout in the node-building docs and assign `this.description` in
+ * their constructor, so look there when the class property has no initializer.
+ */
+export declare function findNodeDescriptionObject(node: TSESTree.ClassDeclaration): TSESTree.ObjectExpression | null;
 export declare function findObjectProperty(obj: TSESTree.ObjectExpression, propertyName: string): TSESTree.Property | null;
 export declare function getLiteralValue(node: TSESTree.Node | null): string | boolean | number | null;
 export declare function getStringLiteralValue(node: TSESTree.Node | null): string | null;

package/dist/utils/ast-utils.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ast-utils.d.ts","sourceRoot":"","sources":["../../src/utils/ast-utils.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,0BAA0B,CAAC;AAezD,wBAAgB,eAAe,CAAC,IAAI,EAAE,QAAQ,CAAC,gBAAgB,GAAG,OAAO,CAUxE;AAED,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,QAAQ,CAAC,gBAAgB,GAAG,OAAO,CAE9E;AAED,sGAAsG;AACtG,wBAAgB,kBAAkB,CAAC,IAAI,EAAE,QAAQ,CAAC,gBAAgB,GAAG,OAAO,CAE3E;AAWD;;;;GAIG;AACH,wBAAgB,aAAa,CAC5B,IAAI,EAAE,QAAQ,CAAC,gBAAgB,EAC/B,gBAAgB,EAAE,QAAQ,CAAC,gBAAgB,GACzC,OAAO,CAET;AAED,wBAAgB,iBAAiB,CAChC,IAAI,EAAE,QAAQ,CAAC,gBAAgB,EAC/B,YAAY,EAAE,MAAM,GAClB,QAAQ,CAAC,kBAAkB,GAAG,IAAI,CAQpC;AAED,wBAAgB,kBAAkB,CACjC,GAAG,EAAE,QAAQ,CAAC,gBAAgB,EAC9B,YAAY,EAAE,MAAM,GAClB,QAAQ,CAAC,QAAQ,GAAG,IAAI,CAQ1B;AAED,wBAAgB,eAAe,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,GAAG,IAAI,GAAG,MAAM,GAAG,OAAO,GAAG,MAAM,GAAG,IAAI,CAK5F;AAED,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,GAAG,IAAI,GAAG,MAAM,GAAG,IAAI,CAG/E;AAED,wBAAgB,aAAa,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,GAAG,IAAI,GAAG,MAAM,GAAG,IAAI,CAevE;AAED,wBAAgB,sBAAsB,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,GAAG,IAAI,GAAG,OAAO,GAAG,IAAI,CAGjF;AAED,wBAAgB,gBAAgB,CAC/B,GAAG,EAAE,QAAQ,CAAC,gBAAgB,EAC9B,YAAY,EAAE,MAAM,GAClB,QAAQ,CAAC,QAAQ,GAAG,IAAI,CAQ1B;AAED,wBAAgB,wBAAwB,CACvC,GAAG,EAAE,QAAQ,CAAC,gBAAgB,EAC9B,YAAY,EAAE,MAAM,GAClB,QAAQ,CAAC,eAAe,GAAG,IAAI,CAMjC;AAED,wBAAgB,oBAAoB,CACnC,IAAI,EAAE,QAAQ,CAAC,kBAAkB,EACjC,WAAW,EAAE,MAAM,GACjB,OAAO,CAST;AAED,wBAAgB,uBAAuB,CACtC,IAAI,EAAE,QAAQ,CAAC,gBAAgB,GAC7B,QAAQ,CAAC,gBAAgB,GAAG,IAAI,CASlC;AAED,wBAAgB,UAAU,CAAC,QAAQ,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,GAAG,OAAO,CAEvE;AAED,wBAAgB,mBAAmB,CAAC,IAAI,EAAE,QAAQ,CAAC,cAAc,GAAG,OAAO,CAM1E;AAED,wBAAgB,mBAAmB,CAAC,IAAI,EAAE,QAAQ,CAAC,cAAc,GAAG,OAAO,CAO1E;AAED,wBAAgB,8BAA8B,CAC7C,OAAO,EAAE,QAAQ,CAAC,eAAe,CAAC,UAAU,CAAC,CAAC,MAAM,CAAC,GACnD;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,QAAQ,CAAC,EAAE,MAAM,CAAC;IAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,CAAA;CAAE,GAAG,IAAI,CA6BjE;AAED,wBAAgB,8BAA8B,CAC7C,OAAO,EAAE,QAAQ,CAAC,eAAe,CAAC,UAAU,CAAC,CAAC,MAAM,CAAC,GACnD;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,CAAA;CAAE,GAAG,IAAI,CAG9C;AAED,2FAA2F;AAC3F,wBAAgB,mBAAmB,CAAC,IAAI,EAAE,QAAQ,CAAC,gBAAgB,GAAG,OAAO,CAO5E;AAED,oEAAoE;AACpE,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,QAAQ,CAAC,cAAc,EAAE,MAAM,EAAE,MAAM,GAAG,OAAO,CAOvF;AAED,4EAA4E;AAC5E,wBAAgB,uBAAuB,CAAC,IAAI,EAAE,QAAQ,CAAC,cAAc,EAAE,MAAM,EAAE,MAAM,GAAG,OAAO,CAO9F;AAED,wBAAgB,kBAAkB,CACjC,MAAM,EAAE,MAAM,EACd,UAAU,EAAE,GAAG,CAAC,MAAM,CAAC,EACvB,WAAW,GAAE,MAAU,EACvB,UAAU,GAAE,MAAU,GACpB,MAAM,EAAE,CAeV"}
+{"version":3,"file":"ast-utils.d.ts","sourceRoot":"","sources":["../../src/utils/ast-utils.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,0BAA0B,CAAC;AAezD,wBAAgB,eAAe,CAAC,IAAI,EAAE,QAAQ,CAAC,gBAAgB,GAAG,OAAO,CAUxE;AAED,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,QAAQ,CAAC,gBAAgB,GAAG,OAAO,CAE9E;AAED,sGAAsG;AACtG,wBAAgB,kBAAkB,CAAC,IAAI,EAAE,QAAQ,CAAC,gBAAgB,GAAG,OAAO,CAE3E;AAWD;;;;GAIG;AACH,wBAAgB,aAAa,CAC5B,IAAI,EAAE,QAAQ,CAAC,gBAAgB,EAC/B,gBAAgB,EAAE,QAAQ,CAAC,gBAAgB,GACzC,OAAO,CAET;AAED,wBAAgB,iBAAiB,CAChC,IAAI,EAAE,QAAQ,CAAC,gBAAgB,EAC/B,YAAY,EAAE,MAAM,GAClB,QAAQ,CAAC,kBAAkB,GAAG,IAAI,CAQpC;AAoDD;;;;GAIG;AACH,wBAAgB,yBAAyB,CACxC,IAAI,EAAE,QAAQ,CAAC,gBAAgB,GAC7B,QAAQ,CAAC,gBAAgB,GAAG,IAAI,CAQlC;AAED,wBAAgB,kBAAkB,CACjC,GAAG,EAAE,QAAQ,CAAC,gBAAgB,EAC9B,YAAY,EAAE,MAAM,GAClB,QAAQ,CAAC,QAAQ,GAAG,IAAI,CAQ1B;AAED,wBAAgB,eAAe,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,GAAG,IAAI,GAAG,MAAM,GAAG,OAAO,GAAG,MAAM,GAAG,IAAI,CAK5F;AAED,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,GAAG,IAAI,GAAG,MAAM,GAAG,IAAI,CAG/E;AAED,wBAAgB,aAAa,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,GAAG,IAAI,GAAG,MAAM,GAAG,IAAI,CAevE;AAED,wBAAgB,sBAAsB,CAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,GAAG,IAAI,GAAG,OAAO,GAAG,IAAI,CAGjF;AAED,wBAAgB,gBAAgB,CAC/B,GAAG,EAAE,QAAQ,CAAC,gBAAgB,EAC9B,YAAY,EAAE,MAAM,GAClB,QAAQ,CAAC,QAAQ,GAAG,IAAI,CAQ1B;AAED,wBAAgB,wBAAwB,CACvC,GAAG,EAAE,QAAQ,CAAC,gBAAgB,EAC9B,YAAY,EAAE,MAAM,GAClB,QAAQ,CAAC,eAAe,GAAG,IAAI,CAMjC;AAED,wBAAgB,oBAAoB,CACnC,IAAI,EAAE,QAAQ,CAAC,kBAAkB,EACjC,WAAW,EAAE,MAAM,GACjB,OAAO,CAST;AAED,wBAAgB,uBAAuB,CACtC,IAAI,EAAE,QAAQ,CAAC,gBAAgB,GAC7B,QAAQ,CAAC,gBAAgB,GAAG,IAAI,CASlC;AAED,wBAAgB,UAAU,CAAC,QAAQ,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,GAAG,OAAO,CAEvE;AAED,wBAAgB,mBAAmB,CAAC,IAAI,EAAE,QAAQ,CAAC,cAAc,GAAG,OAAO,CAM1E;AAED,wBAAgB,mBAAmB,CAAC,IAAI,EAAE,QAAQ,CAAC,cAAc,GAAG,OAAO,CAO1E;AAED,wBAAgB,8BAA8B,CAC7C,OAAO,EAAE,QAAQ,CAAC,eAAe,CAAC,UAAU,CAAC,CAAC,MAAM,CAAC,GACnD;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,QAAQ,CAAC,EAAE,MAAM,CAAC;IAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,CAAA;CAAE,GAAG,IAAI,CA6BjE;AAED,wBAAgB,8BAA8B,CAC7C,OAAO,EAAE,QAAQ,CAAC,eAAe,CAAC,UAAU,CAAC,CAAC,MAAM,CAAC,GACnD;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,IAAI,EAAE,QAAQ,CAAC,IAAI,CAAA;CAAE,GAAG,IAAI,CAG9C;AAED,2FAA2F;AAC3F,wBAAgB,mBAAmB,CAAC,IAAI,EAAE,QAAQ,CAAC,gBAAgB,GAAG,OAAO,CAO5E;AAED,oEAAoE;AACpE,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,QAAQ,CAAC,cAAc,EAAE,MAAM,EAAE,MAAM,GAAG,OAAO,CAOvF;AAED,4EAA4E;AAC5E,wBAAgB,uBAAuB,CAAC,IAAI,EAAE,QAAQ,CAAC,cAAc,EAAE,MAAM,EAAE,MAAM,GAAG,OAAO,CAO9F;AAED,wBAAgB,kBAAkB,CACjC,MAAM,EAAE,MAAM,EACd,UAAU,EAAE,GAAG,CAAC,MAAM,CAAC,EACvB,WAAW,GAAE,MAAU,EACvB,UAAU,GAAE,MAAU,GACpB,MAAM,EAAE,CAeV"}

package/dist/utils/ast-utils.js

@@ -39,6 +39,56 @@ export function findClassProperty(node, propertyName) {
         member.key.name === propertyName);
     return property?.type === AST_NODE_TYPES.PropertyDefinition ? property : null;
 }
+/**
+ * Returns the object literal behind an expression, and looks through the type
+ * assertions node authors write, e.g. `{ … } as INodeTypeDescription`.
+ */
+function asObjectExpression(node) {
+    let current = node;
+    while (current?.type === AST_NODE_TYPES.TSAsExpression ||
+        current?.type === AST_NODE_TYPES.TSSatisfiesExpression ||
+        current?.type === AST_NODE_TYPES.TSTypeAssertion ||
+        current?.type === AST_NODE_TYPES.TSNonNullExpression) {
+        current = current.expression;
+    }
+    return current?.type === AST_NODE_TYPES.ObjectExpression ? current : null;
+}
+function findConstructorAssignedDescription(node) {
+    const constructor = node.body.body.find((member) => member.type === AST_NODE_TYPES.MethodDefinition && member.kind === 'constructor');
+    if (constructor?.type !== AST_NODE_TYPES.MethodDefinition) {
+        return null;
+    }
+    for (const statement of constructor.value.body?.body ?? []) {
+        if (statement.type !== AST_NODE_TYPES.ExpressionStatement)
+            continue;
+        const { expression } = statement;
+        if (expression.type === AST_NODE_TYPES.AssignmentExpression &&
+            expression.operator === '=' &&
+            expression.left.type === AST_NODE_TYPES.MemberExpression &&
+            expression.left.object.type === AST_NODE_TYPES.ThisExpression &&
+            expression.left.property.type === AST_NODE_TYPES.Identifier &&
+            expression.left.property.name === 'description') {
+            const description = asObjectExpression(expression.right);
+            if (description) {
+                return description;
+            }
+        }
+    }
+    return null;
+}
+/**
+ * Returns the `description` object literal of a node class. Versioned nodes
+ * follow the layout in the node-building docs and assign `this.description` in
+ * their constructor, so look there when the class property has no initializer.
+ */
+export function findNodeDescriptionObject(node) {
+    const property = findClassProperty(node, 'description');
+    const propertyValue = asObjectExpression(property?.value ?? null);
+    if (propertyValue) {
+        return propertyValue;
+    }
+    return findConstructorAssignedDescription(node);
+}
 export function findObjectProperty(obj, propertyName) {
     const property = obj.properties.find((prop) => prop.type === AST_NODE_TYPES.Property &&
         prop.key.type === AST_NODE_TYPES.Identifier &&

package/dist/utils/file-utils.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"file-utils.d.ts","sourceRoot":"","sources":["../../src/utils/file-utils.ts"],"names":[],"mappings":"AAgBA;;;GAGG;AACH,wBAAgB,iBAAiB,CAAC,UAAU,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,GAAG,OAAO,CAShF;AAED;;;;;;GAMG;AACH,wBAAgB,YAAY,CAAC,UAAU,EAAE,MAAM,EAAE,GAAG,KAAK,EAAE,MAAM,EAAE,GAAG,MAAM,CAU3E;AAED,wBAAgB,eAAe,CAAC,SAAS,EAAE,MAAM,GAAG,MAAM,GAAG,IAAI,CAahE;AA+BD;;;;;GAKG;AACH,wBAAgB,8BAA8B,CAAC,eAAe,EAAE,MAAM,GAAG,IAAI,GAAG,GAAG,CAAC,MAAM,CAAC,CAO1F;AAkBD,wBAAgB,0BAA0B,CAAC,eAAe,EAAE,MAAM,GAAG,GAAG,CAAC,MAAM,CAAC,CAkB/E;AAED,wBAAgB,6BAA6B,CAAC,kBAAkB,EAAE,MAAM,GAAG,MAAM,GAAG,IAAI,CA4BvF;AAED,wBAAgB,gBAAgB,CAC/B,QAAQ,EAAE,MAAM,EAChB,OAAO,EAAE,MAAM,GACb;IACF,OAAO,EAAE,OAAO,CAAC;IACjB,MAAM,EAAE,OAAO,CAAC;IAChB,MAAM,EAAE,OAAO,CAAC;CAChB,CAYA;AAED,wBAAgB,oBAAoB,CAAC,eAAe,EAAE,MAAM,GAAG,MAAM,EAAE,CAItE;AAwBD;;;;GAIG;AACH,wBAAgB,yBAAyB,CAAC,eAAe,EAAE,MAAM,GAAG,MAAM,EAAE,CAS3E;AAED;;;;GAIG;AACH,wBAAgB,sBAAsB,CACrC,eAAe,EAAE,MAAM,EACvB,IAAI,EAAE,MAAM,EAAE,EACd,OAAO,EAAE,CAAC,QAAQ,EAAE,MAAM,KAAK,OAAO,GACpC,MAAM,EAAE,CAYV;AAED,wBAAgB,mCAAmC,CAClD,cAAc,EAAE,MAAM,EACtB,UAAU,EAAE,MAAM,GAChB,OAAO,CAoBT;AAiED,wBAAgB,oBAAoB,CAAC,UAAU,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,GAAG,MAAM,EAAE,CAiClF"}
+{"version":3,"file":"file-utils.d.ts","sourceRoot":"","sources":["../../src/utils/file-utils.ts"],"names":[],"mappings":"AAgBA;;;GAGG;AACH,wBAAgB,iBAAiB,CAAC,UAAU,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,GAAG,OAAO,CAShF;AAED;;;;;;GAMG;AACH,wBAAgB,YAAY,CAAC,UAAU,EAAE,MAAM,EAAE,GAAG,KAAK,EAAE,MAAM,EAAE,GAAG,MAAM,CAU3E;AAED,wBAAgB,eAAe,CAAC,SAAS,EAAE,MAAM,GAAG,MAAM,GAAG,IAAI,CAahE;AA+BD;;;;;GAKG;AACH,wBAAgB,8BAA8B,CAAC,eAAe,EAAE,MAAM,GAAG,IAAI,GAAG,GAAG,CAAC,MAAM,CAAC,CAO1F;AAkBD,wBAAgB,0BAA0B,CAAC,eAAe,EAAE,MAAM,GAAG,GAAG,CAAC,MAAM,CAAC,CAkB/E;AAED,wBAAgB,6BAA6B,CAAC,kBAAkB,EAAE,MAAM,GAAG,MAAM,GAAG,IAAI,CA4BvF;AAED,wBAAgB,gBAAgB,CAC/B,QAAQ,EAAE,MAAM,EAChB,OAAO,EAAE,MAAM,GACb;IACF,OAAO,EAAE,OAAO,CAAC;IACjB,MAAM,EAAE,OAAO,CAAC;IAChB,MAAM,EAAE,OAAO,CAAC;CAChB,CAYA;AAED,wBAAgB,oBAAoB,CAAC,eAAe,EAAE,MAAM,GAAG,MAAM,EAAE,CAItE;AAwBD;;;;GAIG;AACH,wBAAgB,yBAAyB,CAAC,eAAe,EAAE,MAAM,GAAG,MAAM,EAAE,CAS3E;AAED;;;;GAIG;AACH,wBAAgB,sBAAsB,CACrC,eAAe,EAAE,MAAM,EACvB,IAAI,EAAE,MAAM,EAAE,EACd,OAAO,EAAE,CAAC,QAAQ,EAAE,MAAM,KAAK,OAAO,GACpC,MAAM,EAAE,CAYV;AAED,wBAAgB,mCAAmC,CAClD,cAAc,EAAE,MAAM,EACtB,UAAU,EAAE,MAAM,GAChB,OAAO,CAoBT;AA8DD,wBAAgB,oBAAoB,CAAC,UAAU,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,GAAG,MAAM,EAAE,CAiClF"}

package/dist/utils/file-utils.js

@@ -229,8 +229,7 @@ function checkCredentialUsageInFile(nodeFile, credentialName) {
             enter(node) {
                 if (node.type === AST_NODE_TYPES.ClassDeclaration && isNodeTypeClass(node)) {
                     const descriptionProperty = findClassProperty(node, 'description');
-                    if (!descriptionProperty?.value ||
-                        descriptionProperty.value.type !== AST_NODE_TYPES.ObjectExpression) {
+                    if (descriptionProperty?.value?.type !== AST_NODE_TYPES.ObjectExpression) {
                         return;
                     }
                     const credentialsArray = findArrayLiteralProperty(descriptionProperty.value, 'credentials');

package/dist/utils/rule-creator.d.ts

@@ -1,3 +1,5 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-export declare const createRule: <Options extends readonly unknown[], MessageIds extends string>({ meta, name, ...rule }: Readonly<ESLintUtils.RuleWithMetaAndName<Options, MessageIds, unknown>>) => ESLintUtils.RuleModule<MessageIds, Options, unknown, ESLintUtils.RuleListener>;
+export declare const createRule: <Options extends readonly unknown[], MessageIds extends string>({ meta, name, ...rule }: Readonly<ESLintUtils.RuleWithMetaAndName<Options, MessageIds, unknown>>) => ESLintUtils.RuleModule<MessageIds, Options, unknown, ESLintUtils.RuleListener> & {
+    name: string;
+};
 //# sourceMappingURL=rule-creator.d.ts.map

package/dist/utils/rule-creator.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"rule-creator.d.ts","sourceRoot":"","sources":["../../src/utils/rule-creator.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAKvD,eAAO,MAAM,UAAU,qPAA2E,CAAC"}
+{"version":3,"file":"rule-creator.d.ts","sourceRoot":"","sources":["../../src/utils/rule-creator.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAKvD,eAAO,MAAM,UAAU;;CAA2E,CAAC"}

package/docs/rules/icon-prefer-themed-variants.md

@@ -17,8 +17,8 @@ an error: most existing nodes ship a single icon, so this nudges authors toward
 themed variants without failing verification.
 
 The companion `icon-validation` rule still validates that the referenced files
-exist, use the `file:` protocol, and that the light and dark variants point to
-different files.
+exist and use the `file:` protocol. Both slots can point to the same file if one
+icon design works on both themes.
 
 ## Examples
 

package/docs/rules/icon-validation.md

@@ -1,4 +1,4 @@
-# Validate node and credential icon files exist, use the file: protocol, and that light/dark icons are different (`@n8n/community-nodes/icon-validation`)
+# Validate node and credential icon files exist and use the file: protocol (`@n8n/community-nodes/icon-validation`)
 
 💼 This rule is enabled in the following configs: ✅ `recommended`, ☑️ `recommendedWithoutN8nCloudSupport`.
 
@@ -8,7 +8,7 @@
 
 ## Rule Details
 
-Validates that your node and credential icon files exist and use the correct `file:` protocol. Icons must be different files when providing light/dark theme variants.
+Validates that your node and credential icon files exist and use the correct `file:` protocol. The `light` and `dark` slots can point to the same file: one theme-agnostic icon is a valid choice, and you do not have to copy it under a second filename.
 
 Both SVG and PNG icons are accepted. SVG is recommended (it scales cleanly and supports theming), but PNG is allowed — see the `icon-prefer-themed-variants` rule for the related light/dark nudge.
 
@@ -27,28 +27,28 @@ export class MyNode implements INodeType {
 }
 ```
 
+### ✅ Correct
+
 ```typescript
 export class MyNode implements INodeType {
   description: INodeTypeDescription = {
     displayName: 'My Node',
     name: 'myNode',
-    icon: {
-      light: 'file:icons/my-icon.svg',
-      dark: 'file:icons/my-icon.svg', // Same file for both themes
-    },
+    icon: 'file:icons/my-service.svg', // Correct format
     // ...
   };
 }
 ```
 
-### ✅ Correct
-
 ```typescript
 export class MyNode implements INodeType {
   description: INodeTypeDescription = {
     displayName: 'My Node',
     name: 'myNode',
-    icon: 'file:icons/my-service.svg', // Correct format
+    icon: {
+      light: 'file:icons/my-service-light.svg',
+      dark: 'file:icons/my-service-dark.svg', // Different files
+    },
     // ...
   };
 }
@@ -60,8 +60,8 @@ export class MyNode implements INodeType {
     displayName: 'My Node',
     name: 'myNode',
     icon: {
-      light: 'file:icons/my-service-light.svg',
-      dark: 'file:icons/my-service-dark.svg', // Different files
+      light: 'file:icons/my-service.svg',
+      dark: 'file:icons/my-service.svg', // One file that works on both themes
     },
     // ...
   };

package/docs/rules/no-unsafe-connection-type-cast.md

@@ -0,0 +1,58 @@
+# Disallow type-erasing casts (`as never`, `as any`, `as unknown`) on node description `inputs`/`outputs` (`@n8n/community-nodes/no-unsafe-connection-type-cast`)
+
+💼 This rule is enabled in the following configs: ✅ `recommended`, ☑️ `recommendedWithoutN8nCloudSupport`.
+
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
+
+<!-- end auto-generated rule header -->
+
+## Rule Details
+
+A cast such as `inputs: ['main'] as never` compiles, so nothing in CI objects to it. It also switches off the check that makes `inputs` and `outputs` trustworthy. TypeScript stops verifying the value against `INodeTypeDescription`, and the [`node-connection-type-literal`](node-connection-type-literal.md) rule stops seeing the array, because the cast wraps it. A malformed connection declaration then reaches review and build with no automated signal at all. Removing the cast restores both checks.
+
+There is no legitimate reason to erase the type here. Dynamic connection lists are already allowed as expression strings, and correct static lists type-check on their own:
+
+```typescript
+inputs: `={{ (${configureInputs})($parameter) }}`,
+```
+
+The rule flags `as never`, `as any` and `as unknown`, including inside a chain like `as unknown as NodeConnectionType[]`, where the intermediate `unknown` is what defeats the checker. Expressions that keep the value structurally checked are left alone: `as const`, `satisfies T` and a plain `as NodeConnectionType[]`.
+
+A `satisfies` around a cast does not restore the check, so `['main'] as never satisfies NodeConnectionType[]` is still reported. The suggestion removes the cast and keeps the `satisfies`.
+
+Removing the cast is offered as a suggestion rather than an autofix, because it may surface a real type error that was being suppressed. That error is the point: it is the bug the cast was hiding.
+
+## Examples
+
+### ❌ Incorrect
+
+```typescript
+import type { INodeType, INodeTypeDescription } from 'n8n-workflow';
+
+export class MyNode implements INodeType {
+  description: INodeTypeDescription = {
+    displayName: 'My Node',
+    name: 'myNode',
+    inputs: ['main'] as never,
+    outputs: ['main'] as never,
+    properties: [],
+  };
+}
+```
+
+### ✅ Correct
+
+```typescript
+import type { INodeType, INodeTypeDescription } from 'n8n-workflow';
+import { NodeConnectionTypes } from 'n8n-workflow';
+
+export class MyNode implements INodeType {
+  description: INodeTypeDescription = {
+    displayName: 'My Node',
+    name: 'myNode',
+    inputs: [NodeConnectionTypes.Main],
+    outputs: [NodeConnectionTypes.Main],
+    properties: [],
+  };
+}
+```

package/eslint.config.mjs

@@ -1,15 +1,14 @@
 import { defineConfig } from 'eslint/config';
-import { nodeConfig } from '@n8n/eslint-config/node';
+import { backendConfig } from '@n8n/eslint-config/backend';
 import eslintPlugin from 'eslint-plugin-eslint-plugin';
 
 export default defineConfig([
-	nodeConfig,
+	backendConfig,
 	eslintPlugin.configs.recommended,
 	{
 		files: ['src/**/*.ts'],
 		languageOptions: {
 			parserOptions: {
-				project: './tsconfig.json',
 				allowDefaultProject: true,
 			},
 		},

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@n8n/eslint-plugin-community-nodes",
   "type": "module",
-  "version": "0.31.0",
+  "version": "0.33.0",
   "main": "./dist/plugin.js",
   "types": "./dist/plugin.d.ts",
   "exports": {
@@ -11,23 +11,23 @@
     }
   },
   "dependencies": {
-    "@typescript-eslint/typescript-estree": "^8.35.0",
-    "@typescript-eslint/utils": "^8.35.0",
+    "@typescript-eslint/typescript-estree": "8.70.0",
+    "@typescript-eslint/utils": "8.70.0",
     "fastest-levenshtein": "1.0.16"
   },
   "devDependencies": {
+    "@n8n/typescript-config": "1.12.0",
+    "@n8n/vitest-config": "1.22.0",
     "@types/node": "24.10.1",
-    "@typescript-eslint/rule-tester": "^8.35.0",
+    "n8n-workflow": "2.40.0",
+    "@typescript-eslint/rule-tester": "8.70.0",
     "eslint-doc-generator": "^2.2.2",
     "eslint-plugin-eslint-plugin": "^7.0.0",
     "rimraf": "6.0.1",
     "@typescript/native": "npm:typescript@7.0.2",
     "typescript": "npm:@typescript/typescript6@6.0.2",
     "vite": "^8.0.2",
-    "vitest": "^4.1.9",
-    "@n8n/typescript-config": "1.11.0",
-    "n8n-workflow": "2.38.0",
-    "@n8n/vitest-config": "1.21.0"
+    "vitest": "^4.1.9"
   },
   "peerDependencies": {
     "eslint": "9.29.0",

package/src/plugin.ts

@@ -41,6 +41,7 @@ const configs = {
 			'@n8n/community-nodes/no-runtime-dependencies': 'error',
 			'@n8n/community-nodes/no-silent-error-swallowing': 'error',
 			'@n8n/community-nodes/no-template-placeholders': 'error',
+			'@n8n/community-nodes/no-unsafe-connection-type-cast': 'error',
 			'@n8n/community-nodes/icon-validation': 'error',
 			'@n8n/community-nodes/icon-prefer-themed-variants': 'warn',
 			'@n8n/community-nodes/resource-operation-pattern': 'warn',
@@ -89,6 +90,7 @@ const configs = {
 			'@n8n/community-nodes/no-runtime-dependencies': 'error',
 			'@n8n/community-nodes/no-silent-error-swallowing': 'error',
 			'@n8n/community-nodes/no-template-placeholders': 'error',
+			'@n8n/community-nodes/no-unsafe-connection-type-cast': 'error',
 			'@n8n/community-nodes/icon-validation': 'error',
 			'@n8n/community-nodes/icon-prefer-themed-variants': 'warn',
 			'@n8n/community-nodes/credential-documentation-url': 'error',

package/src/rules/credential-password-field.ts

@@ -69,10 +69,7 @@ export const CredentialPasswordFieldRule = createRule({
 				}
 
 				const propertiesProperty = findClassProperty(node, 'properties');
-				if (
-					!propertiesProperty?.value ||
-					propertiesProperty.value.type !== TSESTree.AST_NODE_TYPES.ArrayExpression
-				) {
+				if (propertiesProperty?.value?.type !== TSESTree.AST_NODE_TYPES.ArrayExpression) {
 					return;
 				}
 

package/src/rules/credential-unnecessary-password.ts

@@ -33,10 +33,7 @@ export const CredentialUnnecessaryPasswordRule = createRule({
 				}
 
 				const propertiesProperty = findClassProperty(node, 'properties');
-				if (
-					!propertiesProperty?.value ||
-					propertiesProperty.value.type !== TSESTree.AST_NODE_TYPES.ArrayExpression
-				) {
+				if (propertiesProperty?.value?.type !== TSESTree.AST_NODE_TYPES.ArrayExpression) {
 					return;
 				}
 

package/src/rules/icon-validation.test.ts

@@ -162,6 +162,17 @@ ruleTester.run('icon-validation', IconValidationRule, {
 				true,
 			),
 		},
+		{
+			name: 'node with the same file for light and dark icons',
+			filename: nodeFilePath,
+			code: createNodeCode(
+				{
+					light: 'file:icons/SameIcon.svg',
+					dark: 'file:icons/SameIcon.svg',
+				},
+				true,
+			),
+		},
 		{
 			name: 'credential with valid string icon',
 			filename: credentialFilePath,
@@ -180,6 +191,14 @@ ruleTester.run('icon-validation', IconValidationRule, {
 				dark: 'file:icons/ValidIcon.dark.svg',
 			}),
 		},
+		{
+			name: 'credential with the same file for light and dark icons',
+			filename: credentialFilePath,
+			code: createCredentialCode({
+				light: 'file:icons/SameIcon.svg',
+				dark: 'file:icons/SameIcon.svg',
+			}),
+		},
 	],
 	invalid: [
 		{
@@ -205,18 +224,6 @@ ruleTester.run('icon-validation', IconValidationRule, {
 			code: createNodeCode('file:icons/NonExistent.svg', true),
 			errors: [{ messageId: 'iconFileNotFound', data: { iconPath: 'icons/NonExistent.svg' } }],
 		},
-		{
-			name: 'light and dark icons are the same file in description',
-			filename: nodeFilePath,
-			code: createNodeCode(
-				{
-					light: 'file:icons/SameIcon.svg',
-					dark: 'file:icons/SameIcon.svg',
-				},
-				true,
-			),
-			errors: [{ messageId: 'lightDarkSame', data: { iconPath: 'icons/SameIcon.svg' } }],
-		},
 		{
 			name: 'credential missing icon property',
 			filename: credentialFilePath,
@@ -240,15 +247,6 @@ ruleTester.run('icon-validation', IconValidationRule, {
 			code: createCredentialCode('file:icons/NonExistent.svg'),
 			errors: [{ messageId: 'iconFileNotFound', data: { iconPath: 'icons/NonExistent.svg' } }],
 		},
-		{
-			name: 'credential light and dark icons are the same file',
-			filename: credentialFilePath,
-			code: createCredentialCode({
-				light: 'file:icons/SameIcon.svg',
-				dark: 'file:icons/SameIcon.svg',
-			}),
-			errors: [{ messageId: 'lightDarkSame', data: { iconPath: 'icons/SameIcon.svg' } }],
-		},
 		{
 			name: 'node icon file does not exist but similar file exists - should suggest similar file',
 			filename: nodeFilePath,

package/src/rules/icon-validation.ts

@@ -16,7 +16,6 @@ import {
 
 const messages = {
 	iconFileNotFound: 'Icon file "{{ iconPath }}" does not exist',
-	lightDarkSame: 'Light and dark icons cannot be the same file. Both point to "{{ iconPath }}"',
 	invalidIconPath: 'Icon path "{{ iconPath }}" must use file: protocol and be a string',
 	missingIcon: 'Node/Credential class must have an icon property defined',
 	addPlaceholder: 'Add icon property with placeholder',
@@ -29,8 +28,7 @@ export const IconValidationRule = createRule({
 	meta: {
 		type: 'problem',
 		docs: {
-			description:
-				'Validate node and credential icon files exist, use the file: protocol, and that light/dark icons are different',
+			description: 'Validate node and credential icon files exist and use the file: protocol',
 		},
 		messages,
 		schema: [],
@@ -114,22 +112,12 @@ export const IconValidationRule = createRule({
 				const lightProperty = findObjectProperty(iconValue, 'light');
 				const darkProperty = findObjectProperty(iconValue, 'dark');
 
-				const lightPath = lightProperty ? getStringLiteralValue(lightProperty.value) : null;
-				const darkPath = darkProperty ? getStringLiteralValue(darkProperty.value) : null;
-
+				// A theme-agnostic file can fill both slots, so only each path is checked
 				if (lightProperty) {
-					validateIcon(lightPath, lightProperty.value);
+					validateIcon(getStringLiteralValue(lightProperty.value), lightProperty.value);
 				}
 				if (darkProperty) {
-					validateIcon(darkPath, darkProperty.value);
-				}
-
-				if (lightPath && darkPath && lightPath === darkPath && lightProperty) {
-					context.report({
-						node: lightProperty.value,
-						messageId: 'lightDarkSame',
-						data: { iconPath: lightPath.replace(/^file:/, '') },
-					});
+					validateIcon(getStringLiteralValue(darkProperty.value), darkProperty.value);
 				}
 			}
 		};
@@ -145,10 +133,7 @@ export const IconValidationRule = createRule({
 
 				if (isNodeClass) {
 					const descriptionProperty = findClassProperty(node, 'description');
-					if (
-						!descriptionProperty?.value ||
-						descriptionProperty.value.type !== TSESTree.AST_NODE_TYPES.ObjectExpression
-					) {
+					if (descriptionProperty?.value?.type !== TSESTree.AST_NODE_TYPES.ObjectExpression) {
 						context.report({
 							node,
 							messageId: 'missingIcon',

package/src/rules/index.ts

@@ -26,6 +26,7 @@ import { NoRestrictedImportsRule } from './no-restricted-imports.js';
 import { NoRuntimeDependenciesRule } from './no-runtime-dependencies.js';
 import { NoSilentErrorSwallowingRule } from './no-silent-error-swallowing.js';
 import { NoTemplatePlaceholdersRule } from './no-template-placeholders.js';
+import { NoUnsafeConnectionTypeCastRule } from './no-unsafe-connection-type-cast.js';
 import { NodeClassDescriptionIconMissingRule } from './node-class-description-icon-missing.js';
 import { NodeConnectionTypeLiteralRule } from './node-connection-type-literal.js';
 import { NodeRegistrationCompleteRule } from './node-registration-complete.js';
@@ -65,6 +66,7 @@ export const rules = {
 	'no-runtime-dependencies': NoRuntimeDependenciesRule,
 	'no-silent-error-swallowing': NoSilentErrorSwallowingRule,
 	'no-template-placeholders': NoTemplatePlaceholdersRule,
+	'no-unsafe-connection-type-cast': NoUnsafeConnectionTypeCastRule,
 	'icon-validation': IconValidationRule,
 	'icon-prefer-themed-variants': IconPreferThemedVariantsRule,
 	'resource-operation-pattern': ResourceOperationPatternRule,

package/src/rules/no-credential-reuse.test.ts

@@ -19,6 +19,7 @@ const mockFindPackageJson = vi.mocked(fileUtils.findPackageJson);
 const ruleTester = new RuleTester();
 
 const nodeFilePath = '/tmp/TestNode.node.ts';
+const versionedNodeFilePath = '/tmp/v1/TestNodeV1.node.ts';
 
 function createNodeCode(
 	credentials: Array<string | { name: string; required?: boolean }> = [],
@@ -97,6 +98,36 @@ export class TestNode implements INodeType {
 }`;
 }
 
+/**
+ * Versioned node layout from the node-building docs: each version class
+ * implements `INodeType` and assigns `description` in its constructor, merging
+ * the `baseDescription` that the `VersionedNodeType` entry file passes in.
+ */
+function createVersionedNodeCode(credentialNameLiteral: string): string {
+	return `
+import type { INodeType, INodeTypeBaseDescription, INodeTypeDescription } from 'n8n-workflow';
+
+export class TestNodeV1 implements INodeType {
+	description: INodeTypeDescription;
+
+	constructor(baseDescription: INodeTypeBaseDescription) {
+		this.description = {
+			...baseDescription,
+			version: 1,
+			inputs: ['main'],
+			outputs: ['main'],
+			credentials: [
+				{
+					name: ${credentialNameLiteral},
+					required: true,
+				},
+			],
+			properties: [],
+		};
+	}
+}`;
+}
+
 // Helper function to create non-node class
 function createNonNodeClass(): string {
 	return `
@@ -163,6 +194,29 @@ ruleTester.run('no-credential-reuse', NoCredentialReuseRule, {
 		},
 	],
 	invalid: [
+		{
+			name: 'SECURITY: versioned node assigning description in its constructor uses credential not in package',
+			filename: versionedNodeFilePath,
+			code: createVersionedNodeCode("'ExternalApi'"),
+			errors: [
+				{
+					messageId: 'credentialNotInPackage',
+					data: { credentialName: 'ExternalApi' },
+					suggestions: [
+						{
+							messageId: 'useAvailable',
+							data: { suggestedName: 'myApiCredential' },
+							output: createVersionedNodeCode('"myApiCredential"'),
+						},
+						{
+							messageId: 'useAvailable',
+							data: { suggestedName: 'anotherApiCredential' },
+							output: createVersionedNodeCode('"anotherApiCredential"'),
+						},
+					],
+				},
+			],
+		},
 		{
 			name: 'SECURITY: node using credential not in package (object form)',
 			filename: nodeFilePath,