@n8n/eslint-plugin-community-nodes 0.28.0 → 0.30.0

package/src/rules/node-usable-as-tool.ts

@@ -2,11 +2,16 @@ import { TSESTree } from '@typescript-eslint/utils';
 
 import {
 	isNodeTypeClass,
+	isTriggerNode,
 	findClassProperty,
 	findObjectProperty,
 	createRule,
 } from '../utils/index.js';
 
+function isSetToTrue(property: TSESTree.Property | null): property is TSESTree.Property {
+	return property?.value.type === TSESTree.AST_NODE_TYPES.Literal && property.value.value === true;
+}
+
 export const NodeUsableAsToolRule = createRule({
 	name: 'node-usable-as-tool',
 	meta: {
@@ -17,6 +22,10 @@ export const NodeUsableAsToolRule = createRule({
 		messages: {
 			missingUsableAsTool:
 				'Node class should have usableAsTool property. When in doubt, set it to true.',
+			triggerUsableAsTool:
+				'Trigger nodes must not set usableAsTool: true. Trigger nodes cannot be invoked as AI tools and doing so pollutes the tool picker. Remove this property.',
+			aiOnlyUsableAsTool:
+				'AI-only nodes (non-main output, no inputs) must not set usableAsTool: true. These nodes are only usable through their AI connection type, not as a generic tool, and doing so pollutes the tool picker. Remove this property.',
 		},
 		fixable: 'code',
 		schema: [],
@@ -40,6 +49,17 @@ export const NodeUsableAsToolRule = createRule({
 				}
 
 				const usableAsToolProperty = findObjectProperty(descriptionValue, 'usableAsTool');
+
+				if (isTriggerNode(node, descriptionValue)) {
+					if (isSetToTrue(usableAsToolProperty)) {
+						context.report({
+							node: usableAsToolProperty,
+							messageId: 'triggerUsableAsTool',
+						});
+					}
+					return;
+				}
+
 				const outputsProperty = findObjectProperty(descriptionValue, 'outputs');
 				const inputsProperty = findObjectProperty(descriptionValue, 'inputs');
 				if (
@@ -59,6 +79,14 @@ export const NodeUsableAsToolRule = createRule({
 					});
 					const isEmptyInputs = inputsProperty?.value?.elements?.length === 0;
 					if (isAiOutput && isEmptyInputs) {
+						// These nodes are only ever consumed via their AI connection type (e.g. as an
+						// Agent's memory/language model), never invoked directly like a regular tool.
+						if (isSetToTrue(usableAsToolProperty)) {
+							context.report({
+								node: usableAsToolProperty,
+								messageId: 'aiOnlyUsableAsTool',
+							});
+						}
 						return;
 					}
 				}

package/src/rules/trigger-node-conventions.ts

@@ -2,6 +2,7 @@ import { TSESTree } from '@typescript-eslint/utils';
 
 import {
 	isNodeTypeClass,
+	isTriggerNodeClass,
 	findClassProperty,
 	findObjectProperty,
 	getStringLiteralValue,
@@ -37,7 +38,7 @@ export const TriggerNodeConventionsRule = createRule({
 					return;
 				}
 
-				if (!node.id?.name.endsWith('Trigger')) {
+				if (!isTriggerNodeClass(node)) {
 					return;
 				}
 

package/src/utils/ast-utils.ts

@@ -29,6 +29,32 @@ export function isCredentialTypeClass(node: TSESTree.ClassDeclaration): boolean
 	return implementsInterface(node, 'ICredentialType');
 }
 
+/** Matches this plugin's convention for identifying trigger nodes: class name ends with `Trigger`. */
+export function isTriggerNodeClass(node: TSESTree.ClassDeclaration): boolean {
+	return node.id?.name.endsWith('Trigger') ?? false;
+}
+
+function hasTriggerGroup(descriptionValue: TSESTree.ObjectExpression): boolean {
+	const groupArray = findArrayLiteralProperty(descriptionValue, 'group');
+	return (
+		groupArray?.elements.some(
+			(element) => element?.type === AST_NODE_TYPES.Literal && element.value === 'trigger',
+		) ?? false
+	);
+}
+
+/**
+ * `group` is the authoritative signal for "is this a trigger node" (also catches e.g. Cron,
+ * Webhook, versioned `*TriggerV1` classes); the name suffix is kept as a fallback for dynamic
+ * `group` values.
+ */
+export function isTriggerNode(
+	node: TSESTree.ClassDeclaration,
+	descriptionValue: TSESTree.ObjectExpression,
+): boolean {
+	return hasTriggerGroup(descriptionValue) || isTriggerNodeClass(node);
+}
+
 export function findClassProperty(
 	node: TSESTree.ClassDeclaration,
 	propertyName: string,

package/.turbo/turbo-build.log

@@ -1,4 +0,0 @@
-
-> @n8n/eslint-plugin-community-nodes@0.28.0 build /home/runner/work/n8n/n8n/packages/@n8n/eslint-plugin-community-nodes
-> tsc --project tsconfig.build.json
-