@n8n/eslint-plugin-community-nodes 0.24.0 → 0.25.0

package/src/rules/cred-filename-against-convention.ts

@@ -1,48 +0,0 @@
-import * as path from 'node:path';
-
-import { isCredentialTypeClass, isFileType, createRule } from '../utils/index.js';
-
-export const CredFilenameAgainstConventionRule = createRule({
-	name: 'cred-filename-against-convention',
-	meta: {
-		type: 'problem',
-		docs: {
-			description: 'Credential filename must match the credential class name',
-		},
-		messages: {
-			renameFile:
-				'Credential filename must match the class name "{{className}}". Rename file to "{{expected}}".',
-		},
-		schema: [],
-	},
-	defaultOptions: [],
-	create(context) {
-		if (!isFileType(context.filename, '.credentials.ts')) {
-			return {};
-		}
-
-		return {
-			ClassDeclaration(node) {
-				if (!isCredentialTypeClass(node)) {
-					return;
-				}
-
-				const classNameNode = node.id;
-				if (!classNameNode) {
-					return;
-				}
-
-				const className = classNameNode.name;
-				const actualBaseName = path.basename(context.filename, '.credentials.ts');
-
-				if (actualBaseName !== className) {
-					context.report({
-						node: classNameNode,
-						messageId: 'renameFile',
-						data: { className, expected: `${className}.credentials.ts` },
-					});
-				}
-			},
-		};
-	},
-});

package/src/rules/no-asterisk-in-option-names.test.ts

@@ -1,185 +0,0 @@
-import { RuleTester } from '@typescript-eslint/rule-tester';
-
-import { NoAsteriskInOptionNamesRule } from './no-asterisk-in-option-names.js';
-
-const ruleTester = new RuleTester();
-
-function createNodeCode(body: string): string {
-	return `
-		import type { INodeType, INodeTypeDescription } from 'n8n-workflow';
-
-		export class TestNode implements INodeType {
-			description: INodeTypeDescription = {
-				${body}
-			};
-		}
-	`;
-}
-
-ruleTester.run('no-asterisk-in-option-names', NoAsteriskInOptionNamesRule, {
-	valid: [
-		{
-			name: 'class that does not implement INodeType',
-			filename: '/tmp/TestNode.node.ts',
-			code: `
-				export class NotANode {
-					description = {
-						properties: [
-							{ options: [{ name: '* All', value: 'all' }] },
-						],
-					};
-				}
-			`,
-		},
-		{
-			name: 'non .node.ts file is ignored',
-			filename: '/tmp/helper.ts',
-			code: `
-				export class TestNode {
-					description = {
-						properties: [
-							{ options: [{ name: '* All', value: 'all' }] },
-						],
-					};
-				}
-			`,
-		},
-		{
-			name: 'option names without asterisk',
-			filename: '/tmp/TestNode.node.ts',
-			code: createNodeCode(`
-				displayName: 'Test Node',
-				name: 'testNode',
-				properties: [
-					{
-						displayName: 'Operation',
-						name: 'operation',
-						type: 'options',
-						options: [
-							{ name: 'Create', value: 'create' },
-							{ name: '[All]', value: 'all' },
-						],
-						default: 'create',
-					},
-				],
-			`),
-		},
-		{
-			name: 'asterisk in displayName outside options is ignored',
-			filename: '/tmp/TestNode.node.ts',
-			code: createNodeCode(`
-				displayName: 'Test * Node',
-				name: 'testNode',
-				properties: [
-					{ displayName: 'Field *', name: 'field', type: 'string', default: '' },
-				],
-			`),
-		},
-	],
-	invalid: [
-		{
-			name: 'asterisk in option name within options array',
-			filename: '/tmp/TestNode.node.ts',
-			code: createNodeCode(`
-				displayName: 'Test Node',
-				name: 'testNode',
-				properties: [
-					{
-						displayName: 'Resource',
-						name: 'resource',
-						type: 'options',
-						options: [
-							{ name: '* All', value: 'all' },
-							{ name: 'User', value: 'user' },
-						],
-						default: 'all',
-					},
-				],
-			`),
-			errors: [
-				{
-					messageId: 'asteriskInOptionName',
-					data: { name: '* All' },
-					suggestions: [
-						{
-							messageId: 'replaceAsterisk',
-							output: createNodeCode(`
-				displayName: 'Test Node',
-				name: 'testNode',
-				properties: [
-					{
-						displayName: 'Resource',
-						name: 'resource',
-						type: 'options',
-						options: [
-							{ name: '[All] All', value: 'all' },
-							{ name: 'User', value: 'user' },
-						],
-						default: 'all',
-					},
-				],
-			`),
-						},
-					],
-				},
-			],
-		},
-		{
-			name: 'asterisk in nested collection options',
-			filename: '/tmp/TestNode.node.ts',
-			code: createNodeCode(`
-				displayName: 'Test Node',
-				name: 'testNode',
-				properties: [
-					{
-						displayName: 'Filters',
-						name: 'filters',
-						type: 'collection',
-						default: {},
-						options: [
-							{
-								displayName: 'Status',
-								name: 'status',
-								type: 'options',
-								options: [{ name: '*', value: 'any' }],
-								default: 'any',
-							},
-						],
-					},
-				],
-			`),
-			errors: [
-				{
-					messageId: 'asteriskInOptionName',
-					data: { name: '*' },
-					suggestions: [
-						{
-							messageId: 'replaceAsterisk',
-							output: createNodeCode(`
-				displayName: 'Test Node',
-				name: 'testNode',
-				properties: [
-					{
-						displayName: 'Filters',
-						name: 'filters',
-						type: 'collection',
-						default: {},
-						options: [
-							{
-								displayName: 'Status',
-								name: 'status',
-								type: 'options',
-								options: [{ name: '[All]', value: 'any' }],
-								default: 'any',
-							},
-						],
-					},
-				],
-			`),
-						},
-					],
-				},
-			],
-		},
-	],
-});

package/src/rules/no-asterisk-in-option-names.ts

@@ -1,111 +0,0 @@
-import type { TSESTree } from '@typescript-eslint/utils';
-import { AST_NODE_TYPES } from '@typescript-eslint/utils';
-
-import {
-	isNodeTypeClass,
-	findClassProperty,
-	findObjectProperty,
-	getStringLiteralValue,
-	isFileType,
-	createRule,
-} from '../utils/index.js';
-
-export const NoAsteriskInOptionNamesRule = createRule({
-	name: 'no-asterisk-in-option-names',
-	meta: {
-		type: 'suggestion',
-		docs: {
-			description: 'Disallow asterisk characters in node option name values',
-		},
-		hasSuggestions: true,
-		messages: {
-			asteriskInOptionName:
-				'Option name "{{ name }}" contains "*", which renders ambiguously in the n8n UI. Use bracketed notation like "[All]" instead.',
-			replaceAsterisk: 'Replace "*" with "[All]".',
-		},
-		schema: [],
-	},
-	defaultOptions: [],
-	create(context) {
-		if (!isFileType(context.filename, '.node.ts')) {
-			return {};
-		}
-
-		// Check every object that is a direct element of an `options` array.
-		const checkOptionsArray = (optionsArray: TSESTree.ArrayExpression): void => {
-			for (const option of optionsArray.elements) {
-				if (!option || option.type !== AST_NODE_TYPES.ObjectExpression) {
-					continue;
-				}
-
-				const valueNode = findObjectProperty(option, 'name')?.value;
-				if (!valueNode) {
-					continue;
-				}
-
-				const name = getStringLiteralValue(valueNode);
-				if (!name?.includes('*')) {
-					continue;
-				}
-
-				context.report({
-					node: valueNode,
-					messageId: 'asteriskInOptionName',
-					data: { name },
-					suggest: [
-						{
-							messageId: 'replaceAsterisk',
-							fix(fixer) {
-								const quote = context.sourceCode.getText(valueNode).at(0) ?? "'";
-								return fixer.replaceText(
-									valueNode,
-									`${quote}${name.replaceAll('*', '[All]')}${quote}`,
-								);
-							},
-						},
-					],
-				});
-			}
-		};
-
-		const traverse = (node: TSESTree.Node): void => {
-			if (node.type === AST_NODE_TYPES.ObjectExpression) {
-				const optionsProperty = findObjectProperty(node, 'options');
-				if (optionsProperty?.value.type === AST_NODE_TYPES.ArrayExpression) {
-					checkOptionsArray(optionsProperty.value);
-				}
-			}
-
-			for (const key in node) {
-				if (key === 'parent') {
-					continue;
-				}
-				const child = node[key as keyof TSESTree.Node] as unknown;
-				if (Array.isArray(child)) {
-					for (const item of child) {
-						if (item && typeof item === 'object' && 'type' in item) {
-							traverse(item as TSESTree.Node);
-						}
-					}
-				} else if (child && typeof child === 'object' && 'type' in child) {
-					traverse(child as TSESTree.Node);
-				}
-			}
-		};
-
-		return {
-			ClassDeclaration(node) {
-				if (!isNodeTypeClass(node)) {
-					return;
-				}
-
-				const descriptionProperty = findClassProperty(node, 'description');
-				if (!descriptionProperty?.value) {
-					return;
-				}
-
-				traverse(descriptionProperty.value);
-			},
-		};
-	},
-});

package/src/rules/no-duplicate-param-options.test.ts

@@ -1,125 +0,0 @@
-import { RuleTester } from '@typescript-eslint/rule-tester';
-
-import { NoDuplicateParamOptionsRule } from './no-duplicate-param-options.js';
-
-const ruleTester = new RuleTester();
-
-function nodeCode(options: string, type = 'options'): string {
-	return `
-		import type { INodeType, INodeTypeDescription } from 'n8n-workflow';
-
-		export class TestNode implements INodeType {
-			description: INodeTypeDescription = {
-				displayName: 'Test Node',
-				name: 'testNode',
-				properties: [
-					{
-						displayName: 'Resource',
-						name: 'resource',
-						type: '${type}',
-						options: [${options}],
-						default: '',
-					},
-				],
-			};
-		}
-	`;
-}
-
-ruleTester.run('no-duplicate-param-options', NoDuplicateParamOptionsRule, {
-	valid: [
-		{
-			name: 'non-INodeType class is skipped',
-			filename: '/tmp/TestNode.node.ts',
-			code: 'export class Foo {}',
-		},
-		{
-			name: 'unique names and values',
-			filename: '/tmp/TestNode.node.ts',
-			code: nodeCode(`
-				{ name: 'Create', value: 'create' },
-				{ name: 'Delete', value: 'delete' },
-			`),
-		},
-		{
-			name: 'unique numeric values',
-			filename: '/tmp/TestNode.node.ts',
-			code: nodeCode(`
-				{ name: 'One', value: 1 },
-				{ name: 'Two', value: 2 },
-			`),
-		},
-		{
-			name: 'multiOptions with unique options',
-			filename: '/tmp/TestNode.node.ts',
-			code: nodeCode(
-				`
-				{ name: 'A', value: 'a' },
-				{ name: 'B', value: 'b' },
-			`,
-				'multiOptions',
-			),
-		},
-		{
-			name: 'non-node.ts file is skipped',
-			filename: '/tmp/TestNode.ts',
-			code: nodeCode(`
-				{ name: 'Dup', value: 'a' },
-				{ name: 'Dup', value: 'b' },
-			`),
-		},
-	],
-	invalid: [
-		{
-			name: 'duplicate name',
-			filename: '/tmp/TestNode.node.ts',
-			code: nodeCode(`
-				{ name: 'Create', value: 'create' },
-				{ name: 'Create', value: 'create2' },
-			`),
-			errors: [{ messageId: 'duplicateName', data: { value: 'Create', displayName: 'Resource' } }],
-		},
-		{
-			name: 'duplicate value',
-			filename: '/tmp/TestNode.node.ts',
-			code: nodeCode(`
-				{ name: 'Create', value: 'create' },
-				{ name: 'Make', value: 'create' },
-			`),
-			errors: [{ messageId: 'duplicateValue', data: { value: 'create', displayName: 'Resource' } }],
-		},
-		{
-			name: 'duplicate numeric value',
-			filename: '/tmp/TestNode.node.ts',
-			code: nodeCode(`
-				{ name: 'One', value: 1 },
-				{ name: 'Uno', value: 1 },
-			`),
-			errors: [{ messageId: 'duplicateValue', data: { value: '1', displayName: 'Resource' } }],
-		},
-		{
-			name: 'duplicate name and value reported separately',
-			filename: '/tmp/TestNode.node.ts',
-			code: nodeCode(`
-				{ name: 'Create', value: 'create' },
-				{ name: 'Create', value: 'create' },
-			`),
-			errors: [
-				{ messageId: 'duplicateName', data: { value: 'Create', displayName: 'Resource' } },
-				{ messageId: 'duplicateValue', data: { value: 'create', displayName: 'Resource' } },
-			],
-		},
-		{
-			name: 'duplicate in multiOptions',
-			filename: '/tmp/TestNode.node.ts',
-			code: nodeCode(
-				`
-				{ name: 'A', value: 'a' },
-				{ name: 'A', value: 'b' },
-			`,
-				'multiOptions',
-			),
-			errors: [{ messageId: 'duplicateName', data: { value: 'A', displayName: 'Resource' } }],
-		},
-	],
-});

package/src/rules/no-duplicate-param-options.ts

@@ -1,125 +0,0 @@
-import type { TSESTree } from '@typescript-eslint/utils';
-import { AST_NODE_TYPES } from '@typescript-eslint/utils';
-
-import {
-	isNodeTypeClass,
-	findClassProperty,
-	findObjectProperty,
-	getStringLiteralValue,
-	getLiteralValue,
-	isFileType,
-	createRule,
-} from '../utils/index.js';
-
-export const NoDuplicateParamOptionsRule = createRule({
-	name: 'no-duplicate-param-options',
-	meta: {
-		type: 'problem',
-		docs: {
-			description: 'Disallow duplicate option names or values within a single node parameter',
-		},
-		messages: {
-			duplicateName: 'Duplicate option name "{{ value }}" in parameter "{{ displayName }}".',
-			duplicateValue: 'Duplicate option value "{{ value }}" in parameter "{{ displayName }}".',
-		},
-		schema: [],
-	},
-	defaultOptions: [],
-	create(context) {
-		if (!isFileType(context.filename, '.node.ts')) {
-			return {};
-		}
-
-		const checkProperty = (property: TSESTree.ObjectExpression): void => {
-			const typeProperty = findObjectProperty(property, 'type');
-			const type = typeProperty ? getStringLiteralValue(typeProperty.value) : null;
-			if (type !== 'options' && type !== 'multiOptions') {
-				return;
-			}
-
-			const optionsProperty = findObjectProperty(property, 'options');
-			if (
-				!optionsProperty?.value ||
-				optionsProperty.value.type !== AST_NODE_TYPES.ArrayExpression
-			) {
-				return;
-			}
-
-			const displayNameProperty = findObjectProperty(property, 'displayName');
-			const displayName =
-				(displayNameProperty ? getStringLiteralValue(displayNameProperty.value) : null) ??
-				'unknown';
-
-			const seenNames = new Set<string>();
-			const seenValues = new Set<string | number | boolean>();
-
-			for (const option of optionsProperty.value.elements) {
-				if (!option || option.type !== AST_NODE_TYPES.ObjectExpression) {
-					continue;
-				}
-
-				const nameProperty = findObjectProperty(option, 'name');
-				const name = nameProperty ? getStringLiteralValue(nameProperty.value) : null;
-				if (name !== null) {
-					if (seenNames.has(name)) {
-						context.report({
-							node: nameProperty!.value,
-							messageId: 'duplicateName',
-							data: { value: name, displayName },
-						});
-					}
-					seenNames.add(name);
-				}
-
-				const valueProperty = findObjectProperty(option, 'value');
-				const value = valueProperty ? getLiteralValue(valueProperty.value) : null;
-				if (value !== null) {
-					if (seenValues.has(value)) {
-						context.report({
-							node: valueProperty!.value,
-							messageId: 'duplicateValue',
-							data: { value: String(value), displayName },
-						});
-					}
-					seenValues.add(value);
-				}
-			}
-		};
-
-		const analyzeNodeDescription = (descriptionValue: TSESTree.Expression | null): void => {
-			if (!descriptionValue || descriptionValue.type !== AST_NODE_TYPES.ObjectExpression) {
-				return;
-			}
-
-			const propertiesProperty = findObjectProperty(descriptionValue, 'properties');
-			if (
-				!propertiesProperty?.value ||
-				propertiesProperty.value.type !== AST_NODE_TYPES.ArrayExpression
-			) {
-				return;
-			}
-
-			for (const property of propertiesProperty.value.elements) {
-				if (!property || property.type !== AST_NODE_TYPES.ObjectExpression) {
-					continue;
-				}
-				checkProperty(property);
-			}
-		};
-
-		return {
-			ClassDeclaration(node) {
-				if (!isNodeTypeClass(node)) {
-					return;
-				}
-
-				const descriptionProperty = findClassProperty(node, 'description');
-				if (!descriptionProperty) {
-					return;
-				}
-
-				analyzeNodeDescription(descriptionProperty.value);
-			},
-		};
-	},
-});

package/src/rules/node-class-description-name-camelcase.test.ts

@@ -1,121 +0,0 @@
-import { RuleTester } from '@typescript-eslint/rule-tester';
-
-import { NodeClassDescriptionNameCamelCaseRule } from './node-class-description-name-camelcase.js';
-
-const ruleTester = new RuleTester();
-
-function createNodeCode(name: string): string {
-	return `
-import type { INodeType, INodeTypeDescription } from 'n8n-workflow';
-
-export class TestNode implements INodeType {
-	description: INodeTypeDescription = {
-		displayName: 'Test Node',
-		name: '${name}',
-		group: ['input'],
-		version: 1,
-		description: 'A test node',
-		defaults: { name: 'Test Node' },
-		inputs: [],
-		outputs: [],
-		properties: [],
-	};
-}`;
-}
-
-function createNodeCodeWithoutName(): string {
-	return `
-import type { INodeType, INodeTypeDescription } from 'n8n-workflow';
-
-export class TestNode implements INodeType {
-	description: INodeTypeDescription = {
-		displayName: 'Test Node',
-		group: ['input'],
-		version: 1,
-		description: 'A test node',
-		defaults: { name: 'Test Node' },
-		inputs: [],
-		outputs: [],
-		properties: [],
-	};
-}`;
-}
-
-function createRegularClass(): string {
-	return `
-export class SomeHelper {
-	name = 'My Helper';
-}`;
-}
-
-ruleTester.run('node-class-description-name-camelcase', NodeClassDescriptionNameCamelCaseRule, {
-	valid: [
-		{
-			name: 'single lowercase word',
-			filename: '/tmp/Github.node.ts',
-			code: createNodeCode('github'),
-		},
-		{
-			name: 'camelCase multi-word name',
-			filename: '/tmp/GoogleSheets.node.ts',
-			code: createNodeCode('googleSheets'),
-		},
-		{
-			name: 'camelCase name with digits',
-			filename: '/tmp/Oauth2.node.ts',
-			code: createNodeCode('myNode2'),
-		},
-		{
-			name: 'class not implementing INodeType is ignored',
-			filename: '/tmp/Github.node.ts',
-			code: createRegularClass(),
-		},
-		{
-			name: 'non-.node.ts file is ignored',
-			filename: '/tmp/Github.ts',
-			code: createNodeCode('My Node'),
-		},
-		{
-			name: 'missing description.name is ignored',
-			filename: '/tmp/Github.node.ts',
-			code: createNodeCodeWithoutName(),
-		},
-	],
-	invalid: [
-		{
-			name: 'PascalCase first letter is lowercased',
-			filename: '/tmp/Github.node.ts',
-			code: createNodeCode('MyNode'),
-			errors: [{ messageId: 'notCamelCase', data: { value: 'MyNode' } }],
-			output: createNodeCode('myNode'),
-		},
-		{
-			name: 'spaces are removed and camelCased',
-			filename: '/tmp/Github.node.ts',
-			code: createNodeCode('My Node'),
-			errors: [{ messageId: 'notCamelCase', data: { value: 'My Node' } }],
-			output: createNodeCode('myNode'),
-		},
-		{
-			name: 'hyphen separators are removed and camelCased',
-			filename: '/tmp/Github.node.ts',
-			code: createNodeCode('my-node'),
-			errors: [{ messageId: 'notCamelCase', data: { value: 'my-node' } }],
-			output: createNodeCode('myNode'),
-		},
-		{
-			name: 'underscore separators are removed and camelCased',
-			filename: '/tmp/Github.node.ts',
-			code: createNodeCode('my_cool_node'),
-			errors: [{ messageId: 'notCamelCase', data: { value: 'my_cool_node' } }],
-			output: createNodeCode('myCoolNode'),
-		},
-		{
-			name: 'names starting with a digit are reported without an autofix',
-			filename: '/tmp/Github.node.ts',
-			code: createNodeCode('123node'),
-			errors: [{ messageId: 'notCamelCase', data: { value: '123node' } }],
-			output: null,
-		},
-	],
-});