@myclub_se/data-access 3.7.1 → 3.7.2

package/fesm2022/myclub_se-data-access.mjs

@@ -5732,7 +5732,7 @@ class ActivityService {
             activityId
         });
     }
-    signUpMemberOpenActivity(memberId, activityId, comment, optionalFees, responses) {
+    signUpMemberOpenActivity(memberId, activityId, comment, optionalFees, responses, guests = []) {
         return this.apiService
             .updateResource(openActivityFactory, Role.MemberAdmin, MEMBER_OPEN_ACTIVITY_RESPOND_WITH_DATA_PATH, {
             memberId,
@@ -5740,17 +5740,19 @@ class ActivityService {
         }, {
             comment,
             optional_fees: optionalFees,
-            responses
+            responses,
+            guests
         });
     }
-    signUpPublicOpenActivity(activityId, comment, optionalFees, responses) {
+    signUpPublicOpenActivity(activityId, comment, optionalFees, responses, guests = []) {
         return this.apiService
             .updateResource(openActivityFactory, Role.Public, PUBLIC_OPEN_ACTIVITY_RESPOND_WITH_DATA_PATH, {
             activityId
         }, {
             comment,
             optional_fees: optionalFees,
-            responses
+            responses,
+            guests
         });
     }
     updateMemberActivity(memberId, activityInviteId, activityInvite) {
@@ -8826,61 +8828,45 @@ class ActivityEffects extends ExtraMembersMixin {
         }
     }), catchError((error) => of(updateMemberActivityAttendanceFailureAction({ payload: error })))))));
     updateMemberActivityInvite$ = createEffect(() => this.actions$
-        .pipe(ofType(updateMemberActivityInviteAction), exhaustMap(({ payload }) => this.activityService.updateMemberActivity(payload.memberId, payload.activityInvite.id, payload.activityInvite)
-        .pipe(mergeMap((activityInvite) => {
-        const guests = payload.guests ?? [];
-        const existingGuests = activityInvite.guests ?? [];
-        return reconcileMemberGuests(payload.memberId, activityInvite.id, guests, existingGuests, this.activityService)
-            .pipe(catchError(() => of(null)), mergeMap(() => this.activityService.getMemberActivityInvite(payload.memberId, activityInvite.id)), catchError(() => of(activityInvite)), map((updatedInvite) => updateMemberActivityInviteSuccessAction({ payload: updatedInvite })));
-    }), catchError((error) => of(updateMemberActivityInviteFailureAction({ payload: error })))))));
+        .pipe(ofType(updateMemberActivityInviteAction), exhaustMap(({ payload }) => {
+        // New guests are sent inline with the respond request so the backend can
+        // include their guest fees in the invoice it creates on accept. Existing
+        // guests are reconciled (update/delete) before responding, so removed
+        // guests are not invoiced.
+        const existingGuests = payload.activityInvite.guests ?? [];
+        const reconcile$ = payload.guests
+            ? reconcileMemberGuests(payload.memberId, payload.activityInvite.id, payload.guests, existingGuests, this.activityService)
+                .pipe(catchError(() => of(null)))
+            : of(null);
+        return reconcile$.pipe(mergeMap(() => this.activityService.updateMemberActivity(payload.memberId, payload.activityInvite.id, { ...payload.activityInvite, guests: newGuests(payload.guests) })
+            .pipe(map((activityInvite) => updateMemberActivityInviteSuccessAction({ payload: activityInvite })), catchError((error) => of(updateMemberActivityInviteFailureAction({ payload: error }))))));
+    })));
     updateMemberOpenActivity$ = createEffect(() => this.actions$
-        .pipe(ofType(updateMemberOpenActivityAction), exhaustMap(({ payload }) => this.activityService.signUpMemberOpenActivity(payload.memberId, payload.activityId, payload.comment, payload.optional_fees, payload.responses)
-        .pipe(mergeMap((openActivity) => {
-        const guests = payload.guests ?? [];
-        if (guests.length === 0) {
-            return of(updateMemberOpenActivitySuccessAction({ payload: openActivity }));
-        }
-        // Step 2: fetch activity to find member's invite ID, then add guests
-        return this.activityService.getMemberActivity(payload.memberId, openActivity.id)
-            .pipe(mergeMap((activity) => {
-            const memberInvite = activity.invited_members.find(m => m.member_id === payload.memberId);
-            if (!memberInvite) {
-                return of(updateMemberOpenActivitySuccessAction({ payload: openActivity }));
-            }
-            const guestOps = guests.map(g => this.activityService.addMemberActivityGuest(payload.memberId, memberInvite.id, { name: g.name, comment: g.comment ?? undefined }));
-            return forkJoin(guestOps).pipe(catchError(() => of(null)), map(() => updateMemberOpenActivitySuccessAction({ payload: openActivity })));
-        }), catchError(() => of(updateMemberOpenActivitySuccessAction({ payload: openActivity }))));
-    }), catchError((error) => of(updateMemberOpenActivityFailureAction({ payload: error })))))));
+        .pipe(ofType(updateMemberOpenActivityAction), exhaustMap(({ payload }) => this.activityService.signUpMemberOpenActivity(payload.memberId, payload.activityId, payload.comment, payload.optional_fees, payload.responses, newGuests(payload.guests))
+        .pipe(map((openActivity) => updateMemberOpenActivitySuccessAction({ payload: openActivity })), catchError((error) => of(updateMemberOpenActivityFailureAction({ payload: error })))))));
     updatePublicActivityInvite$ = createEffect(() => this.actions$
-        .pipe(ofType(updatePublicActivityInviteAction), exhaustMap(({ payload }) => this.activityService.updatePublicActivityInvite(payload.activityInvite.id, payload.token, payload.activityInvite)
-        .pipe(mergeMap((activityInvite) => {
-        const guests = payload.guests ?? [];
-        const existingGuests = activityInvite.guests ?? [];
-        return reconcilePublicTokenGuests(activityInvite.id, payload.token, guests, existingGuests, this.activityService)
-            .pipe(catchError(() => of(null)), mergeMap(() => this.activityService.getPublicActivityInvite(activityInvite.id, payload.token)), catchError(() => of(activityInvite)), map((updatedInvite) => updatePublicActivityInviteSuccessAction({ payload: updatedInvite })));
-    }), catchError((error) => of(updatePublicActivityInviteFailureAction({ payload: error })))))));
+        .pipe(ofType(updatePublicActivityInviteAction), exhaustMap(({ payload }) => {
+        const existingGuests = payload.activityInvite.guests ?? [];
+        const reconcile$ = payload.guests
+            ? reconcilePublicTokenGuests(payload.activityInvite.id, payload.token, payload.guests, existingGuests, this.activityService)
+                .pipe(catchError(() => of(null)))
+            : of(null);
+        return reconcile$.pipe(mergeMap(() => this.activityService.updatePublicActivityInvite(payload.activityInvite.id, payload.token, { ...payload.activityInvite, guests: newGuests(payload.guests) })
+            .pipe(map((activityInvite) => updatePublicActivityInviteSuccessAction({ payload: activityInvite })), catchError((error) => of(updatePublicActivityInviteFailureAction({ payload: error }))))));
+    })));
     updatePublicMemberActivityInvite$ = createEffect(() => this.actions$
-        .pipe(ofType(updatePublicMemberActivityInviteAction), exhaustMap(({ payload }) => this.activityService.updatePublicMemberActivityInvite(payload.activityInvite.id, payload.activityInvite)
-        .pipe(mergeMap((activityInvite) => {
-        const guests = payload.guests ?? [];
-        const existingGuests = activityInvite.guests ?? [];
-        return reconcilePublicTokenGuests(activityInvite.id, activityInvite.token, guests, existingGuests, this.activityService)
-            .pipe(catchError(() => of(null)), mergeMap(() => this.activityService.getPublicMemberActivityInvite(activityInvite.id)), catchError(() => of(activityInvite)), map((updatedInvite) => updatePublicMemberActivityInviteSuccessAction({ payload: updatedInvite })));
-    }), catchError((error) => of(updatePublicMemberActivityInviteFailureAction({ payload: error })))))));
+        .pipe(ofType(updatePublicMemberActivityInviteAction), exhaustMap(({ payload }) => {
+        const existingGuests = payload.activityInvite.guests ?? [];
+        const reconcile$ = payload.guests
+            ? reconcilePublicTokenGuests(payload.activityInvite.id, payload.activityInvite.token, payload.guests, existingGuests, this.activityService)
+                .pipe(catchError(() => of(null)))
+            : of(null);
+        return reconcile$.pipe(mergeMap(() => this.activityService.updatePublicMemberActivityInvite(payload.activityInvite.id, { ...payload.activityInvite, guests: newGuests(payload.guests) })
+            .pipe(map((activityInvite) => updatePublicMemberActivityInviteSuccessAction({ payload: activityInvite })), catchError((error) => of(updatePublicMemberActivityInviteFailureAction({ payload: error }))))));
+    })));
     updatePublicMemberOpenActivity$ = createEffect(() => this.actions$
-        .pipe(ofType(updatePublicMemberOpenActivityAction), exhaustMap(({ payload }) => this.activityService.signUpPublicOpenActivity(payload.activityId, payload.comment, payload.optional_fees, payload.responses)
-        .pipe(mergeMap((openActivity) => {
-        const guests = payload.guests ?? [];
-        if (guests.length === 0) {
-            return of(updatePublicMemberOpenActivitySuccessAction({ payload: openActivity }));
-        }
-        return this.activityService.getPublicOpenActivityGuests(payload.activityId)
-            .pipe(mergeMap((existingCollection) => {
-            const existingGuests = existingCollection.toArray();
-            return reconcilePublicOpenActivityGuests(payload.activityId, guests, existingGuests, this.activityService)
-                .pipe(catchError(() => of(null)), map(() => updatePublicMemberOpenActivitySuccessAction({ payload: openActivity })));
-        }), catchError(() => of(updatePublicMemberOpenActivitySuccessAction({ payload: openActivity }))));
-    }), catchError((error) => of(updatePublicMemberOpenActivityFailureAction({ payload: error })))))));
+        .pipe(ofType(updatePublicMemberOpenActivityAction), exhaustMap(({ payload }) => this.activityService.signUpPublicOpenActivity(payload.activityId, payload.comment, payload.optional_fees, payload.responses, newGuests(payload.guests))
+        .pipe(map((openActivity) => updatePublicMemberOpenActivitySuccessAction({ payload: openActivity })), catchError((error) => of(updatePublicMemberOpenActivityFailureAction({ payload: error })))))));
     updateTeamActivity = createEffect(() => this.actions$
         .pipe(ofType(updateTeamActivityAction), exhaustMap(({ payload }) => this.activityService.updateTeamActivity(payload.teamId, payload.activity)
         .pipe(map((activity) => updateTeamActivitySuccessAction({ payload: activity })), catchError((error) => of(updateTeamActivityFailureAction({ payload: error })))))));
@@ -8899,11 +8885,17 @@ class ActivityEffects extends ExtraMembersMixin {
 i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "18.2.7", ngImport: i0, type: ActivityEffects, decorators: [{
             type: Injectable
         }] });
+// New guests (no id yet) are sent inline with the respond request, so the
+// backend creates them before the invoice and includes their guest fees.
+function newGuests(guests) {
+    return (guests ?? []).filter(g => !g.id).map(g => ({ name: g.name, comment: g.comment ?? undefined }));
+}
+// Updates and deletes of existing guests still use the dedicated guest
+// endpoints; new guests are sent inline with the respond request instead.
 function reconcileMemberGuests(memberId, inviteId, desiredGuests, existingGuests, activityService) {
     const existingById = new Map(existingGuests.map(g => [g.id, g]));
     const desiredIds = new Set(desiredGuests.filter(g => g.id).map(g => g.id));
     const toDelete = existingGuests.filter(g => !desiredIds.has(g.id));
-    const toAdd = desiredGuests.filter(g => !g.id);
     const toUpdate = desiredGuests.filter(g => {
         if (!g.id)
             return false;
@@ -8912,7 +8904,6 @@ function reconcileMemberGuests(memberId, inviteId, desiredGuests, existingGuests
     });
     const ops = [
         ...toDelete.map(g => activityService.deleteMemberActivityGuest(memberId, inviteId, g.id)),
-        ...toAdd.map(g => activityService.addMemberActivityGuest(memberId, inviteId, { name: g.name, comment: g.comment ?? undefined })),
         ...toUpdate.map(g => activityService.updateMemberActivityGuest(memberId, inviteId, g.id, { name: g.name, comment: g.comment ?? undefined })),
     ];
     return ops.length > 0 ? forkJoin(ops) : of(null);
@@ -8921,7 +8912,6 @@ function reconcilePublicTokenGuests(id, token, desiredGuests, existingGuests, ac
     const existingById = new Map(existingGuests.map(g => [g.id, g]));
     const desiredIds = new Set(desiredGuests.filter(g => g.id).map(g => g.id));
     const toDelete = existingGuests.filter(g => !desiredIds.has(g.id));
-    const toAdd = desiredGuests.filter(g => !g.id);
     const toUpdate = desiredGuests.filter(g => {
         if (!g.id)
             return false;
@@ -8930,29 +8920,10 @@ function reconcilePublicTokenGuests(id, token, desiredGuests, existingGuests, ac
     });
     const ops = [
         ...toDelete.map(g => activityService.deletePublicActivityGuestByToken(id, token, g.id)),
-        ...toAdd.map(g => activityService.addPublicActivityGuestByToken(id, token, { name: g.name, comment: g.comment ?? undefined })),
         ...toUpdate.map(g => activityService.updatePublicActivityGuestByToken(id, token, g.id, { name: g.name, comment: g.comment ?? undefined })),
     ];
     return ops.length > 0 ? forkJoin(ops) : of(null);
 }
-function reconcilePublicOpenActivityGuests(activityId, desiredGuests, existingGuests, activityService) {
-    const existingById = new Map(existingGuests.map(g => [g.id, g]));
-    const desiredIds = new Set(desiredGuests.filter(g => g.id).map(g => g.id));
-    const toDelete = existingGuests.filter(g => !desiredIds.has(g.id));
-    const toAdd = desiredGuests.filter(g => !g.id);
-    const toUpdate = desiredGuests.filter(g => {
-        if (!g.id)
-            return false;
-        const existing = existingById.get(g.id);
-        return existing && (existing.name !== g.name || existing.comment !== g.comment);
-    });
-    const ops = [
-        ...toDelete.map(g => activityService.deletePublicOpenActivityGuest(activityId, g.id)),
-        ...toAdd.map(g => activityService.addPublicOpenActivityGuest(activityId, { name: g.name, comment: g.comment ?? undefined })),
-        ...toUpdate.map(g => activityService.updatePublicOpenActivityGuest(activityId, g.id, { name: g.name, comment: g.comment ?? undefined })),
-    ];
-    return ops.length > 0 ? forkJoin(ops) : of(null);
-}
 
 class AuthEffects {
     actions$ = inject(Actions);