@mycadet/gateway 0.12.7 → 0.12.8

package/src/__tests__/shared-invite-registration.test.ts

@@ -1,5 +1,5 @@
 /**
- * Tests for registering `cadet-shared` invites with the platform during
+ * Tests for registering `cadet-shared` invites with the cloud during
  * invite creation (`createInviteNative`). The gateway DB is real; the
  * platform, credential store, feature flags and daemon IPC are stubbed.
  */
@@ -64,15 +64,14 @@ const { createInviteNative, createContactsControlPlaneProxyHandler } =
   await import("../http/routes/contacts-control-plane-proxy.js");
 const { seedContact } = await import("./helpers/contact-fixtures.js");
 
-const BASE_URL_KEY = credentialKey("cadet", "platform_base_url");
 const API_KEY_KEY = credentialKey("cadet", "assistant_api_key");
-const PLATFORM_URL = "https://platform.example.com";
+const CLOUD_URL = "https://test-cloud.mycadet.ai";
 const API_KEY = "vak_test_key";
 const CONTACT_ID = "contact-alice";
 
-function withPlatformCredentials(): void {
+function withCloudCredentials(): void {
+  process.env.CADET_CLOUD_URL = CLOUD_URL;
   storedCredentials = {
-    [BASE_URL_KEY]: { value: `${PLATFORM_URL}/`, unreachable: false },
     [API_KEY_KEY]: { value: API_KEY, unreachable: false },
   };
 }
@@ -101,10 +100,9 @@ beforeEach(() => {
   fetchMock = mock(async () => new Response(null, { status: 204 }));
   ipcCalls = [];
   trustedContactsEnabled = true;
-  withPlatformCredentials();
-  delete process.env.CADET_DISABLE_PLATFORM;
-  delete process.env.IS_PLATFORM;
-  delete process.env.CADET_PLATFORM_URL;
+  withCloudCredentials();
+  delete process.env.CADET_DISABLE_CLOUD;
+  delete process.env.IS_CLOUD;
   delete process.env.ASSISTANT_API_KEY;
 });
 
@@ -119,7 +117,7 @@ describe("cadet-shared invite registration", () => {
 
     expect(fetchMock).toHaveBeenCalledTimes(1);
     const [url, init] = fetchMock.mock.calls[0]!;
-    expect(url).toBe(`${PLATFORM_URL}/v1/internal/shared-invites/`);
+    expect(url).toBe(`${CLOUD_URL}/v1/internal/shared-invites/`);
     expect(init?.method).toBe("POST");
     const headers = init?.headers as Record<string, string>;
     expect(headers.Authorization).toBe(`Api-Key ${API_KEY}`);
@@ -152,7 +150,7 @@ describe("cadet-shared invite registration", () => {
 
   test("falls back to the environment for platform credentials", async () => {
     storedCredentials = {};
-    process.env.CADET_PLATFORM_URL = PLATFORM_URL;
+    process.env.CADET_CLOUD_URL = CLOUD_URL;
     process.env.ASSISTANT_API_KEY = "vak_env_key";
 
     await createInviteNative({
@@ -161,7 +159,7 @@ describe("cadet-shared invite registration", () => {
     });
 
     const [url, init] = fetchMock.mock.calls[0]!;
-    expect(url).toBe(`${PLATFORM_URL}/v1/internal/shared-invites/`);
+    expect(url).toBe(`${CLOUD_URL}/v1/internal/shared-invites/`);
     expect((init?.headers as Record<string, string>).Authorization).toBe(
       "Api-Key vak_env_key",
     );
@@ -200,7 +198,7 @@ describe("registration is skipped", () => {
   });
 
   test("when platform features are disabled", async () => {
-    process.env.CADET_DISABLE_PLATFORM = "true";
+    process.env.CADET_DISABLE_CLOUD = "true";
 
     await createInviteNative({
       contactId: CONTACT_ID,
@@ -223,20 +221,6 @@ describe("registration is skipped", () => {
     expect(activeInviteRows()).toHaveLength(1);
   });
 
-  test("when only the base URL is configured", async () => {
-    storedCredentials = {
-      [BASE_URL_KEY]: { value: PLATFORM_URL, unreachable: false },
-    };
-
-    await createInviteNative({
-      contactId: CONTACT_ID,
-      sourceChannel: "cadet-shared",
-    });
-
-    expect(fetchMock).not.toHaveBeenCalled();
-    expect(activeInviteRows()).toHaveLength(1);
-  });
-
   test("when the trusted-contacts flag is off", async () => {
     trustedContactsEnabled = false;
 
@@ -279,12 +263,12 @@ describe("a failed registration leaves no invite", () => {
     await expectCreateRejected(429, "TOO_MANY_OUTSTANDING_INVITES");
   });
 
-  test("a platform error surfaces as 502", async () => {
+  test("a cloud error surfaces as 502", async () => {
     fetchMock = mock(async () => new Response(null, { status: 503 }));
     await expectCreateRejected(502, "INVITE_REGISTRATION_FAILED");
   });
 
-  test("a platform refusal surfaces as 502", async () => {
+  test("a cloud refusal surfaces as 502", async () => {
     fetchMock = mock(async () => new Response(null, { status: 404 }));
     await expectCreateRejected(502, "INVITE_REGISTRATION_FAILED");
   });
@@ -296,10 +280,9 @@ describe("a failed registration leaves no invite", () => {
     await expectCreateRejected(502, "INVITE_REGISTRATION_FAILED");
   });
 
-  test("an unreachable credential store surfaces as 503 without calling the platform", async () => {
+  test("an unreachable credential store surfaces as 503 without calling the cloud", async () => {
     storedCredentials = {
-      [BASE_URL_KEY]: { value: undefined, unreachable: true },
-      [API_KEY_KEY]: { value: API_KEY, unreachable: false },
+      [API_KEY_KEY]: { value: undefined, unreachable: true },
     };
     await expectCreateRejected(503, "INVITE_REGISTRATION_UNAVAILABLE");
     expect(fetchMock).not.toHaveBeenCalled();

package/src/__tests__/slack-control-plane-proxy.test.ts

@@ -26,7 +26,6 @@ function makeConfig(overrides: Partial<GatewayConfig> = {}): GatewayConfig {
     routingEntries: [],
     port: 7830,
     runtimeProxyRequireAuth: true,
-    shutdownDrainMs: 5000,
     runtimeTimeoutMs: 30000,
     runtimeMaxRetries: 2,
     runtimeInitialBackoffMs: 500,

package/src/__tests__/slack-display-name.test.ts

@@ -77,7 +77,6 @@ function makeConfig(overrides: Partial<GatewayConfig> = {}): GatewayConfig {
     runtimeMaxRetries: 2,
     runtimeProxyRequireAuth: false,
     runtimeTimeoutMs: 30000,
-    shutdownDrainMs: 5000,
     trustProxy: false,
     ...overrides,
   } as GatewayConfig;

package/src/__tests__/slack-normalize.test.ts

@@ -33,7 +33,6 @@ function makeConfig(overrides: Partial<GatewayConfig> = {}): GatewayConfig {
     runtimeMaxRetries: 2,
     runtimeProxyRequireAuth: false,
     runtimeTimeoutMs: 30000,
-    shutdownDrainMs: 5000,
     trustProxy: false,
     ...overrides,
   } as GatewayConfig;

package/src/__tests__/slack-reaction-normalize.test.ts

@@ -22,7 +22,6 @@ function makeConfig(overrides: Partial<GatewayConfig> = {}): GatewayConfig {
     runtimeMaxRetries: 2,
     runtimeProxyRequireAuth: false,
     runtimeTimeoutMs: 30000,
-    shutdownDrainMs: 5000,
     trustProxy: false,
     ...overrides,
   } as GatewayConfig;

package/src/__tests__/slack-socket-mode-catchup.test.ts

@@ -62,7 +62,6 @@ function makeConfig(): GatewayConfig {
     runtimeMaxRetries: 2,
     runtimeProxyRequireAuth: false,
     runtimeTimeoutMs: 30000,
-    shutdownDrainMs: 5000,
     trustProxy: false,
   };
 }

package/src/__tests__/slack-socket-mode-group-dm.test.ts

@@ -121,7 +121,6 @@ function makeConfig(): GatewayConfig {
     runtimeMaxRetries: 2,
     runtimeProxyRequireAuth: false,
     runtimeTimeoutMs: 30000,
-    shutdownDrainMs: 5000,
     trustProxy: false,
   };
 }

package/src/__tests__/slack-socket-mode-liveness.test.ts

@@ -178,7 +178,6 @@ function makeGatewayConfig(): GatewayConfig {
     runtimeMaxRetries: 2,
     runtimeProxyRequireAuth: false,
     runtimeTimeoutMs: 30000,
-    shutdownDrainMs: 5000,
     trustProxy: false,
   } as unknown as GatewayConfig;
 }

package/src/__tests__/slack-socket-mode-outbound-root.test.ts

@@ -134,7 +134,6 @@ function makeConfig(): GatewayConfig {
     runtimeMaxRetries: 2,
     runtimeProxyRequireAuth: false,
     runtimeTimeoutMs: 30000,
-    shutdownDrainMs: 5000,
     trustProxy: false,
   };
 }

package/src/__tests__/slack-socket-mode-thread-tracking.test.ts

@@ -121,7 +121,6 @@ function makeConfig(): GatewayConfig {
     runtimeMaxRetries: 2,
     runtimeProxyRequireAuth: false,
     runtimeTimeoutMs: 30000,
-    shutdownDrainMs: 5000,
     trustProxy: false,
   };
 }

package/src/__tests__/speech-relay-websocket.test.ts

@@ -74,15 +74,15 @@ function makeKeyedCredentials(
 }
 
 describe("tunnel origin derivation", () => {
-  // getPlatformBaseUrl falls back to this env var; pin it absent so the
+  // getCloudBaseUrl falls back to this env var; pin it absent so the
   // missing-credential cases below are deterministic on dev machines.
-  const savedPlatformUrl = process.env.CADET_PLATFORM_URL;
+  const savedCloudUrl = process.env.CADET_CLOUD_URL;
   beforeAll(() => {
-    delete process.env.CADET_PLATFORM_URL;
+    delete process.env.CADET_CLOUD_URL;
   });
   afterAll(() => {
-    if (savedPlatformUrl !== undefined) {
-      process.env.CADET_PLATFORM_URL = savedPlatformUrl;
+    if (savedCloudUrl !== undefined) {
+      process.env.CADET_CLOUD_URL = savedCloudUrl;
     }
   });
 
@@ -104,16 +104,15 @@ describe("tunnel origin derivation", () => {
     ).toBeNull();
   });
 
-  test("derives the tunnel origin from the stored platform base URL when TUNNEL_BASE_URL is unset", async () => {
+  test("derives the tunnel origin from CADET_CLOUD_URL when TUNNEL_BASE_URL is unset", async () => {
     const server = makeFakeServer();
+    process.env.CADET_CLOUD_URL = "https://staging-cloud.mycadet.ai";
     const handler = createSpeechRelayUpgradeHandler(
       makeConfig({ tunnelBaseUrl: undefined }),
       "stt",
       {
         credentials: makeKeyedCredentials({
           "credential/cadet/assistant_api_key": "vk-1",
-          "credential/cadet/platform_base_url":
-            "https://staging-cloud.mycadet.ai",
         }),
       },
     );
@@ -133,19 +132,23 @@ describe("tunnel origin derivation", () => {
   });
 
   test("falls back to prod tunnel for an off-convention or missing platform base URL", async () => {
-    for (const platformBaseUrl of [
+    for (const cloudBaseUrl of [
       "http://localhost:8000",
       "not a url",
       undefined,
     ]) {
       const server = makeFakeServer();
+      if (cloudBaseUrl === undefined) {
+        delete process.env.CADET_CLOUD_URL;
+      } else {
+        process.env.CADET_CLOUD_URL = cloudBaseUrl;
+      }
       const handler = createSpeechRelayUpgradeHandler(
         makeConfig({ tunnelBaseUrl: undefined }),
         "stt",
         {
           credentials: makeKeyedCredentials({
             "credential/cadet/assistant_api_key": "vk-1",
-            "credential/cadet/platform_base_url": platformBaseUrl,
           }),
         },
       );
@@ -162,13 +165,12 @@ describe("tunnel origin derivation", () => {
     }
   });
 
-  test("an explicit TUNNEL_BASE_URL wins over the stored platform base URL", async () => {
+  test("an explicit TUNNEL_BASE_URL wins over CADET_CLOUD_URL", async () => {
     const server = makeFakeServer();
+    process.env.CADET_CLOUD_URL = "https://staging-cloud.mycadet.ai";
     const handler = createSpeechRelayUpgradeHandler(makeConfig(), "stt", {
       credentials: makeKeyedCredentials({
         "credential/cadet/assistant_api_key": "vk-1",
-        "credential/cadet/platform_base_url":
-          "https://staging-cloud.mycadet.ai",
       }),
     });
     const req = new Request(
@@ -265,7 +267,7 @@ describe("createSpeechRelayUpgradeHandler — gate", () => {
   });
 
   test("forwards the tts voice model to tunnel", async () => {
-    // Regression: the daemon sends the selected managed voice as `model`;
+    // Regression: the daemon sends the selected cloud voice as `model`;
     // a gateway that rejects it silently breaks voice selection (the
     // daemon's synthesis fails before tunnel ever sees the session).
     const server = makeFakeServer();

package/src/__tests__/stt-stream-websocket.test.ts

@@ -435,7 +435,7 @@ describe("dictation is not a guardian-only surface", () => {
 });
 
 /**
- * The managed path, where tunnel validated the browser's own token and
+ * The cloud path, where tunnel validated the browser's own token and
  * attested the caller to the bridge. There is no edge JWT on it, so requiring
  * one rejected every managed caller: the socket opened at tunnel and closed at
  * the loopback with an open failure, which the browser saw as a 1014.
@@ -449,7 +449,7 @@ describe("createSttStreamWebsocketHandler: tunnel-attested managed auth", () =>
   const TUNNEL_ORG_ID = "22222222-2222-2222-2222-222222222222";
 
   afterEach(() => {
-    delete process.env.IS_PLATFORM;
+    delete process.env.IS_CLOUD;
   });
 
   const managedUpgrade = ({
@@ -466,9 +466,9 @@ describe("createSttStreamWebsocketHandler: tunnel-attested managed auth", () =>
     tunnelBaseUrl?: string;
   }) => {
     if (managed) {
-      process.env.IS_PLATFORM = "true";
+      process.env.IS_CLOUD = "true";
     } else {
-      delete process.env.IS_PLATFORM;
+      delete process.env.IS_CLOUD;
     }
     const headers = new Headers({
       upgrade: "websocket",
@@ -530,7 +530,7 @@ describe("createSttStreamWebsocketHandler: tunnel-attested managed auth", () =>
     expect(server.upgrade).not.toHaveBeenCalled();
   });
 
-  /** A locally hosted gateway with a tunnel takes the tunnel path like a managed pod. */
+  /** A locally hosted gateway with a tunnel takes the tunnel path like a cloud pod. */
   test("admits an attested caller on a locally hosted gateway with a tunnel", () => {
     const { res, server } = managedUpgrade({
       managed: false,

package/src/__tests__/telegram-control-plane-proxy.test.ts

@@ -26,7 +26,6 @@ function makeConfig(overrides: Partial<GatewayConfig> = {}): GatewayConfig {
     routingEntries: [],
     port: 7830,
     runtimeProxyRequireAuth: true,
-    shutdownDrainMs: 5000,
     runtimeTimeoutMs: 30000,
     runtimeMaxRetries: 2,
     runtimeInitialBackoffMs: 500,

package/src/__tests__/telegram-webhook-drop-visibility.test.ts

@@ -79,7 +79,6 @@ function makeConfig(): GatewayConfig {
     routingEntries: [],
     port: 7830,
     runtimeProxyRequireAuth: false,
-    shutdownDrainMs: 5000,
     runtimeTimeoutMs: 30000,
     runtimeMaxRetries: 2,
     runtimeInitialBackoffMs: 500,

package/src/__tests__/telegram-webhook-handler.test.ts

@@ -33,7 +33,6 @@ function makeConfig(overrides: Partial<GatewayConfig> = {}): GatewayConfig {
     routingEntries: [],
     port: 7830,
     runtimeProxyRequireAuth: false,
-    shutdownDrainMs: 5000,
     runtimeTimeoutMs: 30000,
     runtimeMaxRetries: 2,
     runtimeInitialBackoffMs: 500,