@mycadet/assistant 0.12.8 → 0.12.9

package/node_modules/@mycadet/ces-client/node_modules/@mycadet/service-contracts/package.json

@@ -40,6 +40,6 @@
   },
   "devDependencies": {
     "@types/bun": "1.2.4",
-    "typescript": "5.7.3"
+    "typescript": "5.9.3"
   }
 }

package/node_modules/@mycadet/ces-client/package.json

@@ -19,6 +19,6 @@
   },
   "devDependencies": {
     "@types/bun": "1.2.4",
-    "typescript": "5.7.3"
+    "typescript": "5.9.3"
   }
 }

package/node_modules/@mycadet/ces-client/src/__tests__/ces-client.test.ts

@@ -141,7 +141,7 @@ describe("CesHttpCredentialClient", () => {
       Promise.resolve(
         Response.json({ account: "test-acct", value: "secret-123" }),
       ),
-    ) as typeof fetch;
+    ) as unknown as typeof fetch;
 
     const client = createCesHttpCredentialClient(
       createTestConfig(),
@@ -156,7 +156,7 @@ describe("CesHttpCredentialClient", () => {
   test("get returns not-found on 404", async () => {
     globalThis.fetch = mock(() =>
       Promise.resolve(new Response(null, { status: 404 })),
-    ) as typeof fetch;
+    ) as unknown as typeof fetch;
 
     const client = createCesHttpCredentialClient(
       createTestConfig(),
@@ -171,7 +171,7 @@ describe("CesHttpCredentialClient", () => {
   test("get returns unreachable on 500", async () => {
     globalThis.fetch = mock(() =>
       Promise.resolve(new Response("internal error", { status: 500 })),
-    ) as typeof fetch;
+    ) as unknown as typeof fetch;
 
     const client = createCesHttpCredentialClient(
       createTestConfig(),
@@ -186,7 +186,7 @@ describe("CesHttpCredentialClient", () => {
   test("get returns unreachable on network error", async () => {
     globalThis.fetch = mock(() =>
       Promise.reject(new Error("ECONNREFUSED")),
-    ) as typeof fetch;
+    ) as unknown as typeof fetch;
 
     const client = createCesHttpCredentialClient(
       createTestConfig(),
@@ -201,7 +201,7 @@ describe("CesHttpCredentialClient", () => {
   test("delete returns deleted on 200", async () => {
     globalThis.fetch = mock(() =>
       Promise.resolve(Response.json({ ok: true, account: "acct" })),
-    ) as typeof fetch;
+    ) as unknown as typeof fetch;
 
     const client = createCesHttpCredentialClient(
       createTestConfig(),
@@ -215,7 +215,7 @@ describe("CesHttpCredentialClient", () => {
   test("delete returns not-found on 404", async () => {
     globalThis.fetch = mock(() =>
       Promise.resolve(new Response(null, { status: 404 })),
-    ) as typeof fetch;
+    ) as unknown as typeof fetch;
 
     const client = createCesHttpCredentialClient(
       createTestConfig(),
@@ -229,7 +229,7 @@ describe("CesHttpCredentialClient", () => {
   test("delete returns error on network failure", async () => {
     globalThis.fetch = mock(() =>
       Promise.reject(new Error("network down")),
-    ) as typeof fetch;
+    ) as unknown as typeof fetch;
 
     const client = createCesHttpCredentialClient(
       createTestConfig(),
@@ -243,7 +243,7 @@ describe("CesHttpCredentialClient", () => {
   test("list returns accounts on 200", async () => {
     globalThis.fetch = mock(() =>
       Promise.resolve(Response.json({ accounts: ["a", "b", "c"] })),
-    ) as typeof fetch;
+    ) as unknown as typeof fetch;
 
     const client = createCesHttpCredentialClient(
       createTestConfig(),
@@ -258,7 +258,7 @@ describe("CesHttpCredentialClient", () => {
   test("list returns unreachable on error", async () => {
     globalThis.fetch = mock(() =>
       Promise.reject(new Error("timeout")),
-    ) as typeof fetch;
+    ) as unknown as typeof fetch;
 
     const client = createCesHttpCredentialClient(
       createTestConfig(),
@@ -273,7 +273,7 @@ describe("CesHttpCredentialClient", () => {
   test("bulkSet returns all-failed when request fails", async () => {
     globalThis.fetch = mock(() =>
       Promise.reject(new Error("network")),
-    ) as typeof fetch;
+    ) as unknown as typeof fetch;
 
     const client = createCesHttpCredentialClient(
       createTestConfig(),
@@ -311,7 +311,7 @@ describe("fetchCesLogExport", () => {
           headers: { "Content-Type": "application/gzip" },
         }),
       ),
-    ) as typeof fetch;
+    ) as unknown as typeof fetch;
 
     const result = await fetchCesLogExport({
       baseUrl: "http://ces-test:8090",
@@ -327,7 +327,7 @@ describe("fetchCesLogExport", () => {
   test("returns error on non-OK status", async () => {
     globalThis.fetch = mock(() =>
       Promise.resolve(new Response("forbidden", { status: 403 })),
-    ) as typeof fetch;
+    ) as unknown as typeof fetch;
 
     const result = await fetchCesLogExport({
       baseUrl: "http://ces-test:8090",
@@ -343,7 +343,7 @@ describe("fetchCesLogExport", () => {
   test("returns error on network failure", async () => {
     globalThis.fetch = mock(() =>
       Promise.reject(new Error("connection refused")),
-    ) as typeof fetch;
+    ) as unknown as typeof fetch;
 
     const result = await fetchCesLogExport({
       baseUrl: "http://ces-test:8090",
@@ -361,7 +361,7 @@ describe("fetchCesLogExport", () => {
     globalThis.fetch = mock((url: string | URL | Request) => {
       capturedUrl = typeof url === "string" ? url : url.toString();
       return Promise.resolve(new Response(new ArrayBuffer(0), { status: 200 }));
-    }) as typeof fetch;
+    }) as unknown as typeof fetch;
 
     await fetchCesLogExport(
       { baseUrl: "http://ces-test:8090", serviceToken: "tok" },

package/node_modules/@mycadet/gateway-client/node_modules/@mycadet/service-contracts/package.json

@@ -40,6 +40,6 @@
   },
   "devDependencies": {
     "@types/bun": "1.2.4",
-    "typescript": "5.7.3"
+    "typescript": "5.9.3"
   }
 }

package/node_modules/@mycadet/service-contracts/package.json

@@ -40,6 +40,6 @@
   },
   "devDependencies": {
     "@types/bun": "1.2.4",
-    "typescript": "5.7.3"
+    "typescript": "5.9.3"
   }
 }

package/openapi.yaml

@@ -3,7 +3,7 @@
 openapi: 3.1.0
 info:
   title: Cadet Assistant API
-  version: 0.12.8
+  version: 0.12.9
   description: Auto-generated OpenAPI specification for the Cadet Assistant runtime HTTP server.
 servers:
   - url: http://127.0.0.1:7821
@@ -32738,7 +32738,7 @@ paths:
       summary: Register a cloud callback route
       description: Registers a callback route with the cloud gateway for inbound provider webhooks.
       tags:
-        - platform
+        - cloud
       requestBody:
         required: true
         content:
@@ -45141,14 +45141,6 @@ components:
               type: string
               minLength: 1
             - type: "null"
-        supportsVision:
-          anyOf:
-            - type: boolean
-            - type: "null"
-        invariant:
-          anyOf:
-            - type: boolean
-            - type: "null"
       additionalProperties: {}
     InputModalities:
       type: object
@@ -45501,10 +45493,6 @@ components:
           readOnly: true
           type: string
           minLength: 1
-        supportsVision:
-          type: boolean
-        invariant:
-          type: boolean
     ConnectionProvider:
       type: string
       enum:
@@ -46285,10 +46273,6 @@ components:
           readOnly: true
           type: string
           minLength: 1
-        supportsVision:
-          type: boolean
-        invariant:
-          type: boolean
       additionalProperties: false
     InputModalitiesOutput:
       type: object

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mycadet/assistant",
-  "version": "0.12.8",
+  "version": "0.12.9",
   "license": "MIT",
   "type": "module",
   "exports": {
@@ -20,7 +20,7 @@
     "probe:skill-retrieval": "bun run scripts/probe-skill-retrieval.ts",
     "format": "prettier --write .",
     "format:check": "prettier --check .",
-    "lint": "bun run lint:skills && bun run lint:openapi && eslint --max-warnings 3006",
+    "lint": "bun run lint:skills && bun run lint:openapi && eslint --max-warnings 2956",
     "lint:unused": "knip --include files,dependencies,unlisted",
     "lint:circular": "bun run scripts/check-circular-deps.ts",
     "lint:unused:production": "knip --production --include exports",

package/src/__tests__/cloud-profile-guard.test.ts

@@ -592,12 +592,12 @@ describe("PATCH /v1/config — cloud profile deletion guard", () => {
     });
 
     expect(result).toHaveProperty("ingress");
-    expect(committedRaw()).toEqual({
-      ingress: {
-        publicBaseUrl: "https://manual.example.test",
-        publicBaseUrlManagedBy: "tunnel",
-      },
-    });
+    const committed = committedRaw() as Record<string, any>;
+    expect(committed.ingress.publicBaseUrl).toBe("https://manual.example.test");
+    expect(committed.ingress.publicBaseUrlManagedBy).toBe("tunnel");
+    expect("lastTunnel" in committed.ingress).toBe(false);
+    expect("pairingTunnel" in committed.ingress).toBe(false);
+    expect("assistantId" in committed.ingress).toBe(false);
   });
 
   test("allows patches that modify a cloud profile (non-null)", async () => {
@@ -756,7 +756,7 @@ describe("cloud-profile invariant guard — rejected writes", () => {
       patchRoute.handler({
         body: { llm: { profiles: { balanced: "junk" } } },
       }),
-    ).rejects.toThrow('Cannot delete or replace cloud profile "balanced".');
+    ).rejects.toThrow("expected object, received string");
     expectNothingCommitted();
   });
 
@@ -765,7 +765,7 @@ describe("cloud-profile invariant guard — rejected writes", () => {
       patchRoute.handler({
         body: { llm: { profiles: { balanced: ["disabled"] } } },
       }),
-    ).rejects.toThrow('Cannot delete or replace cloud profile "balanced".');
+    ).rejects.toThrow("expected object, received array");
     expectNothingCommitted();
   });
 
@@ -806,10 +806,7 @@ describe("cloud-profile invariant guard — rejected writes", () => {
       patchRoute.handler({
         body: { llm: { profiles: { balanced: { status: "weird" } } } },
       }),
-    ).rejects.toThrow(
-      'Cannot set status "weird" on cloud profile "balanced". ' +
-        'Only re-enabling (status "active") is allowed.',
-    );
+    ).rejects.toThrow("llm.profiles.balanced.status: Invalid option");
     expectNothingCommitted();
   });
 
@@ -818,7 +815,7 @@ describe("cloud-profile invariant guard — rejected writes", () => {
       setRoute.handler({
         body: { path: "llm.profiles.balanced.status", value: 123 },
       }),
-    ).rejects.toThrow('Cannot set status 123 on cloud profile "balanced"');
+    ).rejects.toThrow("llm.profiles.balanced.status: Invalid option");
     expectNothingCommitted();
   });
 });
@@ -939,12 +936,12 @@ describe("default-profile invariant guard — allowed writes", () => {
 
   test("PATCH non-profile llm writes are unaffected", async () => {
     const result = await patchRoute.handler({
-      body: { llm: { activeProfile: "custom" } },
+      body: { llm: { activeProfile: "balanced" } },
     });
     expect(result).toHaveProperty("llm");
     expectOneCommitCycle();
     expect((committedRaw() as Record<string, any>).llm.activeProfile).toBe(
-      "custom",
+      "balanced",
     );
     // The invariant profiles are untouched by an unrelated llm write.
     expect(savedProfile("balanced")).toEqual(
@@ -1004,12 +1001,13 @@ describe("wire-only profile keys are stripped from writes", () => {
     expect(profile.model).toBe("claude-sonnet");
   });
 
-  test("SET of a wire-only leaf path is dropped without writing", async () => {
+  test("SET of a wire-only leaf path never persists the key", async () => {
     const result = await setRoute.handler({
       body: { path: "llm.profiles.balanced.supportsVision", value: true },
     });
     expect(result).toEqual({ ok: true });
-    expectNothingCommitted();
+    expectOneCommitCycle();
+    expect("supportsVision" in savedProfile("balanced")).toBe(false);
   });
 
   // -------------------------------------------------------------------------
@@ -1425,7 +1423,11 @@ describe("PATCH /v1/config — provider-only services scrub legacy mode", () =>
       string,
       Record<string, Record<string, unknown>>
     >;
-    expect(raw.services["image-generation"]).toEqual({ provider: "cadet" });
-    expect(raw.services["web-search"]).toEqual({ provider: "cadet" });
+    // The section schemas are closed: the parse strips the legacy `mode`
+    // key and materializes the section's defaults around the user's values.
+    expect("mode" in raw.services["image-generation"]!).toBe(false);
+    expect(raw.services["image-generation"]!.provider).toBe("cadet");
+    expect("mode" in raw.services["web-search"]!).toBe(false);
+    expect(raw.services["web-search"]!.provider).toBe("cadet");
   });
 });

package/src/__tests__/config-set-route.test.ts

@@ -85,13 +85,13 @@ describe("config_set route - request validation", () => {
   });
 
   test("accepts body with explicit null value", async () => {
-    seedRawConfig({ heartbeat: { activeHoursStart: 9 } });
+    seedRawConfig({ heartbeat: { timezone: "America/New_York" } });
     const result = await configSetRoute.handler({
-      body: { path: "heartbeat.activeHoursStart", value: null },
+      body: { path: "heartbeat.timezone", value: null },
     });
     expect(result).toEqual({ ok: true });
     const heartbeat = loadRawConfig().heartbeat as Record<string, unknown>;
-    expect(heartbeat.activeHoursStart).toBeNull();
+    expect(heartbeat.timezone).toBeNull();
   });
 
   test("rejects body missing path field", async () => {
@@ -192,12 +192,16 @@ describe("config_set route - request validation", () => {
       body: { path: "memory.cleanup.conversationRetentionDays", value: 30 },
     });
     const saved = loadRawConfig();
-    expect(saved.llm).toEqual({ default: { provider: "anthropic" } });
-    expect(saved.calls).toEqual({ enabled: true });
-    expect(saved.heartbeat).toEqual({
-      activeHoursStart: 9,
-      activeHoursEnd: 22,
+    // The write is schema-canonical: the parse materializes section defaults
+    // around what the user set. The contract under test — a nested set may
+    // not drop or mangle unrelated top-level keys — is asserted leaf-wise.
+    expect((saved.llm as Record<string, unknown>).default).toEqual({
+      provider: "anthropic",
     });
+    expect((saved.calls as Record<string, unknown>).enabled).toBe(true);
+    const heartbeat = saved.heartbeat as Record<string, unknown>;
+    expect(heartbeat.activeHoursStart).toBe(9);
+    expect(heartbeat.activeHoursEnd).toBe(22);
   });
 });
 

package/src/__tests__/credential-health-service.test.ts

@@ -780,8 +780,10 @@ describe("credential-health-service", () => {
     // carries the repair.
     const assistantKeyResult = checkAssistantApiKey;
 
-    test("is not reported when the workspace was never connected", async () => {
-      expect(await assistantKeyResult()).toBeNull();
+    test("is missing_token when no key is stored, connected or not", async () => {
+      const result = await assistantKeyResult();
+      expect(result!.status).toBe("missing_token");
+      expect(result!.canAutoRecover).toBe(true);
     });
 
     test("is healthy when the cloud accepts the stored key", async () => {