@mycadet/assistant 0.12.10 → 0.13.0

package/src/__tests__/vbundle-pax-and-symlink.test.ts

@@ -1,147 +0,0 @@
-/**
- * Tests for PAX extended header round-trip and symlinked skills directory
- * handling in the vbundle builder/validator.
- *
- * Covers:
- * - Builder emits PAX headers for paths >100 bytes; validator parses them
- * - buildExportVBundle follows symlinks when checking skillsDir
- */
-import { mkdirSync, symlinkSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { describe, expect, test } from "bun:test";
-
-const testDir = process.env.CADET_WORKSPACE_DIR!;
-
-process.env.DISABLE_HTTP_AUTH = "true";
-
-import { defaultV1Options } from "../runtime/migrations/__tests__/v1-test-helpers.js";
-import {
-  buildExportVBundle,
-  buildVBundle,
-} from "../runtime/migrations/vbundle-builder.js";
-import { validateVBundle } from "../runtime/migrations/vbundle-validator.js";
-// ---------------------------------------------------------------------------
-// PAX header round-trip
-// ---------------------------------------------------------------------------
-
-describe("PAX extended header round-trip", () => {
-  test("builder + validator round-trip for paths >100 bytes", () => {
-    // Create a path that exceeds the 100-byte ustar limit
-    const longPath =
-      "skills/" +
-      "a".repeat(50) +
-      "/" +
-      "b".repeat(50) +
-      "/very-long-skill-name-that-exceeds-limit.md";
-    expect(new TextEncoder().encode(longPath).length).toBeGreaterThan(100);
-
-    const fileData = new TextEncoder().encode("# Long path skill content");
-    const dbData = new Uint8Array([0x53, 0x51, 0x4c, 0x69, 0x74, 0x65]);
-
-    const { archive } = buildVBundle({
-      files: [
-        { path: "data/db/assistant.db", data: dbData },
-        { path: longPath, data: fileData },
-      ],
-      ...defaultV1Options(),
-    });
-
-    // Validate: should succeed — validator must parse the PAX header
-    const result = validateVBundle(archive);
-    expect(result.errors).toEqual([]);
-    expect(result.is_valid).toBe(true);
-    expect(result.manifest).toBeDefined();
-
-    // The long-path file should appear in the entry map with its full name
-    expect(result.entries?.has(longPath)).toBe(true);
-    const entry = result.entries?.get(longPath);
-    expect(entry?.size).toBe(fileData.length);
-  });
-
-  test("validator rejects long-path file with wrong checksum", () => {
-    const longPath =
-      "skills/" + "x".repeat(60) + "/" + "y".repeat(60) + "/skill.md";
-    expect(new TextEncoder().encode(longPath).length).toBeGreaterThan(100);
-
-    const fileData = new TextEncoder().encode("content");
-    const dbData = new Uint8Array([0x53, 0x51, 0x4c, 0x69, 0x74, 0x65]);
-
-    // Build archive, then re-validate — should pass first
-    const { archive } = buildVBundle({
-      files: [
-        { path: "data/db/assistant.db", data: dbData },
-        { path: longPath, data: fileData },
-      ],
-      ...defaultV1Options(),
-    });
-
-    const result = validateVBundle(archive);
-    expect(result.is_valid).toBe(true);
-  });
-
-  test("short paths (<= 100 bytes) do not emit PAX headers", () => {
-    const shortPath = "config/settings.json";
-    expect(new TextEncoder().encode(shortPath).length).toBeLessThanOrEqual(100);
-
-    const fileData = new TextEncoder().encode("{}");
-    const dbData = new Uint8Array([0x53, 0x51, 0x4c, 0x69, 0x74, 0x65]);
-
-    const { archive } = buildVBundle({
-      files: [
-        { path: "data/db/assistant.db", data: dbData },
-        { path: shortPath, data: fileData },
-      ],
-      ...defaultV1Options(),
-    });
-
-    const result = validateVBundle(archive);
-    expect(result.is_valid).toBe(true);
-    expect(result.entries?.has(shortPath)).toBe(true);
-  });
-});
-
-// ---------------------------------------------------------------------------
-// Symlinked skills directory
-// ---------------------------------------------------------------------------
-
-describe("buildExportVBundle with symlinked skills directory", () => {
-  test("skips symlinked directory inside workspace", () => {
-    // Set up: workspace with a real skills dir and a symlinked dir
-    const wsDir = join(testDir, "export-workspace");
-    const realSkillsDir = join(testDir, "real-skills");
-    mkdirSync(realSkillsDir, { recursive: true });
-    writeFileSync(join(realSkillsDir, "my-skill.md"), "# Skill");
-
-    // Create workspace with a symlink to the skills dir — walkDirectory
-    // skips symlinks, so the symlinked dir should not appear in the archive.
-    mkdirSync(join(wsDir, "skills"), { recursive: true });
-    writeFileSync(join(wsDir, "skills", "real-skill.md"), "# Real");
-    symlinkSync(realSkillsDir, join(wsDir, "linked-skills"));
-
-    // Add a DB so the v1 manifest schema's `data/db/assistant.db` refine
-    // accepts the bundle.
-    mkdirSync(join(wsDir, "data", "db"), { recursive: true });
-    writeFileSync(join(wsDir, "data", "db", "assistant.db"), "fake-db");
-
-    const { archive, manifest } = buildExportVBundle({
-      workspaceDir: wsDir,
-      ...defaultV1Options(),
-    });
-
-    // Validate archive
-    const result = validateVBundle(archive);
-    expect(result.is_valid).toBe(true);
-
-    // Real skill file is in the manifest under workspace/ prefix
-    const realSkill = manifest.contents.find(
-      (f) => f.path === "workspace/skills/real-skill.md",
-    );
-    expect(realSkill).toBeDefined();
-
-    // Symlinked directory is skipped
-    const linkedSkill = manifest.contents.find(
-      (f) => f.path === "workspace/linked-skills/my-skill.md",
-    );
-    expect(linkedSkill).toBeUndefined();
-  });
-});