@myapihq/cli 2.9.0 → 2.10.0

package/dist/commands/container.js

@@ -239,17 +239,6 @@ export async function deploy(id, image, flags) {
     // write their own; a guard that silently passes makes them stop. Restore
     // these the moment the upstream fix lands — see
     // docs/cross-repo-prompts/backend-consolidated-2026-07-28.md.
-    // --smoke is still not honoured; --no-promote was fixed upstream on
-    // 2026-07-28 and works on both deploy paths. Refusing what does not work
-    // beats accepting it, and un-refusing what does beats obstructing.
-    if (typeof flags.smoke === 'string') {
-        error('--smoke is not honoured yet, so this CLI refuses it rather than letting you believe a deploy was checked.\n\n' +
-            'Use --no-promote instead, which now works:\n' +
-            '  1. myapi container deploy <id> <image> --no-promote\n' +
-            '  2. curl the revision URL it prints, for a string only a real build emits\n' +
-            '  3. myapi container promote <id> <revision>\n\n' +
-            'That is the same verify-then-promote, done by you rather than the platform.');
-    }
     const source = typeof flags.source === 'string' ? flags.source : undefined;
     // --image is an alias for the positional image ref.
     if (!image && typeof flags.image === 'string')
@@ -262,6 +251,28 @@ export async function deploy(id, image, flags) {
     const deployOpts = {};
     if (flags['no-promote'] === true)
         deployOpts.promote = false;
+    if (typeof flags.smoke === 'string')
+        deployOpts.smoke = _parseSmoke(flags.smoke);
+    // On a container's FIRST deploy there is no earlier revision to hold
+    // traffic, so the platform runs the assertion against the LIVE url — a
+    // failing build is already serving when you are told it failed. Say so
+    // before the deploy rather than after, because the remedy differs: on any
+    // later deploy a failure is contained, and here it is not.
+    if (deployOpts.smoke || deployOpts.promote === false) {
+        try {
+            const existing = await sdkContainer.listRevisions(config.api_key, orgId, id);
+            if (existing.length === 0) {
+                info('Note: this container has no earlier revision, so there is nothing to hold');
+                info('traffic while the new one is checked. A failing build WILL be serving.');
+                info('Deploy to a non-production container first if that matters.');
+                info('');
+            }
+        }
+        catch { /* advisory only — never block a deploy on it */ }
+    }
+    if (deployOpts.promote === false && deployOpts.smoke) {
+        error('--smoke already withholds traffic until the assertion passes, then promotes.\nUse one or the other: --smoke to verify-and-promote, --no-promote to hold the revision back.');
+    }
     // ── Source-build path (async) ───────────────────────────────────────────
     if (source) {
         let tarball;
@@ -593,13 +604,21 @@ Options:
                  On a container's FIRST deploy there is nothing already
                  serving, so traffic is NOT withheld and the output says so.
 
-  --smoke        Still refused — the platform accepts it and does nothing.
-                 --no-promote gives you the same verify-then-promote by hand.
+  --smoke '<assertion>'
+                 Deploy, assert against the new revision, and promote it ONLY
+                 if the assertion holds. A failure leaves the previous
+                 revision serving and returns SMOKE_FAILED with a revision URL
+                 to inspect. Works on both deploy paths.
+
+                 Grammar: [GET|HEAD] [/path] [status N] [contains TEXT]
+                 Assert on CONTENT — "returns 200" is true of a placeholder
+                 page too, which is how one reached production and stayed.
 
 Examples:
   myapi container deploy <id> registry.example.com/my-app:v2
   myapi container deploy <id> --source ./my-app
-  myapi container deploy <id> <image> --no-promote`,
+  myapi container deploy <id> <image> --no-promote
+  myapi container deploy <id> --source ./app --smoke 'GET / contains assets/'`,
     'rollback': `myapi container rollback <id> [--org <id>] [--json]
 
 Move traffic back to the previous ready revision. Seconds, no rebuild.
@@ -647,8 +666,10 @@ dependencies and long execution.
 Subcommands:
   build-logs <id>      Why the last --source build failed (--tail N; default 100)
   create               Register a container and get its scoped API key (returned once)
+                       (--health-check /livez for an HTTP startup probe)
   delete <id>          Soft-delete and revoke its scoped API key
   deploy <id> <image>  Ship a pre-built image (or --source <dir|tar> to build) and go live
+                       (--smoke to verify before promoting; --no-promote to hold it back)
   domain <id> <domain> Bind a custom domain (--remove to unbind)
   get <id>             Inspect a container
   list                 List containers in your org

package/dist/commands/flag-reachability.test.js

@@ -122,11 +122,21 @@ describe('container deploy — --no-promote must REACH both paths', () => {
         await run(() => deploy('c1', 'img:v1', { org: ORG }));
         expect(sdk.container.deployContainer).toHaveBeenCalledWith('hq_live_test', ORG, 'c1', 'img:v1', {});
     });
-    // --smoke is still not honoured upstream, and refusing beats accepting.
-    it('still refuses --smoke, on either path', async () => {
+    // --smoke was refused while the platform ignored it, and is honoured now.
+    // The assertion has flipped twice; what has not changed is that it must
+    // REACH the call, on whichever path.
+    it('sends the parsed assertion on the image path', async () => {
+        sdk.container.deployContainer.mockResolvedValue({ ...DEPLOYED, promoted: true });
+        const { deploy } = await import('./container.js');
+        await run(() => deploy('c1', 'img:v1', { smoke: 'GET / contains assets/', org: ORG }));
+        expect(sdk.container.deployContainer).toHaveBeenCalledWith('hq_live_test', ORG, 'c1', 'img:v1', { smoke: { method: 'GET', path: '/', contains: 'assets/' } });
+    });
+    // Combining them is a contradiction: --smoke promotes on success, and
+    // --no-promote withholds regardless. Refused rather than silently picking.
+    it('refuses --smoke together with --no-promote', async () => {
         const { deploy } = await import('./container.js');
-        await run(() => deploy('c1', 'img:v1', { smoke: 'GET / contains x', org: ORG }));
-        expect(exitError).toMatch(/--smoke is not honoured yet/);
+        await run(() => deploy('c1', 'img:v1', { smoke: 'GET / contains x', 'no-promote': true, org: ORG }));
+        expect(exitError).toMatch(/one or the other/);
         expect(sdk.container.deployContainer).not.toHaveBeenCalled();
     });
 });

package/dist/errors.js

@@ -45,6 +45,12 @@ export const ERROR_MESSAGES = {
     // on a backend deploy we do not control the timing of, and a CLI that only
     // knows the new names would print a bare code for anyone on the old build.
     // The old five can go once that deploy is everywhere.
+    // Deploy-guard validation, added when the platform started refusing bad
+    // assertions BEFORE building — a source build costs minutes you pay for, so
+    // catching a typo up front matters more than it looks.
+    INVALID_SMOKE: 'The --smoke assertion is not usable. It must assert something: add `contains <text>` or `status <code>`. A check that only requests a path passes on any response, including the placeholder page the flag exists to catch.',
+    SMOKE_FAILED: 'The smoke assertion did not pass, so the new revision was NOT promoted. On a container with an earlier revision that one is still serving; on a FIRST deploy there was nothing to hold traffic and the failing build is live. Inspect the revision URL in the error.',
+    INVALID_HEALTH_CHECK: 'That health-check path is not usable. /healthz is refused specifically: the runtime answers it before your container does, so a probe on it passes even when your app is down. Use /livez or any other path.',
     DNS_UNAVAILABLE: 'The DNS provider is unavailable. This is platform-side and usually transient — retry shortly rather than changing your request.',
     DNS_ZONE_NOT_FOUND: 'No DNS zone for this domain. Register or import it first: myapi domain register <domain>.',
     DNS_ZONE_UNAVAILABLE: 'The DNS zone exists but could not be reached. Platform-side and transient.',

package/dist/skills/my-container-api/SKILL.md

@@ -4,7 +4,7 @@ version: 1.0.0
 description: >
   Run containers on demand — long-running services, background workers, and scheduled jobs. The heavier-duty sibling of edge functions, for native deps and long execution.
 triggers: [container, cloud run, dynamic app, custom domain app, service, worker, scheduled job, deploy container, docker image]
-checksum: sha256-47eda6baa9055dadbd3e9d04df9fc425f1a7e96a9cd80c971c4951b97f1e94ff
+checksum: sha256-0e68a4596027c9ccccf0cc86423deffbe71307d265aa973d3cd6261db2695152
 ---
 
 # MyContainerAPI
@@ -23,26 +23,33 @@ The lifecycle is **create → deploy → (optionally) bind a custom domain**.
   can deploy; you do not need to be able to run one.
 - `domain` puts the container on a **custom domain** — how you serve a dynamic app at `app.yourbrand.com`.
 
-### Deploying safely — NOT YET POSSIBLE ON THIS PLATFORM
+### Deploying safely
 
-A deploy takes 100% of traffic the moment it lands. There is no dry run, no
-definition of correct beyond "something is listening on the port", and no way
-back. Plan for that.
+A plain deploy takes 100% of traffic the moment it lands.
 
-`--no-promote` and `--smoke` exist as flags and **the CLI refuses them**: they
-shipped before the platform could honour them, and a guard that silently
-passes is worse than no guard. `--health-check` is accepted at create but does
-not appear on the container afterwards, so do not rely on it either.
+**`--smoke '<assertion>'`** deploys the revision with no traffic, checks the
+assertion, and promotes only if it holds. A failure returns `SMOKE_FAILED`,
+leaves the previous revision serving, and returns a revision URL to inspect.
 
-Until they work, the only safe sequence is:
+```bash
+myapi container deploy <id> --source ./app --smoke 'GET / contains assets/'
+```
+
+**Assert on content, not status.** A build whose frontend never bundled still
+binds its port and answers `200` — that is how a placeholder page reached
+production and served a dead page for fifteen minutes.
+
+**`--no-promote`** holds the revision back and prints a URL to test yourself,
+then `myapi container promote <id> <revision>`. Use it when the check is more
+than one assertion. On a container's *first* deploy nothing is serving yet, so
+traffic is not withheld and the output says so.
 
-1. deploy to a **non-production** container
-2. verify it yourself — `curl` for a string only a real build emits, not just
-   a 200, because a broken build returns 200 too
-3. deploy the same image to production
+**`myapi container rollback <id>`** returns traffic to the previous ready
+revision in seconds, no rebuild.
 
-`myapi container promote <id> <revision>` currently fails, so a bad deploy
-must be fixed by deploying forward. Keep a known-good image reference to hand.
+`--health-check /livez` at create makes the startup probe an HTTP request
+rather than a bare TCP connect. `/healthz` is refused — the runtime intercepts
+it, so the probe would never reach your container.
 
 ### Custom domains (dynamic apps)
 
@@ -121,8 +128,7 @@ way that looks like an application bug.
   error envelope will not reach the caller. Return a 4xx if the reason has to
   survive.
 - **`--env`, `--cpu`, `--memory`, `--max-instances` and `--cron` are set at
-  `create` and cannot be changed by `deploy`.** Passing them to `deploy` does
-  nothing. Recreate the container to change them.
+  `create` and cannot be changed by `deploy`.** Recreate to change them.
 
 ### Keeping a service warm
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@myapihq/cli",
   "license": "Apache-2.0",
-  "version": "2.9.0",
+  "version": "2.10.0",
   "description": "MyAPI command-line interface",
   "repository": {
     "type": "git",
@@ -46,7 +46,7 @@
     "lint:skills:strict": "node scripts/copy-skills.js && node scripts/lint-skills.js --strict"
   },
   "dependencies": {
-    "@myapihq/sdk": "^2.9.0"
+    "@myapihq/sdk": "^2.10.0"
   },
   "devDependencies": {
     "@types/node": "^25.6.0",