@mxf-dev/core 1.0.0 → 2.0.0

package/src/services/orpar-memory/OrparMemoryCoordinator.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 
@@ -211,6 +211,8 @@ export class OrparMemoryCoordinator {
         this.cleanupIntervalId = setInterval(() => {
             this.cleanupStaleCycles();
         }, OrparMemoryCoordinator.CLEANUP_INTERVAL_MS);
+        // Background sweep — must not keep the event loop alive on its own.
+        this.cleanupIntervalId.unref();
 
         this.logger.debug('[OrparMemoryCoordinator] Started stale cycle cleanup interval');
     }
@@ -323,6 +325,20 @@ export class OrparMemoryCoordinator {
             this.onOrparToolEvent('reflection', payload);
         });
 
+        // Fill phase memory usage from actual retrievals.
+        //
+        // PhaseStrataRouter already emits every phase retrieval with the memory ids it
+        // returned, but nothing consumed it: the only way to populate phaseUsage was the
+        // public recordMemoryUsage(), which no production code ever called. phaseUsage was
+        // therefore always empty, so PhaseWeightedRewarder returned no rewards and cycle
+        // consolidation iterated zero memories. Subscribing here is what makes
+        // phase-weighted rewards real.
+        EventBus.server.on(OrparMemoryEvents.PHASE_MEMORY_RETRIEVED, (payload: any) => {
+            if (this.enabled) {
+                this.onPhaseMemoryRetrieved(payload);
+            }
+        });
+
         // Listen for task completion to retroactively update rewards when
         // the ORPAR cycle completed before task_complete was called
         EventBus.server.on(Events.Task.COMPLETED, (payload: any) => {
@@ -331,7 +347,7 @@ export class OrparMemoryCoordinator {
             }
         });
 
-        this.logger.debug('[OrparMemoryCoordinator] Event listeners registered for ControlLoop, OrparTools, and TaskEvents');
+        this.logger.debug('[OrparMemoryCoordinator] Event listeners registered for ControlLoop, OrparTools, PhaseMemory, and TaskEvents');
     }
 
     /**
@@ -341,11 +357,23 @@ export class OrparMemoryCoordinator {
     private onPhaseEvent(phase: OrparPhase, payload: any, source: string = 'controlLoop'): void {
         if (!this.enabled) return;
 
-        const { agentId, channelId } = payload.data || payload;
-        if (!agentId) return;
+        // agentId/channelId are top-level fields on BaseEventPayload, and loopId lives in
+        // `data` (ControlLoopSpecificData). This previously read both from the wrong
+        // level — `payload.data || payload` resolved to `data`, which carries no agentId —
+        // so every control-loop phase event hit the guard below and returned, and no
+        // server-side ORPAR cycle ever accumulated a phase.
+        const agentId = payload.agentId;
+        const channelId = payload.channelId;
+        if (!agentId) {
+            this.logger.warn(
+                `[OrparMemoryCoordinator] Ignoring ${phase} event from ${source}: payload has no agentId`
+            );
+            return;
+        }
 
-        // Get or create cycle state
-        const cycleId = payload.loopId || `${agentId}-${Date.now()}`;
+        // Fall back to a stable per-agent key rather than a timestamp: a timestamped key
+        // would start a fresh cycle on every event and no cycle would ever accumulate.
+        const cycleId = payload.data?.loopId || `${agentId}:${channelId ?? 'default'}`;
 
         // Fix #2: Acquire lock before modifying cycle state
         if (!this.acquireCycleLock(cycleId)) {
@@ -510,14 +538,28 @@ export class OrparMemoryCoordinator {
         const cycleState = this.activeCycles.get(cycleKey);
         if (!cycleState || cycleState.isComplete) return;
 
-        // Build outcome from reflection data
+        // Build the outcome from what we actually observed.
+        //
+        // This previously hardcoded qualityScore (0.8/0.4), errorCount (0), toolCallCount
+        // (5) and taskCompleted (true) and fed them into the reward calculation as though
+        // they were measurements. Rewards derived from invented numbers are worse than no
+        // rewards, so every field below is either observed or omitted.
         const reflectionData = reflectionPayload.data || {};
+
+        // Phases actually entered during this cycle — a real count, not an assumption
+        // that every cycle runs all five.
+        const phasesObserved = Object.keys(cycleState.phaseStartTimes).length;
+
         const outcome: CycleOutcome = {
             success: reflectionData.expectationsMet !== false,
-            qualityScore: reflectionData.expectationsMet !== false ? 0.8 : 0.4,
-            errorCount: 0,
-            toolCallCount: 5, // ORPAR tools count as one call per phase
-            taskCompleted: true,
+            // Only report a quality score if reflection actually produced one.
+            ...(typeof reflectionData.qualityScore === 'number'
+                ? { qualityScore: reflectionData.qualityScore }
+                : {}),
+            errorCount: Array.isArray(reflectionData.errors) ? reflectionData.errors.length : 0,
+            toolCallCount: phasesObserved,
+            // Only true when reflection says so — the coordinator cannot see task state.
+            taskCompleted: reflectionData.taskCompleted === true,
             metadata: {
                 source: 'orparTools',
                 learnings: reflectionData.learnings,
@@ -735,6 +777,40 @@ export class OrparMemoryCoordinator {
     /**
      * Record memory usage in a cycle
      */
+    /**
+     * Record a phase retrieval reported by PhaseStrataRouter.
+     *
+     * Resolves the agent's active cycle and records every returned memory against the
+     * phase it was retrieved in, so the cycle carries real usage by the time it completes.
+     */
+    private onPhaseMemoryRetrieved(payload: any): void {
+        const agentId = payload.agentId;
+        const channelId = payload.channelId;
+        const phase: OrparPhase | undefined = payload.data?.phase;
+        const memoryIds: string[] = payload.data?.memoryIds ?? [];
+
+        if (!agentId || !phase || memoryIds.length === 0) {
+            return;
+        }
+
+        // Match the cycle key used by onPhaseEvent so retrievals land on the live cycle.
+        const cycleId = payload.data?.loopId || `${agentId}:${channelId ?? 'default'}`;
+        if (!this.activeCycles.has(cycleId)) {
+            this.logger.debug(
+                `[OrparMemoryCoordinator] Phase retrieval for ${cycleId} has no active cycle; ignoring`
+            );
+            return;
+        }
+
+        for (const memoryId of memoryIds) {
+            this.recordMemoryUsage(cycleId, phase, memoryId, 'context');
+        }
+
+        this.logger.debug(
+            `[OrparMemoryCoordinator] Recorded ${memoryIds.length} memories for cycle ${cycleId} (phase=${phase})`
+        );
+    }
+
     public recordMemoryUsage(
         cycleId: string,
         phase: OrparPhase,

package/src/services/orpar-memory/PhaseMemoryOperations.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/services/orpar-memory/PhaseStrataRouter.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/services/orpar-memory/PhaseWeightedRewarder.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/services/orpar-memory/SurpriseOrparAdapter.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/services/orpar-memory/index.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/Agent.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/AgentPerformanceTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/AgentRegistry.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/AgentTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/ChannelContext.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/ControlLoopTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/DagTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/EffectivenessTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/InferenceParameterTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/KnowledgeGraphTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/LlmTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/McpPromptTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/MemoryTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/MemoryUtilityTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 
@@ -448,6 +448,8 @@ export interface UtilityRetrievalOptions {
     maxResults?: number;
     /** Similarity threshold */
     similarityThreshold?: number;
+    /** Hybrid search balance passed to Meilisearch (0 = keyword, 1 = semantic) */
+    hybridRatio?: number;
     /** Include score breakdown */
     includeBreakdown?: boolean;
 }

package/src/types/MxpTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/NetworkRecoveryTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/OrparMemoryIntegrationTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/PatternLearningTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/PatternMemoryTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/ReflectionTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/TaskCompletionTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/TaskTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/TensorFlowTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/ValidationPerformanceTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/toolTypes.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */
 

package/src/types/types.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  *
  * @author Brad Anderson <BradA1878@pm.me>
- * @repository https://github.com/mxf-dev/mxf
+ * @repository https://github.com/BradA1878/model-exchange-framework
  * @documentation https://mxf-dev.github.io/mxf/
  */