@muze-nl/simplystore 0.5.5 → 0.5.6

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@muze-nl/simplystore",
-	"version": "0.5.5",
+	"version": "0.5.6",
 	"main": "src/server.mjs",
 	"type": "module",
 	"scripts": {

package/src/command-worker-module.mjs

@@ -77,7 +77,6 @@ export default async function runCommand(commandStr, request) {
     if (commands[task.name]) {
         let time = Date.now()
         commands[task.name](dataspace, task, request, metaProxy)
-        //TODO: if command/task makes no changes, skip updating data.jsontag and writing it, skip response.data
         FastJSONTag.setAttribute(dataspace, 'command', task.id)
 
         const strData = resultSetStringify(resultSet)
@@ -88,7 +87,7 @@ export default async function runCommand(commandStr, request) {
                 id: meta.index.id
             }
         }
-        //TODO: write data every x commands or x minutes, in seperate thread
+
         await writeFileAtomic(datafile, uint8sab)
         let end = Date.now()
         console.log('task time',end-time)

package/src/server.mjs

@@ -261,8 +261,8 @@ async function main(options) {
         if (!commandId) {
             return
         }
-        let commandStr = req.body.toString()
         try {
+            let commandStr = req.body.toString()
             let request = {
                 method: req.method,
                 url: req.originalUrl,
@@ -289,12 +289,24 @@ async function main(options) {
     })
 
     function checkCommand(req, res) {
+        let error
         let commandStr = req.body.toString() // raw body through express.raw()
-        let command = JSONTag.parse(commandStr)
-        let commandOK = {
-            command: command?.id,
-            code: 202,
-            status: 'accepted'
+        try {
+            let command = JSONTag.parse(commandStr)
+
+            let commandOK = {
+                command: command?.id,
+                code: 202,
+                status: 'accepted'
+            }
+        } catch(err) {
+            error = {
+                code: 400,
+                message: "Bad request",
+                details: err
+            }
+            sendResponse({code: 400, body: JSON.stringify(error)}, res)
+            return false
         }
         if (!command || !command.id) {
             error = {