@muze-nl/od-jsontag 0.2.8 → 0.3.0

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@muze-nl/od-jsontag",
-	"version": "0.2.8",
+	"version": "0.3.0",
 	"description": "On Demand JSONTag: parse/serialize large datastructures on demand, useful for sharing data between threads",
 	"type": "module",
 	"author": "Auke van Slooten <auke@muze.nl>",

package/src/jsontag.mjs

@@ -1,5 +1,5 @@
 import JSONTag from '@muze-nl/jsontag'
-import {source} from './symbols.mjs'
+import {source, isChanged} from './symbols.mjs'
 
 export function getType(obj) {
     return JSONTag.getType(obj?.[source] ?? obj)
@@ -26,22 +26,36 @@ export function isNull(obj) {
 }
 
 export function setAttribute(obj, attr, value) {
+    if (obj?.[source]) {
+        obj[isChanged] = true
+    }
     return JSONTag.setAttribute(obj?.[source] ?? obj, attr, value)
 }
 
 export function setAttributes(obj, attr) {
+    if (obj?.[source]) {
+        obj[isChanged] = true
+    }
     return JSONTag.setAttribute(obj?.[source] ?? obj, attr)
 }
 
 export function setType(obj, type) {
+    if (obj?.[source]) {
+        obj[isChanged] = true
+    }
     return JSONTag.setType(obj?.[source] ?? obj, type)
 }
 
 export function addAttribute(obj, attr, value) {
+    if (obj?.[source]) {
+        obj[isChanged] = true
+    }
     return JSONTag.addAttribute(obj?.[source] ?? obj, attr, value)
 }
 
 export function removeAttribute(obj, attr) {
+    if (obj?.[source]) {
+        obj[isChanged] = true
+    }
     return JSONTag.removeAttribute(obj?.[source] ?? obj, attr)
-}
-
+}

package/src/parse.mjs

@@ -5,6 +5,7 @@ import {source,isProxy,proxyType,getBuffer,getIndex,isChanged,isParsed,position,
 
 const decoder = new TextDecoder()
 const encoder = new TextEncoder()
+const arrayProxies = new WeakMap()
 
 function stringToSAB(strData) {
     const buffer = encoder.encode(strData)
@@ -674,6 +675,18 @@ export default function parse(input, meta, immutable=true)
         })
     }
 
+    const getArrayProxy = (arr, par, handler) => {
+        if (!handler) {
+            handler = handlers.arrayHandler
+        }
+        if (!arrayProxies.has(arr)) {
+            arrayProxies.set(arr, new Proxy(arr, handler))
+        }
+        let aProxy = arrayProxies.get(arr)
+        aProxy[parent] = par
+        return aProxy
+    }
+
     const handlers = {
         newArrayHandler: {
             get(target, prop) {
@@ -694,12 +707,17 @@ export default function parse(input, meta, immutable=true)
                         return undefined
                     }
                     if (Array.isArray(target[prop])) {
-                        return new Proxy(target[prop], handlers.newArrayHandler)
+                        return getArrayProxy(target[prop], target, handlers.newArrayHandler)
                     }
                     return target[prop]
                 }
             },
             set(target, prop, value) {
+                if (prop === isChanged || prop === parent) {
+                    // prevent infinite loops, parent is only needed to mark it isChanged
+                    // but this is a new array proxy, parent is already dirty
+                    return true
+                }
                 if (meta.access && !meta.access(target, prop)) {
                     return undefined
                 }
@@ -745,7 +763,7 @@ export default function parse(input, meta, immutable=true)
                             return undefined
                         }
                         if (Array.isArray(target[prop])) {
-                            return new Proxy(target[prop], handlers.newArrayHandler)
+                            return getArrayProxy(target[prop], target, handlers.newArrayHandler)
                         }
                         return target[prop]
                     break
@@ -782,19 +800,24 @@ export default function parse(input, meta, immutable=true)
                         return result
                     }
                 } else if (prop===isChanged) {
-                    return target[parent][isChanged]
+                    return target[isChanged] || target[parent][isChanged]
+                } else if (prop===source) {
+                    return target
                 } else {
                     if (meta.access && !meta.access(target, prop, 'get')) {
                         return undefined
                     }
                     if (Array.isArray(target[prop])) {
-                        target[prop][parent] = target[parent]
-                        return new Proxy(target[prop], handlers.arrayHandler)
+                        return getArrayProxy(target[prop], target)
                     }
                     return target[prop]
                 }
             },
             set(target, prop, value) {
+                if (prop == parent) {
+                    target[parent] = value
+                    return true
+                }
                 if (immutable) {
                     throw new Error('dataspace is immutable')
                 }
@@ -805,6 +828,7 @@ export default function parse(input, meta, immutable=true)
                     value = getNewValueProxy(value)
                 } 
                 target[prop] = value
+                target[isChanged] = true
                 target[parent][isChanged] = true
                 return true
             },
@@ -819,6 +843,7 @@ export default function parse(input, meta, immutable=true)
                 //that object should be deleted so that its line will become empty
                 //when stringifying resultArray again
                 delete target[prop]
+                target[isChanged] = true
                 target[parent][isChanged] = true
                 return true
             }
@@ -867,15 +892,14 @@ export default function parse(input, meta, immutable=true)
                             return undefined
                         }
                         if (Array.isArray(target[prop])) {
-                            target[prop][parent] = target
-                            return new Proxy(target[prop], handlers.arrayHandler)
+                            return getArrayProxy(target[prop], target)
                         }
                         return target[prop]
                     break
                 }
             },
             set(target, prop, value, receiver) {
-                if (immutable && prop!==resultSet && prop!==source) {
+                if (immutable && prop!==resultSet && prop!==source && prop!==isChanged) {
                     throw new Error('dataspace is immutable')
                 }
                 switch(prop) {

package/src/serialize.mjs

@@ -32,7 +32,7 @@ export default function serialize(value, options={}) {
 		}
 	}
 	if (!resultArray) {
-		resultArray = value[resultSet]
+		resultArray = value?.[resultSet]
 	}
 	if (!resultArray) {
 		resultArray = []
@@ -159,7 +159,7 @@ export default function serialize(value, options={}) {
 		return u8arr
 	}
 
-	if (!value[resultSet]) {
+	if (!value?.[resultSet]) {
 		resultArray.push(value)
 	}
 	let currentSource = 0
@@ -167,7 +167,11 @@ export default function serialize(value, options={}) {
 	let skipCount = 0
 	let result = []
 	while(currentSource<resultArray.length) {
-		if (resultArray[currentSource][isChanged] || !resultArray[currentSource][isProxy]) {
+		if (!resultArray[currentSource]) {
+			//FIXME: should not happen, this means that there is no complete
+			//od-jsontag file, only patches?
+			skipCount++
+		} else if (resultArray[currentSource][isChanged] || !resultArray[currentSource][isProxy]) {
 			if (skipCount) {
 				result[currentResult] = encoder.encode('+'+skipCount)
 				skipCount = 0
@@ -201,7 +205,9 @@ export default function serialize(value, options={}) {
 	for (let line of arr) {
 		length += line.length+1
 	}
-	length -= 1 // skip last newline
+	if (length) {
+		length -= 1 // skip last newline
+	}
 	let sab = new SharedArrayBuffer(length)
 	let u8arr = new Uint8Array(sab)
 	let offset = 0