@muonic/muon 0.0.2-beta.45 → 0.0.2-beta.47

package/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [0.0.2-beta.47](https://github.com/centrica-engineering/muon/compare/v0.0.2-beta.46...v0.0.2-beta.47) (2023-10-03)
+
+
+### Bug Fixes
+
+* checkavailabe cache ([d780dc9](https://github.com/centrica-engineering/muon/commit/d780dc921cf32c377690b7dfdfe1ce3031850ab3))
+
+### [0.0.2-beta.46](https://github.com/centrica-engineering/muon/compare/v0.0.2-beta.45...v0.0.2-beta.46) (2023-09-26)
+
 ### [0.0.2-beta.45](https://github.com/centrica-engineering/muon/compare/v0.0.2-beta.44...v0.0.2-beta.45) (2023-09-18)
 
 ### [0.0.2-beta.44](https://github.com/centrica-engineering/muon/compare/v0.0.2-beta.43...v0.0.2-beta.44) (2023-09-15)

package/directives/svg-loader-directive.js

@@ -24,11 +24,14 @@ export class SVGLoaderDirective extends AsyncDirective {
     try {
       cacheAvailable = 'caches' in self;
       cache = cacheAvailable && await caches?.open(SVG_CONFIG_CACHE);
-      const cacheData = await cache.match(url);
+      const cacheData = cacheAvailable && await cache?.match(url);
 
       response = cache && cacheData ? cacheData : undefined;
+
+      if (!cacheAvailable) {
+        console.info('cache not available');
+      }
     } catch (error) {
-      console.info('cache not available');
       console.info(error);
     }
 
@@ -60,17 +63,18 @@ export class SVGLoaderDirective extends AsyncDirective {
         threshold: 0.01,
         rootMargin: '150px'
       };
+      const observe = parts.parentNode;
 
       const io = new IntersectionObserver((entries) => {
         /* eslint-disable consistent-return */
         return entries.forEach((entry) => {
           if (entry.intersectionRatio > 0) {
+            io.unobserve(observe);
             return resolve(this.render(attributes));
           }
         });
       }, options);
 
-      const observe = parts.parentNode;
       io.observe(observe);
     });
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@muonic/muon",
-  "version": "0.0.2-beta.45",
+  "version": "0.0.2-beta.47",
   "description": "",
   "main": "index.js",
   "scripts": {

package/tests/components/icon/__snapshots__/icon.test.snap.js

@@ -87,3 +87,12 @@ snapshots["icon caches not available"] =
 `;
 /* end snapshot icon caches not available */
 
+snapshots["icon broken caches"] = 
+`<div
+  aria-hidden="true"
+  class="arrow-right icon"
+>
+</div>
+`;
+/* end snapshot icon broken caches */
+

package/tests/components/icon/icon.test.js

@@ -182,6 +182,21 @@ describe('icon', () => {
     expect(el.innerText.trim()).to.equal('', 'has no light dom');
   });
 
+  it('broken caches', async () => {
+    self.caches.open = () => {
+      throw new TypeError('Failed to execute \'open\' on \'CacheStorage\': 1 argument required, but only 0 present.');
+    };
+
+    const consoleWarn = sinon.stub(console, 'info');
+    const el = await fixture(html`<${tag}></${tag}>`);
+
+    await awaitLoading(el);
+    await defaultChecks(el);
+
+    expect(consoleWarn.args[0][0].toString()).to.equal('TypeError: Failed to execute \'open\' on \'CacheStorage\': 1 argument required, but only 0 present.', 'console info shows that cache is not available');
+    expect(consoleWarn.args.length).to.equal(1, 'info shows 1 messages');
+  });
+
   it('caches not available', async () => {
     delete self.caches; // replicate caches API not being available
 
@@ -192,6 +207,6 @@ describe('icon', () => {
     await defaultChecks(el);
 
     expect(consoleWarn.args[0]).to.deep.equal(['cache not available'], 'console info shows that cache is not available');
-    expect(consoleWarn.args.length).to.equal(2, 'info shows 2 messages');
+    expect(consoleWarn.args.length).to.equal(1, 'info shows 1 messages');
   });
 });