@multiplayer-app/session-recorder-browser 2.0.38 → 2.0.40

package/dist/browser/index.js

@@ -25163,7 +25163,7 @@ const CONTINUOUS_DEBUGGING_TIMEOUT = 60000; // 1 minutes
 const DEBUG_SESSION_MAX_DURATION_SECONDS = 10 * 60 + 30; // TODO: move to shared config otel core
 const REMOTE_SESSION_RECORDING_START = 'remote-session-recording:start';
 const REMOTE_SESSION_RECORDING_STOP = 'remote-session-recording:stop';
-const PACKAGE_VERSION_EXPORT = "2.0.38" || 0;
+const PACKAGE_VERSION_EXPORT = "2.0.40" || 0;
 // Regex patterns for OpenTelemetry ignore URLs
 const OTEL_IGNORE_URLS = [
     // Traces endpoint
@@ -26907,6 +26907,7 @@ __webpack_require__.r(__webpack_exports__);
 
 class RecorderBrowserSDK {
     constructor() {
+        this.generation = 0;
         this.intervals = {
             restart: null,
             bufferSnapshot: null,
@@ -26942,12 +26943,15 @@ class RecorderBrowserSDK {
             throw new Error('Configuration not initialized. Call init() before start().');
         }
         this.startedAt = new Date().toISOString();
+        const gen = ++this.generation;
         this.stopFn = (0,rrweb__WEBPACK_IMPORTED_MODULE_6__.record)({
             ...this._buildRecordOptions(),
             emit: async (event) => {
+                if (gen !== this.generation)
+                    return;
                 const ts = event.timestamp;
                 if (!sessionId) {
-                    await this._handleBufferOnlyEvent(event, ts);
+                    await this._handleBufferOnlyEvent(event, ts, gen);
                     return;
                 }
                 this._handleLiveSessionEvent(event, ts, sessionId, sessionType);
@@ -26963,6 +26967,7 @@ class RecorderBrowserSDK {
         var _a;
         try {
             (_a = this.stopFn) === null || _a === void 0 ? void 0 : _a.call(this);
+            this.stopFn = undefined;
             this.start(sessionId, sessionType);
         }
         catch (_e) {
@@ -26976,6 +26981,7 @@ class RecorderBrowserSDK {
         var _a, _b, _c;
         (_a = this.stopFn) === null || _a === void 0 ? void 0 : _a.call(this);
         this.stopFn = undefined;
+        this.generation++;
         if (!((_b = this.config) === null || _b === void 0 ? void 0 : _b.useWebsocket)) {
             (_c = this.socketService) === null || _c === void 0 ? void 0 : _c.close();
         }
@@ -27015,13 +27021,15 @@ class RecorderBrowserSDK {
      * @param event - Event.
      * @param ts - Timestamp.
      */
-    async _handleBufferOnlyEvent(event, ts) {
+    async _handleBufferOnlyEvent(event, ts, gen) {
         if (!this.crashBuffer)
             return;
         try {
             this._applyConsoleMasking(event);
             const packedEvent = (0,_rrweb_packer__WEBPACK_IMPORTED_MODULE_0__.pack)(event);
             this.stoppedAt = new Date(ts).toISOString();
+            if (gen !== this.generation)
+                return;
             await this.crashBuffer.appendEvent({
                 ts,
                 isFullSnapshot: event.type === _rrweb_types__WEBPACK_IMPORTED_MODULE_1__.EventType.FullSnapshot,
@@ -28531,10 +28539,14 @@ class SessionRecorder extends lib0_observable__WEBPACK_IMPORTED_MODULE_16__.Obse
     }
     _startBufferOnlyRecording() {
         var _a, _b;
-        if (this.sessionId ||
-            !this._crashBuffer ||
-            !((_b = (_a = this._configs) === null || _a === void 0 ? void 0 : _a.buffering) === null || _b === void 0 ? void 0 : _b.enabled) ||
-            this.sessionState !== _types__WEBPACK_IMPORTED_MODULE_4__.SessionState.stopped) {
+        // NOTE: `this.sessionId` is intentionally NOT checked. `_stop()` runs
+        // before `_clearSession()` (the stopSession API call sits between them),
+        // so the clear().then() chain fires while sessionId is still set.
+        // Bailing on sessionId here meant rrweb never restarted after manual
+        // stop, leaving the buffer with no FullSnapshot and silently breaking
+        // exception-triggered flushBuffer. `_recorder.restart(null, ...)` passes
+        // null explicitly, so it's safe regardless of `this.sessionId`.
+        if (!this._crashBuffer || !((_b = (_a = this._configs) === null || _a === void 0 ? void 0 : _a.buffering) === null || _b === void 0 ? void 0 : _b.enabled) || this.sessionState !== _types__WEBPACK_IMPORTED_MODULE_4__.SessionState.stopped) {
             return;
         }
         void this._recorder.restart(null, _multiplayer_app_session_recorder_common__WEBPACK_IMPORTED_MODULE_0__.SessionType.MANUAL);
@@ -28604,9 +28616,10 @@ class SessionRecorder extends lib0_observable__WEBPACK_IMPORTED_MODULE_16__.Obse
     async stop(comment) {
         try {
             this._checkOperation('stop');
+            const sid = this.sessionId;
             this._stop();
             if (this.continuousRecording) {
-                await this._apiService.stopContinuousDebugSession(this.sessionId);
+                await this._apiService.stopContinuousDebugSession(sid);
                 this.sessionType = _multiplayer_app_session_recorder_common__WEBPACK_IMPORTED_MODULE_0__.SessionType.MANUAL;
             }
             else {
@@ -28614,10 +28627,9 @@ class SessionRecorder extends lib0_observable__WEBPACK_IMPORTED_MODULE_16__.Obse
                     sessionAttributes: { comment },
                     stoppedAt: this._recorder.stoppedAt,
                 };
-                const response = await this._apiService.stopSession(this.sessionId, request);
+                const response = await this._apiService.stopSession(sid, request);
                 _eventBus__WEBPACK_IMPORTED_MODULE_7__.recorderEventBus.emit(_config__WEBPACK_IMPORTED_MODULE_5__.SESSION_RESPONSE, response);
             }
-            this._clearSession();
         }
         catch (error) {
             this.error = error.message;
@@ -28653,15 +28665,15 @@ class SessionRecorder extends lib0_observable__WEBPACK_IMPORTED_MODULE_16__.Obse
     async cancel() {
         try {
             this._checkOperation('cancel');
+            const sid = this.sessionId;
             this._stop();
             if (this.continuousRecording) {
-                await this._apiService.stopContinuousDebugSession(this.sessionId);
+                await this._apiService.stopContinuousDebugSession(sid);
                 this.sessionType = _multiplayer_app_session_recorder_common__WEBPACK_IMPORTED_MODULE_0__.SessionType.MANUAL;
             }
             else {
-                await this._apiService.cancelSession(this.sessionId);
+                await this._apiService.cancelSession(sid);
             }
-            this._clearSession();
         }
         catch (error) {
             this.error = error.message;
@@ -28975,7 +28987,18 @@ class SessionRecorder extends lib0_observable__WEBPACK_IMPORTED_MODULE_16__.Obse
         this._tracer.stop();
         this._recorder.stop();
         this._navigationRecorder.stop();
-        this._startBufferOnlyRecording();
+        // Clear session identity synchronously. The buffer-restart chain and the
+        // error-span-appended listener both gate on `this.sessionId === null`;
+        // deferring this to `_clearSession()` (after the network stopSession
+        // call) left them seeing a stale id and silently no-oping. Callers that
+        // need the id for the stop/cancel API must capture it before _stop().
+        this.session = null;
+        this.sessionId = null;
+        // rrweb assigns new node IDs on each record() call, so the next buffer
+        // segment must not carry events from the previous generation. Await the
+        // clear so its IDB tx can't race past the fresh FullSnapshot.
+        const cleared = this._crashBuffer ? this._crashBuffer.clear() : Promise.resolve();
+        void cleared.catch(() => undefined).then(() => this._startBufferOnlyRecording());
     }
     /**
      * Pause the session tracing and recording