@multiplatform.one/frappe 8.2.2 → 8.4.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@multiplatform.one/frappe",
-  "version": "8.2.2",
+  "version": "8.4.0",
   "description": "frappe client for multiplatform.one ecosystem",
   "keywords": [
     "auth",
@@ -61,7 +61,7 @@
     "access": "public"
   },
   "dependencies": {
-    "@multiplatform.one/store": "^8.2.2",
+    "@multiplatform.one/store": "^8.4.0",
     "@tanstack/db": "0.11.3",
     "@tanstack/pacer": "0.21.1",
     "@tanstack/react-db": "0.5.3",
@@ -70,10 +70,10 @@
     "socket.io-client": "^4.8.4"
   },
   "devDependencies": {
-    "@multiplatform.one/config": "8.2.2",
-    "@multiplatform.one/platform": "8.2.2",
-    "@multiplatform.one/test-utils": "8.2.2",
-    "@multiplatform.one/theme": "8.2.2",
+    "@multiplatform.one/config": "8.4.0",
+    "@multiplatform.one/platform": "8.4.0",
+    "@multiplatform.one/test-utils": "8.4.0",
+    "@multiplatform.one/theme": "8.4.0",
     "@tamagui/build": "2.7.6",
     "@testing-library/jest-dom": "^7.0.1",
     "@testing-library/react": "^16.3.3",
@@ -86,7 +86,7 @@
     "vitest": "^4.1.12"
   },
   "peerDependencies": {
-    "@multiplatform.one/platform": "^8.2.2",
+    "@multiplatform.one/platform": "^8.4.0",
     "react": "^19.1.0"
   },
   "engines": {

package/src/collection.updateSettle.spec.ts

@@ -0,0 +1,100 @@
+import { afterEach, expect, it, vi } from "vitest";
+import { createFrappeCollection } from "./collection";
+import { SyncModule } from "./sync";
+
+vi.mock("@multiplatform.one/platform", () => ({
+  isNative: false,
+  isServer: true,
+  isWindowDefined: false,
+  onAppFocus: () => () => {},
+  onOnline: () => () => {},
+  onVisibilityChange: () => () => {},
+}));
+
+const instances: SyncModule[] = [];
+const cleanups: (() => unknown)[] = [];
+afterEach(async () => {
+  try {
+    for (const cleanup of cleanups.splice(0)) await cleanup();
+  } finally {
+    for (const sync of instances.splice(0)) await sync.dispose();
+  }
+});
+
+const row = (name: string, title: string) => ({
+  name,
+  title,
+  doctype: "Item",
+  modified: "2026-09-09T01:00:00Z",
+});
+
+function deferred() {
+  let resolve!: () => void;
+  const promise = new Promise<void>((done) => {
+    resolve = done;
+  });
+  return { promise, resolve };
+}
+
+async function mountedCollection() {
+  const ack = deferred();
+  const db = {
+    getDocList: vi.fn().mockResolvedValue([row("a", "old"), row("b", "other")]),
+    updateDoc: vi.fn().mockImplementation(() => ack.promise),
+    getDoc: vi.fn().mockResolvedValue({ ...row("a", "new"), modified: "2026-09-09T02:00:00Z" }),
+  };
+  const sync = new SyncModule(db as never, undefined);
+  instances.push(sync);
+  const collection = createFrappeCollection<ReturnType<typeof row>>("Item", { sync });
+  cleanups.push(() => collection.cleanup());
+  await collection.preload();
+  const seen: string[] = [];
+  const subscription = collection.subscribeChanges((changes) => {
+    for (const change of changes) {
+      if (change.key === "a" && change.type !== "delete") seen.push(change.value.title);
+    }
+  });
+  cleanups.push(() => subscription.unsubscribe());
+  return { ack, collection, db, seen, sync };
+}
+
+it("an edit never shows the previous synced value while its save is in flight or after it settles", async () => {
+  const { ack, collection, db, seen } = await mountedCollection();
+  expect(collection.get("a")?.title).toBe("old");
+
+  const tx = collection.update("a", (draft) => {
+    draft.title = "new";
+  });
+  expect(collection.get("a")?.title).toBe("new");
+
+  await vi.waitFor(() => expect(db.updateDoc).toHaveBeenCalledTimes(1));
+  expect(db.updateDoc.mock.calls[0][0]).toMatchObject({ name: "a", title: "new" });
+  expect(collection.get("a")?.title).toBe("new");
+
+  ack.resolve();
+  await tx.isPersisted.promise;
+  await new Promise((done) => setTimeout(done, 0));
+
+  expect(collection.get("a")?.title).toBe("new");
+  expect(collection.get("b")?.title).toBe("other");
+  expect(seen).toContain("new");
+  expect(seen.slice(seen.indexOf("new"))).not.toContain("old");
+});
+
+it("the synced row already carries the edit when the save resolves, so dropping the optimistic layer changes nothing", async () => {
+  const { ack, collection, sync } = await mountedCollection();
+
+  const tx = collection.update("a", (draft) => {
+    draft.title = "new";
+  });
+  await vi.waitFor(() => expect(sync.getDocFromCache("Item", "a")?.title).toBe("new"));
+
+  ack.resolve();
+  await tx.isPersisted.promise;
+
+  expect(sync.getDocFromCache("Item", "a")).toMatchObject({
+    title: "new",
+    modified: "2026-09-09T02:00:00Z",
+  });
+  expect(collection.state.get("a")?.title).toBe("new");
+});