@multiplatform.one/frappe-ui 8.2.2 → 8.4.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@multiplatform.one/frappe-ui",
-  "version": "8.2.2",
+  "version": "8.4.0",
   "description": "Pre-wired Tamagui components for Frappe doctypes with live data",
   "keywords": [
     "cross-platform",
@@ -91,16 +91,16 @@
     "access": "public"
   },
   "dependencies": {
-    "@multiplatform.one/components": "^8.2.2",
-    "@multiplatform.one/desktop": "^8.2.2",
-    "@multiplatform.one/forms": "^8.2.2",
-    "@multiplatform.one/frappe": "^8.2.2",
-    "@multiplatform.one/markdown": "^8.2.2",
-    "@multiplatform.one/platform": "^8.2.2",
-    "@multiplatform.one/rich-text": "^8.2.2",
-    "@multiplatform.one/store": "^8.2.2",
-    "@multiplatform.one/table": "^8.2.2",
-    "@multiplatform.one/theme": "^8.2.2",
+    "@multiplatform.one/components": "^8.4.0",
+    "@multiplatform.one/desktop": "^8.4.0",
+    "@multiplatform.one/forms": "^8.4.0",
+    "@multiplatform.one/frappe": "^8.4.0",
+    "@multiplatform.one/markdown": "^8.4.0",
+    "@multiplatform.one/platform": "^8.4.0",
+    "@multiplatform.one/rich-text": "^8.4.0",
+    "@multiplatform.one/store": "^8.4.0",
+    "@multiplatform.one/table": "^8.4.0",
+    "@multiplatform.one/theme": "^8.4.0",
     "@phosphor-icons/react": "^2.1.10",
     "@tamagui/colors": "2.7.6",
     "@tanstack/db": "0.11.3",
@@ -117,9 +117,9 @@
     "tamagui": "2.7.6"
   },
   "devDependencies": {
-    "@multiplatform.one/config": "8.2.2",
-    "@multiplatform.one/storybook": "8.2.2",
-    "@multiplatform.one/test-utils": "8.2.2",
+    "@multiplatform.one/config": "8.4.0",
+    "@multiplatform.one/storybook": "8.4.0",
+    "@multiplatform.one/test-utils": "8.4.0",
     "@tamagui/build": "2.7.6",
     "@testing-library/jest-dom": "^7.0.1",
     "@testing-library/react": "^16.3.3",

package/src/FrappeKPICard.spec.tsx

@@ -151,3 +151,28 @@ describe("FrappeKPICard configured paths stay untouched (MPO-237)", () => {
     ).toHaveLength(0);
   });
 });
+
+describe("FrappeKPICard with no aggregate result (LC-220, FZ-8409)", () => {
+  it("draws avg over an empty set as no reading, and a count of none as 0", async () => {
+    const fixtures = new InMemoryFixtureProvider({ ToDo: [] });
+    const { container } = renderWithProviders(
+      <FrappeProvider fixtures={fixtures}>
+        <FrappeKPICard
+          config={{ id: "avg", title: "Average priority", value: 999 }}
+          dataSource={{ doctype: "ToDo", aggregate: "avg", field: "priority" }}
+        />
+        <FrappeKPICard
+          config={{ id: "count", title: "Open ToDos", value: 999 }}
+          dataSource={{ doctype: "ToDo" }}
+        />
+      </FrappeProvider>,
+    );
+
+    await waitFor(() => expect(container.querySelectorAll("[data-kpi-value]")).toHaveLength(2));
+    const [avg, count] = Array.from(container.querySelectorAll("[data-kpi-value]"));
+    expect(avg.getAttribute("data-kpi-reading")).toBe("none");
+    expect(screen.getByLabelText("Average priority: No reading")).toBeTruthy();
+    expect(count.getAttribute("data-kpi-reading")).toBe("measured");
+    expect(count.textContent).toBe("0");
+  });
+});

package/src/FrappeKPICard.tsx

@@ -131,7 +131,7 @@ export function FrappeKPICard({
 
   const liveConfig = useMemo<KPICardConfig>(() => {
     if (!dataSource) return config;
-    return { ...config, value: value ?? "—" };
+    return { ...config, value: value ?? null };
   }, [config, dataSource, value]);
 
   // Static passthrough. The caller supplied the figure and asked for no

package/src/FrappeListView.permissionDenied.spec.tsx

@@ -25,9 +25,7 @@ afterEach(() => {
 describe("FrappeListView Cards / Permission Denied", () => {
   it("shows the permission error, not the empty roster", async () => {
     renderWithProviders(<PermissionDenied />);
-    await waitFor(() =>
-      expect(screen.getByText("Pokemon isn't open to this account")).toBeTruthy(),
-    );
+    await waitFor(() => expect(screen.getByText("No access to Pokemon")).toBeTruthy());
     expect(screen.queryByText("No Pokemon records found")).toBeNull();
   });
 });

package/src/FrappeListView.sidebar.spec.tsx

@@ -127,7 +127,7 @@ describe("FrappeListView sidebar filters", () => {
     expect(screen.getAllByTestId("list-page-sidebar")).toHaveLength(1);
     expect(within(aside).getByRole("radiogroup", { name: "Type" })).toBeTruthy();
     expect(within(aside).getByRole("radiogroup", { name: "Generation" })).toBeTruthy();
-    expect(aside.querySelector("[data-range-slider]")).not.toBeNull();
+    await waitFor(() => expect(aside.querySelector("[data-range-slider]")).not.toBeNull());
     expect(within(aside).getByTestId("pokemon-sidebar-favorites-filter")).toBeTruthy();
   });
 
@@ -192,7 +192,7 @@ describe("FrappeListView phone filters", () => {
     const sheet = await screen.findByTestId("pokemon-filters-sheet");
     expect(within(sheet).getByRole("radiogroup", { name: "Type" })).toBeTruthy();
     expect(within(sheet).getByRole("radiogroup", { name: "Generation" })).toBeTruthy();
-    expect(sheet.querySelector("[data-range-slider]")).not.toBeNull();
+    await waitFor(() => expect(sheet.querySelector("[data-range-slider]")).not.toBeNull());
     expect(within(sheet).getByTestId("pokemon-sheet-favorites-filter")).toBeTruthy();
     expect(within(sheet).getByRole("group", { name: "Sort by" })).toBeTruthy();
   });

package/src/frappeRefusals.spec.tsx

@@ -82,7 +82,7 @@ function expectRefusal(container: HTMLElement, subject: string) {
   const node = container.querySelector('[data-async-state="refused"]');
   expect(node).not.toBeNull();
   expect(container.querySelector('[data-empty-intent="neutral"]')).not.toBeNull();
-  expect(screen.getByText(`${subject} isn't open to this account`)).toBeTruthy();
+  expect(screen.getByText(`No access to ${subject}`)).toBeTruthy();
   expect(screen.queryByText(/Retry/)).toBeNull();
   expect(container.textContent).not.toMatch(/Not permitted|do not have permission/);
 }
@@ -123,7 +123,7 @@ describe("frappe-ui refusals render LC-165's neutral state (FZ-9227)", () => {
     state.error = unreachable();
     const { container } = table();
     expect(screen.getByText("Customer didn't load")).toBeTruthy();
-    expect(screen.getByText(/Can't reach the server\. Tap Retry to try again\./)).toBeTruthy();
+    expect(screen.getByText("Can't reach the server.")).toBeTruthy();
     expect(screen.getByText("Retry")).toBeTruthy();
     expect(container.textContent).not.toMatch(/TypeError|Failed to fetch/);
     fireEvent.click(screen.getByText("Retry"));

package/src/useFrappeRows.lateMount.spec.tsx

@@ -54,7 +54,7 @@ function Roster() {
 describe("useFrappeRows on a read that already failed", () => {
   it("a reader mounted after the failure still shows the permission error", async () => {
     const fixtures = deniedCorpus();
-    const denied = "Customer isn't open to this account";
+    const denied = "No access to Customer";
     const view = renderWithProviders(
       <FrappeProvider fixtures={fixtures}>
         <Roster />

package/src/useFrappeRows.sharedPath.spec.tsx

@@ -200,7 +200,7 @@ describe("FrappeList error plumbing through the shared read", () => {
         />
       </FrappeProvider>,
     );
-    expect(await screen.findByText("Customer isn't open to this account")).toBeTruthy();
+    expect(await screen.findByText("No access to Customer")).toBeTruthy();
     expect(screen.queryByRole("button", { name: /retry/i })).toBeNull();
     expect(screen.queryByText("No Customer records found")).toBeNull();
   });