@multiplatform.one/frappe-ui 7.84.6 → 7.84.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@multiplatform.one/frappe-ui",
-  "version": "7.84.6",
+  "version": "7.84.8",
   "description": "Pre-wired Tamagui components for Frappe doctypes with live data",
   "keywords": [
     "cross-platform",
@@ -72,18 +72,18 @@
     "access": "public"
   },
   "dependencies": {
-    "@multiplatform.one/components": "^7.84.6",
-    "@multiplatform.one/desktop": "^7.84.6",
-    "@multiplatform.one/forms": "^7.84.6",
-    "@multiplatform.one/frappe": "^7.84.6",
-    "@multiplatform.one/i18n": "^7.84.6",
-    "@multiplatform.one/markdown": "^7.84.6",
-    "@multiplatform.one/platform": "^7.84.6",
-    "@multiplatform.one/rich-text": "^7.84.6",
-    "@multiplatform.one/router": "^7.84.6",
-    "@multiplatform.one/store": "^7.84.6",
-    "@multiplatform.one/table": "^7.84.6",
-    "@multiplatform.one/theme": "^7.84.6",
+    "@multiplatform.one/components": "^7.84.8",
+    "@multiplatform.one/desktop": "^7.84.8",
+    "@multiplatform.one/forms": "^7.84.8",
+    "@multiplatform.one/frappe": "^7.84.8",
+    "@multiplatform.one/i18n": "^7.84.8",
+    "@multiplatform.one/markdown": "^7.84.8",
+    "@multiplatform.one/platform": "^7.84.8",
+    "@multiplatform.one/rich-text": "^7.84.8",
+    "@multiplatform.one/router": "^7.84.8",
+    "@multiplatform.one/store": "^7.84.8",
+    "@multiplatform.one/table": "^7.84.8",
+    "@multiplatform.one/theme": "^7.84.8",
     "@phosphor-icons/react": "^2.1.10",
     "@tamagui/colors": "2.7.6",
     "@tanstack/db": "0.8.0",
@@ -100,9 +100,9 @@
     "tamagui": "2.7.6"
   },
   "devDependencies": {
-    "@multiplatform.one/config": "7.84.6",
-    "@multiplatform.one/storybook": "7.84.6",
-    "@multiplatform.one/test-utils": "7.84.6",
+    "@multiplatform.one/config": "7.84.8",
+    "@multiplatform.one/storybook": "7.84.8",
+    "@multiplatform.one/test-utils": "7.84.8",
     "@tamagui/build": "2.7.6",
     "@testing-library/jest-dom": "^7.0.1",
     "@testing-library/react": "^16.3.3",

package/src/FrappeListView.permissionDenied.spec.tsx

@@ -0,0 +1,33 @@
+// The card grid's Permission Denied story, rendered as Storybook renders it:
+// a denied read must reach FrappeList's error panel, never the empty roster
+// (LC-84, FZ-9195).
+import { renderWithProviders } from "@multiplatform.one/test-utils";
+import { cleanup, screen, waitFor } from "@testing-library/react";
+import i18next from "i18next";
+import { initReactI18next } from "react-i18next";
+import { afterEach, beforeAll, describe, expect, it, vi } from "vitest";
+import { PermissionDenied } from "./FrappeListView.cards.stories";
+
+vi.mock("@multiplatform.one/storybook", () => ({ action: () => () => undefined }));
+
+beforeAll(async () => {
+  await i18next.use(initReactI18next).init({
+    lng: "en",
+    interpolation: { escapeValue: false },
+    resources: { en: { translation: {} } },
+  });
+});
+
+afterEach(() => {
+  cleanup();
+});
+
+describe("FrappeListView Cards / Permission Denied", () => {
+  it("shows the permission error, not the empty roster", async () => {
+    renderWithProviders(<PermissionDenied />);
+    await waitFor(() =>
+      expect(screen.getByText("You do not have permission to view Pokemon")).toBeTruthy(),
+    );
+    expect(screen.queryByText("No Pokemon records found")).toBeNull();
+  });
+});

package/src/useFrappeRows.lateMount.spec.tsx

@@ -0,0 +1,74 @@
+// A reader that mounts onto a read whose first sync already failed must
+// still report that failure. The shared collection replays the held error
+// when the late reader retains it, and the reader must not wipe it in the
+// same commit (FZ-9195, LC-84).
+import { InMemoryFixtureProvider } from "@multiplatform.one/frappe";
+import { renderWithProviders } from "@multiplatform.one/test-utils";
+import { cleanup, screen, waitFor } from "@testing-library/react";
+import i18next from "i18next";
+import { initReactI18next } from "react-i18next";
+import { Text } from "tamagui";
+import { afterEach, beforeAll, describe, expect, it, vi } from "vitest";
+import { FrappeList } from "./FrappeList";
+import { FrappeProvider } from "./FrappeProvider";
+
+interface Customer {
+  name: string;
+  doctype: string;
+  customer_name: string;
+}
+
+beforeAll(async () => {
+  await i18next.use(initReactI18next).init({
+    lng: "en",
+    interpolation: { escapeValue: false },
+    resources: { en: { translation: {} } },
+  });
+});
+
+afterEach(() => {
+  cleanup();
+  vi.restoreAllMocks();
+});
+
+function deniedCorpus() {
+  const fixtures = new InMemoryFixtureProvider({
+    Customer: [{ name: "CUST-001", doctype: "Customer", customer_name: "Acme Corp" }],
+  });
+  vi.spyOn(fixtures, "getList").mockRejectedValue(
+    Object.assign(new Error("PermissionError"), { status: 403 }),
+  );
+  return fixtures;
+}
+
+function Roster() {
+  return (
+    <FrappeList<Customer>
+      doctype="Customer"
+      fields={["name", "customer_name"]}
+      renderItem={(item) => <Text>{item.customer_name}</Text>}
+    />
+  );
+}
+
+describe("useFrappeRows on a read that already failed", () => {
+  it("a reader mounted after the failure still shows the permission error", async () => {
+    const fixtures = deniedCorpus();
+    const denied = "You do not have permission to view Customer";
+    const view = renderWithProviders(
+      <FrappeProvider fixtures={fixtures}>
+        <Roster />
+      </FrappeProvider>,
+    );
+    await waitFor(() => expect(screen.getAllByText(denied)).toHaveLength(1));
+
+    view.rerender(
+      <FrappeProvider fixtures={fixtures}>
+        <Roster />
+        <Roster />
+      </FrappeProvider>,
+    );
+    await waitFor(() => expect(screen.getAllByText(denied)).toHaveLength(2));
+    expect(screen.queryByText("No Customer records found")).toBeNull();
+  });
+});

package/src/useFrappeRows.ts

@@ -64,7 +64,7 @@ import {
   type Order,
   type FixtureProvider,
 } from "@multiplatform.one/frappe";
-import { useCallback, useEffect, useMemo, useRef, useState } from "react";
+import { useCallback, useMemo, useRef, useState } from "react";
 import { useFrappeConfig } from "./FrappeProvider";
 import { toLiveLoadError } from "./liveErrors";
 
@@ -231,10 +231,14 @@ export function useFrappeRows<TDoc extends { name: string; doctype: string }>(
     collectionOptions as any,
   );
 
-  // A new collection (doctype / filter / field change) starts clean.
-  useEffect(() => {
+  // A new collection (doctype / filter / field change) starts clean. The
+  // reset runs during render: as an effect it ran after the collection's
+  // retain effect, wiping the held error that retain had just replayed.
+  const [errorCollection, setErrorCollection] = useState(collection);
+  if (errorCollection !== collection) {
+    setErrorCollection(collection);
     setSyncError(null);
-  }, [collection]);
+  }
 
   const {
     data: rawData,

package/types/useFrappeRows.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"useFrappeRows.d.ts","sourceRoot":"","sources":["../src/useFrappeRows.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA0DG;AAEH,OAAO,EACL,mBAAmB,EAEnB,KAAK,KAAK,EACV,KAAK,eAAe,EACrB,MAAM,2BAA2B,CAAC;AAKnC;;;;;;GAMG;AACH,eAAO,MAAM,yBAAyB,MAAM,CAAC;AAE7C;;;;;GAKG;AACH,MAAM,WAAW,oBAAoB;IACnC,oEAAoE;IACpE,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,oEAAoE;IACpE,aAAa,CAAC,EAAE,MAAM,CAAC;IACvB,2DAA2D;IAC3D,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,IAAI,CAAC,EAAE;QACL,QAAQ,CAAC,EAAE,OAAO,CAAC;QACnB,KAAK,CAAC,EAAE,MAAM,GAAG,CAAC,MAAM,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC;QAClD,IAAI,CAAC,EAAE,MAAM,CAAC;KACf,CAAC;IACF,WAAW,CAAC,EAAE,GAAG,CAAC;IAClB,QAAQ,CAAC,EAAE,eAAe,CAAC;CAC5B;AAED,kFAAkF;AAClF,MAAM,WAAW,kBAAkB;IACjC,+EAA+E;IAC/E,UAAU,EAAE,MAAM,CAAC;IACnB,0DAA0D;IAC1D,OAAO,EAAE,MAAM,CAAC;IAChB;;;OAGG;IACH,WAAW,CAAC,EAAE,MAAM,CAAC;CACtB;AAED,MAAM,WAAW,oBAAoB,CAAC,IAAI;IACxC,+EAA+E;IAC/E,MAAM,CAAC,EAAE,SAAS,CAAC,MAAM,IAAI,GAAG,MAAM,CAAC,EAAE,CAAC;IAC1C,OAAO,CAAC,EAAE,OAAO,CAAC,IAAI,CAAC,GAAG,KAAK,CAAC,CAAC,MAAM,IAAI,GAAG,MAAM,EAAE,MAAM,EAAE,GAAG,CAAC,CAAC,CAAC;IACpE,OAAO,CAAC,EAAE,KAAK,CAAC;QAAE,KAAK,EAAE,MAAM,IAAI,GAAG,MAAM,CAAC;QAAC,KAAK,EAAE,KAAK,CAAA;KAAE,CAAC,CAAC;IAC9D;;;;;OAKG;IACH,KAAK,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IACtB,iEAAiE;IACjE,OAAO,CAAC,EAAE,OAAO,CAAC;IAClB,2EAA2E;IAC3E,QAAQ,CAAC,EAAE,kBAAkB,CAAC;IAC9B;;;;;OAKG;IACH,QAAQ,CAAC,EAAE,CAAC,GAAG,EAAE,OAAO,KAAK,KAAK,CAAC;CACpC;AAED,MAAM,WAAW,mBAAmB,CAAC,IAAI;IACvC,mEAAmE;IACnE,IAAI,EAAE,IAAI,EAAE,CAAC;IACb;;;;OAIG;IACH,SAAS,EAAE,KAAK,GAAG,IAAI,CAAC;IACxB,kDAAkD;IAClD,SAAS,EAAE,OAAO,CAAC;IACnB;;;;OAIG;IACH,cAAc,EAAE,OAAO,CAAC;IACxB,gEAAgE;IAChE,OAAO,EAAE,OAAO,CAAC;IACjB,sEAAsE;IACtE,KAAK,EAAE,KAAK,GAAG,IAAI,CAAC;IACpB;;;;OAIG;IACH,UAAU,EAAE,UAAU,CAAC,OAAO,mBAAmB,CAAC,GAAG,CAAC,CAAC,CAAC;CACzD;AAOD;;;;;;;;GAQG;AACH,wBAAgB,aAAa,CAAC,IAAI,SAAS;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,MAAM,CAAA;CAAE,EAC1E,UAAU,EAAE,oBAAoB,GAAG,SAAS,EAC5C,OAAO,EAAE,MAAM,EACf,OAAO,GAAE,oBAAoB,CAAC,IAAI,CAAM,GACvC,mBAAmB,CAAC,IAAI,CAAC,CAyE3B;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,mBAAmB,CAAC,SAAS,CAAC,EAAE;IAC9C,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,WAAW,CAAC,oBAAoB,CAAC,MAAM,CAAC,CAAC,CAAC;IACjD,WAAW,CAAC,EAAE,GAAG,CAAC;CACnB,GAAG,oBAAoB,GAAG,SAAS,CAgBnC"}
+{"version":3,"file":"useFrappeRows.d.ts","sourceRoot":"","sources":["../src/useFrappeRows.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA0DG;AAEH,OAAO,EACL,mBAAmB,EAEnB,KAAK,KAAK,EACV,KAAK,eAAe,EACrB,MAAM,2BAA2B,CAAC;AAKnC;;;;;;GAMG;AACH,eAAO,MAAM,yBAAyB,MAAM,CAAC;AAE7C;;;;;GAKG;AACH,MAAM,WAAW,oBAAoB;IACnC,oEAAoE;IACpE,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,oEAAoE;IACpE,aAAa,CAAC,EAAE,MAAM,CAAC;IACvB,2DAA2D;IAC3D,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,IAAI,CAAC,EAAE;QACL,QAAQ,CAAC,EAAE,OAAO,CAAC;QACnB,KAAK,CAAC,EAAE,MAAM,GAAG,CAAC,MAAM,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC;QAClD,IAAI,CAAC,EAAE,MAAM,CAAC;KACf,CAAC;IACF,WAAW,CAAC,EAAE,GAAG,CAAC;IAClB,QAAQ,CAAC,EAAE,eAAe,CAAC;CAC5B;AAED,kFAAkF;AAClF,MAAM,WAAW,kBAAkB;IACjC,+EAA+E;IAC/E,UAAU,EAAE,MAAM,CAAC;IACnB,0DAA0D;IAC1D,OAAO,EAAE,MAAM,CAAC;IAChB;;;OAGG;IACH,WAAW,CAAC,EAAE,MAAM,CAAC;CACtB;AAED,MAAM,WAAW,oBAAoB,CAAC,IAAI;IACxC,+EAA+E;IAC/E,MAAM,CAAC,EAAE,SAAS,CAAC,MAAM,IAAI,GAAG,MAAM,CAAC,EAAE,CAAC;IAC1C,OAAO,CAAC,EAAE,OAAO,CAAC,IAAI,CAAC,GAAG,KAAK,CAAC,CAAC,MAAM,IAAI,GAAG,MAAM,EAAE,MAAM,EAAE,GAAG,CAAC,CAAC,CAAC;IACpE,OAAO,CAAC,EAAE,KAAK,CAAC;QAAE,KAAK,EAAE,MAAM,IAAI,GAAG,MAAM,CAAC;QAAC,KAAK,EAAE,KAAK,CAAA;KAAE,CAAC,CAAC;IAC9D;;;;;OAKG;IACH,KAAK,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IACtB,iEAAiE;IACjE,OAAO,CAAC,EAAE,OAAO,CAAC;IAClB,2EAA2E;IAC3E,QAAQ,CAAC,EAAE,kBAAkB,CAAC;IAC9B;;;;;OAKG;IACH,QAAQ,CAAC,EAAE,CAAC,GAAG,EAAE,OAAO,KAAK,KAAK,CAAC;CACpC;AAED,MAAM,WAAW,mBAAmB,CAAC,IAAI;IACvC,mEAAmE;IACnE,IAAI,EAAE,IAAI,EAAE,CAAC;IACb;;;;OAIG;IACH,SAAS,EAAE,KAAK,GAAG,IAAI,CAAC;IACxB,kDAAkD;IAClD,SAAS,EAAE,OAAO,CAAC;IACnB;;;;OAIG;IACH,cAAc,EAAE,OAAO,CAAC;IACxB,gEAAgE;IAChE,OAAO,EAAE,OAAO,CAAC;IACjB,sEAAsE;IACtE,KAAK,EAAE,KAAK,GAAG,IAAI,CAAC;IACpB;;;;OAIG;IACH,UAAU,EAAE,UAAU,CAAC,OAAO,mBAAmB,CAAC,GAAG,CAAC,CAAC,CAAC;CACzD;AAOD;;;;;;;;GAQG;AACH,wBAAgB,aAAa,CAAC,IAAI,SAAS;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,MAAM,CAAA;CAAE,EAC1E,UAAU,EAAE,oBAAoB,GAAG,SAAS,EAC5C,OAAO,EAAE,MAAM,EACf,OAAO,GAAE,oBAAoB,CAAC,IAAI,CAAM,GACvC,mBAAmB,CAAC,IAAI,CAAC,CA6E3B;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,mBAAmB,CAAC,SAAS,CAAC,EAAE;IAC9C,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,WAAW,CAAC,oBAAoB,CAAC,MAAM,CAAC,CAAC,CAAC;IACjD,WAAW,CAAC,EAAE,GAAG,CAAC;CACnB,GAAG,oBAAoB,GAAG,SAAS,CAgBnC"}