@multiplatform.one/frappe-ui 7.83.2 → 7.84.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@multiplatform.one/frappe-ui",
-  "version": "7.83.2",
+  "version": "7.84.0",
   "description": "Pre-wired Tamagui components for Frappe doctypes with live data",
   "keywords": [
     "cross-platform",
@@ -72,18 +72,18 @@
     "access": "public"
   },
   "dependencies": {
-    "@multiplatform.one/components": "^7.83.2",
-    "@multiplatform.one/desktop": "^7.83.2",
-    "@multiplatform.one/forms": "^7.83.2",
-    "@multiplatform.one/frappe": "^7.83.2",
-    "@multiplatform.one/i18n": "^7.83.2",
-    "@multiplatform.one/markdown": "^7.83.2",
-    "@multiplatform.one/platform": "^7.83.2",
-    "@multiplatform.one/rich-text": "^7.83.2",
-    "@multiplatform.one/router": "^7.83.2",
-    "@multiplatform.one/store": "^7.83.2",
-    "@multiplatform.one/table": "^7.83.2",
-    "@multiplatform.one/theme": "^7.83.2",
+    "@multiplatform.one/components": "^7.84.0",
+    "@multiplatform.one/desktop": "^7.84.0",
+    "@multiplatform.one/forms": "^7.84.0",
+    "@multiplatform.one/frappe": "^7.84.0",
+    "@multiplatform.one/i18n": "^7.84.0",
+    "@multiplatform.one/markdown": "^7.84.0",
+    "@multiplatform.one/platform": "^7.84.0",
+    "@multiplatform.one/rich-text": "^7.84.0",
+    "@multiplatform.one/router": "^7.84.0",
+    "@multiplatform.one/store": "^7.84.0",
+    "@multiplatform.one/table": "^7.84.0",
+    "@multiplatform.one/theme": "^7.84.0",
     "@phosphor-icons/react": "^2.1.10",
     "@tamagui/colors": "2.7.6",
     "@tanstack/db": "0.8.0",
@@ -100,9 +100,9 @@
     "tamagui": "2.7.6"
   },
   "devDependencies": {
-    "@multiplatform.one/config": "7.83.2",
-    "@multiplatform.one/storybook": "7.83.2",
-    "@multiplatform.one/test-utils": "7.83.2",
+    "@multiplatform.one/config": "7.84.0",
+    "@multiplatform.one/storybook": "7.84.0",
+    "@multiplatform.one/test-utils": "7.84.0",
     "@tamagui/build": "2.7.6",
     "@testing-library/jest-dom": "^7.0.1",
     "@testing-library/react": "^16.3.3",

package/src/FrappeReportBuilder.tsx

@@ -339,10 +339,10 @@ function FrappeReportBuilderBody({
   const compact = useLayoutSizeClass() === "compact";
   const defaultFieldnames = useMemo(
     () =>
-      readsWithoutMeta && layoutMeta
-        ? ["name", ...layoutMeta.fields.map((field) => field.fieldname)]
-        : compact
-          ? phoneReportFieldnames(layoutMeta)
+      compact
+        ? phoneReportFieldnames(layoutMeta)
+        : readsWithoutMeta && layoutMeta
+          ? ["name", ...layoutMeta.fields.map((field) => field.fieldname)]
           : defaultReportFieldnames(layoutMeta),
     [layoutMeta, readsWithoutMeta, compact],
   );

package/src/guestFallback.spec.tsx

@@ -38,6 +38,7 @@ const tackle = {
   move_name: "tackle",
   power: 40,
   accuracy: 0.95,
+  pp: 35,
 };
 
 const settle = { timeout: 8000 };
@@ -203,6 +204,20 @@ describe("LC-96 guest fallback: report views", () => {
     expect(screen.queryByRole("button", { name: /save as/i })).toBeNull();
   });
 
+  it("a doctype report on a phone opens on the phone's fitted columns (FZ-7684)", async () => {
+    const width = window.innerWidth;
+    window.innerWidth = 390;
+    try {
+      renderReport("builder");
+      await waitFor(() => expect(screen.getAllByText("a1b2c3").length).toBeGreaterThan(0), settle);
+      expect(screen.getAllByText("40").length).toBeGreaterThan(0);
+      expect(screen.getAllByText("35").length).toBeGreaterThan(0);
+      expect(screen.queryAllByText("tackle")).toHaveLength(0);
+    } finally {
+      window.innerWidth = width;
+    }
+  });
+
   it("a doctype report whose rows are refused too says the reader can't open it, with no retry", async () => {
     recordsReadable = false;
     renderReport("builder");

package/src/record/RecordPage.tsx

@@ -4,6 +4,7 @@ import {
   H1,
   PageBackButton,
   PageSection,
+  PushedPage,
   Quote,
   Screen,
   ScreenToolbar,
@@ -324,71 +325,75 @@ export function RecordPage<TDoc extends { name: string; doctype: string }>({
     </>
   );
 
+  // LC-270 hero: a pushed page whose name heads the identity block; the bar
+  // takes that name only once it scrolls away (LC-157).
   return (
-    <Screen
-      noPadding
-      gap={0}
-      maxWidth={DETAIL_READABLE_WIDTH}
-      topBar={
-        <RecordTopBar
-          listName={listName}
-          onBack={() => navigate(route)}
-          slug={slug}
-          trailing={trailing}
-        />
-      }
-    >
-      <RecordHeroFrame tint={tint} testID={`${slug}-detail-stage`}>
-        <YStack testID={`${slug}-hero-art`}>
-          <RecordGallery images={images} slides={slides} alt={title} />
-        </YStack>
-      </RecordHeroFrame>
+    <PushedPage hero>
+      <Screen
+        noPadding
+        gap={0}
+        maxWidth={DETAIL_READABLE_WIDTH}
+        topBar={
+          <RecordTopBar
+            listName={listName}
+            onBack={() => navigate(route)}
+            slug={slug}
+            trailing={trailing}
+          />
+        }
+      >
+        <RecordHeroFrame tint={tint} testID={`${slug}-detail-stage`}>
+          <YStack testID={`${slug}-hero-art`}>
+            <RecordGallery images={images} slides={slides} alt={title} />
+          </YStack>
+        </RecordHeroFrame>
 
-      <RecordHeroIdentityColumn testID={`${slug}-hero-identity`}>
-        <XStack gap="$2" alignItems="center" flexWrap="wrap">
-          {code ? (
-            <Text
-              {...nested.label}
-              fontWeight="700"
-              color={(tint ? `$${tint}11` : "$color11") as never}
-            >
-              {code}
+        <RecordHeroIdentityColumn testID={`${slug}-hero-identity`}>
+          <XStack gap="$2" alignItems="center" flexWrap="wrap">
+            {code ? (
+              <Text
+                {...nested.label}
+                fontWeight="700"
+                color={(tint ? `$${tint}11` : "$color11") as never}
+              >
+                {code}
+              </Text>
+            ) : null}
+            {values.map((value) => (
+              <FacetBadge
+                key={value}
+                label={facet?.optionLabel?.(value) ?? value}
+                tint={facet?.tint?.(value)}
+              />
+            ))}
+          </XStack>
+          <RecordLargeTitle title={title} />
+          {look?.subtitle?.(doc) ? (
+            <Text {...nested.body} color="$textMuted">
+              {look.subtitle(doc)}
             </Text>
           ) : null}
-          {values.map((value) => (
-            <FacetBadge
-              key={value}
-              label={facet?.optionLabel?.(value) ?? value}
-              tint={facet?.tint?.(value)}
-            />
-          ))}
-        </XStack>
-        <RecordLargeTitle title={title} />
-        {look?.subtitle?.(doc) ? (
-          <Text {...nested.body} color="$textMuted">
-            {look.subtitle(doc)}
-          </Text>
-        ) : null}
-        <RecordVitals
-          tiles={metrics.map((metric) => {
-            const value = metricValue(doc, metric.field);
-            return {
-              id: metric.field,
-              label: metric.label,
-              value: metric.format ? metric.format(value) : String(value),
-            };
-          })}
-        />
-      </RecordHeroIdentityColumn>
+          <RecordVitals
+            tiles={metrics.map((metric) => {
+              const value = metricValue(doc, metric.field);
+              return {
+                id: metric.field,
+                label: metric.label,
+                value: metric.format ? metric.format(value) : String(value),
+              };
+            })}
+          />
+        </RecordHeroIdentityColumn>
 
-      <YStack {...knobProps.gapLg} paddingTop={knobProps.panelPadding.padding} paddingBottom="$6">
-        {tabItems.length > 0 ? (
-          <Tabs defaultValue={tabItems[0]?.value} lazyMount items={tabItems} />
-        ) : null}
-        <YStack {...knobProps.panelPadding} paddingVertical={0}>
-          <RecordPager prev={pagerEntry(prev)} next={pagerEntry(next)} testID={slug} />
+        <YStack {...knobProps.gapLg} paddingTop={knobProps.panelPadding.padding} paddingBottom="$6">
+          {tabItems.length > 0 ? (
+            <Tabs defaultValue={tabItems[0]?.value} lazyMount items={tabItems} />
+          ) : null}
+          <YStack {...knobProps.panelPadding} paddingVertical={0}>
+            <RecordPager prev={pagerEntry(prev)} next={pagerEntry(next)} testID={slug} />
+          </YStack>
         </YStack>
-      </YStack>
-    </Screen>
+      </Screen>
+    </PushedPage>
   );
 }

package/types/record/RecordPage.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"RecordPage.d.ts","sourceRoot":"","sources":["../../src/record/RecordPage.tsx"],"names":[],"mappings":"AAuBA,OAAO,KAAK,EAAE,aAAa,EAAE,SAAS,EAAE,MAAM,OAAO,CAAC;AAGtD,OAAO,EAAe,KAAK,oBAAoB,EAAE,MAAM,4BAA4B,CAAC;AAGpF,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,mBAAmB,CAAC;AACzD,OAAO,EAAe,KAAK,gBAAgB,EAAE,MAAM,oBAAoB,CAAC;AAOxE,OAAO,KAAK,EAAuB,eAAe,EAAE,MAAM,kBAAkB,CAAC;AAE7E;;;;;GAKG;AACH,wBAAgB,gBAAgB,CAAC,EAAE,KAAK,EAAE,EAAE;IAAE,KAAK,EAAE,MAAM,CAAA;CAAE,2CAQ5D;AAED,yEAAyE;AACzE,MAAM,WAAW,kBAAkB,CAAC,IAAI;IACtC,KAAK,EAAE,MAAM,CAAC;IACd,IAAI,EAAE,aAAa,CAAC;QAAE,IAAI,CAAC,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IACvC,IAAI,EAAE,CAAC,GAAG,EAAE,OAAO,CAAC,IAAI,CAAC,KAAK,MAAM,CAAC;IACrC,MAAM,CAAC,EAAE,MAAM,CAAC;CACjB;AAED,KAAK,GAAG,GAAG,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;AAEnC,MAAM,WAAW,eAAe,CAAC,IAAI,SAAS;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,MAAM,CAAA;CAAE;IAC7E,GAAG,EAAE,OAAO,CAAC,IAAI,CAAC,CAAC;IACnB,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,EAAE,CAAC,CAAC;IAC9B,OAAO,EAAE,MAAM,CAAC;IAChB,KAAK,EAAE,MAAM,CAAC;IACd,QAAQ,EAAE,MAAM,CAAC;IACjB,QAAQ,EAAE,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;IAC1B,IAAI,CAAC,EAAE,gBAAgB,CAAC,IAAI,CAAC,CAAC;IAC9B,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,KAAK,CAAC,EAAE,eAAe,CAAC;IACxB,OAAO,EAAE,SAAS,oBAAoB,EAAE,CAAC;IACzC,OAAO,CAAC,EAAE,CAAC,GAAG,EAAE,OAAO,CAAC,IAAI,CAAC,KAAK;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,IAAI,CAAC,EAAE,MAAM,CAAA;KAAE,GAAG,SAAS,CAAC;IAC9E,IAAI,EAAE,SAAS,eAAe,EAAE,CAAC;IACjC,SAAS,CAAC,EAAE,OAAO,GAAG,MAAM,CAAC;IAC7B,OAAO,EAAE,SAAS,kBAAkB,CAAC,IAAI,CAAC,EAAE,CAAC;IAC7C,OAAO,EAAE,OAAO,CAAC;IACjB,IAAI,EAAE,MAAM,CAAC;IACb,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,QAAQ,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,IAAI,CAAC;IACjC,qDAAqD;IACrD,OAAO,EAAE,OAAO,CAAC;CAClB;AAED;;;GAGG;AACH,wBAAgB,YAAY,CAAC,EAC3B,QAAQ,EACR,MAAM,EACN,IAAI,EACJ,QAAQ,GACT,EAAE;IACD,QAAQ,EAAE,MAAM,CAAC;IACjB,MAAM,EAAE,MAAM,IAAI,CAAC;IACnB,IAAI,EAAE,MAAM,CAAC;IACb,QAAQ,CAAC,EAAE,SAAS,CAAC;CACtB,2CAgBA;AAED;;;;;GAKG;AACH,wBAAgB,UAAU,CAAC,IAAI,SAAS;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,MAAM,CAAA;CAAE,EAAE,EACzE,GAAG,EACH,MAAM,EACN,OAAO,EACP,KAAK,EACL,QAAQ,EACR,QAAQ,EACR,IAAI,EACJ,UAAU,EACV,KAAK,EACL,OAAO,EACP,OAAO,EACP,IAAI,EACJ,SAAS,EACT,OAAO,EACP,OAAO,EACP,IAAI,EACJ,OAAO,EACP,QAAQ,EACR,OAAO,GACR,EAAE,eAAe,CAAC,IAAI,CAAC,2CAuPvB"}
+{"version":3,"file":"RecordPage.d.ts","sourceRoot":"","sources":["../../src/record/RecordPage.tsx"],"names":[],"mappings":"AAwBA,OAAO,KAAK,EAAE,aAAa,EAAE,SAAS,EAAE,MAAM,OAAO,CAAC;AAGtD,OAAO,EAAe,KAAK,oBAAoB,EAAE,MAAM,4BAA4B,CAAC;AAGpF,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,mBAAmB,CAAC;AACzD,OAAO,EAAe,KAAK,gBAAgB,EAAE,MAAM,oBAAoB,CAAC;AAOxE,OAAO,KAAK,EAAuB,eAAe,EAAE,MAAM,kBAAkB,CAAC;AAE7E;;;;;GAKG;AACH,wBAAgB,gBAAgB,CAAC,EAAE,KAAK,EAAE,EAAE;IAAE,KAAK,EAAE,MAAM,CAAA;CAAE,2CAQ5D;AAED,yEAAyE;AACzE,MAAM,WAAW,kBAAkB,CAAC,IAAI;IACtC,KAAK,EAAE,MAAM,CAAC;IACd,IAAI,EAAE,aAAa,CAAC;QAAE,IAAI,CAAC,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IACvC,IAAI,EAAE,CAAC,GAAG,EAAE,OAAO,CAAC,IAAI,CAAC,KAAK,MAAM,CAAC;IACrC,MAAM,CAAC,EAAE,MAAM,CAAC;CACjB;AAED,KAAK,GAAG,GAAG,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;AAEnC,MAAM,WAAW,eAAe,CAAC,IAAI,SAAS;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,MAAM,CAAA;CAAE;IAC7E,GAAG,EAAE,OAAO,CAAC,IAAI,CAAC,CAAC;IACnB,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,EAAE,CAAC,CAAC;IAC9B,OAAO,EAAE,MAAM,CAAC;IAChB,KAAK,EAAE,MAAM,CAAC;IACd,QAAQ,EAAE,MAAM,CAAC;IACjB,QAAQ,EAAE,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;IAC1B,IAAI,CAAC,EAAE,gBAAgB,CAAC,IAAI,CAAC,CAAC;IAC9B,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,KAAK,CAAC,EAAE,eAAe,CAAC;IACxB,OAAO,EAAE,SAAS,oBAAoB,EAAE,CAAC;IACzC,OAAO,CAAC,EAAE,CAAC,GAAG,EAAE,OAAO,CAAC,IAAI,CAAC,KAAK;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,IAAI,CAAC,EAAE,MAAM,CAAA;KAAE,GAAG,SAAS,CAAC;IAC9E,IAAI,EAAE,SAAS,eAAe,EAAE,CAAC;IACjC,SAAS,CAAC,EAAE,OAAO,GAAG,MAAM,CAAC;IAC7B,OAAO,EAAE,SAAS,kBAAkB,CAAC,IAAI,CAAC,EAAE,CAAC;IAC7C,OAAO,EAAE,OAAO,CAAC;IACjB,IAAI,EAAE,MAAM,CAAC;IACb,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,QAAQ,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,IAAI,CAAC;IACjC,qDAAqD;IACrD,OAAO,EAAE,OAAO,CAAC;CAClB;AAED;;;GAGG;AACH,wBAAgB,YAAY,CAAC,EAC3B,QAAQ,EACR,MAAM,EACN,IAAI,EACJ,QAAQ,GACT,EAAE;IACD,QAAQ,EAAE,MAAM,CAAC;IACjB,MAAM,EAAE,MAAM,IAAI,CAAC;IACnB,IAAI,EAAE,MAAM,CAAC;IACb,QAAQ,CAAC,EAAE,SAAS,CAAC;CACtB,2CAgBA;AAED;;;;;GAKG;AACH,wBAAgB,UAAU,CAAC,IAAI,SAAS;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,MAAM,CAAA;CAAE,EAAE,EACzE,GAAG,EACH,MAAM,EACN,OAAO,EACP,KAAK,EACL,QAAQ,EACR,QAAQ,EACR,IAAI,EACJ,UAAU,EACV,KAAK,EACL,OAAO,EACP,OAAO,EACP,IAAI,EACJ,SAAS,EACT,OAAO,EACP,OAAO,EACP,IAAI,EACJ,OAAO,EACP,QAAQ,EACR,OAAO,GACR,EAAE,eAAe,CAAC,IAAI,CAAC,2CA2PvB"}