@multiplatform.one/frappe-ui 7.28.1 → 7.29.0

package/src/FrappeReportView.spec.tsx

@@ -51,6 +51,9 @@ describe("scrubFieldname", () => {
   });
 });
 
+// normalizeReportColumn is the query-report model's column normalizer under
+// FrappeReportView's old name (MPO-15, GL-28): widths come back as numbers
+// and an untyped column carries fieldtype "", the shape both report views read.
 describe("normalizeReportColumn", () => {
   it("parses legacy string columns (Label:Fieldtype/Options:Width)", () => {
     expect(normalizeReportColumn("Name:Link/ToDo:120")).toEqual({
@@ -58,7 +61,7 @@ describe("normalizeReportColumn", () => {
       fieldname: "name",
       fieldtype: "Link",
       options: "ToDo",
-      width: "120",
+      width: 120,
     });
   });
 
@@ -66,7 +69,8 @@ describe("normalizeReportColumn", () => {
     expect(normalizeReportColumn("Status::100")).toEqual({
       label: "Status",
       fieldname: "status",
-      width: "100",
+      fieldtype: "",
+      width: 100,
     });
   });
 
@@ -74,13 +78,15 @@ describe("normalizeReportColumn", () => {
     expect(normalizeReportColumn("Total Amount")).toEqual({
       label: "Total Amount",
       fieldname: "total_amount",
+      fieldtype: "",
     });
   });
 
   it("fills missing fieldname on dict columns from the label", () => {
-    expect(normalizeReportColumn({ label: "Data Size" } as FrappeReportColumn)).toEqual({
+    expect(normalizeReportColumn({ label: "Data Size" })).toEqual({
       label: "Data Size",
       fieldname: "data_size",
+      fieldtype: "",
     });
   });
 
@@ -349,9 +355,7 @@ describe("FrappeReportView", () => {
         }}
       />,
     );
-    expect(
-      await screen.findByText("You do not have permission to run Database Storage Usage By Tables"),
-    ).toBeTruthy();
+    expect(await screen.findByText("You can't run Database Storage Usage By Tables")).toBeTruthy();
     expect(screen.queryByText(/Traceback/)).toBeNull();
   });
 

package/src/FrappeReportView.stories.tsx

@@ -133,6 +133,25 @@ WithFilters.parameters = {
   },
 };
 
+const refusedLoader = async (): Promise<FrappeReportRunResponse> => {
+  throw Object.assign(new Error("You don't have access to Report: Quarterly Sales"), {
+    status: 403,
+    exc_type: "PermissionError",
+  });
+};
+
+export const Refused = () => (
+  <FrappeReportView reportName="Quarterly Sales" fixture={refusedLoader} />
+);
+Refused.parameters = {
+  docs: {
+    description: {
+      story:
+        "The server refuses the run (403 PermissionError): a permission state that says the reader can't run the report, with the server's sentence and no retry, since a retry cannot succeed (LC-96).",
+    },
+  },
+};
+
 // ---------------------------------------------------------------------------
 // Live bench story — a stock Script Report over the real query_report.run
 // ---------------------------------------------------------------------------
@@ -173,7 +192,7 @@ Live.parameters = {
   docs: {
     description: {
       story:
-        "Runs the stock 'Database Storage Usage By Tables' Script Report against the real bench through the Storybook proxy. A session without Report permission (a plain Desk User) sees the permission EmptyState — 'You do not have permission to run …' plus the server's sentence — not a python traceback; same honesty as QueryReportScreen Live. System Manager / Administrator sees the table. When the bench is down the story renders a fixture payload mirroring the same column contract.",
+        "Runs the stock 'Database Storage Usage By Tables' Script Report against the real bench through the Storybook proxy. A session without Report permission (a plain Desk User) sees the permission EmptyState — 'You can't run …' with the server's sentence and no retry (LC-96) — not a python traceback; same honesty as QueryReportScreen Live. System Manager / Administrator sees the table. When the bench is down the story renders a fixture payload mirroring the same column contract.",
     },
   },
 };