@multiplatform.one/frappe-ui 7.28.0 → 7.29.0

package/src/FrappeListView.cards.stories.tsx

@@ -1,7 +1,7 @@
-import { Card } from "@multiplatform.one/components";
+import { Card, Image } from "@multiplatform.one/components";
 import { action } from "@multiplatform.one/storybook";
 import { useResolvedKnobs } from "@multiplatform.one/theme";
-import { Image, Text, YStack } from "tamagui";
+import { Text, YStack } from "tamagui";
 import {
   createRosterFixtures,
   rosterPokemonFields,
@@ -54,10 +54,7 @@ function PokemonTile({ pokemon }: { pokemon: Partial<RosterPokemon> }) {
   return (
     <Card>
       <YStack {...knobProps.panelPadding} {...knobProps.gap} alignItems="center">
-        <Image
-          source={{ uri: pokemon.sprite_front, width: 96, height: 96 }}
-          alt={pokemon.pokemon_name ?? ""}
-        />
+        <Image src={pokemon.sprite_front} size="large" alt={pokemon.pokemon_name ?? ""} />
         <Text {...knobProps.body} fontWeight="700" textTransform="capitalize">
           {pokemon.pokemon_name}
         </Text>

package/src/FrappeListView.tsx

@@ -1,4 +1,4 @@
-import { HttpClient, useDocTypeMeta } from "@multiplatform.one/frappe";
+import { useDocTypeMeta } from "@multiplatform.one/frappe";
 import type { DataTableColumn } from "@multiplatform.one/table";
 import {
   ArrowsClockwiseIcon,
@@ -56,6 +56,7 @@ import {
 import { ListToastHost } from "./list/ListToastHost";
 import { ShufflePanel } from "./list/ShufflePanel";
 import { useListControls } from "./list/useListControls";
+import { recordKeyLabel, useRecordShape } from "./recordShape";
 import { useConnectionFilters, type FrappeDoctypeFilter } from "./useConnectionFilters";
 
 interface ListFieldConfig {
@@ -210,23 +211,6 @@ const storageKeyPrefix = "frappe-listview-";
 /** Cards whose images load eagerly; the rest wait until they near the viewport. */
 const eagerCards = 6;
 
-// Frappe document bookkeeping keys -- never useful as display columns.
-const internalDocKeys = new Set([
-  "name",
-  "owner",
-  "creation",
-  "modified",
-  "modified_by",
-  "docstatus",
-  "idx",
-  "doctype",
-  "_user_tags",
-  "_comments",
-  "_assign",
-  "_liked_by",
-  "_seen",
-]);
-
 // Fieldtypes that structure a form but hold no listable value.
 const layoutFieldtypes = new Set([
   "Column Break",
@@ -238,11 +222,6 @@ const layoutFieldtypes = new Set([
   "Button",
 ]);
 
-/** "pokemon_name" -> "Pokemon Name" for fields we only know by key. */
-function fieldKeyLabel(key: string): string {
-  return key.replace(/_/g, " ").replace(/(^|\s)\S/g, (c) => c.toUpperCase());
-}
-
 /**
  * Resolves an image field value to a full URL.
  */
@@ -398,36 +377,17 @@ function FrappeListViewBody<TDoc extends { name: string; doctype: string }>({
       (route !== undefined && navigate
         ? () => navigate(frappeRouteHref(route, { mode: "create" }))
         : undefined));
-  // Guest fallback: DocType meta is permission-gated (Guests get 403) while
-  // the documents themselves are often guest-readable. Peek one doc with
-  // fields=["*"] and derive display fields from its keys so the views render
-  // real columns instead of collapsing to a lone Name column.
-  const [peekedFields, setPeekedFields] = useState<string[] | null>(null);
-  useEffect(() => {
-    if (meta || isMetaLoading || !metaError || !finalBaseURL) return;
-    let cancelled = false;
-    const http = new HttpClient(
-      finalBaseURL,
-      finalAuth as ConstructorParameters<typeof HttpClient>[1],
-    );
-    (async () => {
-      try {
-        const response = await http.get<{ data?: Record<string, unknown>[] }>(
-          `/api/resource/${encodeURIComponent(doctype)}`,
-          { fields: ["*"], limit_page_length: 1 },
-        );
-        const sample = response.payload?.data?.[0];
-        if (!cancelled && sample) {
-          setPeekedFields(Object.keys(sample).filter((key) => !internalDocKeys.has(key)));
-        }
-      } catch {
-        // Doctype not readable at all -- the views' own empty states handle it.
-      }
-    })();
-    return () => {
-      cancelled = true;
-    };
-  }, [meta, isMetaLoading, metaError, doctype, finalBaseURL, finalAuth]);
+  // Meta refused (Guest gets 403) while the rows are readable: the views
+  // take their fields from one record instead of collapsing to Name (LC-96).
+  const recordShape = useRecordShape(
+    connectionConfig,
+    doctype,
+    !meta && !isMetaLoading && Boolean(metaError),
+  );
+  const peekedFields = useMemo(
+    () => recordShape.fields?.map((field) => field.fieldname) ?? null,
+    [recordShape.fields],
+  );
 
   // List-view fields: prefer the doctype's in_list_view flags; when a doctype
   // declares none, lead with its first data fields so the list/table still
@@ -472,7 +432,7 @@ function FrappeListViewBody<TDoc extends { name: string; doctype: string }>({
       return peekedFields
         .filter((key) => key !== imageFieldName)
         .slice(0, 4)
-        .map((key) => ({ key, label: fieldKeyLabel(key) }));
+        .map((key) => ({ key, label: recordKeyLabel(key) }));
     }
     return [{ key: "name", label: t("Name") }];
   }, [displayFields, meta, metaListFields, peekedFields, imageFieldName, t]);
@@ -546,7 +506,7 @@ function FrappeListViewBody<TDoc extends { name: string; doctype: string }>({
         .slice(0, 4)
         .map(
           (key) =>
-            ({ accessorKey: key, header: fieldKeyLabel(key) }) as DataTableColumn<Partial<TDoc>>,
+            ({ accessorKey: key, header: recordKeyLabel(key) }) as DataTableColumn<Partial<TDoc>>,
         );
     }
     return [{ accessorKey: "name" as string, header: t("Name") }] as DataTableColumn<

package/src/FrappeReportBuilder.stories.tsx

@@ -13,7 +13,7 @@ export default {
     docs: {
       description: {
         component:
-          "Report builder over a Frappe DocType: meta-derived columns, group-by, save/load reports (storage), CSV export. Meta from an in-story fetch mock; rows from fixtures.",
+          "A doctype's report view, the one the desk's view=report renders: desk default columns, a per-column filter row, group-by, totals, saved reports, CSV export and paging. Meta from an in-story fetch mock; rows from fixtures.",
       },
     },
   },
@@ -24,6 +24,7 @@ export default {
 
 const MOCK_HOST = "https://report.mock.test";
 const ERR_HOST = "https://forbidden.report.mock.test";
+const GUEST_HOST = "https://guest.report.mock.test";
 
 function jsonResponse(body: unknown, status = 200): Response {
   return new Response(JSON.stringify(body), {
@@ -71,6 +72,12 @@ function saleMeta(name: string) {
     const urlStr =
       typeof input === "string" ? input : input instanceof URL ? input.toString() : input.url;
     if (urlStr.startsWith(ERR_HOST)) return jsonResponse({ message: "Not permitted" }, 403);
+    if (urlStr.startsWith(GUEST_HOST)) {
+      const url = new URL(urlStr);
+      return url.pathname === "/api/resource/QaSaleGuest"
+        ? jsonResponse({ data: makeSales("QaSaleGuest", 1) })
+        : jsonResponse({ message: "Not permitted" }, 403);
+    }
     if (urlStr.startsWith(MOCK_HOST)) {
       const url = new URL(urlStr);
       const metaMatch = url.pathname.match(/^\/api\/resource\/DocType\/(.+)$/);
@@ -126,8 +133,9 @@ export const EmptyData = () => (
 );
 
 /**
- * Meta endpoint 403s but explicit initialColumns are provided: the builder
- * must still render columns and fixture rows without DocType meta.
+ * Meta endpoint 403s with explicit initialColumns: a reader refused the
+ * schema still gets the rows, laid out from those columns, with nothing to
+ * save (LC-96).
  */
 export const InitialColumnsNoMeta = () => (
   <FrappeProvider baseURL={ERR_HOST} fixtures={fixturesFor("QaSaleNoMeta", 8)}>
@@ -143,12 +151,31 @@ export const InitialColumnsNoMeta = () => (
   </FrappeProvider>
 );
 
+/**
+ * Meta refused, one record readable: the columns come from that record's own
+ * fields, labelled from their keys, and there is nothing to save (LC-96).
+ */
+export const GuestRecordShape = () => (
+  <FrappeProvider baseURL={GUEST_HOST} fixtures={fixturesFor("QaSaleGuest", 8)}>
+    <FrappeReportBuilder doctype="QaSaleGuest" height={480} />
+  </FrappeProvider>
+);
+
+/**
+ * Meta and records both refused: a permission state that says what the reader
+ * can't do, with no retry (LC-96).
+ */
+export const GuestRefused = () => (
+  <FrappeProvider baseURL={ERR_HOST} fixtures={fixturesFor("QaSaleRefused", 8)}>
+    <FrappeReportBuilder doctype="QaSaleRefused" height={480} />
+  </FrappeProvider>
+);
+
 // ---------------------------------------------------------------------------
 // Live bench report: rows over the bench's ToDo doctype stream through the
-// sync engine and refresh in place on realtime events (subtle "Updating..."
-// affordance in the toolbar) while the builder's chosen columns / group-by
-// survive untouched. Fixtures + initialColumns fallback when the bench is
-// unreachable (meta 404s there — initialColumns keep the builder rendering).
+// sync engine and refresh in place on realtime events while the chosen
+// columns and group-by survive untouched. Fixtures stand in when the bench is
+// unreachable.
 // ---------------------------------------------------------------------------
 
 const liveTodoFixtures = new InMemoryFixtureProvider({