@multiplatform.one/config 7.8.0 → 7.11.0

package/lib/index.js

@@ -1,5 +1,5 @@
-import { t as createViteConfig } from "./vite-DCmObTtC.js";
-import { t as createStorybookViteConfig } from "./storybook-B3oEWyc-.js";
+import { t as createViteConfig } from "./vite-D6vMjPwv.js";
+import { t as createStorybookViteConfig } from "./storybook-CGNSgSBS.js";
 import { n as tamaguiWorkspacePathsFile, t as ensureTamaguiWorkspacePaths } from "./tamaguiWorkspacePaths-ZIcqybtn.js";
 import { createVitestConfig } from "./vitest.js";
 

package/lib/{storybook-B3oEWyc-.js → storybook-CGNSgSBS.js}

@@ -1,4 +1,4 @@
-import { i as withSingletonDepAliases, r as resolvePackageMainSource, t as discoverPublicPackageRoots } from "./workspacePublicPackages-DdJxvtWd.js";
+import { i as withSingletonDepAliases, r as resolvePackageMainSource, t as discoverPublicPackageRoots } from "./workspacePublicPackages-B4FGgRYG.js";
 import { t as ensureTamaguiWorkspacePaths } from "./tamaguiWorkspacePaths-ZIcqybtn.js";
 import { createRequire } from "node:module";
 import fs from "node:fs";

package/lib/storybook.js

@@ -1,3 +1,3 @@
-import { t as createStorybookViteConfig } from "./storybook-B3oEWyc-.js";
+import { t as createStorybookViteConfig } from "./storybook-CGNSgSBS.js";
 
 export { createStorybookViteConfig };

package/lib/{vite-DCmObTtC.js → vite-D6vMjPwv.js}

@@ -1,4 +1,4 @@
-import { i as withSingletonDepAliases, t as discoverPublicPackageRoots } from "./workspacePublicPackages-DdJxvtWd.js";
+import { i as withSingletonDepAliases, t as discoverPublicPackageRoots } from "./workspacePublicPackages-B4FGgRYG.js";
 import { t as ensureTamaguiWorkspacePaths } from "./tamaguiWorkspacePaths-ZIcqybtn.js";
 import { createRequire } from "node:module";
 import fs from "node:fs";

package/lib/vite.js

@@ -1,4 +1,4 @@
-import { t as createViteConfig } from "./vite-DCmObTtC.js";
-import { n as publicPackageViteSourceAliases, t as discoverPublicPackageRoots } from "./workspacePublicPackages-DdJxvtWd.js";
+import { t as createViteConfig } from "./vite-D6vMjPwv.js";
+import { n as publicPackageViteSourceAliases, t as discoverPublicPackageRoots } from "./workspacePublicPackages-B4FGgRYG.js";
 
 export { createViteConfig, discoverPublicPackageRoots, publicPackageViteSourceAliases };

package/lib/{workspacePublicPackages-DdJxvtWd.js → workspacePublicPackages-B4FGgRYG.js}

@@ -64,13 +64,28 @@ import path from "node:path";
 * mounting a data-bound panel threw `Cannot read properties of null (reading
 * 'useSyncExternalStore')` on every load, and so did every data-bound page
 * after it.
+*
+* MPO-288. THE CRITERION, so the next addition is a decision against a rule
+* rather than a guess. A package belongs here when a second module record
+* would break it: it holds state at module scope, it subscribes an external
+* store, or it provides a React context consumers compare by identity.
+* Grepping the installed package for `useSyncExternalStore` is a cheap test
+* for the second clause, and `singletonDepAliases.spec.ts` re-runs it against
+* the tree so a tanstack upgrade is checked rather than assumed. It is one
+* clause and not the whole rule: `@tanstack/db` references the hook nowhere
+* and is pinned anyway, for the collection registry it holds at module scope.
+*
+* `@tanstack/react-query` references the hook in 25 shipped files and is not
+* listed. That is recorded rather than settled — no split has been observed
+* there, and pinning it reaches further than this measurement does.
 */
 const CONTEXT_SINGLETONS = [
 	"react-cookie",
 	"@tamagui/core",
 	"@tamagui/web",
 	"@tanstack/db",
-	"@tanstack/react-db"
+	"@tanstack/react-db",
+	"@tanstack/react-store"
 ];
 /**
 * Vite `resolve.alias` entries pinning each context singleton to one directory.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@multiplatform.one/config",
-  "version": "7.8.0",
+  "version": "7.11.0",
   "description": "Shared build and test configuration presets for multiplatform.one",
   "keywords": [
     "config",
@@ -95,14 +95,14 @@
     "access": "public"
   },
   "dependencies": {
+    "@multiplatform.one/utils": "7.11.0",
     "@tamagui/vite-plugin": "2.7.6",
     "@vitejs/plugin-react": "^6.0.1",
     "dotenv": "^17.4.2",
     "vite": "^8.0.10",
     "vite-plugin-external": "^6.2.2",
     "vite-plugin-i18next-loader": "^3.1.3",
-    "vitest": "^4.1.5",
-    "@multiplatform.one/utils": "7.8.0"
+    "vitest": "^4.1.5"
   },
   "devDependencies": {
     "tsdown": "^0.21.10",

package/src/singletonDepAliases.spec.ts

@@ -67,6 +67,18 @@ describe("singletonDepAliases", () => {
     expect(fs.existsSync(path.join(aliases["@tanstack/react-db"], "package.json"))).toBe(true);
   });
 
+  it("pins the react half of the store pair, which is the one that calls the hook (MPO-288)", () => {
+    // The same split as react-db, measured the same way: @tanstack/store has
+    // zero references to useSyncExternalStore and @tanstack/react-store has
+    // three, all of them useSelector, which is what useStore calls.
+    // public/store and public/forms both reach React through it, so a second
+    // record subscribes a store nothing armed.
+    const aliases = singletonDepAliases(workspaceRoot);
+    expect(aliases["@tanstack/react-store"]).toBeTruthy();
+    expect(path.isAbsolute(aliases["@tanstack/react-store"])).toBe(true);
+    expect(fs.existsSync(path.join(aliases["@tanstack/react-store"], "package.json"))).toBe(true);
+  });
+
   it("omits packages that are not installed", () => {
     // Resolution runs against the given root, so a consumer without the
     // package gets no alias rather than a broken one.
@@ -141,3 +153,55 @@ describe("createViteConfig context singletons (MPO-225)", () => {
     expect(alias.tamagui).toBeUndefined();
   });
 });
+
+describe("CONTEXT_SINGLETONS membership, measured rather than recited (MPO-288)", () => {
+  const aliases = singletonDepAliases(workspaceRoot);
+
+  it("pins every tanstack half that subscribes an external store", () => {
+    for (const pkg of ["@tanstack/react-store", "@tanstack/react-db"]) {
+      expect(subscribesExternalStore(pkg), `${pkg} must reference the hook`).toBe(true);
+      expect(aliases[pkg], `${pkg} subscribes and must be pinned`).toBeTruthy();
+    }
+  });
+
+  it("leaves the pacer pair off, which the same measurement confirms", () => {
+    for (const pkg of ["@tanstack/pacer", "@tanstack/react-pacer"]) {
+      expect(subscribesExternalStore(pkg), `${pkg} must not reference the hook`).toBe(false);
+      expect(aliases[pkg], `${pkg} has no measured reason to be pinned`).toBeUndefined();
+    }
+  });
+
+  it("does not treat the grep as the whole rule", () => {
+    // @tanstack/db is pinned and references the hook nowhere: it holds the
+    // collection registry at module scope, which is a different clause of the
+    // criterion and one no grep can see. @tanstack/store carries no such
+    // registry, so silence there means what it says.
+    expect(subscribesExternalStore("@tanstack/db")).toBe(false);
+    expect(aliases["@tanstack/db"]).toBeTruthy();
+    expect(subscribesExternalStore("@tanstack/store")).toBe(false);
+  });
+});
+
+/**
+ * Whether an installed package references `useSyncExternalStore` in anything
+ * it ships. The cheap half of the membership rule, re-run against the tree so
+ * the next tanstack upgrade is checked rather than assumed.
+ */
+function subscribesExternalStore(pkgName: string): boolean {
+  const dir = path.join(workspaceRoot, "node_modules", ...pkgName.split("/"));
+  return fs.existsSync(dir) && referencesHook(dir);
+}
+
+function referencesHook(dir: string): boolean {
+  for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
+    if (entry.name === "node_modules") continue;
+    const full = path.join(dir, entry.name);
+    if (fs.statSync(full).isDirectory()) {
+      if (referencesHook(full)) return true;
+      continue;
+    }
+    if (!/\.(?:js|cjs|mjs|ts|tsx)$/.test(entry.name)) continue;
+    if (fs.readFileSync(full, "utf8").includes("useSyncExternalStore")) return true;
+  }
+  return false;
+}

package/src/singletonDepAliases.ts

@@ -63,6 +63,20 @@ import path from "node:path";
  * mounting a data-bound panel threw `Cannot read properties of null (reading
  * 'useSyncExternalStore')` on every load, and so did every data-bound page
  * after it.
+ *
+ * MPO-288. THE CRITERION, so the next addition is a decision against a rule
+ * rather than a guess. A package belongs here when a second module record
+ * would break it: it holds state at module scope, it subscribes an external
+ * store, or it provides a React context consumers compare by identity.
+ * Grepping the installed package for `useSyncExternalStore` is a cheap test
+ * for the second clause, and `singletonDepAliases.spec.ts` re-runs it against
+ * the tree so a tanstack upgrade is checked rather than assumed. It is one
+ * clause and not the whole rule: `@tanstack/db` references the hook nowhere
+ * and is pinned anyway, for the collection registry it holds at module scope.
+ *
+ * `@tanstack/react-query` references the hook in 25 shipped files and is not
+ * listed. That is recorded rather than settled — no split has been observed
+ * there, and pinning it reaches further than this measurement does.
  */
 const CONTEXT_SINGLETONS: readonly string[] = [
   "react-cookie",
@@ -78,6 +92,12 @@ const CONTEXT_SINGLETONS: readonly string[] = [
   // exactly where it was. MPO-225 named @tanstack/db; the measurement says
   // the pair has to travel together.
   "@tanstack/react-db",
+  // Measured at 0.11.0: @tanstack/store references useSyncExternalStore in
+  // nothing it ships and @tanstack/react-store in three, all useSelector,
+  // which is the call behind useStore. public/store and public/forms both
+  // reach React through it, so a second record would subscribe a store
+  // nothing armed — the null read MPO-225 reported, one package family over.
+  "@tanstack/react-store",
 ];
 
 /**

package/types/singletonDepAliases.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"singletonDepAliases.d.ts","sourceRoot":"","sources":["../src/singletonDepAliases.ts"],"names":[],"mappings":"AAkFA;;;;;;;;;GASG;AACH,wBAAgB,mBAAmB,CAAC,IAAI,GAAE,MAAsB,GAAG,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAUxF;AAED;;;;;;;;;;;;;;;;;;GAkBG;AACH,wBAAgB,uBAAuB,CACrC,IAAI,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,EAC5B,IAAI,GAAE,MAAsB,EAC5B,SAAS,GAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAM,GACrC,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAOxB"}
+{"version":3,"file":"singletonDepAliases.d.ts","sourceRoot":"","sources":["../src/singletonDepAliases.ts"],"names":[],"mappings":"AAsGA;;;;;;;;;GASG;AACH,wBAAgB,mBAAmB,CAAC,IAAI,GAAE,MAAsB,GAAG,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAUxF;AAED;;;;;;;;;;;;;;;;;;GAkBG;AACH,wBAAgB,uBAAuB,CACrC,IAAI,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,EAC5B,IAAI,GAAE,MAAsB,EAC5B,SAAS,GAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAM,GACrC,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAOxB"}