@multiplatform.one/config 7.6.0 → 7.6.2

package/README.md

@@ -68,7 +68,14 @@ Convention rules travel with the package. Consuming apps add one line:
 
 Then enable `mpo-conventions/no-hex-literals` on the globs you want (mpo's
 own `oxlintrc.json` turns it on for `features/**`). Palette modules
-(`themes/base.ts`, `themes/accent.ts`, `*palette*`) are exempt.
+(`themes/base.ts`, `themes/accent.ts`, `*palette*`) are exempt. Comments
+are not visited, so a JSDoc `#025` is not a hit. Widening to `apps/**`
+and `packages/**` is 182 hits on this tree (153 outside tests) — record
+the count, then burn down; do not flip the glob until then.
+
+`no-chrome-props` and `no-raw-geometry` ship in the same plugin (MPO-17).
+Enable them the same way when you start that burndown. Drawing-file
+exceptions come from the spec table `## Drawing files`, not from the code.
 
 ### Lint (node-script checks)
 

package/drawing-registry.mjs

@@ -0,0 +1,145 @@
+/**
+ * Drawing / chrome-allow registry — parsed from the living rulebook.
+ *
+ * MPO-17: raw numeric geometry is legal only in files listed as DRAWING
+ * members, and chrome props on imported @multiplatform.one/* components are
+ * legal only for CHROME-ALLOW members. Both lists are parsed from
+ * `docs/theme-propagation-spec.md` `## Drawing files`, the same shape
+ * scripts/radius-identity-registry.mjs uses for LC-60. Writing more
+ * violations into the code cannot widen either list.
+ *
+ * A consumer tree with no spec (or no Drawing files section) yields empty
+ * lists rather than throwing, so shc can pick the oxlint rules up before it
+ * has copied this table.
+ *
+ * Usage:
+ *   import { readDrawingRegistry } from "./drawing-registry.mjs";
+ *   node drawing-registry.mjs [--json]
+ */
+import { existsSync, readFileSync } from "node:fs";
+import { join } from "node:path";
+import { pathToFileURL } from "node:url";
+
+export const DRAWING_HEADING = "## Drawing files";
+export const DRAWING_CLASS = "DRAWING";
+export const CHROME_ALLOW_CLASS = "CHROME-ALLOW";
+
+/** `// mpo-drawing` or `/* mpo-drawing` at the start of a line. */
+export const DRAWING_PRAGMA = /^\s*(?:\/\/|\/\*)\s*mpo-drawing\b/m;
+
+/**
+ * @param {string} [cwd]
+ */
+export function defaultSpecPath(cwd = process.cwd()) {
+  return join(cwd, "docs/theme-propagation-spec.md");
+}
+
+/** `Members: **Avatar**, **Radio disc**.` → ["Avatar", "Radio disc"]. */
+function parseMembers(text) {
+  const match = text.match(/Members:\s*(.*)$/i);
+  if (!match) return [];
+  return [...match[1].matchAll(/\*\*([^*]+)\*\*/g)].map((m) => m[1].trim()).filter(Boolean);
+}
+
+/**
+ * @param {string} markdown
+ * @param {string} specPath
+ */
+function parseDrawingTable(markdown, specPath) {
+  const lines = markdown.split("\n");
+  const heading = lines.findIndex((line) => /^##\s+Drawing files\s*$/.test(line));
+  if (heading === -1) return null;
+
+  /** @type {{ id: string, text: string }[]} */
+  const rows = [];
+  let seenTable = false;
+  for (let i = heading + 1; i < lines.length; i++) {
+    const line = lines[i].trim();
+    if (line.startsWith("##")) break;
+    if (!line.startsWith("|")) {
+      if (seenTable) break;
+      continue;
+    }
+    seenTable = true;
+    const cells = line
+      .split("|")
+      .slice(1, -1)
+      .map((c) => c.trim());
+    if (cells.length < 2) continue;
+    if (/^:?-{2,}/.test(cells[0])) continue;
+    if (cells[0].toLowerCase() === "class") continue;
+    rows.push({ id: cells[0], text: cells[1] });
+  }
+  if (rows.length === 0) {
+    throw new Error(`${specPath}: "${DRAWING_HEADING}" has no class rows`);
+  }
+  return rows;
+}
+
+/**
+ * @param {string} [specPath]
+ * @returns {{
+ *   specPath: string,
+ *   present: boolean,
+ *   files: string[],
+ *   chromeAllow: string[],
+ * }}
+ */
+export function readDrawingRegistry(specPath = defaultSpecPath()) {
+  if (!existsSync(specPath)) {
+    return { specPath, present: false, files: [], chromeAllow: [] };
+  }
+  const rows = parseDrawingTable(readFileSync(specPath, "utf8"), specPath);
+  if (!rows) {
+    return { specPath, present: false, files: [], chromeAllow: [] };
+  }
+
+  /** @type {Record<string, { text: string, members: string[] }>} */
+  const classes = {};
+  for (const row of rows) {
+    classes[row.id] = { text: row.text, members: parseMembers(row.text) };
+  }
+  if (!classes[DRAWING_CLASS]) {
+    throw new Error(`${specPath}: "${DRAWING_HEADING}" has no ${DRAWING_CLASS} row`);
+  }
+  if (!classes[CHROME_ALLOW_CLASS]) {
+    throw new Error(`${specPath}: "${DRAWING_HEADING}" has no ${CHROME_ALLOW_CLASS} row`);
+  }
+
+  return {
+    specPath,
+    present: true,
+    files: classes[DRAWING_CLASS].members,
+    chromeAllow: classes[CHROME_ALLOW_CLASS].members,
+  };
+}
+
+/**
+ * True when `filename` is one of the registered drawing files.
+ * Members are path suffixes (`listing/glyphs/CanvasGlyph.tsx`) or basenames.
+ *
+ * @param {string | undefined} filename
+ * @param {string[]} files
+ */
+export function isDrawingFile(filename, files) {
+  if (!filename || !files.length) return false;
+  const normalized = filename.replaceAll("\\", "/");
+  return files.some((entry) => {
+    const needle = entry.replaceAll("\\", "/").replace(/^\.\//, "");
+    return normalized === needle || normalized.endsWith(`/${needle}`);
+  });
+}
+
+const invokedDirectly =
+  typeof process.argv[1] === "string" && import.meta.url === pathToFileURL(process.argv[1]).href;
+
+if (invokedDirectly) {
+  const registry = readDrawingRegistry();
+  if (process.argv.includes("--json")) {
+    console.log(JSON.stringify(registry, null, 2));
+  } else {
+    console.log(`drawing registry from ${registry.specPath} (present=${registry.present})`);
+    console.log(`  DRAWING:      ${registry.files.join(", ") || "(none)"}`);
+    console.log(`  CHROME-ALLOW: ${registry.chromeAllow.join(", ") || "(none)"}`);
+  }
+}

package/lib/index.js

@@ -1,5 +1,6 @@
-import { t as createViteConfig } from "./vite-C7884n3X.js";
-import { t as createStorybookViteConfig } from "./storybook-CrdwuS_Y.js";
+import { t as createViteConfig } from "./vite-W9hIeg2_.js";
+import { t as createStorybookViteConfig } from "./storybook-CSzjegfP.js";
+import { n as tamaguiWorkspacePathsFile, t as ensureTamaguiWorkspacePaths } from "./tamaguiWorkspacePaths-ZIcqybtn.js";
 import { createVitestConfig } from "./vitest.js";
 
-export { createStorybookViteConfig, createViteConfig, createVitestConfig };
+export { createStorybookViteConfig, createViteConfig, createVitestConfig, ensureTamaguiWorkspacePaths, tamaguiWorkspacePathsFile };

package/lib/{storybook-CrdwuS_Y.js → storybook-CSzjegfP.js}

@@ -1,4 +1,5 @@
 import { r as resolvePackageMainSource, t as discoverPublicPackageRoots } from "./workspacePublicPackages-COicQSj4.js";
+import { t as ensureTamaguiWorkspacePaths } from "./tamaguiWorkspacePaths-ZIcqybtn.js";
 import { createRequire } from "node:module";
 import fs from "node:fs";
 import path from "node:path";
@@ -89,6 +90,7 @@ function resolvePackageDir(pkgName, root, requireFrom) {
 * ```
 */
 function createStorybookViteConfig(options = {}) {
+	ensureTamaguiWorkspacePaths();
 	const workspaceRoot = options.workspaceRoot || findWorkspaceRoot();
 	const aliases = {
 		...discoverPackageAliases(path.join(workspaceRoot, "packages")),

package/lib/storybook.js

@@ -1,3 +1,3 @@
-import { t as createStorybookViteConfig } from "./storybook-CrdwuS_Y.js";
+import { t as createStorybookViteConfig } from "./storybook-CSzjegfP.js";
 
 export { createStorybookViteConfig };

package/lib/tamaguiWorkspacePaths-ZIcqybtn.js

@@ -0,0 +1,58 @@
+import fs from "node:fs";
+import path from "node:path";
+import { execFileSync } from "node:child_process";
+import { fileURLToPath } from "node:url";
+
+//#region src/tamaguiWorkspacePaths.ts
+const tamaguiWorkspacePathsFile = "tsconfig/tamagui-workspace-paths.generated.json";
+const generatorFile = "../../scripts/generate-tamagui-workspace-paths.mjs";
+function thisPackageDir() {
+	return path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
+}
+function ensureTamaguiWorkspacePaths(options = {}) {
+	const { configPackageDir = thisPackageDir(), log = console.warn } = options;
+	const generatedPath = path.resolve(configPackageDir, tamaguiWorkspacePathsFile);
+	const generatorPath = path.resolve(configPackageDir, generatorFile);
+	if (fs.existsSync(generatedPath)) return {
+		generatedPath,
+		generatorPath,
+		status: "present"
+	};
+	if (!fs.existsSync(generatorPath)) return {
+		generatedPath,
+		generatorPath,
+		status: "no-generator"
+	};
+	try {
+		execFileSync(process.execPath, [generatorPath], { stdio: [
+			"ignore",
+			"ignore",
+			"pipe"
+		] });
+	} catch (error) {
+		const message = error instanceof Error ? error.message : String(error);
+		log?.(`[@multiplatform.one/config] could not regenerate ${tamaguiWorkspacePathsFile}: ${message}`);
+		return {
+			generatedPath,
+			generatorPath,
+			status: "failed"
+		};
+	}
+	if (!fs.existsSync(generatedPath)) {
+		log?.(`[@multiplatform.one/config] ${path.basename(generatorPath)} ran but did not write ${tamaguiWorkspacePathsFile}`);
+		return {
+			generatedPath,
+			generatorPath,
+			status: "failed"
+		};
+	}
+	log?.(`[@multiplatform.one/config] ${tamaguiWorkspacePathsFile} was missing (the root prepare script did not run; a global ignore-scripts skips it). Regenerated it. Run \`pnpm generate:tamagui-paths\` after install to skip this step.`);
+	return {
+		generatedPath,
+		generatorPath,
+		status: "generated"
+	};
+}
+
+//#endregion
+export { tamaguiWorkspacePathsFile as n, ensureTamaguiWorkspacePaths as t };

package/lib/{vite-C7884n3X.js → vite-W9hIeg2_.js}

@@ -1,4 +1,5 @@
 import { t as discoverPublicPackageRoots } from "./workspacePublicPackages-COicQSj4.js";
+import { t as ensureTamaguiWorkspacePaths } from "./tamaguiWorkspacePaths-ZIcqybtn.js";
 import { createRequire } from "node:module";
 import fs from "node:fs";
 import path from "node:path";
@@ -77,6 +78,7 @@ function lookupProjectRoot() {
 * ```
 */
 function createViteConfig(options = {}) {
+	ensureTamaguiWorkspacePaths();
 	const { projectRoot: _projectRoot, publicConfigKeys = [], tamagui = true, i18n = false, one = false, ssr, server, plugins: extraPlugins = [], externalReactRouter, ssrDeps, ssrEntries, ssrCjsExternal, nativeFixes } = options;
 	const projectRoot = _projectRoot || findProjectRoot();
 	dotenv.config({ path: path.resolve(projectRoot, ".env") });

package/lib/vite.js

@@ -1,4 +1,4 @@
-import { t as createViteConfig } from "./vite-C7884n3X.js";
+import { t as createViteConfig } from "./vite-W9hIeg2_.js";
 import { n as publicPackageViteSourceAliases, t as discoverPublicPackageRoots } from "./workspacePublicPackages-COicQSj4.js";
 
 export { createViteConfig, discoverPublicPackageRoots, publicPackageViteSourceAliases };

package/lib/vitest.js

@@ -1,8 +1,9 @@
+import { t as ensureTamaguiWorkspacePaths } from "./tamaguiWorkspacePaths-ZIcqybtn.js";
 import Module from "node:module";
 import fs from "node:fs";
 import path from "node:path";
-import { tamaguiPlugin } from "@tamagui/vite-plugin";
 import { fileURLToPath } from "node:url";
+import { tamaguiPlugin } from "@tamagui/vite-plugin";
 import react from "@vitejs/plugin-react";
 
 //#region src/vitest.ts
@@ -47,6 +48,7 @@ function pinNodeReactRequire(reactDir, reactDomDir, schedulerDir) {
 * ```
 */
 function createVitestConfig(options = {}) {
+	ensureTamaguiWorkspacePaths();
 	const { tamaguiConfig = "./tests/tamagui.config.ts", environment = "jsdom", setupFiles = [], testTimeout = 3e4, inlineDeps = [], externalDeps = [], aliases = {}, coverage, replaceReactNative = true, dedupeReact = true, rootNodeModules: _rootNodeModules, conditions = [
 		"source",
 		"test",

package/lint.d.ts

@@ -3,6 +3,7 @@ export type ConventionRoots = {
   apps?: string;
   features?: string;
   public?: string;
+  packages?: string;
 };
 
 export type RunConventionChecksOptions = {
@@ -14,6 +15,7 @@ export function resolveRoots(roots?: ConventionRoots): {
   apps: string;
   features: string;
   public: string;
+  packages: string;
 };
 
 export function runConventionChecks(options?: RunConventionChecksOptions): number;

package/lint.mjs

@@ -18,6 +18,15 @@
  *    `knobProps.control.height`) are fine. Escape with `sizeRecipeEscape` or
  *    `size-recipe-escape:` on the previous line or same statement. Pilot:
  *    Button/, InputParts/, fields/Select/ only.
+ * 5. Fail on a STORY FILE THE CSF INDEXER CANNOT READ (MPO-93) — a
+ *    `*.stories.*` file that exports a named `meta` beside `export default`
+ *    (`meta` is reserved for CSF Factories, so the indexer reports "missing
+ *    default export"), or one with no default export at all. One such file
+ *    kills the whole gallery and no package build ever sees it.
+ * 6. Fail on an UNDECLARED DRAWING FILE (MPO-17) — a `// mpo-drawing` pragma
+ *    whose path is not a DRAWING member in docs/theme-propagation-spec.md.
+ *    The oxlint rule skips registered drawings; this check is what makes
+ *    adding an undeclared drawing file still fail.
  *
  * Usage:
  *   import { runConventionChecks } from "@multiplatform.one/config/lint";
@@ -31,9 +40,10 @@ import { existsSync, readFileSync, readdirSync, statSync } from "node:fs";
 import { createRequire } from "node:module";
 import { join, relative } from "node:path";
 import { pathToFileURL } from "node:url";
+import { DRAWING_PRAGMA, isDrawingFile, readDrawingRegistry } from "./drawing-registry.mjs";
 
 /**
- * @typedef {{ root?: string, apps?: string, features?: string, public?: string }} ConventionRoots
+ * @typedef {{ root?: string, apps?: string, features?: string, public?: string, packages?: string }} ConventionRoots
  * @typedef {{ roots?: ConventionRoots }} RunConventionChecksOptions
  */
 
@@ -45,6 +55,8 @@ let APPS_DIR = join(ROOT, "apps");
 let FEATURES_DIR = join(ROOT, "features");
 /** @type {string} */
 let PUBLIC_DIR = join(ROOT, "public");
+/** @type {string} */
+let PACKAGES_DIR = join(ROOT, "packages");
 
 /**
  * @param {ConventionRoots} [roots]
@@ -56,6 +68,7 @@ export function resolveRoots(roots = {}) {
     apps: roots.apps ?? join(root, "apps"),
     features: roots.features ?? join(root, "features"),
     public: roots.public ?? join(root, "public"),
+    packages: roots.packages ?? join(root, "packages"),
   };
 }
 
@@ -68,6 +81,7 @@ function applyRoots(roots) {
   APPS_DIR = resolved.apps;
   FEATURES_DIR = resolved.features;
   PUBLIC_DIR = resolved.public;
+  PACKAGES_DIR = resolved.packages;
   sourceFileCache = undefined;
   requireFromRoot = createRequire(join(ROOT, "package.json"));
 }
@@ -670,6 +684,100 @@ function checkSizeRecipeEscape() {
   return violations;
 }
 
+// ── Story file shape (MPO-93) ─────────────────────────────────────────────
+
+const STORY_FILE_RE = /\.(stories|story)\.(js|jsx|mjs|ts|tsx)$/;
+
+/**
+ * Names exported through `export { a, b as c }` statements.
+ * @param {string} src
+ * @returns {Set<string>}
+ */
+function braceExportNames(src) {
+  const names = new Set();
+  for (const m of src.matchAll(/^export\s*\{([^}]*)\}/gm)) {
+    for (const item of m[1].split(",")) {
+      const parts = item.trim().split(/\s+as\s+/);
+      const name = (parts[1] ?? parts[0] ?? "").trim();
+      if (name) names.add(name);
+    }
+  }
+  return names;
+}
+
+/**
+ * Storybook's CSF indexer accepts a story file in exactly two shapes: classic
+ * CSF (`const meta = {...}; export default meta`) or CSF Factories
+ * (`export const meta = preview.meta({...})`, no default export). A file that
+ * exports a NAMED `meta` next to `export default` is neither — the indexer
+ * takes the named export as the factory shape, finds no factory call, and
+ * reports "CSF: missing default export (line 1, col 0)". One such file fails
+ * the whole index, the preview build, and `storybook dev` exits non-zero.
+ * Nothing else catches it: package builds exclude `.stories.` files, so the
+ * pipeline stays green. Three files did exactly this on main (MPO-93).
+ */
+function checkStoryFileShape() {
+  /** @type {string[]} */
+  const violations = [];
+  const scan = (filePath) => {
+    if (!STORY_FILE_RE.test(filePath)) return;
+    const rel = relative(ROOT, filePath);
+    const src = readFileSync(filePath, "utf8");
+    const braced = braceExportNames(src);
+    const namedMeta =
+      src.match(/^export\s+(?:const|let|var|function|class)\s+meta\b/m) ??
+      (braced.has("meta") ? src.match(/^export\s*\{[^}]*\bmeta\b[^}]*\}/m) : null);
+    const hasDefault = /^export\s+default\b/m.test(src) || braced.has("default");
+    const isFactory = /^export\s+(?:const|let|var)\s+meta\b[^=\n]*=\s*[\w$.]+\.meta\s*\(/m.test(
+      src,
+    );
+    if (namedMeta && hasDefault) {
+      violations.push(
+        `${rel}:${lineAt(src, namedMeta.index ?? 0)} — exports a named \`meta\` beside \`export default\`; drop the \`export\` (\`meta\` is reserved for CSF Factories)`,
+      );
+    } else if (namedMeta && !isFactory) {
+      violations.push(
+        `${rel}:${lineAt(src, namedMeta.index ?? 0)} — exports a named \`meta\` that is not a CSF factory call (\`preview.meta(...)\`) and has no default export`,
+      );
+    } else if (!namedMeta && !hasDefault) {
+      violations.push(`${rel} — no default export (classic CSF needs \`export default meta\`)`);
+    }
+  };
+  for (const dir of [PUBLIC_DIR, PACKAGES_DIR, APPS_DIR, FEATURES_DIR]) walkFiles(dir, scan);
+  return violations;
+}
+
+/**
+ * MPO-17: a `// mpo-drawing` pragma is not itself an exemption. The file
+ * must also be a DRAWING member in the spec table. Missing spec → skip
+ * (shc can run the oxlint rules before it copies the table).
+ */
+function checkUndeclaredDrawings() {
+  const specPath = join(ROOT, "docs/theme-propagation-spec.md");
+  let registry;
+  try {
+    registry = readDrawingRegistry(specPath);
+  } catch (error) {
+    return {
+      violations: [`drawing registry: ${error instanceof Error ? error.message : String(error)}`],
+      ok: false,
+    };
+  }
+  if (!registry.present) return { violations: [], ok: true };
+  /** @type {string[]} */
+  const violations = [];
+  const scan = (filePath) => {
+    if (!/\.(tsx|ts|jsx|js)$/.test(filePath)) return;
+    const src = readFileSync(filePath, "utf8");
+    if (!DRAWING_PRAGMA.test(src)) return;
+    const rel = relative(ROOT, filePath);
+    if (isDrawingFile(rel, registry.files) || isDrawingFile(filePath, registry.files)) return;
+    violations.push(`${rel} — // mpo-drawing without a DRAWING Members row in ## Drawing files`);
+  };
+  for (const dir of [PUBLIC_DIR, PACKAGES_DIR, APPS_DIR, FEATURES_DIR]) walkFiles(dir, scan);
+  return { violations, ok: true };
+}
+
 /**
  * Run structural convention checks over a consumer tree.
  *
@@ -681,6 +789,8 @@ export function runConventionChecks(options = {}) {
   const css = checkCssInApps();
   const twins = checkFeaturesTwins();
   const sizeRecipeEscape = checkSizeRecipeEscape();
+  const storyShape = checkStoryFileShape();
+  const undeclaredDrawings = checkUndeclaredDrawings();
   const tokens = checkTransitionTokens();
   const styleTokens = checkStyleTokens();
   const themeNames = checkThemeNames();
@@ -729,6 +839,24 @@ export function runConventionChecks(options = {}) {
     console.error("");
   }
 
+  if (storyShape.length) {
+    failed = true;
+    console.error(
+      'Convention (MPO-93 STORY FILE SHAPE): a story file must be classic CSF (`export default meta`, no named `meta` export) or a CSF factory (`export const meta = preview.meta(...)`). Anything else makes Storybook\'s indexer fail the WHOLE gallery with "CSF: missing default export", and no package build ever sees it.\n',
+    );
+    for (const msg of storyShape) console.error(`  ${msg}`);
+    console.error("");
+  }
+
+  if (undeclaredDrawings.violations.length) {
+    failed = true;
+    console.error(
+      "Convention (MPO-17 DRAWING REGISTRY): `// mpo-drawing` is only legal on a file listed as a DRAWING member in docs/theme-propagation-spec.md. Adding an undeclared drawing file still fails.\n",
+    );
+    for (const msg of undeclaredDrawings.violations) console.error(`  ${msg}`);
+    console.error("");
+  }
+
   if (tokens.violations.length) {
     failed = true;
     console.error(

package/oxlint.d.ts

@@ -2,6 +2,7 @@ export const COLOR_LITERAL: RegExp;
 export const PALETTE_FILE: RegExp;
 export const CHROME_PROPS: readonly string[];
 export const LAYOUT_PROPS: readonly string[];
+export const GEOMETRY_PROPS: readonly string[];
 export function isPaletteModule(filename: string | undefined): boolean;
 export function matchColorLiteral(value: unknown): string | undefined;
 export const plugin: {