@multiplatform.one/config 7.3.0 → 7.4.1

package/lib/vitest.js

@@ -102,8 +102,6 @@ function createVitestConfig(options = {}) {
 		test: testConfig,
 		resolve: {
 			extensions: [
-				".test.ts",
-				".test.tsx",
 				".web.ts",
 				".web.tsx",
 				".web.js",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@multiplatform.one/config",
-  "version": "7.3.0",
+  "version": "7.4.1",
   "description": "Shared build and test configuration presets for multiplatform.one",
   "keywords": [
     "config",
@@ -87,7 +87,7 @@
     "vite-plugin-external": "^6.2.2",
     "vite-plugin-i18next-loader": "^3.1.3",
     "vitest": "^4.1.5",
-    "@multiplatform.one/utils": "7.3.0"
+    "@multiplatform.one/utils": "7.4.1"
   },
   "devDependencies": {
     "tsdown": "^0.21.10",

package/src/vitest.spec.ts

@@ -0,0 +1,76 @@
+/**
+ * createVitestConfig — resolve.extensions must never prefer a .test.* sibling.
+ *
+ * Regression guard for MPO-11: the defaults listed ".test.ts" / ".test.tsx"
+ * first, so vite resolved an extensionless `import "./foo"` to foo.test.ts
+ * whenever both files existed. That pulled the test file's own imports into the
+ * module graph and killed the lookout unit job with "Cannot bundle Node.js
+ * built-in node:test imported from src/format.test.ts".
+ */
+
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import { afterAll, describe, expect, it } from "vitest";
+import { createServer, type ViteDevServer } from "vite";
+import { createVitestConfig } from "./vitest.js";
+
+const fixtureDir = path.resolve(
+  path.dirname(fileURLToPath(import.meta.url)),
+  "../tests/fixtures/extensionless-resolve",
+);
+
+const servers: ViteDevServer[] = [];
+
+afterAll(async () => {
+  await Promise.all(servers.map((server) => server.close()));
+});
+
+/**
+ * Resolve a specifier through a real vite pipeline built from the produced
+ * config, so the assertion exercises vite's own extension probing rather than
+ * re-implementing it.
+ */
+async function resolveThroughVite(specifier: string, importer: string) {
+  const config = createVitestConfig({ tamaguiConfig: false, dedupeReact: false });
+  const server = await createServer({
+    configFile: false,
+    logLevel: "silent",
+    root: fixtureDir,
+    server: { middlewareMode: true },
+    resolve: config.resolve,
+  });
+  servers.push(server);
+  const environment = server.environments?.client ?? server.environments?.ssr;
+  const container = environment ? environment.pluginContainer : (server as any).pluginContainer;
+  const resolved = await container.resolveId(specifier, importer);
+  return resolved?.id ?? null;
+}
+
+describe("resolve.extensions", () => {
+  it("does not list any .test.* extension", () => {
+    const extensions = createVitestConfig().resolve?.extensions ?? [];
+    expect(extensions.filter((extension) => extension.startsWith(".test."))).toEqual([]);
+  });
+
+  it("still resolves platform-specific and plain source extensions, web first", () => {
+    const extensions = createVitestConfig().resolve?.extensions ?? [];
+    expect(extensions).toEqual([
+      ".web.ts",
+      ".web.tsx",
+      ".web.js",
+      ".web.jsx",
+      ".ts",
+      ".tsx",
+      ".js",
+      ".jsx",
+    ]);
+    expect(extensions.indexOf(".web.ts")).toBeLessThan(extensions.indexOf(".ts"));
+  });
+
+  it("resolves an extensionless ./foo to foo.ts even when foo.test.ts sits beside it", async () => {
+    const id = await resolveThroughVite("./foo", path.join(fixtureDir, "entry.ts"));
+    expect(id).toBeTruthy();
+    expect(path.basename(id!)).toBe("foo.ts");
+    expect(id).not.toContain(".test.");
+  });
+});

package/src/vitest.ts

@@ -217,18 +217,13 @@ export function createVitestConfig(options: CreateVitestConfigOptions = {}): Use
     plugins,
     test: testConfig,
     resolve: {
-      extensions: [
-        ".test.ts",
-        ".test.tsx",
-        ".web.ts",
-        ".web.tsx",
-        ".web.js",
-        ".web.jsx",
-        ".ts",
-        ".tsx",
-        ".js",
-        ".jsx",
-      ],
+      // Never list .test.* here. Vite tries these suffixes in order for an
+      // extensionless specifier, so a leading ".test.ts" makes `import "./foo"`
+      // resolve to foo.test.ts instead of foo.ts whenever both exist. That drags
+      // the test file (and whatever it imports, e.g. node:test) into the module
+      // graph and vitest dies with "Cannot bundle Node.js built-in node:test".
+      // Test files are collected by test.include globs, not by resolution.
+      extensions: [".web.ts", ".web.tsx", ".web.js", ".web.jsx", ".ts", ".tsx", ".js", ".jsx"],
       mainFields: ["browser", "module", "main"],
       alias: {
         ...resolveAliases,

package/types/vitest.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"vitest.d.ts","sourceRoot":"","sources":["../src/vitest.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,MAAM,CAAC;AAEvC,MAAM,WAAW,yBAAyB;IACxC;;;;OAIG;IACH,aAAa,CAAC,EAAE,MAAM,GAAG,KAAK,CAAC;IAE/B;;OAEG;IACH,WAAW,CAAC,EAAE,OAAO,GAAG,WAAW,GAAG,MAAM,CAAC;IAE7C;;OAEG;IACH,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;IAEtB;;OAEG;IACH,WAAW,CAAC,EAAE,MAAM,CAAC;IAErB;;OAEG;IACH,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;IAEtB;;OAEG;IACH,YAAY,CAAC,EAAE,MAAM,EAAE,CAAC;IAExB;;OAEG;IACH,OAAO,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IAEjC;;OAEG;IACH,QAAQ,CAAC,EAAE;QACT,OAAO,CAAC,EAAE,MAAM,EAAE,CAAC;KACpB,CAAC;IAEF;;;OAGG;IACH,kBAAkB,CAAC,EAAE,OAAO,CAAC;IAE7B;;;OAGG;IACH,WAAW,CAAC,EAAE,OAAO,CAAC;IAEtB;;;OAGG;IACH,eAAe,CAAC,EAAE,MAAM,CAAC;IAEzB;;OAEG;IACH,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;IAEtB;;OAEG;IACH,OAAO,CAAC,EAAE,MAAM,EAAE,CAAC;IAEnB;;OAEG;IACH,OAAO,CAAC,EAAE,MAAM,EAAE,CAAC;IAEnB;;OAEG;IACH,eAAe,CAAC,EAAE,OAAO,CAAC;CAC3B;AAED;;;;;;;;;;;;;;;;;GAiBG;AACH,wBAAgB,kBAAkB,CAAC,OAAO,GAAE,yBAA8B,GAAG,UAAU,CAmJtF"}
+{"version":3,"file":"vitest.d.ts","sourceRoot":"","sources":["../src/vitest.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,MAAM,CAAC;AAEvC,MAAM,WAAW,yBAAyB;IACxC;;;;OAIG;IACH,aAAa,CAAC,EAAE,MAAM,GAAG,KAAK,CAAC;IAE/B;;OAEG;IACH,WAAW,CAAC,EAAE,OAAO,GAAG,WAAW,GAAG,MAAM,CAAC;IAE7C;;OAEG;IACH,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;IAEtB;;OAEG;IACH,WAAW,CAAC,EAAE,MAAM,CAAC;IAErB;;OAEG;IACH,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;IAEtB;;OAEG;IACH,YAAY,CAAC,EAAE,MAAM,EAAE,CAAC;IAExB;;OAEG;IACH,OAAO,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IAEjC;;OAEG;IACH,QAAQ,CAAC,EAAE;QACT,OAAO,CAAC,EAAE,MAAM,EAAE,CAAC;KACpB,CAAC;IAEF;;;OAGG;IACH,kBAAkB,CAAC,EAAE,OAAO,CAAC;IAE7B;;;OAGG;IACH,WAAW,CAAC,EAAE,OAAO,CAAC;IAEtB;;;OAGG;IACH,eAAe,CAAC,EAAE,MAAM,CAAC;IAEzB;;OAEG;IACH,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;IAEtB;;OAEG;IACH,OAAO,CAAC,EAAE,MAAM,EAAE,CAAC;IAEnB;;OAEG;IACH,OAAO,CAAC,EAAE,MAAM,EAAE,CAAC;IAEnB;;OAEG;IACH,eAAe,CAAC,EAAE,OAAO,CAAC;CAC3B;AAED;;;;;;;;;;;;;;;;;GAiBG;AACH,wBAAgB,kBAAkB,CAAC,OAAO,GAAE,yBAA8B,GAAG,UAAU,CA8ItF"}