@multiplatform.one/config 7.23.0 → 7.23.2

package/README.md

@@ -76,8 +76,8 @@ computed colours, from all but `no-raw-typography`. A project that wants its
 own levels keeps the older one-line form,
 `{ "jsPlugins": ["@multiplatform.one/config/oxlint"] }`, and writes its own
 rules block (mpo's own `oxlintrc.json` turns `no-hex-literals` on for
-`apps/**`, `packages/**` and `features/**`, and off for specs and `tests/`
-trees). Palette modules (`themes/base.ts`, `themes/accent.ts`,
+`apps/**`, `packages/**`, `features/**`, `public/frappe-ui/src` and
+`public/backoffice/src`, and off for specs and `tests/` trees). Palette modules (`themes/base.ts`, `themes/accent.ts`,
 `*palette*`) are exempt. Comments are not visited, so a JSDoc `#025` is not
 a hit. A file no theme token reaches opts out with a `// hex-escape: <reason>`
 line comment; `lint` fails that comment unless the spec table
@@ -87,6 +87,9 @@ whose comment is gone (MPO-326).
 `no-chrome-props` and `no-raw-geometry` ship in the same plugin (MPO-17).
 Enable them the same way when you start that burndown. Drawing-file
 exceptions come from the spec table `## Drawing files`, not from the code.
+`no-raw-geometry` leaves `0` alone (`00` L8 E1). mpo's own `oxlintrc.json`
+runs it as an error over `public/frappe-ui/src` and `public/backoffice/src`
+(MPO-15), off for specs.
 
 `no-child-margin` (MPO-23, `00` L9a) fails a non-zero `margin*` prop, long
 or shorthand, on any element nested inside another element's JSX: the parent

package/oxlint.mjs

@@ -23,9 +23,10 @@
  *     stay legal. Exceptions come from the spec DRAWING table's CHROME-ALLOW
  *     row, not from the code (MPO-17).
  *   mpo-conventions/no-raw-geometry — ban numeric height/width/padding/fontSize
- *     on those same imports. Silent behind sizeRecipeEscape() and inside a
- *     file listed as DRAWING. An undeclared `// mpo-drawing` pragma is a
- *     lint.mjs failure, not a skip here.
+ *     on those same imports. `0` is `00` L8 E1 and stays legal. Silent
+ *     behind sizeRecipeEscape() and inside a file listed as DRAWING. An
+ *     undeclared `// mpo-drawing` pragma is a lint.mjs failure, not a skip
+ *     here.
  *   mpo-conventions/no-child-margin — `00` L9a: the parent owns the gap. Ban a
  *     non-zero margin* prop on any element nested inside another element's
  *     JSX. The outermost element of a tree is left alone (a file cannot see
@@ -182,7 +183,7 @@ export const MARGIN_PROPS = Object.freeze([
 
 const CHROME_PROP_SET = new Set(CHROME_PROPS);
 const MARGIN_PROP_SET = new Set(MARGIN_PROPS);
-const ZERO_MARGIN = /^(?:-?0(?:\.0+)?(?:px)?|\$0)$/;
+const ZERO_VALUE = /^(?:-?0(?:\.0+)?(?:px)?|\$0)$/;
 const GEOMETRY_PROP_SET = new Set(GEOMETRY_PROPS);
 
 const RULE_OPTIONS_SCHEMA = [
@@ -222,19 +223,20 @@ function resolveSlotMargins(context) {
 
 /**
  * `0` is `00` L8 E1, legal anywhere: a zero-reset is the absence of an outer
- * margin, not one (Tamagui's own headings ship `margin: 0`).
+ * margin or a size, not one (Tamagui's own headings ship `margin: 0`, and
+ * `minWidth={0}` is what lets a flex child shrink below its content).
  * @param {unknown} value
  */
-function isZeroMargin(value) {
+function isZeroReset(value) {
   const node = unwrapJsxValue(value);
   if (!node || typeof node !== "object") return false;
   const expr =
     /** @type {{ type?: string, value?: unknown, operator?: string, argument?: unknown }} */ (node);
   if (expr.type === "Literal") {
     if (typeof expr.value === "number") return expr.value === 0;
-    if (typeof expr.value === "string") return ZERO_MARGIN.test(expr.value.trim());
+    if (typeof expr.value === "string") return ZERO_VALUE.test(expr.value.trim());
   }
-  if (expr.type === "UnaryExpression" && expr.operator === "-") return isZeroMargin(expr.argument);
+  if (expr.type === "UnaryExpression" && expr.operator === "-") return isZeroReset(expr.argument);
   return false;
 }
 
@@ -541,7 +543,7 @@ export const plugin = {
         type: "problem",
         docs: {
           description:
-            "Ban numeric geometry on imported @multiplatform.one/* components unless wrapped in sizeRecipeEscape or the file is a declared drawing.",
+            "Ban non-zero numeric geometry on imported @multiplatform.one/* components unless wrapped in sizeRecipeEscape or the file is a declared drawing.",
         },
         schema: RULE_OPTIONS_SCHEMA,
         messages: {
@@ -557,6 +559,7 @@ export const plugin = {
             if (!GEOMETRY_PROP_SET.has(prop)) continue;
             if (isSizeRecipeEscape(attr.value)) continue;
             if (!isNumericLiteral(attr.value)) continue;
+            if (isZeroReset(attr.value)) continue;
             context.report({
               node: attr,
               messageId: "geometry",
@@ -601,7 +604,7 @@ export const plugin = {
             for (const attr of node.attributes ?? []) {
               const prop = jsxAttrName(attr);
               if (!MARGIN_PROP_SET.has(prop)) continue;
-              if (isZeroMargin(attr.value)) continue;
+              if (isZeroReset(attr.value)) continue;
               context.report({
                 node: attr,
                 messageId: "childMargin",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@multiplatform.one/config",
-  "version": "7.23.0",
+  "version": "7.23.2",
   "description": "Shared build and test configuration presets for multiplatform.one",
   "keywords": [
     "config",
@@ -99,7 +99,7 @@
     "access": "public"
   },
   "dependencies": {
-    "@multiplatform.one/utils": "7.23.0",
+    "@multiplatform.one/utils": "7.23.2",
     "@tamagui/vite-plugin": "2.7.6",
     "@vitejs/plugin-react": "^6.0.1",
     "dotenv": "^17.4.2",

package/src/oxlint.spec.ts

@@ -266,6 +266,37 @@ describe("mpo-conventions/no-raw-geometry (MPO-17)", () => {
     expect(wrapped).toEqual([]);
   });
 
+  it("never flags a zero-reset (00 L8 E1) but still flags any other number", () => {
+    const zero = driveHouseRule("no-raw-geometry", filename, [
+      importCard,
+      jsxOpen("Card", [
+        { prop: "minWidth", value: numeric(0) },
+        { prop: "padding", value: numeric(0) },
+        {
+          prop: "minHeight",
+          value: {
+            type: "JSXExpressionContainer",
+            expression: {
+              type: "UnaryExpression",
+              operator: "-",
+              argument: { type: "Literal", value: 0 },
+            },
+          },
+        },
+      ]),
+    ]);
+    expect(zero).toEqual([]);
+
+    const small = driveHouseRule("no-raw-geometry", filename, [
+      importCard,
+      jsxOpen("Card", [
+        { prop: "padding", value: numeric(2) },
+        { prop: "minWidth", value: numeric(0.5) },
+      ]),
+    ]);
+    expect(small.map((r) => r.data?.prop)).toEqual(["padding", "minWidth"]);
+  });
+
   it("stays silent inside a registered drawing file", () => {
     expect(
       driveHouseRule(

package/src/singletonDepAliases.spec.ts

@@ -235,9 +235,10 @@ function declares(dir: string, pkgName: string): boolean {
 }
 
 /**
- * Whether an installed package references `useSyncExternalStore` in anything
+ * Whether an installed package references `useSyncExternalStore` in the code
  * it ships. The cheap half of the membership rule, re-run against the tree so
- * the next tanstack upgrade is checked rather than assumed.
+ * the next tanstack upgrade is checked rather than assumed. Comments do not
+ * count: @tanstack/db 0.8 names the hook in doc comments and calls it nowhere.
  */
 function subscribesExternalStore(pkgName: string): boolean {
   const dir = path.join(workspaceRoot, "node_modules", ...pkgName.split("/"));
@@ -253,7 +254,13 @@ function referencesHook(dir: string): boolean {
       continue;
     }
     if (!/\.(?:js|cjs|mjs|ts|tsx)$/.test(entry.name)) continue;
-    if (fs.readFileSync(full, "utf8").includes("useSyncExternalStore")) return true;
+    if (withoutComments(fs.readFileSync(full, "utf8")).includes("useSyncExternalStore")) {
+      return true;
+    }
   }
   return false;
 }
+
+function withoutComments(source: string): string {
+  return source.replace(/\/\*[\s\S]*?\*\//g, "").replace(/(^|[^:\\])\/\/.*$/gm, "$1");
+}